Re: W3C Proposed Recommendation: Pointer Events

2015-04-29 Thread smaug
On 01/16/2015 04:31 AM, L. David Baron wrote: On Tuesday 2015-01-06 15:14 -0800, L. David Baron wrote: W3C recently published the following proposed recommendation (the stage before W3C's final stage, Recommendation): http://www.w3.org/TR/pointerevents/ Pointer Events There's a call for

Re: Enabling Pointer Events in Firefox (desktop) Nightly

2015-04-29 Thread smaug
On 04/24/2015 08:57 PM, Matt Brubeck wrote: tl;dr: We plan to enable Pointer Events for mouse and pen input in Firefox Nightly builds within the next few weeks. Background: Pointer Events is a W3C recommendation that defines new DOM events for unified handling of mouse, touch, and pen input.

Re: Treeherder UI performance much worse in Nightly vs Chrome

2015-04-26 Thread smaug
On 04/23/2015 07:43 AM, Ed Morley wrote: Scrolling fluidity/general app responsiveness of Treeherder is massively worse in Nightly compared to Chrome. eg try this in both: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central The problem is even more noticeable when the "get next 50" button

Re: Proposal to ban the usage of refcounted objects inside C++ lambdas in Gecko

2015-04-10 Thread smaug
On 04/10/2015 09:09 PM, Seth Fowler wrote: On Apr 10, 2015, at 8:46 AM, Ehsan Akhgari wrote: I would like to propose that we should ban the usage of refcounted objects inside lambdas in Gecko. Here is the reason: Consider the following code: nsINode* myNode; TakeLambda([&]() { myNode->Fo

Re: SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

2015-03-29 Thread smaug
On 03/28/2015 02:32 AM, Nicolas B. Pierron wrote: On 03/27/2015 11:51 PM, Bobby Holley wrote: On Fri, Mar 27, 2015 at 2:04 PM, Mats Palmgren wrote: So let's change the project-wide coding rules instead to allow 99 columns as the hard limit, but keep 80 columns as the recommended (soft) limit.

dev-platform@lists.mozilla.org

2015-03-02 Thread smaug
no runtime penalty. But this is false." Can we somehow make use of nsDependentString easier? (not that I think it is hard. The name is just a bit long) -Olli -Jeff On Sun, Mar 1, 2015 at 7:04 PM, smaug wrote: On 03/02/2015 01:11 AM, Xidorn Quan wrote: On Mon, Mar 2, 2015 at 9:50 AM

dev-platform@lists.mozilla.org

2015-03-01 Thread smaug
On 03/02/2015 01:11 AM, Xidorn Quan wrote: On Mon, Mar 2, 2015 at 9:50 AM, Boris Zbarsky wrote: On 3/1/15 5:04 PM, Xidorn Quan wrote: Hence I think we should remove this method. All callees should use either AssignLiteral(MOZ_UTF16("some string")), or, if don't want to bloat the binary, expl

Re: Intent to ship: MouseEvent.offsetX/Y

2015-03-01 Thread smaug
On 02/28/2015 05:25 AM, Robert O'Callahan wrote: On Sat, Feb 28, 2015 at 8:30 AM, Jeff Muizelaar wrote: On Fri, Feb 27, 2015 at 2:21 PM, Robert O'Callahan wrote: Oh, another issue is that I've followed the spec and made offsetX/Y doubles, whereas Blink is integers, which introduces a small a

Re: Getting rid of already_AddRefed?

2014-12-26 Thread smaug
On 12/26/2014 03:08 PM, Aryeh Gregor wrote: On Mon, Dec 22, 2014 at 11:10 PM, Jeff Muizelaar wrote: Possible solutions would be to: - remove implicit conversions to T* If this were done, I think we should change the calling convention for functions that take pointers to refcounted classes.

Re: Getting rid of already_AddRefed?

2014-12-25 Thread smaug
On 12/25/2014 11:22 PM, smaug wrote: On 12/23/2014 11:59 PM, Martin Thomson wrote: On Tue, Dec 23, 2014 at 1:51 PM, L. David Baron wrote: Just to be clear, is your problem the implicit conversion itself or the reference count increment/decrement? The latter -- the problem is that there&#

Re: Getting rid of already_AddRefed?

2014-12-25 Thread smaug
On 12/23/2014 11:59 PM, Martin Thomson wrote: On Tue, Dec 23, 2014 at 1:51 PM, L. David Baron wrote: Just to be clear, is your problem the implicit conversion itself or the reference count increment/decrement? The latter -- the problem is that there's an implicit conversion that has surpris

Re: after NPAPI ?

2014-11-25 Thread smaug
On 11/25/2014 05:45 PM, Reuben Morais wrote: On Nov 25, 2014, at 13:22, Gijs Kruitbosch wrote: On 25/11/2014 14:22, rayna...@gmail.com wrote: I need to get the audio sample data and do some math on it, then play it in the speaker, with the minimum of latency (arround 20ms). Only the wasapi d

Re: Profiling on Linux

2014-11-13 Thread smaug
ere: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Profiling_with_Zoom On Thu, Nov 13, 2014 at 1:03 PM, smaug wrote: On 11/13/2014 08:01 PM, smaug wrote: Hi all, looks like Zoom profiler[1] is now free. It has rather good UI on top of oprofile/rrprofile perf/oprofile/rrprofile making

Profiling on Linux

2014-11-13 Thread smaug
Hi all, looks like Zoom profiler[1] is now free. It has rather good UI on top of oprofile/rrprofile making profiling quite easy. I've found it easier to use than Gecko profiler and it gives different kinds of views to the same data. However it does lack the JS specific bits Gecko profiler has.

Re: Profiling on Linux

2014-11-13 Thread smaug
On 11/13/2014 08:01 PM, smaug wrote: Hi all, looks like Zoom profiler[1] is now free. It has rather good UI on top of oprofile/rrprofile perf/oprofile/rrprofile making profiling quite easy. I've found it easier to use than Gecko profiler and it gives different kinds of views to the

Re: Intent to ship: Web Speech API - Speech Recognition with Pocketsphinx

2014-10-30 Thread smaug
Intent to ship is too strong for this. We need to first have implementation landed and tested ;) I wouldn't ship the implementation in desktop FF without plenty of more testing. -Olli On 10/31/2014 01:18 AM, Andre Natal wrote: I've been researching speech recognition in Firefox for two year

Re: Intent to ship: Web Speech API - Speech Recognition with Pocketsphinx

2014-10-30 Thread smaug
On 10/31/2014 02:21 AM, smaug wrote: Intent to ship is too strong for this. We need to first have implementation landed and tested ;) I wouldn't ship the implementation in desktop FF without plenty of more testing. But I guess the question is what people think about shipping the pocket

Re: Intent to implement: Touchpad event

2014-09-11 Thread smaug
On 09/11/2014 08:26 PM, Chris Peterson wrote: On 9/11/14 3:49 AM, Mounir Lamouri wrote: On Thu, 11 Sep 2014, at 18:26, Ms2ger wrote: First of all, you neglected to explain the standardization situation here. Is this feature being standardized? If not, why not? How do other browser vendors feel

Re: Intent to implement: Touchpad event

2014-09-11 Thread smaug
If we just needs new coordinates, couldn't we extend the existing event interfaces with some new properties? -Olli On 09/12/2014 12:52 AM, smaug wrote: > What would be the event types for touchpad events? > We must not add yet another types of events to handle pointer typ

Re: Intent to implement: Touchpad event

2014-09-11 Thread smaug
What would be the event types for touchpad events? We must not add yet another types of events to handle pointer type of events. And besides, touch event model is rather horrible, so if we for some strange reason need totally new events, I'd prefer using something closer to pointer events. -Ol

Re: Getting rid of already_AddRefed?

2014-08-13 Thread smaug
On 08/13/2014 07:24 PM, Aryeh Gregor wrote: On Wed, Aug 13, 2014 at 5:44 PM, Ehsan Akhgari wrote: Can't you do the following instead? unused << MyFunction(); // I know that I'm leaking this ref, but it's ok somehow No, because the use-case is where you don't want to leak the ref -- you want

Re: Getting rid of already_AddRefed?

2014-08-13 Thread smaug
On 08/12/2014 06:23 PM, Aryeh Gregor wrote: On Tue, Aug 12, 2014 at 6:16 PM, Benoit Jacob wrote: As far as I know, the only downside in replacing already_AddRefed by nsCOMPtr would be to incur more useless calls to AddRef and Release. In the case of "threadsafe" i.e. atomic refcounting, these u

Re: Recommendations on source control and code review

2014-04-14 Thread smaug
On 04/14/2014 12:42 AM, Robert O'Callahan wrote: On Sat, Apr 12, 2014 at 8:29 AM, Gregory Szorc wrote: I came across the following articles on source control and code review: * https://secure.phabricator.com/book/phabflavor/article/ recommendations_on_revision_control/ * https://secure.phabri

Re: Promise.jsm and the predefined Promise object

2014-03-31 Thread smaug
On 03/29/2014 02:55 PM, Paolo Amadini wrote: With bug 988122 landing soon, you'll now find a "Promise" object available by default in the global scope of JavaScript modules. However, this default implementation is still limited, and you're strongly recommended to import Promise.jsm explicitly in

Re: Graceful Platform Degradation

2014-03-28 Thread smaug
lower refresh rate in some cases in order to try to avoid extra layout flushes etc. --Jet - Original Message - From: "smaug" To: "Nicholas Nethercote" , "Jet Villegas" Sent: Friday, March 28, 2014 11:16:42 AM Subject: Re: Graceful Platform Degradation Per

Re: Graceful Platform Degradation

2014-03-28 Thread smaug
On 03/27/2014 10:26 AM, Nicholas Nethercote wrote: This sounds like a worthy and interesting idea, but also a very difficult one. PC games allow the user to turn certain features (mostly graphics related ones) on and off so that they can find their own level of acceptable performance/quality.

Re: Memory management in features implemented in JS

2014-03-20 Thread smaug
ovides no guarantees about cycles, but if this is necessary, I could rework it in something a bit faster/more robust. Cheers, David On 3/20/14 1:25 AM, smaug wrote: And we could add a flag to WrappedJS so that it would call some callback when it is about to go away. That would let cleanup of Wea

Re: Memory management in features implemented in JS

2014-03-19 Thread smaug
On 03/20/2014 02:25 AM, smaug wrote: On 03/20/2014 01:58 AM, smaug wrote: On 03/20/2014 01:39 AM, Kyle Huey wrote: Followup to dev-platform please. We are discovering a lot of leaks in JS implemented DOM objects. The general pattern seems to be that we have a DOM object that also needs to

Re: Memory management in features implemented in JS

2014-03-19 Thread smaug
On 03/20/2014 01:58 AM, smaug wrote: On 03/20/2014 01:39 AM, Kyle Huey wrote: Followup to dev-platform please. We are discovering a lot of leaks in JS implemented DOM objects. The general pattern seems to be that we have a DOM object that also needs to listen to events from the message

Re: Memory management in features implemented in JS

2014-03-19 Thread smaug
On 03/20/2014 01:39 AM, Kyle Huey wrote: Followup to dev-platform please. We are discovering a lot of leaks in JS implemented DOM objects. The general pattern seems to be that we have a DOM object that also needs to listen to events from the message manager or notifications from the observer se

Re: Intent to ship: CSS Variables

2014-03-19 Thread smaug
On 03/18/2014 11:26 AM, Cameron McCormack wrote: CSS Variables is a feature that allows authors to define custom properties that cascade and inherit in the same way that regular properties do, and to reference the values of these custom properties in the values of regular properties (and other

Re: DXR gets multi-line highlighting

2014-03-18 Thread smaug
On 03/19/2014 12:10 AM, Karl Tomlinson wrote: On Thu, 13 Mar 2014 12:46:14 -0400, Erik Rose wrote: A lot of you have asked for the ability to select and share ranges within source files. Now, thanks to contributor Jamon Carmisso, you can: http://dxr.mozilla.org/mozilla-central/source/content/m

Re: Please do not add new web-exposed XPCOM objects

2014-03-15 Thread smaug
On 03/14/2014 11:20 PM, Boris Zbarsky wrote: We're at a point where we are actively trying to eliminate xpconnect usage on the web. I'm happy to enumerate the reasons we're doing that if people care, but the practical upshot is: 1) Do not add new objects with classinfo to nsDOMClassInfo.cpp

Re: ISomething, nsISomething or mozISomething?

2014-02-17 Thread smaug
On 02/17/2014 11:18 PM, Justin Dolske wrote: On 2/17/14 12:41 PM, Ehsan Akhgari wrote: On 2/17/2014, 9:15 AM, David Rajchenbach-Teller wrote: Do we have naming conventions for new xpcom interfaces? I believe that I have seen all three forms on the tree. I need to pick one for my new bug. Which

Re: Tracking Docshells

2014-02-13 Thread smaug
On 02/13/2014 12:53 PM, Girish Sharma wrote: Thank you everyone for your inputs. Since there is no current method of precisely tracking window creation and removal, how should I proceed and add such functionality ? What I basically want is that despite of BFCache or anything, I should be able to

Re: Please use NS_WARN_IF instead of NS_ENSURE_SUCCESS

2014-01-07 Thread smaug
On 01/07/2014 08:46 AM, Bobby Holley wrote: On Mon, Jan 6, 2014 at 5:04 PM, smaug wrote: no, since it is always possible to expand those macros. However if (NS_WARN_IF(NS_FAILED(rv)) { return rv; } is super ugly. Note that there in a explicit stylistic exception that NS_WARN_IF

Re: Please use NS_WARN_IF instead of NS_ENSURE_SUCCESS

2014-01-07 Thread smaug
On 01/07/2014 05:14 PM, smaug wrote: On 01/07/2014 08:46 AM, Bobby Holley wrote: On Mon, Jan 6, 2014 at 5:04 PM, smaug wrote: no, since it is always possible to expand those macros. However if (NS_WARN_IF(NS_FAILED(rv)) { return rv; } is super ugly. Note that there in a explicit

Re: Mozilla style guide issues, from a JS point of view

2014-01-06 Thread smaug
On 01/07/2014 02:46 AM, Jeff Walden wrote: I'm writing this list, so obviously I'm choosing what I think is on it. But I think there's rough consensus on most of these among JS hackers. JS widely uses 99ch line lengths (allows a line-wrap character in 100ch terminals). Given C++ symbol names

Re: Please use NS_WARN_IF instead of NS_ENSURE_SUCCESS

2014-01-06 Thread smaug
On 01/07/2014 02:58 AM, Karl Tomlinson wrote: smaug writes: Why this deprecation? NS_ENSURE_ macros hid return paths. Also many people didn't understand that they issued warnings, and so used the macros for expected return paths. Was there some useful functionality that is not provid

Re: Please use NS_WARN_IF instead of NS_ENSURE_SUCCESS

2014-01-06 Thread smaug
On 11/22/2013 10:18 PM, Benjamin Smedberg wrote: With the landing of bug 672843, the NS_ENSURE_* macros are now considered deprecated. If you are writing code that wants to issue warnings when methods fail, please either use NS_WARNING directly or use the new NS_WARN_IF macro. if (NS_WARN_IF(s

Re: List of deprecated constructs [was Re: A proposal to reduce the number of styles in Mozilla code]

2014-01-06 Thread smaug
On 01/07/2014 01:38 AM, Joshua Cranmer 🐧 wrote: On 1/6/2014 4:27 PM, Robert O'Callahan wrote: That's just not true, sorry. If some module owner decides to keep using NULL or PRUnichar, or invent their own string class, they will be corrected. Maybe. But we also have a very large number of dep

Re: A proposal to reduce the number of styles in Mozilla code

2014-01-06 Thread smaug
le. I could perhaps be persuaded at some point if someone wants to do the leg work. bholley On Mon, Jan 6, 2014 at 6:07 AM, smaug wrote: Sounds good, and I'd include also js/* so that we had consistent style everywhere. It is rather painful to hack various non-js/* and js/* (xpconnect in

Re: A proposal to reduce the number of styles in Mozilla code

2014-01-06 Thread smaug
Sounds good, and I'd include also js/* so that we had consistent style everywhere. It is rather painful to hack various non-js/* and js/* (xpconnect in my case) in the same patch. (I also happen to think that Mozilla coding style is inherently better than js style, since it has clear rules for n

Re: On the usefulness of style guides (Was: style guide proposal)

2013-12-19 Thread smaug
On 12/20/2013 12:11 AM, Ehsan Akhgari wrote: On 12/19/2013, 12:57 PM, Till Schneidereit wrote: I think we should do more than encourage: we should back out for all style guide violations. Period. We could even enforce that during upload to a review tool, perhaps. However. This has to be done on

Re: Can we start using C++ STL containers in Mozilla code?

2013-12-10 Thread smaug
On 12/10/2013 11:28 AM, Chris Pearce wrote: Hi All, Can we start using C++ STL containers like std::set, std::map, std::queue in Mozilla code please? Many of the STL containers are more convenient to use than our equivalents, and more familiar to new contributors. I understand that we used to

Removing favor-perf-mode

2013-12-08 Thread smaug
user input or paint requests). I do expect some tp regressions but significant tp_responsiveness improvements. (I'll need to still fix few racy tests before landing) -smaug [1] https://bugzilla.mozilla.org/show_bug.cgi?id=930793 [2] https://bugzilla.mozilla.org/show_bug.cgi?id=7

unified build mode and memory consumption

2013-11-29 Thread smaug
Hi all and FYI unified build mode has increased memory usage of building with gcc significantly. On my laptop (8 gig mem) I started to see some swapping, and because of that build times with unified mode weren't that much better than before. But now, finally there is a use case for clang - it

Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread smaug
On 11/21/2013 10:15 PM, Gavin Sharp wrote: It would be good to explore alternatives to Bonsai. https://github.com/mozilla/mozilla-central is supposed to have full CVS history, right? Some concerns with that alternative: - I think that repo misses some history from some branches of CVS - I'm not

Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread smaug
On 11/21/2013 09:43 PM, Laura Thomson wrote: I'll keep it short and to the point. Are there any objections to shutting down http://bonsai.mozilla.org/cvsqueryform.cgi ? If you don't know what that is--and few people do, which is even more reason to shut it off--it's a search engine for some of

How to reduce the time m-i is closed?

2013-11-16 Thread smaug
Hi all, the recent OOM cases have been really annoying. They have slowed down development, even for those who haven't been dealing with the actual issue(s). Could we handle this kind of cases differently. Perhaps clone the bad state of m-i to some other repository we're tracking using tbpl, b

Re: Closure of trunk trees - owners for bugs needed

2013-11-03 Thread smaug
On 11/01/2013 07:55 AM, Nicholas Nethercote wrote: I have (slightly optimistically) started writing a post-mortem of this closure, analyzing what went wrong and why, and how we might avoid it in the future: https://etherpad.mozilla.org/mEB0H50ZjX FWIW, I added the following TL;DR to the doc

Re: Killing the Moz Audio Data API

2013-10-16 Thread smaug
On 10/17/2013 12:09 AM, Ehsan Akhgari wrote: I'd like to write a patch to kill Moz Audio Data in Firefox 28 in favor of Web Audio. We added a deprecation warning for this API in Firefox 23 (bug 855570). I'm not sure what our usual process for this kind of thing is, should we just take the patch

Re: Poll: What do you need in MXR/DXR?

2013-10-05 Thread smaug
- Clicking on macros seem to lead to some results, but definitely not the one I'd expect - the definition of the macro. - Trying to find files is hard. (Still haven't figured out how to get easily from the main page to Navigator.cpp on dom/base) - "cycleCollection" on the right side may or m

Re: proposal to use JS GC Handle/Rooted typedefs everywhere

2013-09-18 Thread smaug
On 09/18/2013 10:55 PM, Luke Wagner wrote: To save typing, the JS engine has typedefs like typedef Handle HandleObject; typedef Rooted RootedValue; and the official style is to prefer the HandleX/RootedX typedefs when there is no need to use the Handle/Rooted template-ids directly. This issue

Re: DevTools: how to get list of mutation observers for an element

2013-09-04 Thread smaug
a bug for this? Yes, please. CC me -Olli :smaug Honza ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Refcounting threadsafety assertions are now fatal in opt builds.

2013-09-03 Thread smaug
On 08/30/2013 10:48 PM, Kyle Huey wrote: The assertions that we have to catch refcounting objects on the wrong thread are now fatal in opt builds. This change is scoped to the nightly channel to avoid performance penalties on builds that are widely used, and will not propagate to aurora. See bu

Re: Is it necessary to remove message listeners?

2013-07-27 Thread smaug
On 07/27/2013 06:06 AM, Mark Hammond wrote: On 27/07/2013 2:53 AM, Justin Lebar wrote: ... > Whether or not we totally succeed in this endeavor is another question entirely. You could instrument your build to count the number of live nsFrameMessageManager objects and report the number of messa

Re: review stop-energy (was 24hour review)

2013-07-10 Thread smaug
On 07/09/2013 03:14 PM, Taras Glek wrote: Hi, Browsers are a competitive field. We need to move faster. Eliminating review lag is an obvious step in the right direction. I believe good code review is essential for shipping a good browser. Conversely, poor code review practices hold us back. I

Re: We should drop MathML

2013-05-06 Thread smaug
On 05/06/2013 05:46 AM, Benoit Jacob wrote: Let me just reply to a few points to keep this conversation manageable: 2013/5/5 Here are a couple of reasons why dropping MathML would be a bad idea. (While I wrote this others made some of the points as well.) * MathML is part of HTML5 and epub3.

Re: Accelerating exact rooting work

2013-04-23 Thread smaug
On 04/23/2013 06:23 PM, Ehsan Akhgari wrote: Hmm, another question. Your list includes a bunch of stuff under tools/profiler, and I took a quick look and picked JSObjectBuilder.cpp. Changing the JS::Value's there to JS::RootedValue's cause compiler errors about conversion from jsvals when us

Re: Accelerating exact rooting work

2013-04-23 Thread smaug
On 04/23/2013 04:07 PM, Tom Schuster wrote: At the moment it's really just Jono working full time on this, and terrence and other people reviewing. This stuff is actually quite easy and you can expect really fast review times from our side. In some parts of the code rooting could literally just

Re: Revamping touch input on Windows

2013-04-19 Thread smaug
On 04/18/2013 03:50 PM, Jim Mathies wrote: We have quite a few issues with touch enabled sites on Windows. [1] Our support for touch stretches back to when we first implemented MozTouch events which over time has morphed into a weird combination of W3C touch / simple gestures support. It is rat

Re: Firing events at the window vs. firing them at the chrome event handler

2013-03-05 Thread smaug
On 03/04/2013 08:20 PM, Boris Zbarsky wrote: On 3/4/13 1:08 PM, Zack Weinberg wrote: It only needs to be certain of seeing the event despite anything content can do, In that case, a capturing handler on the chrome event listener will work fine. -Boris or capturing or bubbling event listene

Re: Soliciting advice on #650960 (replacement for print progress bars)

2013-02-25 Thread smaug
On 02/25/2013 11:28 PM, Benjamin Smedberg wrote: On 2/25/2013 4:14 PM, Zack Weinberg wrote: The current thinking is that we need *some* indication that a print job is in progress, because we need to prevent the user from closing the tab or window until the print job has been completely handed

Re: Soliciting advice on #650960 (replacement for print progress bars)

2013-02-25 Thread smaug
On 02/26/2013 01:18 AM, Daniel Holbert wrote: On 02/25/2013 01:57 PM, Bobby Holley wrote: We clone static copies of documents for print preview. We could potentially do the same for normal printing, I'd think. I'm almost certain that we already do. (smaug would know for sure)

Re: Running mousemove events from the refresh driver

2013-02-15 Thread smaug
On 02/14/2013 05:48 AM, Robert O'Callahan wrote: On Thu, Feb 14, 2013 at 3:21 AM, Benjamin Smedberg wrote: On what OSes? Windows by default coalesces mouse move events. They are like WM_PAINT events in that they are only delivered when the event queue is empty. See http://blogs.msdn.com/b/oldne

Re: print preview and documentation

2013-02-04 Thread smaug
On 02/02/2013 11:37 AM, rvj wrote: Its been a couple of years since Ive used the Mozilla libraries and some of the functionality now seems iffy For example print preview requests now generate an invalid pointer error error[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_I

Re: The future of PGO on Windows

2013-01-31 Thread smaug
On 01/31/2013 10:37 AM, Nicholas Nethercote wrote: On Thu, Jan 31, 2013 at 3:03 PM, Ehsan Akhgari wrote: Given the above, I'd like to propose the following long-term solutions: 1. Disable PGO/LTCG now. 2. Try to delay disabling PGO/LTCG as much as possible. 3. Try to delay disabling PGO/LTCG

Re: Use of "instanceof SomeDOMInterface" in chrome and extensions

2012-12-29 Thread smaug
On 12/27/2012 12:18 PM, Boris Zbarsky wrote: We have a bunch of chrome and extension code that does things like "instanceof HTMLAnchorElement" (and likewise with other DOM interfaces). The problem is that per WebIDL spec and general ECMAScript sanity this shouldn't work: instanceof goes up the

Re: No more cycle collections during shutdown (opt builds)

2012-12-15 Thread smaug
On 12/15/2012 12:31 AM, smaug wrote: Hi all, I just landed the patch for https://bugzilla.mozilla.org/show_bug.cgi?id=818739 in order to speed up shutdown times. Shutdown cycle collections are still run in debug builds so that we can detect leaks. Also, one can set

No more cycle collections during shutdown (opt builds)

2012-12-14 Thread smaug
Hi all, I just landed the patch for https://bugzilla.mozilla.org/show_bug.cgi?id=818739 in order to speed up shutdown times. Shutdown cycle collections are still run in debug builds so that we can detect leaks. Also, one can set XPCOM_CC_RUN_DURING_SHUTDOWN env variable to enable shutdown cycl

Re: Super-review, what shall we do with you?

2012-11-26 Thread smaug
On 11/26/2012 05:51 AM, Gregory Szorc wrote: On 11/25/12 7:29 PM, L. David Baron wrote: On Monday 2012-11-26 04:21 +0100, Robert Kaiser wrote: Justin Dolske schrieb: I think we should consider jettisoning/rewriting that part of the policy. It doesn't match what we've been doing in reality(*)

Re: Proposed W3C Charter: Pointer Events Working Group

2012-10-11 Thread smaug
On 10/11/2012 07:55 PM, L. David Baron wrote: W3C is proposing a charter for a new Pointer Events Working Group. For more details, see: http://lists.w3.org/Archives/Public/public-new-work/2012Sep/0017.html http://www.w3.org/2012/pointerevents/charter/charter-proposed.html Mozilla has the opport

Re: How to be notified when a node gets detached/reparented?

2012-10-11 Thread smaug
On 10/11/2012 02:40 PM, Paul Rouget wrote: Context: in the firefox devtools, we need to track some nodes and update different "views" based on what's happening to this node (show its parents, show its child, show its attributes, …). The new Mutation observers are very helpful. But there's one th

Re: New XPIDL attribute: [infallible]

2012-08-24 Thread smaug
On 08/24/2012 02:42 AM, Neil wrote: Justin Lebar wrote: So now you can do nsCOMPtr foo; int32_t f = foo->GetFoo(); Why was I expecting this to be Foo()? (Perhaps unreasonably.) Yeah, it should be Foo(). File a bug? I rejected the first approach because it meant that every call to G

Re: Paint Timing Changes and Tp5

2012-08-10 Thread smaug
On 08/10/2012 02:59 PM, smaug wrote: On 08/09/2012 08:36 PM, Boris Zbarsky wrote: On 8/9/12 11:37 AM, Benjamin Smedberg wrote: This seems important. If the computer is running close to 100% CPU which is why paints are being throttled, then we're just introducing extra work for no benefi

Re: Paint Timing Changes and Tp5

2012-08-10 Thread smaug
On 08/09/2012 08:36 PM, Boris Zbarsky wrote: On 8/9/12 11:37 AM, Benjamin Smedberg wrote: This seems important. If the computer is running close to 100% CPU which is why paints are being throttled, then we're just introducing extra work for no benefit. We know that a significant portion of our u

<    1   2   3