Re: How would you like to spell check this?

2015-09-03 Thread Ehsan Akhgari
On 2015-09-03 6:44 AM, Florian Quèze wrote: The solution I would like to see implemented (and I'm willing to help) is automatic detection of the language. Note that in addition to this, in order to make the feature completely useful for multilingual users, we would need to implement support

Re: How would you like to spell check this?

2015-09-03 Thread Florian Quèze
On Sun, Aug 30, 2015 at 10:17 PM, Jörg Knobloch wrote: > So please voice your objections to the proposed solution, if any ;-) As someone mentioned already, lots of websites are actually communication tools (eg. webmail, chat, social networks), and there's no way the website can

Re: How would you like to spell check this?

2015-09-03 Thread Jörg Knobloch
On 3/09/2015 12:44, Florian Quèze wrote: The solution I would like to see implemented (and I'm willing to help) is automatic detection of the language. Nice idea. I'd like to clean-up the current behaviour first in https://bugzilla.mozilla.org/show_bug.cgi?id=1200533 so we have a solid base

Re: How would you like to spell check this?

2015-09-03 Thread Panos Astithas
On Thu, Sep 3, 2015 at 1:44 PM, Florian Quèze wrote: > On Sun, Aug 30, 2015 at 10:17 PM, Jörg Knobloch wrote: > > > So please voice your objections to the proposed solution, if any ;-) > > As someone mentioned already, lots of websites are actually >

Re: How would you like to spell check this?

2015-09-02 Thread Jörg Knobloch
On 2/09/2015 07:17, lalo.mart...@gmail.com wrote: To put it simply, if I select a language via the context menu, it should still be there next time I visit the same site; it's the intended behaviour for the current code, and even if I don't think it's ideal, it's currently broken, and I don't

Re: How would you like to spell check this?

2015-09-02 Thread Robert O'Callahan
On Wed, Sep 2, 2015 at 6:41 PM, Jörg Knobloch wrote: > I would like to hear a good argument why this confusing behaviour should > be maintained. I don't consider the following a good argument (quote): > "Believe me when I say that *every single time* we have tried to "fix" >

Re: How would you like to spell check this?

2015-09-02 Thread Jörg Knobloch
On 2/09/2015 12:24, Robert O'Callahan wrote: The patch in bug 717433 just seemed like an especially clear improvement. Agreed. This was the nastiest problem that affected the most users and had the most obvious fix. As detailed earlier in the thread, there is another puzzling issue that

Re: How would you like to spell check this?

2015-09-01 Thread Jörg Knobloch
On 1/09/2015 16:01, Ehsan Akhgari wrote: I suppose you can find them on #fx-team. Just for the record from IRC: jorgk: Hi, #fx-team. I had this discussion with Ehsan https://groups.google.com/forum/#!topic/mozilla.dev.platform/Et02D8Mk2d0 on improving the spell checking in Firefox.

Re: How would you like to spell check this?

2015-09-01 Thread Jörg Knobloch
Hi all, I hope we can at least agree on fixing the problems with the current behaviour. I raised bug https://bugzilla.mozilla.org/show_bug.cgi?id=1200533 for that. The clear order of priorities that will be established will be: 1) content preference, not ignoring an "en-GB" setting on a plain

Re: How would you like to spell check this?

2015-09-01 Thread lalo . martins
Oh come on, this is getting ridiculous. THIS IS A BUG, no matter how much some contributors want to pretend it isn't. It's a conceptually simple bug that's been sitting around for at least 3.5 years (since reported). To put it simply, if I select a language via the context menu, it should

Re: How would you like to spell check this?

2015-09-01 Thread Jörg Knobloch
On 1/09/2015 16:01, Ehsan Akhgari wrote: The fundamental issue is that different people have different needs, and there is also the information that the website gives us which we need to take into account somehow. You are describing what _you_ would like to see. Actually: No. I was

Re: How would you like to spell check this?

2015-09-01 Thread Ehsan Akhgari
On 2015-08-31 5:57 PM, Jörg Knobloch wrote: On 31/08/2015 17:18, Ehsan Akhgari wrote: Just wanting to reiterate that the problem is not as big as you claim it is. We did not break Firefox for "single language users". If you take a good look at the fallback processing in

Re: How would you like to spell check this?

2015-08-31 Thread Anne van Kesteren
On Sun, Aug 30, 2015 at 10:17 PM, Jörg Knobloch wrote: > Reinstate "spellchecker.dictionary" as a global override, if it has a value > set. So we establish the following list of priorities: > 1) Content preference > 2) "spellchecker.dictionary", if set > 3) language determined by

Re: How would you like to spell check this?

2015-08-31 Thread Jörg Knobloch
On 31/08/2015 08:12, Anne van Kesteren wrote: HTML4 is long obsolete. OK, the HTML5 definition is here: http://www.w3.org/TR/html5/dom.html#the-lang-and-xml:lang-attributes It comes to the same result. 4) Fall-back options including the locale and others. "Polyglot users" unset

Re: How would you like to spell check this?

2015-08-31 Thread Jörg Knobloch
On 31/08/2015 17:18, Ehsan Akhgari wrote: Just wanting to reiterate that the problem is not as big as you claim it is. We did not break Firefox for "single language users". If you take a good look at the fallback processing in editor/composer/nsEditorSpellCheck.cpp, you will notice that it

How would you like to spell check this?

2015-08-30 Thread Jörg Knobloch
Hi all, Today I would like to discuss a change I'd like to make to the way the spell checking language is selected for text input (editor) fields. Before I get to my proposal, we need to take a little stroll down memory lane. In the good old days, when setting the spell check language in a