Re: connections to external hosts during tests now cause crashes

2014-06-18 Thread Zack Weinberg
On 2014-06-17 11:01 AM, Nathan Froyd wrote: [bcc dev-tree-management] In the continuing effort to make our testsuites more reliable, bug 995417 has landed on inbound. This bug enforces the long-standing policy of no external network connections in the testsuite with code: external network conne

Re: connections to external hosts during tests now cause crashes

2014-06-17 Thread Nicholas Nethercote
On Tue, Jun 17, 2014 at 8:01 AM, Nathan Froyd wrote: > > In the continuing effort to make our testsuites more reliable, bug 995417 has > landed on inbound. This bug enforces the long-standing policy of no external > network connections in the testsuite with code: external network connections >

Re: connections to external hosts during tests now cause crashes

2014-06-17 Thread Nathan Froyd
- Original Message - > On 6/17/2014 2:22 PM, Philipp Kewisch wrote: > > Hey Kent, > > > > reading bug 995417, the crash only happens if > > MOZ_DISABLE_NONLOCAL_CONNECTIONS is set, which is set only in the > > testing infrastructure. > > Which is actually not ideal because it means we can

Re: connections to external hosts during tests now cause crashes

2014-06-17 Thread Ryan VanderMeulen
On 6/17/2014 2:22 PM, Philipp Kewisch wrote: Hey Kent, reading bug 995417, the crash only happens if MOZ_DISABLE_NONLOCAL_CONNECTIONS is set, which is set only in the testing infrastructure. Philipp Which is actually not ideal because it means we can end up with failures on TBPL that aren't

Re: connections to external hosts during tests now cause crashes

2014-06-17 Thread Philipp Kewisch
On 6/17/14 7:58 PM, Kent James wrote: > On 6/17/2014 8:01 AM, Nathan Froyd wrote: >> - For xpcshell, you should set up mock servers via httpd.js (see >> numerous examples in existing xpcshell tests). > > I use xpcshell to drive tests for an extension that attaches to external > servers. This is al

Re: connections to external hosts during tests now cause crashes

2014-06-17 Thread Kent James
On 6/17/2014 8:01 AM, Nathan Froyd wrote: - For xpcshell, you should set up mock servers via httpd.js (see numerous examples in existing xpcshell tests). I use xpcshell to drive tests for an extension that attaches to external servers. This is all done by me and not part of any official Mozil

connections to external hosts during tests now cause crashes

2014-06-17 Thread Nathan Froyd
[bcc dev-tree-management] In the continuing effort to make our testsuites more reliable, bug 995417 has landed on inbound. This bug enforces the long-standing policy of no external network connections in the testsuite with code: external network connections will now crash the browser if and wh