On 2013/10/26 12:47, Cameron McCormack wrote:
Tim Abraldes:
So my question is this; is it preferable to keep the As*Event
functions, or to use regular C++ casts to accomplish the same
behavior? We could use static_cast unconditionally for upcasts,
static_cast with a check of |eventStructType|
Tim Abraldes:
So my question is this; is it preferable to keep the As*Event
functions, or to use regular C++ casts to accomplish the same
behavior? We could use static_cast unconditionally for upcasts,
static_cast with a check of |eventStructType| for downcasts to
most-derived event
I hope this change makes you happy!
It most certainly does! I'm a huge proponent of code cleanup and organization,
and this looks like a beautiful example of those.
Finally, the root class, WidgetEvent, has As*Event class. The *
doesn't include the prefix. I.e., for WidgetMouseEvent, the
Hello. I'd like to share the information about new event related stuff
in Gecko.
nsGUIEvent.h defined and implemented all events (except
nsMutationEvent). Additionally, it's included by a lot of files
including some headers. So, this caused changes in the header needing to
waste long time
On 2013-10-23 3:18 AM, Masayuki Nakano wrote:
I hope this change makes you happy!
Thanks for doing this!
Ehsan
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
On 23/10/2013 09:18, Masayuki Nakano wrote:
I hope this change makes you happy!
It does - this is great stuff! Thank you for all your work on this!
--
Masayuki Nakano masay...@d-toybox.com
Manager, Internationalization, Mozilla Japan.
___
6 matches
Mail list logo