Workaround for hg.mozilla.org timeouts with TBPL try results

2014-01-19 Thread Ed Morley
TBPL try pushes have recently been failing to load, due to problems with the try pushlog on hg.mozilla.org (bug 959769). In the last few days I have landed a workaround in TBPL (bug 721152) that means you can continue to see your job results for a single push, even if the hg.mozilla.org

Re: Workaround for hg.mozilla.org timeouts with TBPL try results

2014-01-19 Thread Ed Morley
On 19 January 2014 16:35:11, Ed Morley wrote: In addition, this change will mean that try repository resets (done periodically to avoid problems with the way we abuse mercurial for try server) will no longer stop you accessing old job results - as long as you have the revision URL from the

Re: Toolkit sub-module Preferred Reviewers who are not Toolkit Peers

2014-01-19 Thread Dave Townsend
Everyone who is a preferred reviewer should be a peer, if they aren't it's likely because I forgot to update the appropriate lists. Who do you see who is absent from the peer list? On Sat, Jan 18, 2014 at 11:51 AM, Matthew N. ma...@mozilla.com wrote: Hello, What does it mean to be a

Re: Workaround for hg.mozilla.org timeouts with TBPL try results

2014-01-19 Thread Gijs Kruitbosch
On 19/01/2014 16:38, Ed Morley wrote: On 19 January 2014 16:35:11, Ed Morley wrote: In addition, this change will mean that try repository resets (done periodically to avoid problems with the way we abuse mercurial for try server) will no longer stop you accessing old job results - as long as

Re: Exact rooting is now enabled on desktop

2014-01-19 Thread Chris Peterson
On 1/18/14, 9:04 AM, Terrence Cole wrote: Great question! We have a tool called GC zeal in builds with --enable-gc-zeal and in all debug builds unconditionally. It adds a small runtime overhead, but gives us fine-grained control over when GC's happen and adds several verification modes for

Re: Toolkit sub-module Preferred Reviewers who are not Toolkit Peers

2014-01-19 Thread Matthew N.
Thanks for clarifying. Myself, Jared Wein, and Paolo Amadini (Download Manager Owner) seem to be missing from the Toolkit peer list then. Thanks, Matthew On 1/19/14, 8:47 PM, Dave Townsend wrote: Everyone who is a preferred reviewer should be a peer, if they aren't it's likely because I

Re: Toolkit sub-module Preferred Reviewers who are not Toolkit Peers

2014-01-19 Thread Kyle Huey
On Sat, Jan 18, 2014 at 2:03 PM, Ms2ger ms2...@gmail.com wrote: On 01/18/2014 08:51 PM, Matthew N. wrote: Hello, What does it mean to be a Preferred Reviewer (previously called a peer) in a Toolkit sub-module[1] and not be on the list of Toolkit Peers[2]? The Toolkit Code Review page[3]

Re: Toolkit sub-module Preferred Reviewers who are not Toolkit Peers

2014-01-19 Thread Tom Schuster
I refactorted and debugged most of the findbar code. Mike seems to the de facto owner, so I think it makes sense for me to do reviews. I doubt anybody else knows much about the code. There seems to be no submodule for it anyway? On Jan 19, 2014 10:40 PM, Matthew N. ma...@mozilla.com wrote:

Re: Toolkit sub-module Preferred Reviewers who are not Toolkit Peers

2014-01-19 Thread Shih-Chiang Chien
I added a component for captive portal detection about a year ago. Should I update https://wiki.mozilla.org/Toolkit/Submodules myself? Best Regards, Shih-Chiang Chien Mozilla Taiwan On Jan 20, 2014, at 8:17 AM, Tom Schuster t...@schuster.me wrote: I refactorted and debugged most of the

Re: CPP_UNIT_TESTS being removed from make check

2014-01-19 Thread Chris Pearce
Is there trychooser syntax for just running the cpp tests on a try push? And can http://trychooser.pub.build.mozilla.org/ be updated to include it please? :) Cheers, Chris P. On 1/9/2014 7:00 AM, Ted Mielczarek wrote: Hello, Just a heads up that very soon we'll be removing CPP_UNIT_TESTS

Re: Toolkit sub-module Preferred Reviewers who are not Toolkit Peers

2014-01-19 Thread Dave Townsend
Ideally you would have talked to the Toolkit module owner (i.e. me) before adding a new chunk of code to it but Toolkit has basically become the wild-west of modules and I'm not sure what purpose an owner is meant to have at this point. The Submodule page is probably hopelessly out of date at this