Re: Always brace your ifs

2014-02-24 Thread Chris AtLee
On 17:37, Sat, 22 Feb, L. David Baron wrote: On Saturday 2014-02-22 15:57 -0800, Gregory Szorc wrote: On Feb 22, 2014, at 8:18, Kyle Huey m...@kylehuey.com wrote: If you needed another reason to follow the style guide: https://www.imperialviolet.org/2014/02/22/applebug.html Code coverage

Re: Fixing build warnings [was: Re: Always brace your ifs]

2014-02-24 Thread Sylvestre Ledru
On 24/02/2014 05:54, Daniel Holbert wrote: On 02/22/2014 12:26 PM, Hubert Figuière wrote: Now we talk about enabling more warning, yet Mozilla codebase is far from building warning free Maybe we should start with that first? FWIW, I (and others) have been working on that, as a side

Re: Fixing build warnings [was: Re: Always brace your ifs]

2014-02-24 Thread Daniel Holbert
On 02/24/2014 08:25 AM, Sylvestre Ledru wrote: By the way, do you have any plan to do the same with these libraries and forward the patches upstream? I don't have concrete plans to do this, but others are welcome to! It's often more difficult (with less immediate benefit) to fix warnings in

Re: Fixing build warnings [was: Re: Always brace your ifs]

2014-02-24 Thread Ralph Giles
On 2014-02-24 9:21 AM, Daniel Holbert wrote: a) We try to avoid directly modifying third-party code in m-c, since any such patches would be clobbered on the next library-update. So we may not be able to directly fix our in-tree copy of the code, unless it's really important. FWIW in the media

Re: Fixing build warnings [was: Re: Always brace your ifs]

2014-02-24 Thread Chris Peterson
On 2/23/14, 8:54 PM, Daniel Holbert wrote: We currently have only 100-200 build warnings[1], if you filter out warnings from third-party libraries that we import (e.g. cairo, skia, protobuf, ICU, various media codecs). On my machine, Firefox for OS X has 284 warnings, but only 24 are from

Re: Use of MOZ_ARRAY_LENGTH for static constants?

2014-02-24 Thread Chris Peterson
On 2/23/14, 4:05 PM, Neil wrote: Both ArrayLength and MOZ_ARRAY_LENGTH are typesafe when compiled as C++, however ArrayLength has the disadvantage that it's not a constant expression in MSVC. In unoptimised builds this is direly slow as the templated function does not even get inlined, but even

Re: We live in a memory-constrained world

2014-02-24 Thread Chris Peterson
On 2/22/14, 1:39 PM, Nicholas Nethercote wrote: On Sat, Feb 22, 2014 at 11:22 PM, Andreas Gal andreas@gmail.com wrote: So, I'm wondering how much effort we should put in reducing the number of ChromeWorkers. We should continue to use JS in Chrome where it makes sense. Its often easier

Re: We live in a memory-constrained world

2014-02-24 Thread Ben Kelly
On 2/21/2014 5:40 PM, Brian Smith wrote: On Fri, Feb 21, 2014 at 1:38 PM, Nicholas Nethercote n.netherc...@gmail.com wrote: Optimizations that wouldn't have been worthwhile in the desktop-only days are now worthwhile. For example, an optimization that saves 100 KiB of memory per process is

Re: Visual Studio Project Generation

2014-02-24 Thread Honza Bambas
On 2/21/2014 7:31 AM, Yuan Xulei(袁徐磊) wrote: That's really good! I'm looking forward to eclipse project generation feature. +1 -hb- PS: Gregory, thanks for your work on VS project generation! It's a pretty good stuff. ___ dev-platform mailing

Rendering meeting, Monday 5:30pm PDT (the later time)

2014-02-24 Thread Milan Sreckovic
The Rendering meeting is about all things Gfx, Image, Layout, and Media. It takes place every second Monday, alternating between 2:30pm PDT and 5:30pm PDT. The next meeting will take place today, Monday, February 24th at 5:30 PM US/Pacific Please add to the agenda:

Including Adobe CMaps

2014-02-24 Thread Brendan Dahl
PDF.js plans to soon start including and using Adobe CMap files for converting character codes to character id’s(CIDs) and mapping character codes to unicode values. This will fix a number of bugs in PDF.js and will improve our support for Chinese, Korean, and Japanese(CJK) documents. I wanted

Re: Including Adobe CMaps

2014-02-24 Thread Andreas Gal
Is this something we could load dynamically and offline cache? Andreas Sent from Mobile. On Feb 24, 2014, at 23:41, Brendan Dahl bd...@mozilla.com wrote: PDF.js plans to soon start including and using Adobe CMap files for converting character codes to character id's(CIDs) and mapping

Re: Including Adobe CMaps

2014-02-24 Thread Kyle Huey
On Mon, Feb 24, 2014 at 3:01 PM, Andreas Gal andreas@gmail.com wrote: Is this something we could load dynamically and offline cache? Andreas Sent from Mobile. On Feb 24, 2014, at 23:41, Brendan Dahl bd...@mozilla.com wrote: PDF.js plans to soon start including and using Adobe CMap

Re: Including Adobe CMaps

2014-02-24 Thread Ralph Giles
On 2014-02-24 2:41 PM, Brendan Dahl wrote: There are 168 files with an average size of ~40KB, and all of the files together are roughly: 6.9M 2.2M when gzipped IIRC mupdf was able to save significant space by pre-parsing the files. Their code for that is GPL (and oriented toward compiling-in

Re: Including Adobe CMaps

2014-02-24 Thread Rik Cabanier
On Mon, Feb 24, 2014 at 3:01 PM, Andreas Gal andreas@gmail.com wrote: Is this something we could load dynamically and offline cache? That should be possible. The CMap name is in the PDF so Firefox could download it on demand. Also, if the user has acrobat, the CMaps are already on their

Re: Including Adobe CMaps

2014-02-24 Thread Brendan Dahl
It’s certainly possible to load dynamically. Do we currently do this for any other Firefox resources? From what I’ve seen, many PDF’s use CMaps even if they don’t necessarily have CJK characters, so it may just be better to include them. FWIW both Popper and Mupdf embed the CMaps. Brendan

Re: Including Adobe CMaps

2014-02-24 Thread Andreas Gal
My assumption is that certain users only need certain CMaps because they tend to read only documents in certain languages. This seems like something we can really optimize and avoid ahead-of-time download cost for. The fact that we don’t do this yet doesn’t seem like a good criteria. There is

Re: We live in a memory-constrained world

2014-02-24 Thread John Schoenick
On 02/21/2014 02:57 PM, Nicholas Nethercote wrote: On Sat, Feb 22, 2014 at 9:40 AM, Brian Smith br...@briansmith.org wrote: How worthwhile is it to cut 100KiB from the parent process? We don't have a fixed memory budget per se. If it's easy and doesn't have bad side-effects, do it.

Re: We live in a memory-constrained world

2014-02-24 Thread Ehsan Akhgari
Nick, do we run any kind of automated leak checking through valgrind? I found bug 976363 today, it's something that any automated leak detection tool should be able to catch. Thanks! Ehsan On 2/21/2014, 4:38 PM, Nicholas Nethercote wrote: Greetings, We now live in a memory-constrained

Re: We live in a memory-constrained world

2014-02-24 Thread Nicholas Nethercote
On Mon, Feb 24, 2014 at 6:50 PM, Ehsan Akhgari ehsan.akhg...@gmail.com wrote: Nick, do we run any kind of automated leak checking through valgrind? I found bug 976363 today, it's something that any automated leak detection tool should be able to catch. The Valgrind test job does leak

Re: We live in a memory-constrained world

2014-02-24 Thread Andrew McCreight
- Original Message - The Valgrind test job does leak checking, and it's recently caught some leaks and caused the offending patches to be backed out. However, the test coverage is pretty meagre, and it's desktop only so can't detect leaks in IPC code. I believe the ASan builds also

Proposed W3C Charter: Timed Text Working Group (WebVTT and TTML)

2014-02-24 Thread L. David Baron
The W3C is proposing a revised charter for: Timed Text Working Group http://lists.w3.org/Archives/Public/public-new-work/2014Feb/0004.html http://www.w3.org/2013/10/timed-text-charter.html deadline for comments: March 20 This new charter is quite substantive, in that it recharters a

Proposed W3C Charter: Geolocation Working Group

2014-02-24 Thread L. David Baron
The W3C is proposing a revised charter for: Geolocation Working Group http://lists.w3.org/Archives/Public/public-new-work/2014Feb/0002.html http://www.w3.org/2014/02/geo-charter.html deadline for comments: March 15 I don't know any of the background on this one. Mozilla has the