Re: Intent to implement: Frame Timing API

2015-04-27 Thread Brian Birtles
On 2015/04/28 10:43, Jonas Sicking wrote: Please make sure to do a security review so that this doesn't expose any sensitive information accidentally. In particular, is there any way to use this API to use :visited hacks along with timing information to see if a user has visited a particular URL?

Re: RFC: Navigation transitions

2015-04-27 Thread Jonas Sicking
This is awesome!! I completely agree that the Google proposal is much too complicated for an initial take on solving transitions. I agree with Anne that this should be doable by adding CSS rules to a normal stylesheet rather than using a special linking mechanism. If that sounds good to you, then

Re: Announcing Operation Instrument

2015-04-27 Thread Robert O'Callahan
How is this related to PROFILER_LABELs, docshell ProfileTimelineMarkers, and VisualEventTracer? Rob -- oIo otoeololo oyooouo otohoaoto oaonoyooonoeo owohooo oioso oaonogoroyo owoiotoho oao oboroootohoeoro oooro osoiosotoeoro owoiololo oboeo osouobojoeocoto otooo ojouodogomoeonoto.o oAogoaoiono,o

Re: Proposal to alter the coding style to not require the usage of 'virtual' where 'override' is used

2015-04-27 Thread Trevor Saunders
On Mon, Apr 27, 2015 at 09:07:51PM -0400, Ehsan Akhgari wrote: > On Mon, Apr 27, 2015 at 5:45 PM, Trevor Saunders > wrote: > > > On Mon, Apr 27, 2015 at 03:48:48PM -0400, Ehsan Akhgari wrote: > > > Right now, our coding style requires that both the virtual and override > > > keywords to be specif

Re: Intent to implement: Frame Timing API

2015-04-27 Thread Jonas Sicking
Please make sure to do a security review so that this doesn't expose any sensitive information accidentally. In particular, is there any way to use this API to use :visited hacks along with timing information to see if a user has visited a particular URL? / Jonas On Mon, Apr 27, 2015 at 2:27 AM,

Re: Proposal to alter the coding style to not require the usage of 'virtual' where 'override' is used

2015-04-27 Thread Ehsan Akhgari
On Mon, Apr 27, 2015 at 5:45 PM, Trevor Saunders wrote: > On Mon, Apr 27, 2015 at 03:48:48PM -0400, Ehsan Akhgari wrote: > > Right now, our coding style requires that both the virtual and override > > keywords to be specified for overridden virtual functions. A few things > > have changed since

Re: Proposal to alter the coding style to not require the usage of 'virtual' where 'override' is used

2015-04-27 Thread Ehsan Akhgari
That's correct. Using override and final on a non-virtual function is a compile time error. On Apr 27, 2015 5:34 PM, "L. David Baron" wrote: > On Monday 2015-04-27 15:48 -0400, Ehsan Akhgari wrote: > > Right now, our coding style requires that both the virtual and override > > keywords to be spec

Re: Announcing Operation Instrument

2015-04-27 Thread Nick Fitzgerald
Wow. Email formatting fail. Hopefully this turns out a little better: """ Hello platform hackers! [Operation Instrument](https://wiki.mozilla.org/DevTools/OperationInstrument) is a project that aims to add tracing instrumentation to Gecko and provide a holistic view of where time is being spent a

Announcing Operation Instrument

2015-04-27 Thread Nick Fitzgerald
Hello platform hackers!​ ​[​ Operation Instrument ​] (htt ​​ ps://wiki.mozilla.org/DevTools/OperationInstrument)​ is a project that aims to add tracing instrumentation to Gecko and provide a holistic view of where time is being spent and why. Examples of traced operations include: * ​ ​ ​ Style

Re: Proposal to alter the coding style to not require the usage of 'virtual' where 'override' is used

2015-04-27 Thread Trevor Saunders
On Mon, Apr 27, 2015 at 03:48:48PM -0400, Ehsan Akhgari wrote: > Right now, our coding style requires that both the virtual and override > keywords to be specified for overridden virtual functions. A few things > have changed since we decided that a number of years ago: > > 1. The override and fi

Re: Proposal to alter the coding style to not require the usage of 'virtual' where 'override' is used

2015-04-27 Thread Daniel Holbert
On 04/27/2015 01:47 PM, Daniel Holbert wrote: > BUT, if we add back the "virtual" keyword, we *lose some strictness*. In > other words, this is *not* equivalent to the versions above: > "virtual void foo() final" > Unless the formulations above, this version isn't guaranteed to override. (er s/U

Re: Proposal to alter the coding style to not require the usage of 'virtual' where 'override' is used

2015-04-27 Thread Daniel Holbert
On 04/27/2015 12:48 PM, Ehsan Akhgari wrote: > I think we should > change it to require the usage of exactly one of these keywords per > *overridden* function: virtual, override, and final. Let me attempt to clarify why the "exactly one" requirement here is important. (It's non-obvious.) This ver

Re: Proposal to alter the coding style to not require the usage of 'virtual' where 'override' is used

2015-04-27 Thread Seth Fowler
I completely support this. Let the needless verbosity end! - Seth > On Apr 27, 2015, at 12:48 PM, Ehsan Akhgari wrote: > > Right now, our coding style requires that both the virtual and override > keywords to be specified for overridden virtual functions. A few things > have changed since we d

Proposal to alter the coding style to not require the usage of 'virtual' where 'override' is used

2015-04-27 Thread Ehsan Akhgari
Right now, our coding style requires that both the virtual and override keywords to be specified for overridden virtual functions. A few things have changed since we decided that a number of years ago: 1. The override and final keywords are now available on all of the compilers that we build with

Re: You can now log into BMO with your GitHub account

2015-04-27 Thread Nicholas Alexander
On Mon, Apr 27, 2015 at 7:15 AM, Mark Côté wrote: > This morning we enabled a feature on bugzilla.mozilla.org that allows > users to log in with their GitHub credentials, similar to our existing > Persona support. If you have several email addresses associated with > your GitHub account, you wil

Re: (mozci) Triggering jobs on treeherder

2015-04-27 Thread Armen Zambrano G.
Thank you all for reading through the post and the feedback. It seems that there is interest for this. On 15-04-24 06:06 PM, Mike Hommey wrote: On Fri, Apr 24, 2015 at 10:26:58PM +0100, Gijs Kruitbosch wrote: Are you going to build a web UI for this so I don't need to check out a repo and run a

Re: You can now log into BMO with your GitHub account

2015-04-27 Thread Mike Hoye
On 2015-04-27 10:54 AM, Mark Côté wrote: On 2015-04-27 10:41 AM, Mike Hoye wrote: What does "special administrative or security permissions" mean? Can a user logged in via GitHub have editbugs or canconfirm? editbugs and canconfirm on their own are fine. The vast majority of users will be able

Re: You can now log into BMO with your GitHub account

2015-04-27 Thread Mark Côté
On 2015-04-27 10:41 AM, Mike Hoye wrote: > On 2015-04-27 10:15 AM, Mark Côté wrote: >> This morning we enabled a feature on bugzilla.mozilla.org that allows >> users to log in with their GitHub credentials, similar to our existing >> Persona support. If you have several email addresses associated

Re: You can now log into BMO with your GitHub account

2015-04-27 Thread Ehsan Akhgari
On 2015-04-27 10:41 AM, Mike Hoye wrote: On 2015-04-27 10:15 AM, Mark Côté wrote: This morning we enabled a feature on bugzilla.mozilla.org that allows users to log in with their GitHub credentials, similar to our existing Persona support. If you have several email addresses associated with you

Re: You can now log into BMO with your GitHub account

2015-04-27 Thread Mike Hoye
On 2015-04-27 10:15 AM, Mark Côté wrote: This morning we enabled a feature on bugzilla.mozilla.org that allows users to log in with their GitHub credentials, similar to our existing Persona support. If you have several email addresses associated with your GitHub account, you will be prompted to

You can now log into BMO with your GitHub account

2015-04-27 Thread Mark Côté
This morning we enabled a feature on bugzilla.mozilla.org that allows users to log in with their GitHub credentials, similar to our existing Persona support. If you have several email addresses associated with your GitHub account, you will be prompted to choose one. In either case, if your chosen

Re: NS_LITERAL_CSTRING

2015-04-27 Thread Ehsan Akhgari
On 2015-04-27 6:29 AM, Neil wrote: NS_LITERAL_STRING, as its name suggests, only ever gets used on string literals, or macros that expand to string literals. NS_LITERAL_CSTRING gets (ab?)used in all sorts of ways. Should we be consistent and require NS_LITERAL_CSTRING to be used on string litera

NS_LITERAL_CSTRING

2015-04-27 Thread Neil
NS_LITERAL_STRING, as its name suggests, only ever gets used on string literals, or macros that expand to string literals. NS_LITERAL_CSTRING gets (ab?)used in all sorts of ways. Should we be consistent and require NS_LITERAL_CSTRING to be used on string literals? I found the following in-tree

xulrunner under android and libxpcom.so missing

2015-04-27 Thread Suppaman
Hi all I want to develop an multiplatform application for Windows and Android with web browse capabilties. The application will be written using C++. Under Windows no problem but looking into xulrunner version for android I don't find the library "libxpcom.so" to use for run xul gecko engine. T

Intent to implement: Frame Timing API

2015-04-27 Thread Hiroyuki Ikezoe
Summary: Provides an interface for receiving frame performance timing including composites happening on a separate thread/process. This can be used to calculate measures of smoothness that incorporate the effect of async pan and zoom and off-main thread animation. Bug: https://bugzilla.mozilla.org