Hiding 'new' statements - Good or Evil?

2017-11-22 Thread gsquelart
Should we allow hiding 'new' statements, or keep them as visible as possible? Some context: Recently in bug 1410252 I added a MakeNotNull(args...) function that does `NotNull(new T(args...))`, in the style of MakeUnique and others. It also works with RefPtr. My first goal was to avoid

Intent to ship: webvtt region

2017-11-22 Thread bechen
We are going to enable the webvtt region preference soon. It is a very useful feature for the developer/content provider to place the caption in a specific area(region). And in the feature, we can apply css styles on it. Related Bugs: Bug 1415821 - [webvtt] support multi-line region parsing.

Intent to remove: WebVR on insecure contexts

2017-11-22 Thread Kearwood Kip Gilbert
Summary: WebVR on insecure contexts (i.e. web sites served over non-HTTPS) is deprecated and will soon stop working in Firefox. Sites wanting to use WebVR should switch to HTTPS if they have not already. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1381645 Link to standard:

Re: Intent to implement: scroll-boundary-behavior

2017-11-22 Thread Botond Ballo
For those following along, please note that this CSS property has been renamed from 'scroll-boundary-behavior' to 'overscroll-behavior'. The spec is accordingly now at [1], and the preference for controlling the feature has changed correspondingly. Cheers, Botond [1]

Re: About --disable-stylo [was: Re: Fennec/Android turns on Quantum CSS (stylo) as default]

2017-11-22 Thread Tom Ritter
On Wed, Nov 22, 2017 at 10:36 AM, Sylvestre Ledru wrote: > > > On 22/11/2017 17:25, Tom Prince wrote: >> On Wed, Nov 22, 2017 at 8:51 AM Jet Villegas wrote: >> >>> Do you have a use case for shipping the ESR with --disable-stylo? >>> >> Thunderbird in a

About --disable-stylo [was: Re: Fennec/Android turns on Quantum CSS (stylo) as default]

2017-11-22 Thread Sylvestre Ledru
On 22/11/2017 17:25, Tom Prince wrote: > On Wed, Nov 22, 2017 at 8:51 AM Jet Villegas wrote: > >> Do you have a use case for shipping the ESR with --disable-stylo? >> > Thunderbird in a similar position to Tor. Our current build system is on > fairly old infrastructure

Re: Fennec/Android turns on Quantum CSS (stylo) as default

2017-11-22 Thread Emilio Cobos Álvarez
On 11/22/2017 05:15 PM, Tom Ritter wrote: > On Wed, Nov 22, 2017 at 9:51 AM, Jet Villegas wrote: >> Do you have a use case for shipping the ESR with --disable-stylo? We want to >> be very quick about removing the legacy C++ style system as it adds >> significant impedance

Re: Fennec/Android turns on Quantum CSS (stylo) as default

2017-11-22 Thread Tom Prince
On Wed, Nov 22, 2017 at 8:51 AM Jet Villegas wrote: > Do you have a use case for shipping the ESR with --disable-stylo? > Thunderbird in a similar position to Tor. Our current build system is on fairly old infrastructure that has issues compiling stylo. I'm busy porting

Re: Fennec/Android turns on Quantum CSS (stylo) as default

2017-11-22 Thread Tom Ritter
On Wed, Nov 22, 2017 at 9:51 AM, Jet Villegas wrote: > Do you have a use case for shipping the ESR with --disable-stylo? We want to > be very quick about removing the legacy C++ style system as it adds > significant impedance to new feature development. I have not heard of

Re: Fennec/Android turns on Quantum CSS (stylo) as default

2017-11-22 Thread Jet Villegas
Do you have a use case for shipping the ESR with --disable-stylo? We want to be very quick about removing the legacy C++ style system as it adds significant impedance to new feature development. I have not heard of any site breakage that would warrant keeping --disable-stylo after Stylo is in

Re: Fennec/Android turns on Quantum CSS (stylo) as default

2017-11-22 Thread Tom Ritter
On Wed, Nov 22, 2017 at 8:08 AM, Makoto Kato wrote: > When enabling stylo, explicit memory will be 2-3% grow on Linux from > AWSY, so android will be same rate > > Also, APK size grows 1.5MB now. But stylo team is working to remove > old style system. Is there a

Re: Fennec/Android turns on Quantum CSS (stylo) as default

2017-11-22 Thread Makoto Kato
When enabling stylo, explicit memory will be 2-3% grow on Linux from AWSY, so android will be same rate Also, APK size grows 1.5MB now. But stylo team is working to remove old style system. -- Makoto Kato On Wed, Nov 22, 2017 at 7:38 PM, Astley Chen wrote: > Cool! Thanks

Re: Fennec/Android turns on Quantum CSS (stylo) as default

2017-11-22 Thread Astley Chen
Cool! Thanks for the hard work to make it happen! As for mobile constraints, we are concerning the code size and memory usage. Do we know what’s the impact for now? Makoto Kato 於 2017年11月22日 週三，下午6:09寫道： > Last month, I enabled building stylo as default even if Fennec.