PSA: Avoid invoking Debug formatters in release-mode Rust

TL;DR: To prevent code bloat, avoid {:?} in format strings for panic!(), unreachable!(), error!(), warn!(), and info!() for Rust code that ships in Gecko. Longer version: One nice thing about Rust is that you can #[derive(Debug)] for a type, and the compiler will generate a stringification

Intent to remove: some methods of nsIEditActionListener or the interface itself

I'd like to remove unnecessary methods of nsIEditActionListener or nsIEditActionListener itself completely. This is not buildinclass. So, this can be implemented by XUL addons. Currently, this is used only by ThunderHTMLedit (only Did*()). Additionally, 3 internal classes of Gecko implements

Re: PSA: searchfox now indexes rust

On 01/12/2018 11:48 AM, Kartikaya Gupta wrote: On Fri, Jan 12, 2018 at 2:03 PM, Nicholas Alexander wrote: Does SF index non-trunk trees? I can't find a way to search mozilla-{release,beta} right now. Please correct me if it does? It does not. I don't know too much

Re: Intent to unship: remote jar: protocol pref

I should have been explicit about my considerations for telemetry; apologies for not doing so upfront. The bug for the removal of telemetry code claims usage was 0.01% of sessions 9 months ago, before the pref was flipped. I think that's fine in terms of removing things. I don't think we

Re: Intent to unship: remote jar: protocol pref

On 12/01/2018 22:12, Gijs Kruitbosch wrote: As Kris already pointed out in his footnote, the most likely group of people to have enabled this (given 0 public reports on breakage so far, as far as I'm aware) are people on ESR or otherwise in enterprise environments, and our collection rates on

Re: Intent to unship: remote jar: protocol pref

Telemetry was removed in 55: https://bugzilla.mozilla.org/show_bug.cgi?id=1358004 You can still query it on tmo for 54... except it seems to give me a JS error. -tom On Fri, Jan 12, 2018 at 3:55 PM, Kris Maglione wrote: > Do we have telemetry on the usage of the

Re: Intent to unship: remote jar: protocol pref

Do we have telemetry on the usage of the preference or of remote JAR channels? If not, it shouldn't be hard to add, and would be a lot safer than guessing[1]. Either way, I definitely agree that it would be nice to get rid of this. -Kris [1]: Except, of course, that it wouldn't tell us much

Intent to unship: remote jar: protocol pref

Hello, jar: is an internal protocol that enables loading resources from inside a jar/zip file . Firefox is the only browser I'm aware of that supports it. In Firefox 55, due to security concerns, we put using jar: with remote content (ie loaded over http(s), ftp - anything apart from

Re: PSA: searchfox now indexes rust

On Fri, Jan 12, 2018 at 2:03 PM, Nicholas Alexander wrote: > Does SF index non-trunk trees? I can't find a way to search > mozilla-{release,beta} right now. Please correct me if it does? It does not. ___ dev-platform mailing

Re: PSA: searchfox now indexes rust

On Mon, Jan 8, 2018 at 1:51 PM, Mike Hommey wrote: > On Mon, Jan 08, 2018 at 11:15:13AM -0500, Kartikaya Gupta wrote: > > Just a heads-up, thanks to a bunch of work by Emilio, searchfox.org > > now indexes rust code as well, so you can do things like jump to > > function

Re: Intent to Implement: canvas-imagedata permission

On Thu, Jan 11, 2018 at 10:26 AM, Gervase Markham wrote: > On 10/01/18 18:40, Tom Ritter wrote: >> This proposal is that. Add a permission 'canvas-imagedata' that will >> return 'granted' when Resist Fingerprinting mode is disabled, and >> 'prompt' when RP is enabled and

Re: Inheriting annotations into included reftest.list files

Closing the loop: the changes in bug 1429580 have landed, and so now doing "skip-if(foo) include bar/reftest.list" behaves as one would expect, and skips the include entirely if the foo condition is true. On Wed, Jan 10, 2018 at 4:01 PM, L. David Baron wrote: > On Wednesday