Re: Running C++ early in shutdown without an observer
On Fri, Jun 07, 2019 at 11:40:05AM -0700, Chris Peterson wrote: Note that on Android, you may never get an opportunity for a clean shutdown because the OS can kill your app at any time. I don't know what is the recommendation for shutdown activities on Android. The GeckoView team has had some recent bugs caused by shutdown tasks not running (e.g. committing cached font files or deleting temp files). I think these tasks were moved to startup or scheduled to run periodically. A lot of things really need to have flush timeouts with shutdown blockers for their finalizers. In JS land, we have helpers like DeferredTask and JSONFile for that. I don't think we really have anything comparable for C++. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Running C++ early in shutdown without an observer
Even on Desktop, we needed to move some cleanup to startup, in case the process was killed by the OS. On 07/06/2019 20:40, Chris Peterson wrote: > On 6/7/2019 9:36 AM, Kris Maglione wrote: >> On Fri, Jun 07, 2019 at 09:18:38AM +0300, Henri Sivonen wrote: >>> For late shutdown cleanup, we have nsLayoutStatics::Shutdown(). Do we >>> have a similar method for running things as soon as we've decided that >>> the application is going to shut down? >>> >>> (I know there are observer topics, but I'm trying to avoid having to >>> create an observer object and to make sure that _it_ gets cleaned up >>> properly.) >> >> Observers are automatically cleaned up at XPCOM shutdown, so you >> generally don't need to worry too much about them. That said, >> nsIAsyncShutdown is really the way to go when possible. But it >> currently requires an unfortunate amount of boilerplate. > > Note that on Android, you may never get an opportunity for a clean > shutdown because the OS can kill your app at any time. > > I don't know what is the recommendation for shutdown activities on > Android. The GeckoView team has had some recent bugs caused by shutdown > tasks not running (e.g. committing cached font files or deleting temp > files). I think these tasks were moved to startup or scheduled to run > periodically. > ___ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Running C++ early in shutdown without an observer
On 6/7/2019 9:36 AM, Kris Maglione wrote: On Fri, Jun 07, 2019 at 09:18:38AM +0300, Henri Sivonen wrote: For late shutdown cleanup, we have nsLayoutStatics::Shutdown(). Do we have a similar method for running things as soon as we've decided that the application is going to shut down? (I know there are observer topics, but I'm trying to avoid having to create an observer object and to make sure that _it_ gets cleaned up properly.) Observers are automatically cleaned up at XPCOM shutdown, so you generally don't need to worry too much about them. That said, nsIAsyncShutdown is really the way to go when possible. But it currently requires an unfortunate amount of boilerplate. Note that on Android, you may never get an opportunity for a clean shutdown because the OS can kill your app at any time. I don't know what is the recommendation for shutdown activities on Android. The GeckoView team has had some recent bugs caused by shutdown tasks not running (e.g. committing cached font files or deleting temp files). I think these tasks were moved to startup or scheduled to run periodically. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: To what extent is sccache's distributed compilation usable?
I've been working through issues with distributed sccache, but I've recently sent instructions to people currently running icecream in the SF office on how to switch to running sccache-dist with IT managed hardware. We're going to use that as a test bed before rolling out more widely, and if all goes well there this should happen shortly (likely shortly after returning from Whistler). Regarding that bug, that's tracking IT work for the most part so probably needs to stay restricted. Most of the work I've been doing is tracked in sccache's github repo and can be followed there, or tracked by https://bugzilla.mozilla.org/show_bug.cgi?id=1499145. Chris On Wed, Jun 5, 2019 at 1:52 AM Miko Mynttinen wrote: > Has there been any progress with this? Bug 1524533 is still restricted. > > Miko > > > On Apr 2, 2019, at 10:39 PM, Jeff Muizelaar > wrote: > > > > That bug is restricted. Does it need to be? > > > > -Jeff > > > > On Tue, Apr 2, 2019 at 4:22 PM Kim Moir wrote: > >> > >> The tracking bug for sccache being deployed to offices is here > >> > >> https://bugzilla.mozilla.org/show_bug.cgi?id=1524533 > >> > >> Kim > >> > >> On Tue, Apr 2, 2019 at 3:22 AM Frederik Braun > wrote: > >> > >>> Am 01.04.19 um 22:16 schrieb Chris M.: > Hi Emilio, if you're interested you're encouraged to try it out, > however > we're shipping machines to offices now to run the schedulers, the > first > >>> of > which I'll be testing in the SF office this week, so we're planning an > officially supported setup in the near future. > > >>> > >>> That's great news. Can we follow progress or detailed plans somewhere? > >>> ___ > >>> dev-platform mailing list > >>> dev-platform@lists.mozilla.org > >>> https://lists.mozilla.org/listinfo/dev-platform > >>> > >> ___ > >> dev-platform mailing list > >> dev-platform@lists.mozilla.org > >> https://lists.mozilla.org/listinfo/dev-platform > > ___ > > dev-platform mailing list > > dev-platform@lists.mozilla.org > > https://lists.mozilla.org/listinfo/dev-platform > > ___ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Running C++ early in shutdown without an observer
On Fri, Jun 07, 2019 at 09:18:38AM +0300, Henri Sivonen wrote: For late shutdown cleanup, we have nsLayoutStatics::Shutdown(). Do we have a similar method for running things as soon as we've decided that the application is going to shut down? (I know there are observer topics, but I'm trying to avoid having to create an observer object and to make sure that _it_ gets cleaned up properly.) Observers are automatically cleaned up at XPCOM shutdown, so you generally don't need to worry too much about them. That said, nsIAsyncShutdown is really the way to go when possible. But it currently requires an unfortunate amount of boilerplate. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Intent to implement and ship: blob.text(), blob.arrayBuffer(), blob.stream()
On 6/7/19 8:47 AM, Andrea Marchesini wrote: Summary: implement and ship 3 new methods to read Blob contents: blob.text(), blob.arrayBuffer() and blob.stream(). Looks good to me. -Boris ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Intent to implement and ship: blob.text(), blob.arrayBuffer(), blob.stream()
Summary: implement and ship 3 new methods to read Blob contents: blob.text(), blob.arrayBuffer() and blob.stream(). Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1557121 Link to standard: https://w3c.github.io/FileAPI https://github.com/w3c/FileAPI/pull/117 Platform coverage: all. Estimated or target release: 69 Preference behind which this will be implemented: none. Do other browser engines implement this? Chrome has already shipped these methods. See: https://bugs.chromium.org/p/chromium/issues/detail?id=945893 Safari hasn't started to work on them yet. See: https://bugs.webkit.org/show_bug.cgi?id=196258 web-platform-tests: We have existing WPTs. See: https://github.com/web-platform-tests/wpt/blob/master/FileAPI/blob Is this feature restricted to secure contexts? No. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Running C++ early in shutdown without an observer
Have you looked at nsIAsyncShutdown? On 07/06/2019 08:18, Henri Sivonen wrote: > For late shutdown cleanup, we have nsLayoutStatics::Shutdown(). Do we > have a similar method for running things as soon as we've decided that > the application is going to shut down? > > (I know there are observer topics, but I'm trying to avoid having to > create an observer object and to make sure that _it_ gets cleaned up > properly.) > ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Running C++ early in shutdown without an observer
For late shutdown cleanup, we have nsLayoutStatics::Shutdown(). Do we have a similar method for running things as soon as we've decided that the application is going to shut down? (I know there are observer topics, but I'm trying to avoid having to create an observer object and to make sure that _it_ gets cleaned up properly.) -- Henri Sivonen hsivo...@mozilla.com ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
