I also added a link at
https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch#Creating_a_patch
Benoit Girard writes:
I didn't know this existed. I filed bug 995763 to get this link added to
the 'review requested' email to hopefully increase visibility.
On Sat, Apr
Joshua Cranmer . writes:
On 4/13/2014 4:42 PM, Robert O'Callahan wrote:
Honestly, I think we're already pretty close to most of those
recommendations, most of the time.
Some experienced Mozillians are breaking up their large changes
well, but some are not. And many less experienced
Gregory Szorc writes:
2) Run marked intermittent tests multiple times. If it works all
25 times, fail the test run for inconsistent metadata.
We need to consider intermittently failing tests as failed, and we
need to only test things that always pass.
We can't rely on statistics to tell us
Randell Jesup writes:
1) running on TBPL (AWS) the internal timings reported show the specific
test going from 30 seconds to 450 seconds with the patch.
2) on my local system, the test self-reports ~10 seconds, with or
without the patch.
Note: the timer in question is
Aryeh Gregor writes:
On Tue, Apr 8, 2014 at 2:41 AM, Ehsan Akhgari ehsan.akhg...@gmail.com wrote:
What you're saying above is true *if* someone investigates the
intermittent test failure and determines that the bug is not
important. But in my experience, that's not what happens at
all. I
chiaki ISHIKAWA writes:
I think 7.2 10 is also relevant here.
--- quote ---
An expression of arithmetic or enumeration type can be converted
to an enumeration type explicitly. The
value is unchanged if it is in the range of enumeration values of
the enumeration type; otherwise the
On Fri, 04 Apr 2014 11:03:57 -0400, Zack Weinberg wrote:
On Tue, Apr 1, 2014 at 10:13 PM, Karl Tomlinson mozn...@karlt.net
wrote:
Does WARNINGS_AS_ERRORS make the default:MOZ_CRASH()
unnecessary?
No, because it's possible that the thing you're testing is not
actually a valid enum value
On Fri, 4 Apr 2014 12:49:45 -0700 (PDT), jmaher wrote:
overburdened in other ways (e.g., reviews). the burden
needs to be placed on the regressing change rather than the original
author of the test.
I am open to ideas to help figure out the offending changes. My
understanding is many of
On Fri, 4 Apr 2014 11:58:28 -0700 (PDT), jmaher wrote:
Two exceptions:
2) When we are bringing a new platform online (Android 2.3, b2g, etc.) many
tests will need to be disabled prior to getting the tests on tbpl.
It makes sense to disable some tests so that others can run.
I assume bugs
chiaki ISHIKAWA writes:
(2014/04/07 10:16), Karl Tomlinson wrote:
because enumeration types may hold values that don't match any of
their enumerator values.
Is this allowed by C (or C++) specification today?
It is allowed in N3242. I think the relevant sections are
5.2.9 Static cast
10
Jason Orendorff writes:
If the code is truly unreachable, it doesn't matter what we replace it
with. The question is what to do when the impossible occurs. To me,
letting control flow past such a place is just as scary as undefined
behavior.
That depends on the particular code. Often
Zack Weinberg writes:
This is a bit of a tangent, but: There are a whole bunch of places in
layout, and probably elsewhere, where we have the following catch-22:
if you have a switch statement over the values of an enumeration, gcc
and clang (with -Wall) will warn you about enumeration values
Karl Tomlinson writes:
Jason Orendorff writes:
If the code is truly unreachable, it doesn't matter what we replace it
with. The question is what to do when the impossible occurs. To me,
letting control flow past such a place is just as scary as undefined
behavior.
That depends
Benjamin Smedberg writes:
I think in general we should be willing to make more of our
assertions fatal in release builds, especially in
non-performance-sensitive code. Of course the choice of assertion
depends on the characteristics of what's being asserted.
Sounds good.
Neil n...@parkwaycc.co.uk writes:
I tried to push a patch which changes the DOM of the HTML
directory listing page but it tripped over this assertion while
running an RTL test.
It seems to be something to do with the reflow caused by the
loading of the icons on an RTL directory listing
Jason Orendorff writes:
On 3/24/14, 2:42 AM, K. Gadd wrote:
There are two collectors.
The JS engine's garbage collector runs more frequently.
The XPCOM cycle collector runs less often.
That may be true in some scenarios, but I sometimes observe the
cycle collector running more frequently
Ehsan Akhgari writes:
On 2014-03-19, 10:50 PM, Boris Zbarsky wrote:
On 3/19/14 10:40 PM, Ehsan Akhgari wrote:
Why do we have to touch that list on shutdown?
We Release() all the things in it (nsIWeakReferences in this case).
Well, that was sort of my point (gotta work on my style of being
On Thu, 13 Mar 2014 12:46:14 -0400, Erik Rose wrote:
A lot of you have asked for the ability to select and share ranges within
source files. Now, thanks to contributor Jamon Carmisso, you can:
http://dxr.mozilla.org/mozilla-central/source/content/media/AbstractMediaDecoder.h#7-13
As on
Daniel Holbert writes:
On 02/27/2014 10:26 AM, Zack Weinberg wrote:
Does that mean a patch to squelch the uninitialized variable
warnings in layout will now be accepted? Those are the only
warnings in layout on my (Linux, debug) builds.
layout/base/FrameLayerBuilder.cpp:3462:56
Anthony Jones writes:
There is also some vagueness and inconsistency around:
bool
MyClass::MyFunction()
vs
bool MyClass::MyFunction()
Most of the code seems to do this only for top-level functions i.e. when
not already indented. I'd like some clarification on the rule here. It
seems
Bobby Holley writes:
Note that there in a explicit stylistic exception that NS_WARN_IF
statements do not require braces. So it's:
if (NS_WARN_IF(NS_FAILED(rv)))
return rv;
I don't see that on the current version of
https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style
I
Chris Peterson writes:
If mozilla-central is reformatted, that would be a good time to
also remove the modelines.
5. Remove modelines from mozilla-central files
I'm happy with removal of modelines provided .dir-locals.el files
are added to provide the same functionality.
There is imported
Nicholas Nethercote writes:
We've had some recent discussions about code style. I have a propasal
I'm sceptical about the value of such changes out-weighing the
cost here. I know there will be a cost now and in the future, but
I don't recall seeing any entire files so badly formatted that it
Martin Thomson writes:
I would like to think that adding (or removing) braces from block statements
should be acceptable.
I would argue that braces should not be added with automation.
When debugging code, it is important to understand the intent of
the author. Adding braces at
smaug sm...@welho.com writes:
Why this deprecation?
NS_ENSURE_ macros hid return paths.
Also many people didn't understand that they issued warnings, and
so used the macros for expected return paths.
Was there some useful functionality that is not provided by the
replacements?
Gregory Szorc writes:
I think you just gave an example of why our tooling needs to
identify poorly formatted code better. An if without a brace
followed by multiple indented lines containing compiler
expressions is a bug at worst or unreadable/unclear code at
best. We could, of course,
L. David Baron writes:
I tend to think that we should either:
* stick to 80
* require no wrapping, meaning that comments must be one paragraph
per line, boolean conditions must all be single line, and assume
that people will deal, using an editor that handles such code
usefully
Nicholas Nethercote writes:
- When a job times out, the output produced by Valgrind is
usually chopped off in the middle of a line. In fact, it's
often chopped off in the middle of a line that would have been
produced by a single write() system call. So it feels like the
test harness is
Lawrence Mandel writes:
- Original Message -
On 27/11/13 07:36, Gabriele Svelto wrote:
I'm always tempted to close the former as duplicates of the
actual fix and the latter as WONTFIX so that they won't show
up on the following searches but I'm also afraid that closing
a bug
Henri Sivonen writes:
On *nix platforms, it's not clear to me what exactly the platform
charset is used for these days. An MXR search turns up surprisingly
little.
* Do we (or gtk) really still support non-UTF-8 platform charset
values on *nix? (MXR turns up so little that it makes me
Gregory Szorc writes:
Do we need periodic clobber? It's just wallpapering over legit
clobber-needed issues, which doesn't exactly help us fix them.
The problem is that unfixed bugs in dependences mean that code
bugs can sometimes not show up until the next clobber. There is
then a huge
For the sake of WebGL, GL compositing is most likely the preferred
backend for Linux/X11. Basic layers with Render compositing is
available as a fallback for those without sufficient GL support.
Our goal for X11 should be OMTC GL compositing. Adding OMTC
support for X11 basic layers will
Nicholas Cameron writes:
Currently on Linux our only 'supported' graphics backend is the
main-thread software backend (basic layers).
FWIW basic layers is predominantly GPU-based compositing
(not-softwared) on most X11 systems.
5) We would love to spend time making OMTC OpenGL on Linux work
Andreas Gal writes:
Its not a priority to fix Linux/X11. We will happily take
contributed patches, and people are welcome to fix issues they
see, as long its not at the expense of the things that matter.
Do bugs in B2G Desktop on Linux/X11 matter?
I assume glitches and perf issues that are
Andreas Gal writes:
On Nov 7, 2013, at 1:48 PM, Karl Tomlinson mozn...@karlt.net wrote:
Andreas Gal writes:
Its not a priority to fix Linux/X11. We will happily take
contributed patches, and people are welcome to fix issues they
see, as long its not at the expense of the things
Matt Brubeck writes:
On 10/15/2013 1:36 PM, al...@yahoo.com wrote:
Why are these ignored?
As to whether we should pull someone off of other tasks to focus
on these XP text-rendering bugs, that's tricky.
So in some cases we might need to choose between speed and
subpixel rendering.
Many
Jeff Walden writes:
On 10/15/2013 06:06 PM, Benjamin Smedberg wrote:
That means sync I/O on the main thread, and not well-optimized because it
won't be part of the binary. Just to note.
When sync I/O is performed to read in-binary-object data, how is
that better?
Just readahead?
Wouldn't
Marco writes:
The bug has regressed a lot of things. To me it looks like the
decision to land it was a bit rushed.
I can't help wondering whether the feature was needed urgently on
b2g, and the people involved just didn't care enough if getting
that done quickly also damaged desktop products.
Gregory Szorc writes:
Just landed in inbound is a mass conversion of mochitests to use manifests.
When adding a new test, the process used to be:
1. add new file path/to/test/directory/new-file
2. add new-file to MOCHITEST_FILES in path/to/test/directory/Makefile.in
3. make -C
Bill McCloskey writes:
# Silence ++THIS and --THAT
export MOZ_QUIET=1
# Silence NS_WARNING
export MOZ_IGNORE_WARNINGS=1
then you won't get any more messages about DOM windows or
docshell creation/destruction or about NS_WARNINGs firing.
Thanks very much, Bill. I think I'll also find
ishikawa ishik...@yk.rim.or.jp writes:
- Has anyone have mode-line (or .emacs) setting to make the indentation in
Emacs to follow the prefered style?
I've got by so-far with M-x set-variable js-indent-level 2 when
necessary, but this doesn't automatically become buffer-local, so
I find myself
On Fri, 09 Aug 2013 13:51:45 +0200, Axel Hecht wrote:
To clarify, the tool does support either .name. or .name-list. at
this point. Is there a code path or a setup where we have for any
language/family both a .name. and a .name-list. entry?
I.e.
pref(font.name.serif.zh-TW, Times);
Axel Hecht writes:
On 8/8/13 10:45 PM, Karl Tomlinson wrote:
Axel Hecht writes:
On 8/8/13 5:17 PM, Jonathan Kew wrote:
On 8/8/13 15:17, Axel Hecht wrote:
Couter example seems to be Chinese, the unagi shows something, while my
tool reports 13k missing glyphs for zh-TW.
If we're using
Axel Hecht writes:
On 8/8/13 5:17 PM, Jonathan Kew wrote:
On 8/8/13 15:17, Axel Hecht wrote:
Couter example seems to be Chinese, the unagi shows something, while my
tool reports 13k missing glyphs for zh-TW.
If we're using Droid Sans Fallback, I believe it supports somewhere well
over
Paul Rouget writes:
The Firefox OS Simulator is a XulRunner instance run
from Firefox. Two processes, two windows, two different
version of gecko.
It would be very useful if we could display the simulator
as part of Firefox. Inside a tab.
Under X11, the XEmbed protocol was designed for
Robert O'Callahan writes:
How about this idea: after processing a WM_MOUSEMOVE event, go into an
anti-flood state where WM_MOUSEMOVE is ignored. After we service the
Gecko event queue, exit the anti-flood state.
The general approach sounds good.
I expect ignored will have to be ignored at
Robert O'Callahan writes:
On Tue, Feb 19, 2013 at 11:47 AM, Karl Tomlinson mozn...@karlt.net wrote:
Robert O'Callahan writes:
How about this idea: after processing a WM_MOUSEMOVE event, go into an
anti-flood state where WM_MOUSEMOVE is ignored. After we service the
Gecko event queue
BTW, everyone, please don't use NS_ENSURE_* unless you really want
all developers to be told if the test fails.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
Henrik Skupin writes:
differences like 'mochitest' vs. 'mochitests'. The right usage would be
'mochitest' and it would apply to the other frameworks too.
It would be useful to have different names to distinguish between
tests and implementation for the tests. I don't know whether that
is an
LANGLOIS Olivier writes:
xulrunner: 16.0.1
Is this a regression?
i.e. Do you know whether it worked differently in previous versions?
and the plugin-container thread stack is:
#1 0xb7f9a915 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/libpthread.so.0
#2 0xb5aa4b5f in PR_WaitCondVar ()
Nathan Froyd writes:
- Trace Malloc tests (all of them); it's not clear how useful these
tests are, given the pageload we run them with and the availability
of tools like about:memory.
I'd like to receive notifications if these results change.
If the results are changing for the small
jmaher writes:
In our continuing effort on the Auotmation and Tools team to make Talos tests
useful and make sure we know and care about what we are measuring, we have
realized that the tdhtml tests are not providing us any value.
Are you able to expand on the reasons why these don't provide
On Fri, 28 Sep 2012 11:44:56 -0700, Gary Kwong wrote:
http://blog.johnford.org/new-mac-builders-ssds-j-settings/
Quoted from that blog:
I did find that it is better to set the -j setting too high than
it is to set it too low.
-Gary
Better in terms of build time, which is the right metric
On 8/22/12 6:10 AM, Robert Kaiser wrote:
[...]
esp. given that basic file I/O is often costly (from watching my CPU
usage, a lot of the build time is spent in I/O wait when using spinning
disks - SSDs improve that hugely).
On Wed, 22 Aug 2012 12:29:24 -0700, Gregory Szorc wrote:
Yes, I/O
On Fri, 24 Aug 2012 12:20:58 -0700, Justin Lebar wrote:
inline int32_t GetFoo() {
int32_t result = 0;
nsresult rv = GetFoo(result);
MOZ_ASSERT(NS_SUCCEEDED(rv));
return result;
}
so that we never return uninitialized memory in release builds. 0 may
or may not be right, but
101 - 155 of 155 matches
Mail list logo
