Re: Website memory leaks

On Mon, Nov 6, 2017 at 1:53 AM, David Teller wrote: > I wanted to add something like that to about:performance, but at the > time, my impression was that we did not have sufficient platform data on > where allocations come from to provide something convincing. > ​The

Re: Website memory leaks

We have https://bugzilla.mozilla.org/show_bug.cgi?id=1243091 on file for automatic leak detection in the DevTools' memory panel. I'd have liked to try implementing http://www.cs.utexas.edu/ftp/techreports/tr06-07.pdf because it can see through frameworks/libraries (or claims to in a convincing

Re: Intent to require `mach try` for submitting to Try

Does `mach try` still require `git cinnabar` when using a `git` checkout of m-c, or does it work with `moz-git-tools` now too? Thanks, Nick On Fri, Sep 15, 2017 at 3:30 PM, Gregory Szorc wrote: > The Try Service ("Try") is a mechanism that allows developers to schedule >

Rust bindings to SpiderMonkey on inbound

(cc dev-servo, dev-platfrom; reply to js-engine-internals) Hello everyone! The Rust bindings to SpiderMonkey that Servo uses just landed in mozilla-inbound[0]! You can monitor their test results on taskcluster as the `SM-tc[tier-2](rust)` job. If any of your patches break these tests, please

Re: Intent to ship: SourceMap header

On Wed, May 17, 2017 at 10:51 AM, Tom Tromey wrote: > > "Boris" == Boris Zbarsky writes: > > >> https://github.com/source-map/source-map-rfc > > Boris> Are there any plans to have a standard here? > > All I found was this: >

Re: Intent to ship: SourceMap header

Error().stack is not affected by source maps (nor should it be IMO). This is just devtools facing with nothing that is web observable. On Wed, May 17, 2017 at 9:06 AM, Boris Zbarsky wrote: > On 5/17/17 11:01 AM, Tom Tromey wrote: > >> In this case I think this does not apply,

Re: FYI: We've forked the Breakpad client code

I can review the DWARF related bits in a pinch, too. On Thu, Feb 9, 2017 at 2:04 PM, Mike Hommey wrote: > On Thu, Feb 09, 2017 at 12:41:07PM -0800, Jim Blandy wrote: > > Under the circumstances, I'll volunteer to review, if that's feasible. > > I can too. > > > On Thu, Feb 9,

Re: Introducing mozilla::Result for better error handling

FWIW, you can also avoid the check-for-error-and-early-return-or-else-unwrap dance that is being "hidden" within MOZ_TRY by using `mozilla::Result::andThen` (and `mozilla::Result::map`) which are on inbound and will be on m-c soon. The patch in https://bugzilla.mozilla.org/show_bug.cgi?id=1324829

Re: Introducing mozilla::Result for better error handling

Thanks for getting this landed! Hooray for better error handling! \o/ On Tue, Dec 20, 2016 at 5:46 AM, Jan de Mooij wrote: > Hi all, > > A few weeks ago we added mozilla::Result to MFBT [0][1]. I was asked > to inform dev-platform about this, so here's a quick

Re: So, what's the point of Cu.import, these days?

On Wed, Sep 28, 2016 at 1:19 AM, David Teller wrote: > > * CommonJS > ​Just a heads up: the devtools have been using CommonJS modules and lazily requiring modules for a couple years now. If you don't want to jump directly to ES modules, reusing our infrastructure is

Re: PSA: mozilla/unused.h renamed to mozilla/Unused.h

Thanks Kan-Ru! I've personally tried to include the header with the wrong case multiple times, so I appreciate this change a lot. On Fri, Aug 26, 2016 at 7:54 PM, Kan-Ru Chen wrote: > Hello, > > In Bug 1297276 I landed a patch to rename mozilla/unused.h to > mozilla/Unused.h

Re: New [must_use] property in XPIDL

On Mon, Aug 22, 2016 at 4:39 PM, R Kent James wrote: > On 8/21/2016 9:14 PM, Nicholas Nethercote wrote: > > I strongly encourage people to do likewise on > > any IDL files with which they are familiar. Adding appropriate checks > isn't > > always easy > > Exactly, and I hope

Re: Intent to implement and ship: Changing the toString result on DOM prototype objects

Ok, I've filed this bug to use @@toStringTag in the debugger instead of Debugger.Object.prototype.class: https://bugzilla.mozilla.org/show_bug.cgi?id=1278310 On Mon, Jun 6, 2016 at 10:35 AM, Boris Zbarsky <bzbar...@mit.edu> wrote: > On 6/6/16 12:23 PM, Nick Fitzgerald wrote: >

Re: Intent to implement and ship: Changing the toString result on DOM prototype objects

t;p...@mozilla.com> wrote: > On Fri, Jun 3, 2016 at 8:21 PM, Nick Fitzgerald <nfitzger...@mozilla.com> > wrote: > >> On Fri, Jun 3, 2016 at 8:41 AM, Boris Zbarsky <bzbar...@mit.edu> wrote: >> >> > Devtools bug: none so far, but maybe we need o

Re: Static analysis for "use-after-move"?

We could create a MoveGuard, similar to ReentrancyGuard, that sets a `moved = true` flag in debug builds and make methods assert against that. (But it isn't nearly as nice as having borrowck...) On Wed, Apr 27, 2016 at 5:53 PM, smaug wrote: > On 04/28/2016 08:00 AM, Gerald

Re: PSA: Dump GC's retaining paths for any GC thing while debugging with JS::ubi::dumpPaths

ou show a sample patch that uses this? > > On Mon, Apr 25, 2016 at 10:19 AM, Nick Fitzgerald <nfitzger...@mozilla.com > > wrote: > >> Hi everyone! >> >> Friendly PSA: sometimes you're debugging a "leak" where the GC considers >> something reachable

PSA: Dump GC's retaining paths for any GC thing while debugging with JS::ubi::dumpPaths

Hi everyone! Friendly PSA: sometimes you're debugging a "leak" where the GC considers something reachable and therefore won't collect it, and this happens at an inopportune time for using the devtools memory panel (eg right before a DESTROY_RUNTIME collection), so you can't use the nice GUI for

Re: Proposal: use nsresult& outparams in constructors to represent failure

On Thu, Apr 21, 2016 at 3:24 AM, Nicholas Nethercote wrote: > On Thu, Apr 21, 2016 at 7:38 PM, Nicolas Silva > wrote: > > Fallible construction (even with a way to report failure) is annoying if > > only because the object's destructor has to

Re: Build System Project - Update from the last 2 weeks

Is there a reason why we aren't using LTO? On Fri, Apr 8, 2016 at 4:35 PM, Ted Mielczarek wrote: > No. GCC *has* an LTO optimizer, but we're not using it. We're just doing > a PGO build. MSVC requires enabling LTO to use their PGO, so the > resulting build has both. > >

Re: Coding style for C++ enums

On Fri, Apr 8, 2016 at 9:29 AM, Birunthan Mohanathas < birunt...@mohanathas.com> wrote: > On 8 April 2016 at 18:10, Kartikaya Gupta wrote: > > Others? > > enum class OptionD { > SentenceCaseValues, > ThisWontBeConfusedWithOtherThings > // ... because you need to use

Re: #include sorting: case-sensitive or -insensitive?

Any reason not to adopt SpiderMonkey's check_spidermonkey_style.py? It deals almost exclusively with header and include related things, and not indent levels, line lengths, or other things that gecko style disagrees with.

Re: rr chaos mode update

It seems like try/tbpl could automatically detect new test files and run them N times. That way, the developer doesn't have to do it manually, so it is less "intimidating" and also less likely to be skipped by accident or forgotten. Running under rr would be nice, but even without rr this seems

Re: Dominator tree memory analysis now in Nightly

On Sat, Jan 16, 2016 at 5:41 AM, Philip Chee wrote: > This is great! Is there a way of expanding/collapsing the whole tree? > Thunderbird uses "\" (collapse) and "*" (expand). > ​You can use ALT+click on an arrow to expand a​ whole subtree. However, because after a

Re: Dominator tree memory analysis now in Nightly

Reply inline below. On Thu, Jan 14, 2016 at 2:49 PM, Jared Wein wrote: > From your screenshot, there are a lot of instances of "objects > Array", > "objects > Object", etc. Is the a way to display the variable name used for > those objects? > ​The node might not be in a JS

Dominator tree memory analysis now in Nightly

Hi folks! Dominator trees give you fine-grained insight into memory retention. In a graph rooted by some node R, a node A is said to dominate B iff every path to B starting from R passes through A. In the context of a heap graph, another way to say this would be that A is retaining B: if the

Re: New heap snapshots tool in the developer tools

​On Wed, Nov 4, 2015 at 11:07 AM, David Rajchenbach-Teller < dtel...@mozilla.com> wrote: > That sounds very useful. > > Any chance we can get the same kind of output on the console in case of > mochitest memory leak? > ​I've filed ​https://bugzilla.mozilla.org/show_bug.cgi?id=1221704 to track

New heap snapshots tool in the developer tools

Hi folks! (Jordan Santell made an announcement on the devtools mailing list[0], but I thought I'd spread the word around.) The first iteration of the new heap snapshots memory tools landed on m-c in the middle of the last cycle and rode the train to Developer Edition with the merge. This tool

Re: easily getting allocation stacks for leaking objects

Note that for JS objects (and JS strings very soon), you can track allocation stacks with the Debugger API: https://developer.mozilla.org/en-US/docs/Tools/Debugger-API/Debugger.Memory On Thu, Sep 17, 2015 at 10:55 AM, Andrew McCreight wrote: > On Thu, Sep 17, 2015 at

Re: GTK3 linux builds

One more group of defectors within Mozilla. From the DevTools coding standards[0]: - aArguments aAre the aDevil (don't use them please) Although, there are still some files in tree with the legacy style. [0] https://wiki.mozilla.org/DevTools/CodingStandards#Code_style On Tue, Jul 7,

Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++

(Posted this reply to the wrong thread, reposting to the right one... _) One more group of defectors within Mozilla. From the DevTools coding standards[0]: - aArguments aAre the aDevil (don't use them please) Although, there are still some files in tree with the legacy style. [0]

Re: Announcing the Content Performance program

On Sun, Jun 28, 2015 at 5:14 PM, Nathan Froyd nfr...@mozilla.com wrote: On Sun, Jun 28, 2015 at 5:23 PM, Mike Hommey m...@glandium.org wrote: BTW, wasn't there an effort a few couple years ago, to move content event loop in different threads for different tabs? What happened to that?

Re: Announcing the Content Performance program

From your blog post: Heavy activity in background tabs badly affects desktop Firefox’s scrolling performance1 (much worse than other browsers — we need E10S) I was under the impression that because e10s is only a single process for all content (at least right now) a background tab can still

Re: DXR 2.0 staged. Feedback please!

Looking forward to eventually getting better JS searching via the multi-language support! What is the relative priority of permalinks to specific revisions? On Wed, Jun 3, 2015 at 12:10 PM, Erik Rose e...@mozilla.com wrote: DXR 2.0 is about to land! This is a major revision touching every part

Re: Announcing Operation Instrument

This is built on top of the docshell ProfileTimelineMarkers. There is a marker for the start of the traced operation and another for the end of the traced operation. The RAII class mozilla::AutoTimelineMarker simply adds these start and end markers on construction and destruction respectively

Re: Announcing Operation Instrument

Wow. Email formatting fail. Hopefully this turns out a little better: Hello platform hackers! [Operation Instrument](https://wiki.mozilla.org/DevTools/OperationInstrument) is a project that aims to add tracing instrumentation to Gecko and provide a holistic view of where time is being spent and

Announcing Operation Instrument

Hello platform hackers!​ ​[​ Operation Instrument ​] (htt ​​ ps://wiki.mozilla.org/DevTools/OperationInstrument)​ is a project that aims to add tracing instrumentation to Gecko and provide a holistic view of where time is being spent and why. Examples of traced operations include: * ​ ​ ​ Style

Re: Excessive inbound bustage

On Tue, Apr 21, 2015 at 3:22 PM, Bobby Holley bobbyhol...@gmail.com wrote: It's not about making mistakes - it's about being mis-calibrated with respect to the rest of the development community. And it's not about shaming - it's about making people (both the developer and others) aware of

Re: Excessive inbound bustage

On Tue, Apr 21, 2015 at 3:39 PM, Bobby Holley bobbyhol...@gmail.com wrote: On Tue, Apr 21, 2015 at 3:32 PM, Nick Fitzgerald nfitzger...@mozilla.com wrote: ​And this can surely be done via private channels​, without public shaming and the potential negatives people have listed elsewhere

Re: The e10s throbber

Yes they are built on the same SPS profiler backend. However, the gecko profiler addon will do things the builtin devtools can't, like open a shell and call `atos` to symbolicate C++ function addresses. See https://bugzilla.mozilla.org/show_bug.cgi?id=1132529 for some context. For the time

Re: It is now possible to apply arbitrary tags to tests/manifests and run all tests with a given tag

On Tue, Mar 31, 2015 at 9:30 AM, Andrew Halberstadt ahalberst...@mozilla.com wrote: ​For example, we may implement a way to run all tests with a given tag across multiple different suites. ​Does this mean that I can't do `./mach​ test --tag foobar` to run both xpcshell and mochitests tagged

Re: JavaScript code coverage

I recommend reading https://developer.mozilla.org/en-US/docs/Tools/Debugger-API or js/src/doc/Debugger/ for more information. On Tue, Jan 20, 2015 at 1:29 PM, Nick Fitzgerald nfitzger...@mozilla.com wrote: ​On Mon, Jan 19, 2015 at 12:36 PM, Joshua Cranmer [image: ] pidgeo...@gmail.com wrote

Re: JavaScript code coverage

​On Mon, Jan 19, 2015 at 12:36 PM, Joshua Cranmer  pidgeo...@gmail.com wrote: Getting good code coverage (line and branch coverage) ultimately requires fine-grained instrumentation (ideally bytecode-level) not presented by the current Debugger. ​I think you can get fine-grained enough data

Compiling m-c within Emacs (was: Re: Good ways to view Firefox compile errors in a terminal?)

​On Tue, Jan 13, 2015 at 10:01 AM, Nathan Froyd nfr...@mozilla.com wrote: On Tue, Jan 13, 2015 at 11:52 AM, Nick Fitzgerald nfitzger...@mozilla.com wrote: For those of us using Emacs: I use M-x shell as my terminal, and when combined with compilation-shell-minor-mode, I get the following

Re: Is anyone still using JS strict warnings?

I generally don't find them useful, but instead annoying, and that they provide a lot of noise to filter out to find actual relevant errors. This is including the undefined property errors. It is a common JS style to pass around configuration/option objects that will be missing many properties