Re: Do we have some documents listing up when we need to touch CLOBBER?

[Michael Shal]

On Fri, Dec 16, 2016 at 12:22 PM, Benoit Girard  wrote:

> I don't believe anyone has taken to time to go through the CLOBBER hg
> history to find the causes and document them. That could be interesting.
>
>
A while back I wrote a series of blog posts on clobber builds that details
some of the reasons for them, and how they can be solved:

http://gittup.org/blog/2014/03/6-clobber-builds-part-1---missing-dependencies/
http://gittup.org/blog/2014/05/7-clobber-builds-part-2---fixing-missing-dependencies/
http://gittup.org/blog/2014/06/8-clobber-builds-part-3---other-clobber-causes/
http://gittup.org/blog/2015/03/13-clobber-builds-part-4---fixing-other-clobber-causes/

Though I did not go through bug 941904 / `hg log CLOBBER` to categorize the
number of times we run into various instances of missing dependencies vs.
other reasons for clobbers. That might be interesting too :)

-Mike
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Do we have some documents listing up when we need to touch CLOBBER?

[Mike Hommey]

On Fri, Dec 16, 2016 at 05:16:25PM +0900, Masayuki Nakano wrote:
> Hi,
> 
> I'm looking for some documents which explain when we need to touch CLOBBER
> to avoid build failure. However, I've not found such document yet. I see
> such information only in CLOBBER about WebIDL change.
> 
> So, is there any document which lists up when we need to touch CLOBBER?

The rule is that CLOBBER should never need to be touched. Unfortunately,
our build system is far from perfect, and there are plenty of cases
where that doesn't actually hold true. There are a bunch of bugs filed
for those cases, and new ones should be filed and marked as blocking bug
#941904. IOW, the dependencies of bug #941904 that are still open are
the currently known cases where a CLOBBER was required, but many of them
are of the form "bug # required a clobber".

Mike
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Do we have some documents listing up when we need to touch CLOBBER?

[Masayuki Nakano]

On 2016/12/16 19:53, Mike Hommey wrote:

On Fri, Dec 16, 2016 at 05:16:25PM +0900, Masayuki Nakano wrote:

Hi,

I'm looking for some documents which explain when we need to touch CLOBBER
to avoid build failure. However, I've not found such document yet. I see
such information only in CLOBBER about WebIDL change.

So, is there any document which lists up when we need to touch CLOBBER?


The rule is that CLOBBER should never need to be touched. Unfortunately,
our build system is far from perfect, and there are plenty of cases
where that doesn't actually hold true. There are a bunch of bugs filed
for those cases, and new ones should be filed and marked as blocking bug
#941904. IOW, the dependencies of bug #941904 that are still open are
the currently known cases where a CLOBBER was required, but many of them
are of the form "bug # required a clobber".

Mike



Thank you for the information! That fixes my concern. I thought that 
platform developers need to touch CLOBBER at writing patches by themselves.


So, not necessary us to touch CLOBBER really helps me.

--
Masayuki Nakano 
Manager, Internationalization, Mozilla Japan.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Do we have some documents listing up when we need to touch CLOBBER?

[Masayuki Nakano]

Oh, do you mean that nobody doesn't have concrete scenarios when 
developers need to touch CLOBBER?


When not touching CLOBBER causes build failure at autoland, will it be 
fixed by a follow up landing which touches CLOBBER or backed out and 
need to reland same patches with touching CLOBBER?


If it's the latter, there should be listed up the scenarios in MDN or 
somewhere. (Although, even if it's the former, such document must be 
helpful for anybody work on managing the tree.)


On 2016/12/17 2:22, Benoit Girard wrote:

One of my goal when introducing CLOBBER was to document what was causing us
to CLOBBER so that we could audit and fix them if we ever found the time.
You can get a pretty good idea by going through the history of the file.

I don't believe anyone has taken to time to go through the CLOBBER hg
history to find the causes and document them. That could be interesting.

On Fri, Dec 16, 2016 at 12:16 AM, Masayuki Nakano 
wrote:


Hi,

I'm looking for some documents which explain when we need to touch CLOBBER
to avoid build failure. However, I've not found such document yet. I see
such information only in CLOBBER about WebIDL change.

So, is there any document which lists up when we need to touch CLOBBER?

--
Masayuki Nakano 
Manager, Internationalization, Mozilla Japan.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform




--
Masayuki Nakano 
Manager, Internationalization, Mozilla Japan.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Do we have some documents listing up when we need to touch CLOBBER?

[Boris Zbarsky]

On 12/16/16 3:16 AM, Masayuki Nakano wrote:

I see such information only in CLOBBER about WebIDL change.


This is specifically about 
https://bugzilla.mozilla.org/show_bug.cgi?id=1103153 or something else?


-Boris
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Do we have some documents listing up when we need to touch CLOBBER?

[Benoit Girard]

One of my goal when introducing CLOBBER was to document what was causing us
to CLOBBER so that we could audit and fix them if we ever found the time.
You can get a pretty good idea by going through the history of the file.

I don't believe anyone has taken to time to go through the CLOBBER hg
history to find the causes and document them. That could be interesting.

On Fri, Dec 16, 2016 at 12:16 AM, Masayuki Nakano 
wrote:

> Hi,
>
> I'm looking for some documents which explain when we need to touch CLOBBER
> to avoid build failure. However, I've not found such document yet. I see
> such information only in CLOBBER about WebIDL change.
>
> So, is there any document which lists up when we need to touch CLOBBER?
>
> --
> Masayuki Nakano 
> Manager, Internationalization, Mozilla Japan.
> ___
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Do we have some documents listing up when we need to touch CLOBBER?

[Masayuki Nakano]

Hi,

I'm looking for some documents which explain when we need to touch 
CLOBBER to avoid build failure. However, I've not found such document 
yet. I see such information only in CLOBBER about WebIDL change.


So, is there any document which lists up when we need to touch CLOBBER?

--
Masayuki Nakano 
Manager, Internationalization, Mozilla Japan.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform