Re: Coding style: Argument alignment

2017-10-01 Thread Gregory Szorc
On Wed, Sep 27, 2017 at 11:58 AM, Gregory Szorc wrote: > On Tue, Sep 26, 2017 at 6:45 PM, Nicholas Hurley > wrote: > >> So I'm going to chime in on a formatting discussion for probably the >> second >> time in my life as a mozillian. (It's apparently that

Re: Coding style: Argument alignment

2017-09-27 Thread Gregory Szorc
On Tue, Sep 26, 2017 at 6:45 PM, Nicholas Hurley wrote: > So I'm going to chime in on a formatting discussion for probably the second > time in my life as a mozillian. (It's apparently that important to me.) > > On Tue, Sep 26, 2017 at 9:25 AM, Mats Palmgren

Re: Coding style: Argument alignment

2017-09-26 Thread Nicholas Hurley
So I'm going to chime in on a formatting discussion for probably the second time in my life as a mozillian. (It's apparently that important to me.) On Tue, Sep 26, 2017 at 9:25 AM, Mats Palmgren wrote: > 2. touching more lines than necessary when adding/removing params, >

Re: Coding style: Argument alignment

2017-09-26 Thread Mats Palmgren
On 9/19/17 5:09 PM, Ehsan Akhgari wrote: Do you find the arguments that people have against this convincing? No. If not, would you mind elaborating why please? Sure, to recap, the arguments against aligned params in this thread are: 1. more work Not an issue if we use a tool to do the

Re: Coding style: Argument alignment

2017-09-19 Thread Ehsan Akhgari
On 09/09/2017 12:12 PM, Mats Palmgren wrote: On 8/31/17 6:50 PM, Ehsan Akhgari wrote: On 08/30/2017 09:03 PM, Eric Rahm wrote: Okay sounds like there's agreement on a). Indeed. I have edited the Style Guide to reflect this. Fwiw, I disagree with this decision. Here's a more realistic

Re: Coding style: Argument alignment

2017-09-11 Thread Randell Jesup
>On 8/31/17 6:50 PM, Ehsan Akhgari wrote: >> On 08/30/2017 09:03 PM, Eric Rahm wrote: >>> Okay sounds like there's agreement on a). >> >> Indeed.  I have edited the Style Guide to reflect this. > >Fwiw, I disagree with this decision. > >Here's a more realistic example of *actual use* from our code

Re: Coding style: Argument alignment

2017-09-09 Thread Mats Palmgren
On 8/31/17 6:50 PM, Ehsan Akhgari wrote: On 08/30/2017 09:03 PM, Eric Rahm wrote: Okay sounds like there's agreement on a). Indeed.  I have edited the Style Guide to reflect this. Fwiw, I disagree with this decision. Here's a more realistic example of *actual use* from our code base:

Re: Coding style: Argument alignment

2017-08-31 Thread Ehsan Akhgari
On 08/30/2017 09:03 PM, Eric Rahm wrote: Okay sounds like there's agreement on a). Indeed. I have edited the Style Guide to reflect this. Thanks everyone! -e On Tue, Aug 29, 2017 at 11:40 PM, Martin Thomson > wrote: On Wed, Aug 30, 2017 at

Re: Coding style: Argument alignment

2017-08-30 Thread Eric Rahm
Okay sounds like there's agreement on a). Thanks everyone! -e On Tue, Aug 29, 2017 at 11:40 PM, Martin Thomson wrote: > On Wed, Aug 30, 2017 at 12:07 PM, L. David Baron > wrote: > > I think I do this because (b) has the disadvantage that more code > >

Re: Coding style: Argument alignment

2017-08-30 Thread Eric Rescorla
On Wed, Aug 30, 2017 at 9:29 AM, Sylvestre Ledru wrote: > Le 30/08/2017 à 17:25, Eric Rescorla a écrit : > > > > On Wed, Aug 30, 2017 at 1:21 AM, Sylvestre Ledru > wrote: > >> >> Le 30/08/2017 à 08:53, Henri Sivonen a écrit : >> > Regardless of the

Re: Coding style: Argument alignment

2017-08-30 Thread Sylvestre Ledru
Le 30/08/2017 à 17:25, Eric Rescorla a écrit : > > > On Wed, Aug 30, 2017 at 1:21 AM, Sylvestre Ledru > wrote: > > > Le 30/08/2017 à 08:53, Henri Sivonen a écrit : > > Regardless of the outcome of this particular style issue, where are we >

Re: Coding style: Argument alignment

2017-08-30 Thread Eric Rescorla
On Wed, Aug 30, 2017 at 1:21 AM, Sylvestre Ledru wrote: > > Le 30/08/2017 à 08:53, Henri Sivonen a écrit : > > Regardless of the outcome of this particular style issue, where are we > > in terms of clang-formatting all the non-third-party C++ in the tree? > > We have been

Re: Coding style: Argument alignment

2017-08-30 Thread Martin Thomson
On Wed, Aug 30, 2017 at 5:21 PM, Sylvestre Ledru wrote: > Could you report a bug? We wrote a few patches upstream to improve > the support of our coding style. This isn't a bug either, but I've noticed that alignment anywhere can cause collateral changes. `clang-format

Re: Coding style: Argument alignment

2017-08-30 Thread Nicolas B. Pierron
On 08/30/2017 07:21 AM, Sylvestre Ledru wrote: Le 30/08/2017 à 08:53, Henri Sivonen a écrit : Regardless of the outcome of this particular style issue, where are we in terms of clang-formatting all the non-third-party C++ in the tree? We have been working on that but we delayed it to avoid

Re: Coding style: Argument alignment

2017-08-30 Thread Henri Sivonen
On Wed, Aug 30, 2017 at 10:21 AM, Sylvestre Ledru wrote: > > Le 30/08/2017 à 08:53, Henri Sivonen a écrit : > > Regardless of the outcome of this particular style issue, where are we > in terms of clang-formatting all the non-third-party C++ in the tree? > > We have been

Re: Coding style: Argument alignment

2017-08-30 Thread Sylvestre Ledru
Le 30/08/2017 à 08:53, Henri Sivonen a écrit : > Regardless of the outcome of this particular style issue, where are we > in terms of clang-formatting all the non-third-party C++ in the tree? We have been working on that but we delayed it to avoid doing it during the 57 work. We will share more

Re: Coding style: Argument alignment

2017-08-30 Thread Henri Sivonen
Regardless of the outcome of this particular style issue, where are we in terms of clang-formatting all the non-third-party C++ in the tree? I've had a couple of cases of late where the initializers in a pre-existing constructor didn't follow our style, so when I changed the list a tiny bit, the

Re: Coding style: Argument alignment

2017-08-30 Thread Martin Thomson
On Wed, Aug 30, 2017 at 12:07 PM, L. David Baron wrote: > I think I do this because (b) has the disadvantage that more code > changes require touching additional lines, which is both changes > blame and is extra work (although it's not extra work if we're using > clang-format

Re: Coding style: Argument alignment

2017-08-29 Thread Gregory Szorc
On Tue, Aug 29, 2017 at 7:07 PM, L. David Baron wrote: > On Tuesday 2017-08-29 18:32 -0700, Eric Rahm wrote: > > Do we explicitly state a preferred alignment of arguments in multi-line > > function declarations (primarily in the context of C++) [1]? This > question > > has

Re: Coding style: Argument alignment

2017-08-29 Thread L. David Baron
On Tuesday 2017-08-29 18:32 -0700, Eric Rahm wrote: > Do we explicitly state a preferred alignment of arguments in multi-line > function declarations (primarily in the context of C++) [1]? This question > has come up in regards to using clang-format for cleaning up code [2] and > it would be

Coding style: Argument alignment

2017-08-29 Thread Eric Rahm
Hi folks- Do we explicitly state a preferred alignment of arguments in multi-line function declarations (primarily in the context of C++) [1]? This question has come up in regards to using clang-format for cleaning up code [2] and it would be helpful to be able to reference a concrete example in