Re: Intent to ship: Array.prototype.values

2018-02-08 Thread Tom Schuster
I plan on landing this today, so this change is going to be in Firefox 60. The pref for enabling/disabling this feature is javascript.options.array_prototype_values. On Fri, Feb 2, 2018 at 4:20 PM, Tom Schuster wrote: > I talked to Jan de Mooij and it's feasible to add a pref for this, > so we

Re: Intent to ship: Array.prototype.values

2018-02-02 Thread Emilio Cobos Álvarez
On 02/02/2018 03:27 PM, Andrew Overholt wrote: > On Fri, Feb 2, 2018 at 8:45 AM, Tom Schuster > wrote: > > Chrome seems to > want to add a kill pref for this,  from my experience more difficult > for us with the way we define methods in SpiderMonkey. Should th

Re: Intent to ship: Array.prototype.values

2018-02-02 Thread Tom Schuster
I talked to Jan de Mooij and it's feasible to add a pref for this, so we are definitely going to do this. Array.prototype.values has always been enabled on Nightly. Based on where the breakage occurred, internal company webpages, I would not expect EARLY_BETA_OR_EARLIER to shake out any addition

Re: Intent to ship: Array.prototype.values

2018-02-02 Thread Mike Taylor
On Feb 2, 2018, at 7:45 AM, Tom Schuster wrote: > Any additional ideas how to mitigate the risk here? Chrome seems to > want to add a kill pref for this, from my experience more difficult > for us with the way we define methods in SpiderMonkey. Should that be > a requirement for shipping? Add a

Re: Intent to ship: Array.prototype.values

2018-02-02 Thread Lars Hansen
On Fri, Feb 2, 2018 at 2:45 PM, Tom Schuster wrote: > Any additional ideas how to mitigate the risk here? Chrome seems to > want to add a kill pref for this, from my experience more difficult > for us with the way we define methods in SpiderMonkey. Should that be > a requirement for shipping? >

Re: Intent to ship: Array.prototype.values

2018-02-02 Thread Boris Zbarsky
On 2/2/18 8:45 AM, Tom Schuster wrote: Should that be a requirement for shipping? Imo, yes, given the history of trying to ship this in the past (had to be backed out for web compat fail twice, etc). -Boris ___ dev-platform mailing list dev-platfor

Re: Intent to ship: Array.prototype.values

2018-02-02 Thread Andrew Overholt
On Fri, Feb 2, 2018 at 8:45 AM, Tom Schuster wrote: > Chrome seems to > want to add a kill pref for this, from my experience more difficult > for us with the way we define methods in SpiderMonkey. Should that be > a requirement for shipping? > If it's not too difficult it does make it a lot eas

Intent to ship: Array.prototype.values

2018-02-02 Thread Tom Schuster
We already tried to ship Array.prototype.values before in Firefox 48, but this broke Microsoft Dynamics CRM 2011 (https://bugzilla.mozilla.org/show_bug.cgi?id=1299593). We are however aware this might have caused other breakages as well. The compatibility risk for this change is high. However Chro