Re: Intent to ship: Return pixel deltas in wheel event if deltaMode is not checked by authors

2021-03-10 Thread Masayuki Nakano
On 2021/03/10 21:23, Xidorn Quan wrote: On Wed, Mar 10, 2021, at 8:01 PM, Anne van Kesteren wrote: That does seem unfortunate, but unless other browsers are interested in picking this up, I think it will hurt us more to be different than that it helps. I don't think we should make aligning with

Re: Intent to ship: Return pixel deltas in wheel event if deltaMode is not checked by authors

2021-03-10 Thread Xidorn Quan
On Wed, Mar 10, 2021, at 8:01 PM, Anne van Kesteren wrote: > That does seem unfortunate, but unless other browsers are interested > in picking this up, I think it will hurt us more to be different than > that it helps. I don't think we should make aligning with Chrome and > Safari conditional upon

Re: Intent to ship: Return pixel deltas in wheel event if deltaMode is not checked by authors

2021-03-10 Thread Anne van Kesteren
On Wed, Mar 10, 2021 at 9:11 AM Masayuki Nakano wrote: > Indeed, in long term goal must be that we'd dispatch exactly same wheel > events as Chrome/Chromium. However, without implementing alternative new > API, web apps will not be able to handle raw value for better UX. > Therefore, I filed a spe

Re: Intent to ship: Return pixel deltas in wheel event if deltaMode is not checked by authors

2021-03-10 Thread Masayuki Nakano
Oops, On 2021/03/10 17:11, Masayuki Nakano wrote: Example 1: ``` addEventListener("wheel", event => {  let amount = event.deltaY;  if (isFirefox) {    amount *= 16;  }  scroll(amount);  event.preventDefault(); }); ``` Example 2: ``` addEventListener("wheel", event => {  let amount = even

Re: Intent to ship: Return pixel deltas in wheel event if deltaMode is not checked by authors

2021-03-10 Thread Masayuki Nakano
Hi, Thank you Emilio for your great work! I'd like to explain the background. First, `WheelEvent` was designed for making it possible web browsers to expose raw wheel event information with 3 kinds of delta value modes which listeners can distinguish with `WheelEvent#deltaMode`. And then, I

Re: Intent to ship: Return pixel deltas in wheel event if deltaMode is not checked by authors

2021-03-09 Thread Karl Dubost
Hello, So about experimenting with wheelEvent… Cool to see the work of Emilio in that space. Le 2021/03/10 à 07:13, Emilio Cobos Álvarez a écrit : > I guess we could enable the always-disabled pref on Nighly and watch for a > few releases to see if there's reports of broken sites. Would that s

Re: Intent to ship: Return pixel deltas in wheel event if deltaMode is not checked by authors

2021-03-09 Thread Emilio Cobos Álvarez
On 3/9/21 20:36, James Graham wrote: It seems like having all browsers have the same behaviour is going to be better in the long run than having some weird heuristic in gecko that acts as a footgun for authors going forward. Do we have any way to assess the compat impact of switching to match

Re: Intent to ship: Return pixel deltas in wheel event if deltaMode is not checked by authors

2021-03-09 Thread James Graham
On 09/03/2021 18:21, Emilio Cobos Álvarez wrote: On 3/9/21 17:10, Anne van Kesteren wrote: On Tue, Mar 9, 2021 at 4:45 PM Emilio Cobos Álvarez wrote: Let me know if you have any concerns with this or what not. So if I understand it correctly we'll have a getter with side effects. Is the ex

Re: Intent to ship: Return pixel deltas in wheel event if deltaMode is not checked by authors

2021-03-09 Thread Emilio Cobos Álvarez
On 3/9/21 17:10, Anne van Kesteren wrote: On Tue, Mar 9, 2021 at 4:45 PM Emilio Cobos Álvarez wrote: Let me know if you have any concerns with this or what not. So if I understand it correctly we'll have a getter with side effects. Is the expectation that we can eventually remove this? Are o

Re: Intent to ship: Return pixel deltas in wheel event if deltaMode is not checked by authors

2021-03-09 Thread Anne van Kesteren
On Tue, Mar 9, 2021 at 4:45 PM Emilio Cobos Álvarez wrote: > Let me know if you have any concerns with this or what not. So if I understand it correctly we'll have a getter with side effects. Is the expectation that we can eventually remove this? Are other browsers on board with this model? _

Intent to ship: Return pixel deltas in wheel event if deltaMode is not checked by authors

2021-03-09 Thread Emilio Cobos Álvarez
Hi, In bug 1696384, I plan to enable dom.event.wheel-deltaMode-lines.disabled on all channels. This is a compat intervention for sites that check WheelEvent.delta{X,Y,Z} before checking WheelEvent.deltaMode, generally assuming that the deltas are going to be pixels. These deltas are enviro