Re: String contenation and temporaries

2019-10-16 Thread Boris Zbarsky
On 10/16/19 10:11 AM, Simon Giesecke wrote: I am wondering if the following is supposed to be safe: I would think so, yes. That said, using string types as return values is not that common (using an outparam is the normal way they are used), and so may be under-tested. On the treeherder b

String contenation and temporaries

2019-10-16 Thread Simon Giesecke
Hi, I am wondering if the following is supposed to be safe: Given a function (from https://searchfox.org/mozilla-central/source/dom/indexedDB/ActorsParent.cpp#9290): nsAutoCString MakeColumnPairSelectionList( const nsLiteralCString& aPlainColumnName, const nsLiteralCString& aLocaleAwareC