On Tue, Jul 7, 2015 at 11:49 AM, Mike Conley mcon...@mozilla.com wrote:
Aren't there tools for our (admittedly varied) editors / IDEs to make
the readability that people are getting from aFoo readily available, but
that don't also require us to pack it into the actual name of the variable?
I
Karl Tomlinson mailto:mozn...@karlt.net
July 7, 2015 at 12:55 AM
I find the 'a' prefix useful to tell me that this variable has the
value that was provided to the function.
(I'm assuming that the prefix is used with this convention.)
There's no additional safety enforced, but I find the
On 7/7/15 11:49 AM, Mike Conley wrote:
I suspect that knowing what things were passed into a method or function
is something that can be divined via static analysis.
Aren't there tools for our (admittedly varied) editors / IDEs
And debuggers. And dxr and blame views?
-Boris
I suspect that knowing what things were passed into a method or function
is something that can be divined via static analysis.
Aren't there tools for our (admittedly varied) editors / IDEs to make
the readability that people are getting from aFoo readily available, but
that don't also require us
On Tue, Jul 7, 2015 at 6:03 AM, Kartikaya Gupta kgu...@mozilla.com wrote:
I'd be interested to know: of those people who are in favour of
removing the prefix, how many regularly have to deal with functions
that are longer than two pages (a page is however much code you can
see at a time in
On 7/7/15 11:36 AM, Jeff Muizelaar wrote:
FWIW, I did a quick poll of the people in our Gfx daily. Here are the results:
To add some more split opinions to the situation, I rather like the
aArgument form precisely because it makes it easier to trace dataflow.
Though the fact that some
I agree with Karl that, the 'a' prefix sometimes helps me in that way
when I read code. Also it is sometimes convenient to have a local
variable use the parameter name without the prefix, like:
SomeType foo = CastOrUnwrap(aFoo);
I don't have strong opinion on this, though. If the majority of the
On Tue, Jul 7, 2015 at 4:54 AM, Honza Bambas hbam...@mozilla.com wrote:
I'm strongly against removing the prefix. I got used to this and it has
its meaning all the time I inspect code (even my own) and doing reviews.
Recognizing a variable is an argument is very very useful. It's important
As someone who spends more than 50% of working time doing reviews I'm strongly
against this proposal.
aFoo helps with readability - reader knows immediately when the code is dealing
with arguments.
-Olli
On 07/07/2015 06:12 AM, Jeff Gilbert wrote:
I propose that we stop recommending the
On 7/7/2015 19:38, Boris Zbarsky wrote:
On 7/7/15 11:49 AM, Mike Conley wrote:
I suspect that knowing what things were passed into a method or function
is something that can be divined via static analysis.
Aren't there tools for our (admittedly varied) editors / IDEs
And debuggers. And dxr
If we do unify Gecko/SpiderMonkey styles (something it seems like we're
moving towards and I think would be great), it would be a real shame to
switch 'cx' (a parameter to basically every function in SpiderMonkey) to
'aCx'; that would really make some eyes bleed. One compromise could be to
drop
On Tue, Jul 7, 2015 at 6:03 AM, Kartikaya Gupta kgu...@mozilla.com wrote:
I'd be interested to know: of those people who are in favour of
removing the prefix, how many regularly have to deal with functions
that are longer than two pages (a page is however much code you can
see at a time in
We noticed a lot of Mozillians struggle to use the Telemetry dashboards
effectively. It can be difficult to interpret the graphs numbers, hard to
find or filter the data, and there is a risk of making the wrong
conclusions. The dashboards needed an overhaul.
Anthony Zhang, our summer intern, has
Can we fix the UX?
Presumably we will never have zero shutdown hangs and there may be
different/better ways to prompt the user about it.
On Mon, Jul 6, 2015 at 10:48 PM, Vladan D vdje...@mozilla.com wrote:
KaiRo pointed out another reason to reduce shutdown hang rates on IRC:
it's lousy UX.
On 7/7/15 2:26 PM, Vladan Djeric wrote:
Let us know if you find bugs, notice missing functionality, or if anything
is ambiguous or counter-intuitive.
When I first load https://telemetry.mozilla.org/ it says, in the console:
ReferenceError: CustomSelector is not defined dashboard.js:674:5
It looks like there is some kind of bug with propagating the changes to the
(static) dashboard files in S3, somehow causing the old dash to be shown at
telemetry.mozilla.org for some users. Others are reporting dashes that
don't load.
Apologies for the (very embarassing) technical difficulties.
On 7/7/2015 21:27, Jeff Gilbert wrote:
On Tue, Jul 7, 2015 at 4:54 AM, Honza Bambas hbam...@mozilla.com wrote:
I'm strongly against removing the prefix. I got used to this and it has
its meaning all the time I inspect code (even my own) and doing reviews.
Recognizing a variable is an argument
On Tue, Jul 7, 2015 at 1:03 PM, smaug opet...@mozilla.com wrote:
As someone who spends more than 50% of working time doing reviews I'm
strongly against this proposal.
aFoo helps with readability - reader knows immediately when the code is
dealing with arguments.
When and why is this useful
On 07/07/2015 10:55 PM, Jeff Gilbert wrote:
On Tue, Jul 7, 2015 at 12:36 PM, Honza Bambas hbam...@mozilla.com wrote:
On 7/7/2015 21:27, Jeff Gilbert wrote:
On Tue, Jul 7, 2015 at 4:54 AM, Honza Bambas hbam...@mozilla.com wrote:
I'm strongly against removing the prefix. I got used to this
On Mon, Jul 6, 2015 at 8:12 PM, Jeff Gilbert jgilb...@mozilla.com wrote:
I propose we strike the `aFoo` recommendation from the Mozilla style guide.
Just so the proposal doesn't get lost in the bike shed, Jeff is only
proposing a change to the style guide, not a tree-wide find/replace
On Mon, Jul 6, 2015 at 8:12 PM, Jeff Gilbert jgilb...@mozilla.com wrote:
I propose that we stop recommending the universal use of an 'a' prefix for
arguments to functions in C and C++. If the prefix helps with
disambiguation, that's fine. However, use of this prefix should not be
prescribed
On Tue, Jul 07, 2015 at 11:52:12PM +0300, smaug wrote:
On 07/07/2015 11:45 PM, Milan Sreckovic wrote:
Removing the style guide for “prefix function arguments with a” will not
preclude people from naming a variable aFoo. At least the current style
guide precludes people from naming
On Tue, Jul 7, 2015 at 1:20 PM, smaug opet...@mozilla.com wrote:
readability / easier to follow the dataflow are rather compelling reasons.
It hurts readability for me and many others.
I don't see how it revolutionizes following dataflow, since we have locals
that are pure functions of args,
On 07/07/2015 11:45 PM, Milan Sreckovic wrote:
Removing the style guide for “prefix function arguments with a” will not
preclude people from naming a variable aFoo. At least the current style guide
precludes people from naming non-function arguments that way, albeit indirectly.
I’m trying
On Tue, Jul 7, 2015 at 3:33 PM, Jeff Gilbert jgilb...@mozilla.com wrote:
On Tue, Jul 7, 2015 at 6:03 AM, Kartikaya Gupta kgu...@mozilla.com wrote:
I'd be interested to know: of those people who are in favour of
removing the prefix, how many regularly have to deal with functions
that are
Outvars are good candidates for having markings in the variable name.
`aFoo` for all arguments is a poor solution for this, though.
On Tue, Jul 7, 2015 at 1:22 PM, smaug opet...@mozilla.com wrote:
On 07/07/2015 11:18 PM, Jeff Gilbert wrote:
On Tue, Jul 7, 2015 at 1:03 PM, smaug
Removing the style guide for “prefix function arguments with a” will not
preclude people from naming a variable aFoo. At least the current style guide
precludes people from naming non-function arguments that way, albeit indirectly.
I’m trying to understand the possible outcomes of this
One more group of defectors within Mozilla. From the DevTools coding
standards[0]:
- aArguments aAre the aDevil (don't use them please)
Although, there are still some files in tree with the legacy style.
[0] https://wiki.mozilla.org/DevTools/CodingStandards#Code_style
On Tue, Jul 7,
On 2015-07-07 6:37 AM, Aryeh Gregor wrote:
Did you check whether this actually occurs in an optimized build? C++
allows temporaries to be optimized away under some circumstances,
e.g., when returning a local variable. It would make a lot of sense
to me if it allowed the temporary created by a
(Posted this reply to the wrong thread, reposting to the right one... _)
One more group of defectors within Mozilla. From the DevTools coding
standards[0]:
- aArguments aAre the aDevil (don't use them please)
Although, there are still some files in tree with the legacy style.
[0]
FWIW, I did a quick poll of the people in our Gfx daily. Here are the results:
For aArguments:
Bas
Milan
Matt
Kats
Against aArguments:
Me
No strong opinion:
Sotoro
Lee
Benoit
Nical
Mason
-Jeff
On Tue, Jul 7, 2015 at 11:12 AM, Nick Fitzgerald
nfitzger...@mozilla.com wrote:
(Posted
On Tuesday, July 7, 2015 at 3:30:59 PM UTC-7, Birunthan Mohanathas wrote:
On 7 July 2015 at 15:02, Mike Hommey m...@glandium.org wrote:
On Tue, Jul 07, 2015 at 11:52:12PM +0300, smaug wrote:
until the tools (and poiru) are run and make the code follow Mozilla
coding style.
Assuming
On Tue, Jul 7, 2015 at 1:12 PM, Jeff Gilbert jgilb...@mozilla.com wrote:
Notable works or style guides which *do* recommend `aFoo`:
* Mozilla (except for IDL, Java, and Python)
* ?
Just FYI, Someone in Twitter mentioned that, code generated by Xcode
uses this style by default. The languages
On Tue, Jul 7, 2015 at 1:03 PM, smaug sm...@welho.com wrote:
As someone who spends more than 50% of working time doing reviews I'm
strongly against this proposal.
aFoo helps with readability - reader knows immediately when the code is
dealing with arguments.
I'd like to point out that
CloudFront was serving stale data, it's fixed now. Give it another try?
On Tuesday, July 7, 2015 at 3:06:45 PM UTC-4, Boris Zbarsky wrote:
On 7/7/15 2:26 PM, Vladan Djeric wrote:
Let us know if you find bugs, notice missing functionality, or if anything
is ambiguous or counter-intuitive.
On Tue, Jul 7, 2015 at 3:02 PM, Mike Hommey m...@glandium.org wrote:
On Tue, Jul 07, 2015 at 11:52:12PM +0300, smaug wrote:
On 07/07/2015 11:45 PM, Milan Sreckovic wrote:
Removing the style guide for “prefix function arguments with a” will
not preclude people from naming a variable aFoo.
On 7 July 2015 at 15:02, Mike Hommey m...@glandium.org wrote:
On Tue, Jul 07, 2015 at 11:52:12PM +0300, smaug wrote:
until the tools (and poiru) are run and make the code follow Mozilla coding
style.
Assuming you're talking about clang-format, that doesn't take care
about anything else than
On Tue, Jul 7, 2015 at 3:59 PM, Eric Rahm er...@mozilla.com wrote:
I'm not a huge fan of the 'aFoo' style, but I am a huge fan of
consistency. So if we want to change the style guide we should update our
codebase, and I don't think we can reasonably do that automatically without
introducing
On Tue, Jul 07, 2015 at 05:09:57PM -0700, Gregory Szorc wrote:
On Tue, Jul 7, 2015 at 1:03 PM, smaug sm...@welho.com wrote:
As someone who spends more than 50% of working time doing reviews I'm
strongly against this proposal.
aFoo helps with readability - reader knows immediately when the
On 07/07/15 07:17, Eric Rescorla wrote:
I am in favor of getting rid of aFoo.
-Ekr
P.S. At the risk of convincing people I am crazy and thus discounting
my opinion above, I rather prefer foo_ to mFoo, but this seems like more
a matter of taste.
I agree that `aFoo` is only useful very
I'm strongly against removing the prefix. I got used to this and it has
its meaning all the time I inspect code (even my own) and doing
reviews. Recognizing a variable is an argument is very very useful.
It's important to have it and it's good we enforce it!
-hb-
On 7/7/2015 5:12, Jeff
On Monday, July 6, 2015 at 3:52:39 PM UTC-5, Kyle Huey wrote:
On Mon, Jul 6, 2015 at 1:37 PM, Ryan VanderMeulen rya...@gmail.com wrote:
On 7/6/2015 4:34 PM, Vladan D wrote:
Background: Firefox shutdown hangs are turned into shutdown crashes by a
watchdog thread [1] that forces a crash
On Fri, Jul 3, 2015 at 6:22 PM, Michael Layzell mich...@thelayzells.com wrote:
So the ternary actually causes an unnecessary AddRef/Release pair, neat.
Did you check whether this actually occurs in an optimized build? C++
allows temporaries to be optimized away under some circumstances,
e.g.,
Jeff encouraged me to add more things to this thread, so I’m blaming him. So,
some random thoughts.
After getting paid to write code for 20+ years and then showing up at Mozilla,
and seeing the a prefix, I thought “this is brilliant, how come we didn’t think
of doing that before?!”, as a
On Tue, Jul 7, 2015 at 6:06 PM, Karl Tomlinson mozn...@karlt.net wrote:
Jeff Gilbert writes:
I work with a number of these, but after a page or two, why is it at all
relevant which vars were args? For information flow? Should we mark
locals
that purely derive from args as `aFoo` as well?
Jeff Gilbert writes:
On Tue, Jul 7, 2015 at 5:41 PM, Karl Tomlinson mozn...@karlt.net wrote:
Some people find the prefix helps readability, because it makes
extra information immediately available in the code being
examined, while you are indicating that this is a significant
burden on
Jeff Gilbert writes:
It can be a burden on the hundreds of devs who have to read and understand
the code in order to write more code.
Some people find the prefix helps readability, because it makes
extra information immediately available in the code being
examined, while you are indicating
On Tue, Jul 7, 2015 at 5:13 PM, Jeff Gilbert jgilb...@mozilla.com wrote:
On Tue, Jul 7, 2015 at 3:59 PM, Eric Rahm er...@mozilla.com wrote:
I'm not a huge fan of the 'aFoo' style, but I am a huge fan of
consistency. So if we want to change the style guide we should update our
codebase,
On Tue, Jul 7, 2015 at 5:13 PM, Jeff Gilbert jgilb...@mozilla.com wrote:
MSVC 2013 (which I believe is our main windows compiler right now) will
error during compilation if such a shadowing issue arises. Thus, if the
code compiles there, `aFoo`-`foo` is safe. I would be very surprised if
GCC
On Mon, Jul 6, 2015 at 8:26 PM, Mike Hommey m...@glandium.org wrote:
The existence of aFoo goes along with the existence of mFoo, sFoo, kFoo,
and others I might have forgotten. Not that I particularly care about
aFoo, but why strike this one and not the others?[1] It's not like they
have
Jeff Gilbert writes:
I work with a number of these, but after a page or two, why is it at all
relevant which vars were args? For information flow? Should we mark locals
that purely derive from args as `aFoo` as well? Long functions (which have
poor readability anyway) generally have so much
+1 for removing this. Gecko's use is inconsistent, and outside of Gecko code
that does use it, I've never seen it used in any other codebase. I've never
gone to another project and thought, I miss decorating everything in a way
that changes capitalization and impairs canonical naming.
Reasons
+1 for removing this. Gecko's use is inconsistent, and outside of Gecko code
that does use it, I've never seen it used in any other codebase. I've never
gone to another project and thought, I miss decorating everything in a way
that changes capitalization and impairs canonical naming.
Reasons
On Tue, Jul 7, 2015 at 5:41 PM, Karl Tomlinson mozn...@karlt.net wrote:
Jeff Gilbert writes:
It can be a burden on the hundreds of devs who have to read and
understand
the code in order to write more code.
Some people find the prefix helps readability, because it makes
extra information
On 7/7/2015 15:03, Kartikaya Gupta wrote:
I'd be interested to know: of those people who are in favour of
removing the prefix, how many regularly have to deal with functions
that are longer than two pages (a page is however much code you can
see at a time in your coding environment)?
All the
On 07/07/2015 05:12, Jeff Gilbert wrote:
Notable works or style guides [2] which do not recommend `aFoo`: [3]
[...]
To add another internal datapoint the FxOS gaia codebase is mostly
devoid of this style. There are some places using the m prefix for
pseudo member variables (really just JS
+1
On 07/07/15 13:54, Honza Bambas wrote:
I'm strongly against removing the prefix. I got used to this and it
has its meaning all the time I inspect code (even my own) and doing
reviews. Recognizing a variable is an argument is very very useful.
It's important to have it and it's good we
I'd be interested to know: of those people who are in favour of
removing the prefix, how many regularly have to deal with functions
that are longer than two pages (a page is however much code you can
see at a time in your coding environment)? I'd be happy to support
removing the prefix if people
On Tue, Jul 7, 2015 at 9:18 AM, Honza Bambas hbam...@mozilla.com wrote:
I'd be happy to support
removing the prefix if people also commit to splitting any giant
functions they touch as part of the prefix removal.
That's (sorry) non-sense. In almost all cases longer methods/functions
cannot
On 7/7/15 6:17 PM, David Anderson wrote:
+1 for removing this. Gecko's use is inconsistent, and outside of
Gecko code that does use it, I've never seen it used in any other
codebase. I've never gone to another project and thought, I miss
decorating everything in a way that changes capitalization
*The stale file issues are fixed, please try out the new dashes!*
https://telemetry.mozilla.org/
CloudFront was serving stale data and we needed to invalidate its caches
(and give it enough time to complete the invalidations).
On Tue, Jul 7, 2015 at 3:15 PM, Vladan Djeric vdje...@mozilla.com
On Tuesday, June 16, 2015 at 5:12:17 PM UTC-4, Mike Hommey wrote:
On Tue, Jun 16, 2015 at 04:16:13PM -0400, Jeff Muizelaar wrote:
We're working on making all of the tests green for GTK3. This means
that we could be changing the default linux configuration to GTK3 as
early as FF42. If anyone
62 matches
Mail list logo
