Re: PSA: Building Firefox for arm64 windows got a lot easier

2019-01-11 Thread Gabriele Svelto
Hi all, On 11/01/2019 01.24, Mike Hommey wrote: > In the MSVC installer, choose the following extra components: > - Visual Studio C++ compiler and libraries for ARM64 > - Visual C++ ATL for ARM64 > - Visual C++ MFC for ARM64 I don't have the MFC for ARM64 libraries installed and I didn't

Re: XPCOM Tidying Proposal

2019-01-11 Thread Nathan Froyd
On Thu, Jan 10, 2019 at 6:15 PM Kyle Machulis wrote: > In an effort to bring Marie Kondo memes to dev-platform, I'd like to > propose an XPCOM tidying project. +1. > - Removal of [noscript] methods in interfaces in favor of direct calls via > Cast() where possible. > - Direct getters through

Re: XPCOM Tidying Proposal

2019-01-11 Thread Kyle Machulis
On Fri, Jan 11, 2019 at 7:21 AM Nathan Froyd wrote: > > - Removal of [noscript] methods in interfaces in favor of direct calls > via > > Cast() where possible. > > - Direct getters through Cast() where possible, infallible (also where > > possible) otherwise. > > For avoidance of doubt, since I

Re: XPCOM Tidying Proposal

2019-01-11 Thread Boris Zbarsky
On 1/10/19 6:15 PM, Kyle Machulis wrote: - Removal of [noscript] methods in interfaces in favor of direct calls via Cast() where possible. This seems generally reasonably, though I'd like to put in a bit of a vote for the pattern I recently used for nsIPrincipal::IsSystemPrincipal, which

Re: XPCOM Tidying Proposal

2019-01-11 Thread Bobby Holley
On Fri, Jan 11, 2019 at 11:30 AM Boris Zbarsky wrote: > On 1/10/19 6:15 PM, Kyle Machulis wrote: > > - Removal of [noscript] methods in interfaces in favor of direct calls > via > > Cast() where possible. > > This seems generally reasonably, though I'd like to put in a bit of a > vote for the

Apple Notary Service and Debugging Impact

2019-01-11 Thread Haik Aftandilian
Please take a look if you debug Firefox on macOS. Apple's notary service[1] is a new way to sign macOS applications that has some security benefits[2] and provides a slight user experience improvement[3] when users download the application and run it for the first time. Specifically, the dialog

Re: XPCOM Tidying Proposal

2019-01-11 Thread Kyle Machulis
On Fri, Jan 11, 2019 at 11:59 AM Bobby Holley wrote: > The idea is that we should gradually pass BasePrincipal around the codebase > rather than nsIPrincipal, which would avoid the need to invoke Cast at the > specific callsite. I have no objection to your proposed pattern in the > interim if it