Re: Feedback requested: mach try auto

2020-05-06 Thread Andrew Halberstadt
On Wed, May 6, 2020 at 4:04 PM Steve Fink wrote: > Would it work to make a `mach try fuzzy --auto` or similar entrypoint, > where it brings up the fzf selector with the automatic set of tests as a > starting point? > Yes, this is something I've thought about as well. We could remove chunk

Re: New and improved stack-fixing

2020-05-06 Thread Gabriele Svelto
On 06/05/20 17:01, Markus Stange wrote: > I see. What about crashes during regular optimized builds? I'd hope > those print stacks. You mean local builds? Unless you have ac_add_options --enable-debug in your mozconfig you won't see stack traces. What you can do in that case is build with the

Re: Feedback requested: mach try auto

2020-05-06 Thread Steve Fink
Would it work to make a `mach try fuzzy --auto` or similar entrypoint, where it brings up the fzf selector with the automatic set of tests as a starting point? On 5/6/20 6:55 AM, Andrew Halberstadt wrote: Hello everyone, A handful of us have been hard at work on an initiative to become

Re: New and improved stack-fixing

2020-05-06 Thread Gabriele Svelto
On 05/05/20 23:38, Nicholas Nethercote wrote: > As for why that check is there... do opt builds produce any stack traces in > tests? Normal assertions aren't enabled on opt builds, but > diagnostic/release assertions are. I can't remember off the top of my head > if they produce stacks traces in

Feedback requested: mach try auto

2020-05-06 Thread Andrew Halberstadt
Hello everyone, A handful of us have been hard at work on an initiative to become smarter about which tests we schedule for a given push. We are approaching our first major milestone, a try selector that can automatically pick which tests are most relevant to your push on your behalf. You can

Re: New and improved stack-fixing

2020-05-06 Thread Markus Stange
On Wed, May 6, 2020 at 6:44 AM Gabriele Svelto wrote: > On 05/05/20 23:38, Nicholas Nethercote wrote: > > As for why that check is there... do opt builds produce any stack traces > in > > tests? Normal assertions aren't enabled on opt builds, but > > diagnostic/release assertions are. I can't