Re: PGO: another test + PGO topcrashes
On 11/1/2012 9:19 PM, Dave Mandelin wrote: (a) How about building Windows with a newer version of MSVC, say 2012? (What version are we using now, anyway? The build instructions page says 2010 is official, but a tbpl log showed Visual Studio 9.0 on the path.) Maybe they have fixed bugs in PGO. As Ehsan mentioned, we're blocked on switching to 2012 until they sort out XP support, but that should be in SP1 (which is usually a safe release to wait for anyway). I'd support switching to 2012SP1 when it is released. Microsoft has been pretty good about fixing compiler bugs when we submit them with test cases. It can be hard to get a useful reproducible testcase out of a PGO compiler bug, but we should probably try harder to do so so we have a chance of removing these workarounds in the future. -Ted ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: PGO: another test + PGO topcrashes
On Fri, Nov 2, 2012 at 2:19 PM, Dave Mandelin dmande...@gmail.com wrote: (b) Failing that, how about not fixing PGO bugs unless they are reproducible, on a trial basis? If my lifecycle theory is correct, then the total crash rate would stay roughly constant. And I assume that if the crash rate doesn't actually go up, that's OK. If it does, and especially if that can be shown to be due to an increasing number due to outstanding PGO bugs, that would show that we do benefit from fixing them. Seems to me a good start would be to make a number of builds from regularly spaced points in the past, backing out all PGO fixes in all those builds, and examining the code to see if each PGO bug was present. Perhaps you could improve the results by weighting each bug according to its measured topcrash rate while it was present. Rob -- Jesus called them together and said, “You know that the rulers of the Gentiles lord it over them, and their high officials exercise authority over them. Not so with you. Instead, whoever wants to become great among you must be your servant, and whoever wants to be first must be your slave — just as the Son of Man did not come to be served, but to serve, and to give his life as a ransom for many.” [Matthew 20:25-28] ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: PGO: another test + PGO topcrashes
On 2012-11-01 9:19 PM, Dave Mandelin wrote: (a) How about building Windows with a newer version of MSVC, say 2012? (What version are we using now, anyway? The build instructions page says 2010 is official, but a tbpl log showed Visual Studio 9.0 on the path.) Maybe they have fixed bugs in PGO. We use 2010. We cannot use 2012 yet because its dynamically linked runtime libraries don't support Windows XP, which may come in a future update. Cheers, Ehsan ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
