Re: [dev-servo] Error during compilation

2018-12-06 Thread Avanthikaa Ravichandran
te: > >> I pushed a fix, please rebase your pull request to master to pull it in. >> >> Thanks, >> -Manish Goregaokar >> >> >> On Wed, Dec 5, 2018 at 10:08 PM Avanthikaa Ravichandran >> wrote: >> >>> We pushed the final

Re: [dev-servo] Error during compilation

2018-12-05 Thread Avanthikaa Ravichandran
Which github issue are you talking about?) > -Manish Goregaokar > > > On Fri, Nov 30, 2018 at 6:38 AM Avanthikaa Ravichandran > wrote: > >> I made changes to the ConstantSourceNode example as suggested in the review >> for the pull request. However, I am getting the follow

[dev-servo] Implementing periodic wave options for Oscillator node

2018-11-27 Thread Avanthikaa Ravichandran
Hi, We are implementing the periodic wave options for the oscillator node and the formula as mentioned in the link below uses a 'N' which is said to be a power of 2. How do we know what the value of N is? Is this set by the user or do we assume it to be some arbitrary power of 2 > 0?

Re: [dev-servo] Mozilla Servo Media - Implementing WebAudio Nodes

2018-11-17 Thread Avanthikaa Ravichandran
Nov 15, 2018 at 4:15 PM Avanthikaa Ravichandran > > wrote: > > > Thank you so much. > > We are also trying to implement the periodic wave option for the > oscillator > > node. The sizes of the real and imag arrays in the PeriodicWaveOptions > > structure a

Re: [dev-servo] Mozilla Servo Media - Implementing WebAudio Nodes

2018-11-15 Thread Avanthikaa Ravichandran
`k` here is an AudioParam, so it's not always a constant -- > similar to how frequency in OscillatorSourceNode or gain in GainNode can > vary per frame. > -Manish Goregaokar > > > On Thu, Nov 15, 2018 at 2:48 PM Avanthikaa Ravichandran > > wrote: > > > Hi, > > > > We

[dev-servo] Mozilla Servo Media - Implementing WebAudio Nodes

2018-11-15 Thread Avanthikaa Ravichandran
Hi, We are working on implementing the missing WebAudio nodes in servo-media. One of the initial steps says* ‘implement the missing ConstantSource node type that produces a constant tone based on a stored value that can be modified using the GainNode implementation as a model*'. Am I right in

Re: [dev-servo] Rustfmt now checked on CI

2018-11-08 Thread Avanthikaa Ravichandran
We are working on the media crate for servo and we were asked to run the rustfmt to format the code. However, in the servo/media repo that we worked on, we cannot run the ./mach command. Are we expected to integrate it with the main servo repository? How do we run rustfmt on our file otherwise?

Re: [dev-servo] Query regarding WebAudio node API - Implementing periodic wave options

2018-11-07 Thread Avanthikaa Ravichandran
ways that forbid that (such as adding a Vec member), feel > free to remove the derivation. > > Cheers, > Josh > > On 11/6/18 8:09 PM, Avanthikaa Ravichandran wrote: > > Hi, > > I am trying to write an implementation for the PeriodicWaveOptions in the > > oscillator no

[dev-servo] Query regarding WebAudio node API - Implementing periodic wave options

2018-11-06 Thread Avanthikaa Ravichandran
Hi, I am trying to write an implementation for the PeriodicWaveOptions in the oscillator node. The parameters for this - real and imaginary, do not have fixed sizes at compile time since they depend on the user input options. This requires the use of the Vec datatype. However, vectors do not