Re: [dev-servo] Query regarding WebAudio node API - Implementing periodic wave options

2018-11-07 Thread Manish Goregaokar
No, that creates an empty (silent) buffer for the oscillator generation to write to. The code that needs rewriting is the code that calls sin(). -Manish Goregaokar On Wed, Nov 7, 2018 at 3:27 PM Avanthikaa Ravichandran wrote: > Thank you for your response. > I was also wondering if the statem

Re: [dev-servo] Query regarding WebAudio node API - Implementing periodic wave options

2018-11-07 Thread Avanthikaa Ravichandran
Thank you for your response. I was also wondering if the statement inputs.blocks.push(Default::default()); in "oscillator_node.rs" is the one setting default values for the oscillator node wave? What exactly does this statement push into the input blocks? From my understanding, this needs to be rew

Re: [dev-servo] Query regarding WebAudio node API - Implementing periodic wave options

2018-11-07 Thread Josh Bowman-Matthews
Yes, if there are types that derive Copy right now that are being modified in ways that forbid that (such as adding a Vec member), feel free to remove the derivation. Cheers, Josh On 11/6/18 8:09 PM, Avanthikaa Ravichandran wrote: Hi, I am trying to write an implementation for the PeriodicWav

Re: [dev-servo] Query regarding WebAudio node API - Implementing periodic wave options

2018-11-06 Thread Manish Goregaokar
Yeah, it is fine to remove the Copy. On Tue, Nov 6, 2018, 5:09 PM Avanthikaa Ravichandran Hi, > I am trying to write an implementation for the PeriodicWaveOptions in the > oscillator node. The parameters for this - real and imaginary, do not have > fixed sizes at compile time since they depend on

[dev-servo] Query regarding WebAudio node API - Implementing periodic wave options

2018-11-06 Thread Avanthikaa Ravichandran
Hi, I am trying to write an implementation for the PeriodicWaveOptions in the oscillator node. The parameters for this - real and imaginary, do not have fixed sizes at compile time since they depend on the user input options. This requires the use of the Vec datatype. However, vectors do not derive