Thank you for all your help in formatting the existing code and enabling
rustfmt in CI! I'm very pleased that we've adopted rustfmt and that we
now have consistent formatting with the rest of the Rust ecosystem.
Cheers,
Josh
On 11/7/18 1:51 PM, Pyfisch wrote:
Hi Everyone,
Servo source code
Woohoo! Great work everyone!
On Wed, Nov 7, 2018 at 11:22 AM Josh Bowman-Matthews
wrote:
>
> Thank you for all your help in formatting the existing code and enabling
> rustfmt in CI! I'm very pleased that we've adopted rustfmt and that we
> now have consistent formatting with the rest of the Rust
Hi Everyone,
Servo source code is now formatted with rustfmt [1]. Style checking is
part of ./mach test-tidy and enforced on CI. To automatically format
your code run ./mach fmt before commiting. Import order was changed but
./mach fmt will fix
any issues. Please ask any questions you may
No, that creates an empty (silent) buffer for the oscillator generation to
write to.
The code that needs rewriting is the code that calls sin().
-Manish Goregaokar
On Wed, Nov 7, 2018 at 3:27 PM Avanthikaa Ravichandran
wrote:
> Thank you for your response.
> I was also wondering if the
Thank you for your response.
I was also wondering if the statement
inputs.blocks.push(Default::default());
in "oscillator_node.rs" is the one setting default values for the
oscillator node wave? What exactly does this statement push into the input
blocks? From my understanding, this needs to be
Yes, if there are types that derive Copy right now that are being
modified in ways that forbid that (such as adding a Vec member), feel
free to remove the derivation.
Cheers,
Josh
On 11/6/18 8:09 PM, Avanthikaa Ravichandran wrote:
Hi,
I am trying to write an implementation for the
6 matches
Mail list logo
