Re: [dev-servo] Web-platform-tests status

2014-04-19 Thread Manish Goregaokar
> * we don't have an easy way to run single tests run.py (in src/test/wpt) has an --include option. Be sure to source the virtualenv in the build dir before running run.py > * Servo times out on a lot of tests, causing the run to take 11 minutes here We probably should exclude some of the t

Re: [dev-servo] Web-platform-tests status

2014-04-20 Thread Manish Goregaokar
g people run the entire check-wpt after every PR is a bit unsustainable) We probably should have bors output a diff of the metadata directory after running the tests, which we can inspect for issues and then check in. -Manish Goregaokar On Sat, Apr 19, 2014 at 9:51 PM, James Graham wrote: > On 1

Re: [dev-servo] DOM rooting is live

2014-05-03 Thread Manish Goregaokar
This is great! -Manish Goregaokar On Sun, May 4, 2014 at 1:04 AM, Patrick Walton wrote: > On 5/3/14 12:30 PM, Josh Matthews wrote: > >> Learn to love it. When you find a type error where something is asking >> for a JSRef and you're not providing it, that's a pot

Re: [dev-servo] New on Servo

2014-05-14 Thread Manish Goregaokar
b.com/mozilla/servo/issues?labels=E-easy&page=1&state=open> that you can try once you have some familiarity with Rust. And #servo on IRC is usually reasonably active if you need help. -Manish Goregaokar On Wed, May 14, 2014 at 3:27 PM, Ricardo Brandão wrote: > Hi All, > > Yeste

[dev-servo] rust-http, Teepee, and Fetch

2014-07-07 Thread Manish Goregaokar
should we do about our own http library? - Thoughts in general? (These can be discussed in the meeting, just putting this mail out with most of the details in case I can't turn up) Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] rust-http, Teepee, and Fetch

2014-07-18 Thread Manish Goregaokar
brary -- I feel that this is something the community does need at some point; but that's probably not going to happen yet. I'll probably get started on rust-fetch Sunday. Semester starts Monday, progress might be a bit slow (fortunately cors.rs contains a lot of the stuff I need fo

Re: [dev-servo] rust-http, Teepee, and Fetch

2014-07-18 Thread Manish Goregaokar
Sorry, the link is https://github.com/Manishearth/rust-http/compare/chris-morgan:master...Manishearth:discombobulate -Manish Goregaokar On Sat, Jul 19, 2014 at 1:40 AM, Manish Goregaokar wrote: > Okay, so the past few days I've been playing around with rust-http. The > main issue

Re: [dev-servo] Servo documentation and website

2014-08-07 Thread Manish Goregaokar
which is a bit confusing. -Manish Goregaokar On Thu, Aug 7, 2014 at 6:26 PM, Simon Sapin wrote: > Hi all, > > http://doc.servo.org/ is now live! It’s the rustdoc documentation for > Servo master, including all submodules and Rust, at the specific versions > that are being use

Re: [dev-servo] Servo documentation and website

2014-08-07 Thread Manish Goregaokar
I'll have a look if I get time, then. -Manish Goregaokar On Thu, Aug 7, 2014 at 7:31 PM, Simon Sapin wrote: > On 07/08/14 14:11, Manish Goregaokar wrote: > >> :D Love the docs, especially the bit about having the docs for our own >> compiler version. I usually end up

[dev-servo] Cleaner llvm options?

2014-08-27 Thread Manish Goregaokar
A few days ago I was setting up a clean Rust build, and I wanted to avoid the llvm build. For some reason, the apt-get install from the Travis file didn't work -- there were gpg issues. Eventually I ended up using Servo's llvm snapshot. Which was fine with me. However, the only reason I knew that

Re: [dev-servo] Cleaner llvm options?

2014-08-27 Thread Manish Goregaokar
This was supposed to go to rust-dev. Sorry about that. -Manish Goregaokar On Wed, Aug 27, 2014 at 11:51 PM, Manish Goregaokar wrote: > A few days ago I was setting up a clean Rust build, and I wanted to avoid > the llvm build. > > For some reason, the apt-get install from the

[dev-servo] New blog

2014-09-01 Thread Manish Goregaokar
blog.servo.org is up! Feel free to put whatever you want there (and improve the theme). I plan to put "This week in Servo"s up there, other posts or improvements to the existing TWiS would be appreciated :) -Manish Goregaokar ___ dev-ser

Re: [dev-servo] New blog

2014-09-01 Thread Manish Goregaokar
Fixed, thanks :) -Manish Goregaokar On Tue, Sep 2, 2014 at 4:14 AM, Steve Klabnik wrote: > I tweeted this, and got two questions: > https://twitter.com/badboy_/status/506572974187896832 > ___ dev-servo mailing list dev-servo@lists.mozilla.

Re: [dev-servo] New Contributors

2014-09-03 Thread Manish Goregaokar
Github aren't enough, feel free to ping someone in IRC. Another thing you can do is trawl through web platform test failures (some instructions here <https://github.com/servo/servo/blob/master/src/test/wpt/README.md>). There are a lot of failures due to trivial issues there. -Manish

Re: [dev-servo] Fwd: Re: Reviewing the SpiderMonkey upgrade for Servo

2014-10-17 Thread Manish Goregaokar
> Potential issues I see with the design: > > - there are Root, Handle and MutableHandle types that work on SM GC > things, but there's no equivalent of the rooting analysis (that I could > see) that prevents you from keeping unrooted GC thing pointers live over an > operation that could GC. > >

[dev-servo] Meeting notes 10/27 (Work week planning, acid2, string interning perf gains, glutin, split builds)

2014-10-29 Thread Manish Goregaokar
https://github.com/servo/servo/wiki/Meeting-2014-10-27 -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

[dev-servo] We can do some minor dogfooding now

2014-11-13 Thread Manish Goregaokar
related stuff without too many issues (aside from the random compositor panics and lack of pdf support) Highly suggest you try it! -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] SpiderMonkey upgrade blockers

2014-12-08 Thread Manish Goregaokar
What sort of static analysis pass is needed? Is it something our plugins crate can do? Also, my Reflector/InheritancePass PR provides match_unwrap_ty(), so linting for Vec> is potentially a one line change (+boilerplate). -Original Message- From: "Josh Matthews" Sent: ‎12/‎9/‎2014

[dev-servo] Meeting notes 12/8 (Rust in Gecko; HTTP cache; SpiderMonkey upgrade; Azure upgrade, Dogfooding)

2014-12-09 Thread Manish Goregaokar
https://github.com/servo/servo/wiki/Meeting-2014-12-08 -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Give the user control

2015-01-20 Thread Manish Goregaokar
This isn't really the domain of a browser *engine* IMO, it's the domain of the browser as a whole (which we aren't, not right now anyway) -Manish Goregaokar On Tue, Jan 20, 2015 at 6:17 PM, Marc Collin wrote: > How about a browser that, for once, empowers their users? > Pe

Re: [dev-servo] Channels and synchronous networking

2015-01-28 Thread Manish Goregaokar
Perhaps if we had some sort of priority system to the queue, where high priority events (navigation, etc) override the other ones? -Manish Goregaokar On Thu, Jan 29, 2015 at 2:00 AM, Boris Zbarsky wrote: > On 1/28/15 12:33 PM, Josh Matthews wrote: > >> I'm not certain what y

[dev-servo] Moving deps to nightlies

2015-01-31 Thread Manish Goregaokar
think of is html5ever, and it already tracks nightlies. Thoughts? -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Moving deps to nightlies

2015-01-31 Thread Manish Goregaokar
Alright, I'll start soon. This makes travisifying easier too :) -Original Message- From: "Jack Moffitt" Sent: ‎1/‎31/‎2015 9:01 PM To: "Lars Bergstrom" Cc: "Manish Goregaokar" ; "dev-servo" Subject: Re: [dev-servo] Moving deps to nightlie

Re: [dev-servo] HTTP referer disabled by default

2015-02-04 Thread Manish Goregaokar
to help avoid break the web, at the same time providing much better security guarantees that (eventually) webapp devs don't have to worry about. Though this is for the standards people to decide. -Manish Goregaokar On Wed, Feb 4, 2015 at 7:05 PM, Jack Moffitt wrote: > > However, do s

Re: [dev-servo] Build flavors and defaults

2015-02-24 Thread Manish Goregaokar
instead of per-PR. This way we don't double our build times or need extra buildslaves. -Manish Goregaokar On Tue, Feb 24, 2015 at 7:42 PM, Lars Bergstrom wrote: > Two questions about build flavors. > > 1) Should we change the default build type back from debug to release? > > Whe

Re: [dev-servo] Build flavors and defaults

2015-02-24 Thread Manish Goregaokar
follow any clear pattern. I was more concerned about buildslaves running out and then the build taking as long as T(debug)+T(release); instead of being just max(T(debug), T(release)) -Manish Goregaokar On Tue, Feb 24, 2015 at 9:56 PM, Jack Moffitt wrote: > I'm +1 to make ./mach build do re

Re: [dev-servo] Build flavors and defaults

2015-02-24 Thread Manish Goregaokar
I added a set of builders (not hooked up with bors) to saltfs: https://github.com/servo/saltfs/pull/15 If we merge that, we should be able to time it. -Manish Goregaokar On Tue, Feb 24, 2015 at 10:00 PM, Manish Goregaokar wrote: > With wpt? I think they're mostly the same, since

Re: [dev-servo] Build flavors and defaults

2015-02-24 Thread Manish Goregaokar
- Debug - 28:00 <http://build.servo.org/builders/linux2/builds/849>, 18:56 without WPT - Release - 26:45, without WPT <http://build.servo.org/builders/linux2-rel/builds/0> We'll need to fix wpt on release <https://github.com/servo/servo/issues/5056> to get proper nu

Re: [dev-servo] Easier layout issues?

2015-02-25 Thread Manish Goregaokar
27;s go for it! -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

[dev-servo] PSA: Cargo home directory moving

2015-03-07 Thread Manish Goregaokar
and friends, you can override this behavior: - Copy servobuild.example to .servobuild - Edit `cache-dir` and `cargo-home-dir` to point to wherever you want it to be (`./.servo` and `~/.cargo` respectively if you want to keep the old behavior). Thanks, -Manish Goregaokar

Re: [dev-servo] PSA: Cargo home directory moving

2015-03-07 Thread Manish Goregaokar
(It just landed, so be careful when pulling the latest master) -Manish Goregaokar On Sat, Mar 7, 2015 at 7:31 PM, Manish Goregaokar wrote: > Once https://github.com/servo/servo/pull/5168 lands the default .cargo > directory for all dependency clones will be moved to the repo root, simila

[dev-servo] Travis now checks tidy

2015-03-15 Thread Manish Goregaokar
2f6-4fdafbb5223b.png> . Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

[dev-servo] Let's collaborate on This Week In Servo!

2015-04-02 Thread Manish Goregaokar
ependency) which you think belongs in TWiS, don't hesitate add it to the notable changes section in the draft! (nothing wrong about adding your own changes). If we incrementally write it through the week, it becomes simple to finish it up after the meeting and publis

[dev-servo] Updating your repos

2015-04-03 Thread Manish Goregaokar
odules whilst doing so. Try to rebase and push all of your open PRs to master, too, github chokes on these otherwise. You may need to do similar gymnastics whilst rebasing, *or* just simulate a rebase via cherry picks (checkouts take a while if you're crossing jgraham's PR) Thanks, -M

[dev-servo] Switching to homu

2015-04-06 Thread Manish Goregaokar
he bot behind the invocation is likely to change to @homu: or @bors:, but for now we don't have the support in homu's codebase. Bors is dead, long live homu! -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Meeting notes 4/27 (Reviewable; blog posts; github/BMO; infra issues; Whistler planning)

2015-04-28 Thread Manish Goregaokar
being tracked on Bugzilla and we' probably should continue with that); but for now I don't see much of a reason to migrate, aside from avoiding having to migrate a larger Servo in the future. -Manish Goregaokar On Tue, Apr 28, 2015 at 10:33 AM, Robert O'Callahan wrote: > On Tu

Re: [dev-servo] Meeting notes 4/27 (Reviewable; blog posts; github/BMO; infra issues; Whistler planning)

2015-04-28 Thread Manish Goregaokar
worse option IMO. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

[dev-servo] Adding Windows CI

2015-05-09 Thread Manish Goregaokar
Appveyor provides free CI for Windows, and is pretty easy to set up. Since we already have Travis set up on almost all deps, should we do the same with Appveyor? I tried it out on rust-url[1] and it worked pretty smoothly (yml copied from Glutin) Most of our deps should just work with Windows,

Re: [dev-servo] Adding Windows CI

2015-05-10 Thread Manish Goregaokar
ther image libs -Manish Goregaokar On Sun, May 10, 2015 at 3:03 PM, Sean McArthur wrote: > It can be a sanity check that a library builds on Windows. Mostly that all > its dependencies don't suddenly lose support or stop compiling. > > That's the only reason I'm consi

Re: [dev-servo] Policy for publishing submodules to crates.io

2015-05-22 Thread Manish Goregaokar
are enough env vars available to check for branches and PRs). This would be fiddly, but it should work. It would be nice to set up a shell script on servo-s3 and curl it from all travis files (making this process easy to update) -Manish Goregaokar On Fri, May 22, 2015 at 7:19 PM,

Re: [dev-servo] crates.io package ownership (write access)

2015-05-26 Thread Manish Goregaokar
This sounds good. We can expand as needed. -Manish Goregaokar On Tue, May 26, 2015 at 9:09 PM, Jack Moffitt wrote: > > Who should that be? Everyone on > https://github.com/orgs/servo/teams/owners ? > > Everyone on https://github.com/orgs/servo/people ? Some other set of &

Re: [dev-servo] Draft blog post about memory measurement

2015-06-01 Thread Manish Goregaokar
The comment goes away in that PR :) As for Arc, I think the plan is to divide by the refcount; to get a "weight" sort of thing. Note that we only need to worry about shared references, not all non-owning references (borrows can be ignored) -Manish Goregaokar On Mon, Jun 1, 2015

[dev-servo] PSA: Do not use the try feature on homu

2015-06-01 Thread Manish Goregaokar
... it sets things on fire. I think Rust has a slightly different setup for try which somehow works, but in our case @bors-servo: try on jgraham's PR <https://github.com/servo/servo/pull/6244>queued nearly 200 PRs for trying. -Manish

[dev-servo] PRs are now gated on csstests on linux

2015-06-02 Thread Manish Goregaokar
ittents let jgraham know (and disable them). We can un-gate if there are too many of them. Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] PRs are now gated on csstests on linux

2015-06-02 Thread Manish Goregaokar
As far as tryserver goes it should be easy to patch homu to accept a wider list of "try-enabled" users, which we can hand out liberally like Firefox does. First we should get around to fixing the try feature though :) -Manish Goregaokar On Tue, Jun 2, 2015 at 11:29 PM, James Gra

[dev-servo] Audit of unstable Rust feature usage in Servo

2015-06-09 Thread Manish Goregaokar
is just one bikeshed away. ccing part of the rust libs team in case they're interested in these results. Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Best way to work on multiple branches concurrently?

2015-06-10 Thread Manish Goregaokar
Copy servobuild.example to .servobuild Then just add the path of a central .cargo or .servo to the cache-dir and cargo-home-dir keys. Mine are ./../.servo and ./../.cargo -Manish Goregaokar On Thu, Jun 11, 2015 at 1:26 AM, Nicholas Nethercote wrote: > Hi, > > I often like to work on

Re: [dev-servo] (Not) using wildcard version when declaring dependencies

2015-06-15 Thread Manish Goregaokar
the versions in toml files though. -Manish Goregaokar On Tue, Jun 16, 2015 at 2:22 AM, Simon Sapin wrote: > Some of our dependencies to crates on crates.io are declared in > Cargo.toml files like this: > > [dependencies] > foo = "*" > > To be honest, I’m not su

Re: [dev-servo] (Not) using wildcard version when declaring dependencies

2015-06-15 Thread Manish Goregaokar
Yes, I was talking about Crates crates too :) My plan is to upgrade Rust often now that it's pretty stable, which automatically keeps our libraries up to date too. But if we don't want to do that I guess pinning to semver is okay. -Manish Goregaokar On Tue, Jun 16, 2015 at 2:52 AM, S

[dev-servo] Allowing occasional rollups?

2015-08-07 Thread Manish Goregaokar
less linear history is okay, especially when most of the PRs being rolled up are minor ones. Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] mac3

2015-08-07 Thread Manish Goregaokar
s. If something breaks, we can bisect if necessary. -Manish Goregaokar On Fri, Aug 7, 2015 at 3:10 PM, Ms2ger wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi all, > > The last mac3 run (<http://build.servo.org/builders/mac3/builds/829>) > took 1 hrs, 13 m

Re: [dev-servo] Travis, Rust Nightlies & Aster

2015-08-20 Thread Manish Goregaokar
That sounds doable. I'm open to helping maintain aster's nightlyness. -Manish Goregaokar On Thu, Aug 20, 2015 at 9:47 PM, Simon Sapin wrote: > On 20/08/15 17:50, Ms2ger wrote: > >> Hi all, >> >> Recently, homu has regularly rejected PRs to rust-layers be

Re: [dev-servo] Turning on autoloader rebasing and/or autosquashing

2015-10-15 Thread Manish Goregaokar
work. `git log --topo-order` iirc does bunching of commits by parent chains (verses `git log --date-order`, which I *think* is the default). -Manish Goregaokar On Thu, Oct 15, 2015 at 7:17 PM, Anthony Ramine wrote: > Le 15 oct. 2015 à 14:42, Lars Bergstrom a écrit : > > > - Aut

Re: [dev-servo] Turning on autoloader rebasing and/or autosquashing

2015-10-15 Thread Manish Goregaokar
Barosl just verified in chat that it makes an empty commit with the merge information even when rebasing. I'm now pretty ambivalent towards this. I don't mind linear histories, but ... I can handle graphy ones too. -Manish Goregaokar On Fri, Oct 16, 2015 at 2:08 AM, Manish Goregao

Re: [dev-servo] (no subject)

2015-10-17 Thread Manish Goregaokar
s://github.com/brson/multirust> is a way of maintaining multiple Rust installs in parallel, if you don't want to uninstall your nightly. I'll let you know when stuff is working again. -Manish Goregaokar ___ dev-servo mailing list dev-se

Re: [dev-servo] (no subject)

2015-10-18 Thread Manish Goregaokar
I'll get around to updating all of the deps to work with it later. @Divya try a fresh checkout of rust-layers. I tweaked the crates so that they don't need plugin support when being built standalone (since the plugins are only needed for Servo integration to work) -Manish Goregaokar O

Re: [dev-servo] (no subject)

2015-10-19 Thread Manish Goregaokar
Delete your Cargo.lock -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] WPT Tests

2015-10-20 Thread Manish Goregaokar
CI (there was an incident when this stopped working, IIRC). It's not an "actual" web platform test. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] (no subject)

2015-10-21 Thread Manish Goregaokar
mach cargo, ./mach rustc) instead. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] (no subject)

2015-10-21 Thread Manish Goregaokar
just have to do it. -Manish Goregaokar On Thu, Oct 22, 2015 at 4:03 AM, Divya Jain wrote: > Hi Manish, > > So with you advice, I reset the HEAD to the commit you mentioned in the > previous mail. The cargo override for Servo is building fine with the > commit mentioned in the em

Re: [dev-servo] "Hacking Servo for noobs" moving it to servo repo or to wiki?

2015-10-22 Thread Manish Goregaokar
CONTRIBUTING sgtm -Manish Goregaokar On Thu, Oct 22, 2015 at 4:51 PM, Paul Rouget wrote: > Maybe I could merge it into CONTRIBUTING.md? Or README.md? > What would you recommend? > > On Thu, Oct 22, 2015 at 12:54 PM, Josh Matthews > wrote: > > I'd like to move it into

Re: [dev-servo] Additional crashing and timeout tests for XMLHttpRequest

2015-10-24 Thread Manish Goregaokar
et to implement, fine, if not, then re-check your implementation of overrideMimeType(). (You can open a pull request first if you wish) Thanks, -Manish Goregaokar On Sun, Oct 25, 2015 at 2:33 AM, Jitendra Jain wrote: > Hello, > > We are working on M1504: Implement support for missing XMLH

Re: [dev-servo] Error in ./mach test-tidy

2015-11-01 Thread Manish Goregaokar
You need to add a link to the spec where you got the webidl from. The other interfaces all have a link to html.spec.whatwg.org or similar. -Manish Goregaokar On Sun, Nov 1, 2015 at 11:02 AM, JIGAR SHARDA wrote: > Hi All, > > I am trying to add a new interface and while running the ./

[dev-servo] Handling cases where the spec is inefficient and not followed by anyone

2015-11-02 Thread Manish Goregaokar
e can implement the spec as is (which require major changes and affect perf or complexity), or we can hope that nobody relies on this behaviour (given that it's not followed by major browsers) and implement it as logically as possible, keeping in line with other browsers (and leaving a bug open

Re: [dev-servo] Meeting notes 11/2 (review carry-over; test coverage; 2016 roadmap; rebase/autosquash; PR queue; debug logging; CSSWG reftests)

2015-11-03 Thread Manish Goregaokar
I believe that's the internal spreadsheet, not supposed to be public. The roadmap on the wiki exists -Manish Goregaokar On Tue, Nov 3, 2015 at 4:10 PM, Tetsuharu OHZEKI wrote: > > 2016 Roadmap > > > https://docs.google.com/spreadsheets/d/1HYoEo5Vx9XuFWFh_1zGWtT-pvebNqspY-P

Re: [dev-servo] Meeting notes 11/2 (review carry-over; test coverage; 2016 roadmap; rebase/autosquash; PR queue; debug logging; CSSWG reftests)

2015-11-03 Thread Manish Goregaokar
That sounds like a good idea. Perhaps we should do this on the mozilla-central side; move things out of mochitest into WPT? Is there an easy way of identifying browser-agnostic mochitests? -Manish Goregaokar ___ dev-servo mailing list dev-servo

Re: [dev-servo] Meeting notes 11/2 (review carry-over; test coverage; 2016 roadmap; rebase/autosquash; PR queue; debug logging; CSSWG reftests)

2015-11-03 Thread Manish Goregaokar
We probably can't do it in an automated way; tests being converted to WPT need to match spec and usually also need a spec link in the top. We could, however, import them wholesale into Servo's tests/wpt/mozilla/foo, and then manually pick through them. -Manish Goregaokar On Wed, Nov

Re: [dev-servo] Meeting notes 11/2 (review carry-over; test coverage; 2016 roadmap; rebase/autosquash; PR queue; debug logging; CSSWG reftests)

2015-11-03 Thread Manish Goregaokar
le changes that require internal-only APIs to trigger. > Agreed, still need webdriver. Once we get webdriver it might be nice to translate&upstream even more content mochitests to WPT or wherever we'll be keeping the webdriver tests. -Manish Goregaokar ___

Re: [dev-servo] Handling cases where the spec is inefficient and not followed by anyone

2015-11-04 Thread Manish Goregaokar
g it) and filing a bug -- if it's not too hard to do so -- is what we should do. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Handling cases where the spec is inefficient and not followed by anyone

2015-11-04 Thread Manish Goregaokar
Oh, yeah, in that case we should just mimic the other browsers and file bugs. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

[dev-servo] PSA: Review delegation enabled for homu

2015-11-11 Thread Manish Goregaokar
can see it in action here <https://github.com/servo/saltfs/pull/160>. Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] PSA: Review delegation enabled for homu

2015-11-12 Thread Manish Goregaokar
Bit late to the party, but I think there are a couple of core issues causing this debate: There are actually two kinds of trust involved. First is the trust to not botnet the CI, basically everyone here (at least everyone with try) has that. But that's not the actual one being discussed here. The

Re: [dev-servo] Question about webidl files and old versions of servo

2015-11-28 Thread Manish Goregaokar
, you'll also need to add the webidl file (as well as a dom module) for ImageData <https://html.spec.whatwg.org/multipage/scripting.html#imagedata>. Do you have a link to the spec for ImageRequest? I couldn't find it after some quick searching. Let

Re: [dev-servo] Mozlando meeting notes

2015-12-13 Thread Manish Goregaokar
since Magic DOM probably will change the landscape. -Manish Goregaokar On Sat, Dec 12, 2015 at 11:41 PM, Anthony Ramine wrote: > > Le 12 déc. 2015 à 09:56, Lars Bergstrom a écrit : > > > > Thanks to everybody for a fantastic workweek! I was impressed by how > > well w

Re: [dev-servo] IndexDB project

2015-12-14 Thread Manish Goregaokar
We were thinking of SQLite4, however there seem to be people <https://twitter.com/floydophone/status/676540491068891137> using rocksdb+rust in production (https://github.com/spacejam/rust-rocksdb?) -Manish Goregaokar On Tue, Dec 15, 2015 at 8:57 AM, Jack Moffitt wrote: > Probably th

Re: [dev-servo] IndexDB project

2015-12-14 Thread Manish Goregaokar
Apparently SQlite4 has a good kv store included, but nox knows it better and understands the justification. I think firefox uses sqlite (3?); it uses sqlite for everything. -Manish Goregaokar On Tue, Dec 15, 2015 at 9:12 AM, Jack Moffitt wrote: > Why would we use a nearly full sql eng

Re: [dev-servo] IndexDB project

2015-12-14 Thread Manish Goregaokar
g necessary things too, not only focusing on new experiments :) Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] IndexDB project

2015-12-14 Thread Manish Goregaokar
More or less. If you're going to pick leveldb it would be better to use rocksdb (which is a leveldb fork, IIRC) since there is a Rust wrapper that's in use by others. -Manish Goregaokar On Tue, Dec 15, 2015 at 11:03 AM, Shing Lyu wrote: > Thank you guys. > > So from what I

Re: [dev-servo] Fwd: Re: Suggested code review workflow

2016-02-21 Thread Manish Goregaokar
ype PR messages since nobody wants to retype what the issue says. -Manish Goregaokar On Sun, Feb 21, 2016 at 5:58 AM, Lars Bergstrom wrote: > This may also be less of a big deal here at Mozilla, where there's > (presumably?) only been one bug database since 1998 and will only be > one

Re: [dev-servo] PSA: incoming Windows CI (AppVeyor)

2016-03-05 Thread Manish Goregaokar
This has been deployed. https://github.com/servo/servo/pull/9884#issuecomment-192805671 The builder is called "status-appveyor" and behaves similar to Travis. I'll be watching the queue today and tomorrow. Revert the salt deployment if anything goes wrong. Thanks, -Manish larsb...@mozilla.co

Re: [dev-servo] PSA: incoming Windows CI (AppVeyor)

2016-03-07 Thread Manish Goregaokar
It's a key milestone for stability on windows. We don't release nightlies for any desktop platform yet. Thanks, -Manish Goregaokar On Sun, Mar 6, 2016 at 8:23 AM, Phil Sweeney wrote: > Great works.. is this a key milestone for the eventual delivery of Windows > nightly bu

Re: [dev-servo] Questions about GSoC File Support project

2016-03-15 Thread Manish Goregaokar
-Manish Goregaokar On Wed, Mar 16, 2016 at 1:37 AM, Manish Goregaokar wrote: > > On Tue, Mar 15, 2016 at 3:13 PM, Zhen Zhang wrote: > >> >> 1. About FileList API, It is said to be *at risk* to be replaced by >> Array. <https://w3c.github.io/FileAPI/#filelist-secti

Re: [dev-servo] when to switch to webrender by default

2016-03-28 Thread Manish Goregaokar
Last time I tried it, Servo with LLVMpipe and WR wasn't too bad, even on the moire demo. It was slightly worse than Servo without WR, which IIRC has similar performance as Gecko. -Manish Goregaokar On Tue, Mar 29, 2016 at 2:20 AM, Bobby Holley wrote: > In general, does the software-

Re: [dev-servo] Proposal: cancel the weekly meeting

2016-04-14 Thread Manish Goregaokar
etings aren't happening anyway. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Moving away from merge commits

2016-04-27 Thread Manish Goregaokar
s some use of rev-list and skip. But it's possible; I recall doing this once. Thanks, -Manish Goregaokar On Tue, Apr 26, 2016 at 11:50 PM, Gregory Szorc wrote: > Servo developers, > > I noticed that Servo and a number of other Servo related Git repos have > tons of merge commi

Re: [dev-servo] Moving away from merge commits

2016-04-27 Thread Manish Goregaokar
Yeah, it does, that's what homu does currently. -Manish Goregaokar On Wed, Apr 27, 2016 at 9:08 PM, Nick Fitzgerald wrote: > On Wed, Apr 27, 2016 at 8:34 AM, Matt Brubeck > wrote: > > > On Wed, Apr 27, 2016 at 7:25 AM, Manish Goregaokar < > manishsm...@gmail.com>

Re: [dev-servo] Moving away from merge commits

2016-05-05 Thread Manish Goregaokar
it > doesn't. If there is a bad merge commit, `git bisect` will clearly point > to it as the culprit; while problems introduced in a rebase will in no > way indicate the rebase as the cause. > note that git bisect gets rather muddled with merge commits unless you teach it to on

Re: [dev-servo] Pull request template

2016-05-07 Thread Manish Goregaokar
ntry. It might also be nice to have bors' approval message note travis failures (only travis for now, appveyor isn't always passing) if a travis-failing PR is approved. -Manish Goregaokar On Fri, May 6, 2016 at 8:43 PM, Josh Matthews wrote: > Github introduced templates for issue

Re: [dev-servo] Difficulty getting access to Rust nightly build while building Servo.

2016-05-16 Thread Manish Goregaokar
This is the folder you want: https://static.rust-lang.org/dist/2016-05-14/index.html -Manish Goregaokar On Mon, May 16, 2016 at 3:17 PM, wrote: > Hi, > > I am trying to port Servo to Power8/LE platform (ref thread: > https://groups.google.com/forum/#!topic/mozilla.dev.servo

Re: [dev-servo] Servo without Bluetooth

2016-05-31 Thread Manish Goregaokar
endency paths do not have it enabled). If this turns out to be working reliably I'd prefer to do this, though it may unexpectedly break in the future. -Manish Goregaokar On Tue, May 31, 2016 at 8:04 PM, Jack Moffitt wrote: > > Doing it via Cargo features sounds like the better

Re: [dev-servo] Servo without Bluetooth

2016-05-31 Thread Manish Goregaokar
Oh, interesting. I have had strange errors when not fully specifying the features but the reason might have been something else. We should just do that, then, agreed. -Manish Goregaokar On Tue, May 31, 2016 at 8:21 PM, Simon Sapin wrote: > On 31/05/16 16:40, Manish Goregaokar wrote: >

Re: [dev-servo] Servo without Bluetooth

2016-06-01 Thread Manish Goregaokar
It should be net/device/bluetooth. For some reason the crate is imported as "device" instead of "devices" in net -Manish Goregaokar On Wed, Jun 1, 2016 at 1:29 PM, Dirkjan Ochtman wrote: > On Tue, May 31, 2016 at 4:51 PM, Simon Sapin wrote: > >> It is possi

Re: [dev-servo] Servo without Bluetooth

2016-06-02 Thread Manish Goregaokar
It seems like it's still checking the git repo for the feature. Might be worth landing your devices changes and proceeding from there. -Manish Goregaokar On Thu, Jun 2, 2016 at 12:56 PM, Dirkjan Ochtman wrote: > On Wed, Jun 1, 2016 at 10:53 AM, Manish Goregaokar > wrote: > >

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

2016-06-21 Thread Manish Goregaokar
oo, mostly script and then layout -- so it might be best to not split style out. Thanks, -Manish Goregaokar On Mon, Jun 20, 2016 at 8:31 PM, Lars Bergstrom wrote: > As many of you may have seen from the document > ( > https://docs.google.com/document/d/1uubYE7JXaVY10PoAY9BVx8A-T11Zx

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

2016-06-22 Thread Manish Goregaokar
anges will trigger a m-c CI build in Servo. Do lockfile changes cause this build? What about edits to util? Thanks, -Manish Goregaokar On Tue, Jun 21, 2016 at 4:16 PM, Manish Goregaokar wrote: > My main issue is that backouts aren't addressed. They are reasonably > common in m-c (admitt

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

2016-06-22 Thread Manish Goregaokar
become less of a pain, while actual changes affecting both will still be tested. The reverse can also exist, as a checkbox in the trychooser interface. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

2016-06-22 Thread Manish Goregaokar
icts. > You make it sound like refactorings don't introduce bugs. ;) > Sure they can, but they should be less likely to :) We will still have the full CI run on a sync so these will get caught, just not immediately. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

2016-06-22 Thread Manish Goregaokar
Coordinating rollups across two repos will be a pain. The proposed automation sounds better to me. -Manish Goregaokar On Thu, Jun 23, 2016 at 10:08 AM, Michael Howell wrote: > If the model you're proposing is "almost isomorphic" to roll ups, then why > not just use roll up

Re: [dev-servo] Standardizing upgrade procedures for crates.io dependencies for servo/servo

2016-06-23 Thread Manish Goregaokar
We rarely use ranges, just a minimum version, and aside from major version differences cargo just picks the max. dev-servo@lists.mozilla.org wrote: > Is there a risk that non-overlapping version ranges in dependent Cargo.toml > files will cause multiple versions of the package to be imported? Or

Re: [dev-servo] Standardizing upgrade procedures for crates.io dependencies for servo/servo

2016-06-23 Thread Manish Goregaokar
resumably we want to crawl >> the Cargo.toml files in that case? And again, will it be obvious that needs >> to happen from the Cargo.lock diff? >> >> On Thu, Jun 23, 2016 at 9:32 AM, Manish Goregaokar >> wrote: >>> We rarely use ranges, just a minimum version,

  1   2   >