Re: [dev-servo] CSS parser architecture: data structures vs. callbacks

2013-02-12 Thread Nicholas Nethercote
On Mon, Feb 11, 2013 at 10:37 PM, Robert O'Callahan wrote: > > Couldn't you just make it a pointer into the text of the style sheet? Then > an auxiliary data structure could be used to quickly extract a line number > given such a pointer. (E.g. for each 256 byte boundary in the style sheet, > stor

Re: [dev-servo] Minutes of the discussion regarding strings

2013-06-07 Thread Nicholas Nethercote
On Thu, Jun 6, 2013 at 11:09 AM, Robert O'Callahan wrote: > Immutable strings sound good to me. > > How hard would it be to add UTF-8 strings to Spidermonkey? JSString already > has a lot of "modes", perhaps one more wouldn't hurt :-). I'm imagining > that for anything that required UTF-16 (charAt

Re: [dev-servo] Unanswered questions from a Q&A about Servo

2013-07-12 Thread Nicholas Nethercote
> The pwn2own and Pwnium results demonstrate, at least to me, that memory > safety is still valuable even in the presence of intricate sandboxing. We > need defense in depth, and Rust's type system provides a strong layer of > defense for new code. Yeah. IMO, memory safety is a BFD. Nick ___

Re: [dev-servo] Rust and Servo internships with the GNOME Outreach Program for Women

2013-10-20 Thread Nicholas Nethercote
On Sat, Oct 19, 2013 at 8:14 AM, Brian Anderson wrote: > > This year, the Rust and Servo projects are participating in the GNOME > Outreach Program for Women (OPW). Nice to hear. Nick ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists

Re: [dev-servo] meeting notes (UTF8)

2014-07-07 Thread Nicholas Nethercote
On Mon, Jul 7, 2014 at 7:51 PM, Cameron Zwarich wrote: > Are UTF8-backed (as opposed to Latin1-backed) JS strings with random access > going to be a real possibility in SpiderMonkey? It’s obviously possible to > make random access work with an appropriate indexing data structure, but > popular

Re: [dev-servo] Meeting notes (Q3)

2014-07-07 Thread Nicholas Nethercote
On Mon, Jul 7, 2014 at 8:03 PM, Robert O'Callahan wrote: > > If you want to brainstom about getting to absurdly low memory targets like > 32MB, I suggest talking to Nick Nethercote. This is where he lives. I've already been asked about whether SpiderMonkey could be made to work in that context. M

[dev-servo] Servo memory usage

2014-07-10 Thread Nicholas Nethercote
Hi, With https://github.com/mozilla/servo/pull/2803 applied, the -m option now gives some measurements from jemalloc. Here's example output after starting up and viewing about:mozilla on my Linux box. _category_ : _size (MiB)_ vsize : 1414.54 resident:88.50 hea

Re: [dev-servo] Servo memory usage

2014-07-10 Thread Nicholas Nethercote
On Thu, Jul 10, 2014 at 10:34 PM, Patrick Walton wrote: > > Historically, Rust's large stacks were due to the fact that at the time > stack growth was removed, rustc had worse codegen than it did today, > resulting in frames with very large activation records. Coupled with the > fact that rustc it

Re: [dev-servo] Servo memory usage

2014-07-10 Thread Nicholas Nethercote
On Thu, Jul 10, 2014 at 10:34 PM, Patrick Walton wrote: >> >> Does Rust have any stack-measuring capabilities? > > It doesn't; let's definitely file a Rust issue on that. I filed https://github.com/rust-lang/rust/issues/15600. I have no idea how it would be implemented. Nick

Re: [dev-servo] WTF-8 encoding for DOM strings and HTML parsing

2014-10-09 Thread Nicholas Nethercote
On Thu, Oct 9, 2014 at 9:21 PM, Henri Sivonen wrote: > On Wed, Oct 8, 2014 at 4:13 PM, Jan de Mooij wrote: > > Has SpiderMonkey ever been instrumented to find out if most strings > are even just ASCII? There are some measurements in https://blog.mozilla.org/javascript/2014/07/21/slimmer-and-fast

Re: [dev-servo] November 2014 work week minutes

2014-11-11 Thread Nicholas Nethercote
On Tue, Nov 11, 2014 at 8:47 AM, Josh Matthews wrote: > > - arewefastyet/areweslimyet style recording/display of servo data over time > (mbrubeck) Relatedly: I still hope to work on about:memory-style measurements for Servo. It'll hopefully end up on my Q1 goal list. Let me know if it's not still

Re: [dev-servo] Servo memory usage

2015-02-04 Thread Nicholas Nethercote
this happens by looking at the output of strace. It's also something I should have known since it came up in Firefox in bug 827691. Nick On Fri, Jul 11, 2014 at 12:04 PM, Brian Anderson wrote: > > On 07/10/2014 11:11 PM, Nicholas Nethercote wrote: >> >> On Thu, Jul 10, 2014

Re: [dev-servo] Question about regex crate in util

2015-02-26 Thread Nicholas Nethercote
On Fri, Feb 27, 2015 at 12:21 PM, Gilles Leblanc wrote: > Hello, I have a question. > > The crate components/util uses regular expressions. In it's lib.rs file it > has the following statements: > > #[cfg(target_os="linux")] > extern crate regex; > > Why is the extern crate regex only used under L

[dev-servo] Draft blog post about memory measurement

2015-05-31 Thread Nicholas Nethercote
Hi there, I've written a draft of a blog post about memory profiling in Firefox vs. Servo, which focuses on the Rust features that make the task more pleasant in Servo. There's a draft copy here: http://njn.valgrind.org/measuring.html I'd appreciate any feedback you all might have, esp. if I've g

Re: [dev-servo] Draft blog post about memory measurement

2015-06-01 Thread Nicholas Nethercote
WordPress gunk and to make it clear that it's a draft. Full details here: https://news.ycombinator.com/item?id=9642833. I'll post the final version on my real blog in the next day or two. Nick On Sun, May 31, 2015 at 8:39 PM, Nicholas Nethercote wrote: > Hi there, > > I'

Re: [dev-servo] Draft blog post about memory measurement

2015-06-01 Thread Nicholas Nethercote
On Mon, Jun 1, 2015 at 8:46 AM, Andrew McCreight wrote: > > This is probably too esoteric for the blog post, but it seems like the > malloc_size_of thing isn't passed in for the Rust version. (For those who > don't know, in Firefox, this is used for the Dark Matter Detector (DMD): a > method can b

Re: [dev-servo] Draft blog post about memory measurement

2015-06-01 Thread Nicholas Nethercote
On Mon, Jun 1, 2015 at 8:59 AM, Jack Moffitt wrote: > > One question I still had at the end was whether things like Arc > (non-owning references) are accounted for somewhere? If there's a clear owner, then it makes sense to measure the struct from there. Otherwise, we'll have to do some kind of "

Re: [dev-servo] Draft blog post about memory measurement

2015-06-01 Thread Nicholas Nethercote
On Mon, Jun 1, 2015 at 4:07 PM, Azita Rashed wrote: > This is very nice. One small note in the beginning of your post, you called > Servo an experimental browser engine. We should take out the word > experimental and just call it a new or next generation browser engine. The > project isn’t i

[dev-servo] Best way to work on multiple branches concurrently?

2015-06-10 Thread Nicholas Nethercote
Hi, I often like to work on multiple branches concurrently, to work around the fact that Servo builds are slow. The obvious way to do this is to just have multiple clones. That's what I do with Firefox (using Mercurial). I've read that git 2.5 will have a `git checkout --to=path` command which wi

Re: [dev-servo] Multiprocess safety

2015-06-18 Thread Nicholas Nethercote
The memory profiler relies heavily on passing channels over channels. The memory profiler makes measurement requests of threads and passes them a channel through which they can return the measurements. One example from paint_task.rs: impl Reporter for PaintChan { // Just injects an appropriat

Re: [dev-servo] Multiprocess safety

2015-06-18 Thread Nicholas Nethercote
On Thu, Jun 18, 2015 at 5:45 PM, Patrick Walton wrote: > It's fine to pass channels over channels as long as those channels don't > cross process boundaries. In that case, the paint task lives in the chrome > process (since it has access to the GPU), so you're fine. The problematic > cases are ess

Re: [dev-servo] The rules of @bors-servo: retry

2015-08-03 Thread Nicholas Nethercote
On Tue, Aug 4, 2015 at 9:14 AM, James Graham wrote: > > 2) Start posting the results of test runs to treeherder, which will surface > the failures in a clearer way than the buildbot waterfall and will hopefully > in the near future get a measure of auto-matching test results against known > interm

Re: [dev-servo] PSA: import blocks are now sorted

2015-08-20 Thread Nicholas Nethercote
On Thu, Aug 20, 2015 at 7:54 AM, Ms2ger wrote: > > Consecutive lines of imports are now sorted, thanks to Johann Tuffe. > test-tidy will complain about any violations. You're talking about `use` items, right? It looks like they're sorted within each group, but you can still have separate groups.

Re: [dev-servo] PSA: import blocks are now sorted

2015-08-24 Thread Nicholas Nethercote
On Fri, Aug 21, 2015 at 4:40 AM, Ms2ger wrote: >> >> You're talking about `use` items, right? It looks like they're >> sorted within each group, but you can still have separate groups. >> (Where the boundary between a group is a blank line.) Is that >> right? > > That's correct. Unfortunately the

Re: [dev-servo] PSA: Review delegation enabled for homu

2015-11-11 Thread Nicholas Nethercote
On Wed, Nov 11, 2015 at 6:31 PM, Bobby Holley wrote: > > From a project standpoint, I am trying to blaze the trail of the > committer-but-not-reviewer role IME having to re-get r+ every time you have a trivial merge conflict or minor CI failure (e.g. a "tidy" failure due to trailing whitespace) i

Re: [dev-servo] Hello and intro!

2016-02-08 Thread Nicholas Nethercote
On Tue, Feb 9, 2016 at 2:20 AM, Simon Sapin wrote: Feel free to ask questions on this list or on the #servo IRC channel: > https://wiki.mozilla.org/IRC > I second that. The #rust channel is also really good. Both channels are full of friendly and helpful people. Don't be afraid to ask questions,

Re: [dev-servo] Weekly status updates

2016-09-22 Thread Nicholas Nethercote
I'm not a Servo person, but... I think hand-written updates are *much* better than auto-generated updates, because you can put interesting context and background into hand-written updates. (In my long experience at Mozilla I enjoy reading hand-written updates of various kinds, but auto-generated o

Re: [dev-servo] Incremental compilation and other compile time tricks

2017-04-05 Thread Nicholas Nethercote
`mach cargo check` is worth listing in Servo's README.md, IMO! Nick On Sat, Apr 1, 2017 at 4:43 AM, Simon Sapin wrote: > If you build Servo a lot you may have noticed that compilation times have > improved over the last few months. This is combination of multiple factors. > > > # Compiler optim

Re: [dev-servo] Pre-alpha of libservo available

2017-09-20 Thread Nicholas Nethercote
What is the backwards compatibility story? Are the APIs stable? I ask because, as I understand it, API instability has always been the problem with embedding Firefox. Nick On Thu, Sep 21, 2017 at 2:03 AM, Till Schneidereit < t...@tillschneidereit.net> wrote: > Hello friends of Servo! > > We're

[dev-servo] Memory reporting in Servo: the next step

2017-10-05 Thread Nicholas Nethercote
Hi, Currently we have two similar but distinct approaches to measuring memory usage in Servo. - Servo uses the heapsize and heapsize_derive crates, from crates.io. - Gecko uses the malloc_size_of and malloc_size_of_derive crates, which are in the tree. Because of this, you see this pattern qu

Re: [dev-servo] Memory reporting in Servo: the next step

2017-10-05 Thread Nicholas Nethercote
On Fri, Oct 6, 2017 at 2:33 PM, Xidorn Quan wrote: > > There are multiple Servo dependencies on crates.io depend on heapsize. > [1] How are they handled at the moment? And what would we do to them in > the future with the second option? > > [1] https://crates.io/crates/heapsize/reverse_dependenci

Re: [dev-servo] Memory reporting in Servo: the next step

2017-10-05 Thread Nicholas Nethercote
On Fri, Oct 6, 2017 at 4:07 PM, Manish Goregaokar wrote: > I kinda feel like upgrading HeapSizeOf to have a generic second trait-bound > argument that we substitute MallocSizeOfOps as would be good. What problem would that solve? I don't want to add unnecessary abstraction. Nick

Re: [dev-servo] Memory reporting in Servo: the next step

2017-10-05 Thread Nicholas Nethercote
On Fri, Oct 6, 2017 at 4:15 PM, Manish Goregaokar wrote: > If we do impls in the mallocsizeof crate is we can't make use of the custom > derive functionality and have to manually write out impls (which in many > cases won't be possible). Not being able to use derive doesn't worry me, because it

Re: [dev-servo] Memory reporting in Servo: the next step

2017-10-06 Thread Nicholas Nethercote
et shortest paths and dominators[2] for free. > > Interested in your thoughts on the subject! > > Cheers, > > Nick > > [0] http://searchfox.org/mozilla-central/source/js/public/UbiNode.h#32-164 > [1] http://www.cs.utexas.edu/ftp/techreports/tr06-07.pdf > [2] https://github