Re: [JS-internals] Clang-format

2016-05-13 Thread Ehsan Akhgari
On 2016-05-13 8:01 AM, Anthony Ramine wrote: > On Friday, May 13, 2016 at 2:04:25 AM UTC+2, Ehsan Akhgari wrote: >> The current reality how web browsers are made don't afford us treating >> our codebase in that way any more. To me, discussions around unifying >> the coding style drill into the

Re: [JS-internals] Clang-format

2016-05-13 Thread Nicholas Nethercote
If we do an auto-reformat I strongly recommend doing it in small chunks. Start with a few files at a time, to minimize risk. On Fri, May 13, 2016 at 7:21 PM, Shu-yu Guo wrote: > First, Bill, I'm flattered by your mention, thank you. > > I am in favor of unifying styles with

Re: [JS-internals] Clang-format

2016-05-13 Thread Anthony Ramine
On Friday, May 13, 2016 at 2:04:25 AM UTC+2, Ehsan Akhgari wrote: > The current reality how web browsers are made don't afford us treating > our codebase in that way any more. To me, discussions around unifying > the coding style drill into the heart of this problem: we need to move > on from

Re: [JS-internals] Clang-format

2016-05-13 Thread Shu-yu Guo
First, Bill, I'm flattered by your mention, thank you. I am in favor of unifying styles with Gecko, though I have a practical concern. I am currently in the middle of a frontend rewrite that is an unwieldy amount of changes. Could I request the re-style to be put off for a month or three until