[GitHub] accumulo pull request #291: ACCUMULO-4693: Add instance-specific ProcessName...

2017-08-11 Thread billoley
Github user billoley commented on a diff in the pull request: https://github.com/apache/accumulo/pull/291#discussion_r132674184 --- Diff: server/base/src/main/java/org/apache/accumulo/server/metrics/MetricsSystemHelper.java --- @@ -16,20 +16,65 @@ */ package

[GitHub] accumulo pull request #291: ACCUMULO-4693: Add instance-specific ProcessName...

2017-08-11 Thread billoley
Github user billoley commented on a diff in the pull request: https://github.com/apache/accumulo/pull/291#discussion_r132674190 --- Diff: server/base/src/main/java/org/apache/accumulo/server/metrics/MetricsSystemHelper.java --- @@ -16,20 +16,65 @@ */ package

[GitHub] accumulo pull request #291: ACCUMULO-4693: Add instance-specific ProcessName...

2017-08-11 Thread billoley
Github user billoley commented on a diff in the pull request: https://github.com/apache/accumulo/pull/291#discussion_r132674187 --- Diff: server/base/src/main/java/org/apache/accumulo/server/metrics/MetricsSystemHelper.java --- @@ -16,20 +16,65 @@ */ package

[GitHub] accumulo issue #290: ACCUMULO-4392: Expose metrics2 JVM metrics

2017-08-10 Thread billoley
Github user billoley commented on the issue: https://github.com/apache/accumulo/pull/290 FYI - used commit from ACCUMULO-4693 since the changes were the same. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] accumulo issue #291: ACCUMULO-4693: Add instance-specific ProcessName to Had...

2017-08-08 Thread billoley
Github user billoley commented on the issue: https://github.com/apache/accumulo/pull/291 @ctubbsii I don't need to rely on the -Dapp property because the same string is declared in main() of TabletServer, Master, etc and passed to various init methods. I can configure

[GitHub] accumulo pull request #290: ACCUMULO-4392: Expose metrics2 JVM metrics

2017-08-07 Thread billoley
GitHub user billoley opened a pull request: https://github.com/apache/accumulo/pull/290 ACCUMULO-4392: Expose metrics2 JVM metrics Create process name from system property -Dapp and instance from -Daccumulo.service.instance if applicable By passing the process name

[GitHub] accumulo pull request #291: ACCUMULO-4693: Add instance-specific ProcessName...

2017-08-07 Thread billoley
GitHub user billoley opened a pull request: https://github.com/apache/accumulo/pull/291 ACCUMULO-4693: Add instance-specific ProcessName to Hadoop2 metrics Create process name from system property -Dapp and instance from -Daccumulo.service.instance if applicable By adding

[GitHub] accumulo issue #291: ACCUMULO-4693: Add instance-specific ProcessName to Had...

2017-08-07 Thread billoley
Github user billoley commented on the issue: https://github.com/apache/accumulo/pull/291 I'd be happy to use something other than the system properties and am open to suggestions. The need for discovering the instance (1,2, etc) is that intermingling tserver metrics makes