Github user billoley commented on the issue:

    https://github.com/apache/accumulo/pull/291
  
    @ctubbsii
    
    I don't need to rely on the -Dapp property because the same string is
    declared in main() of TabletServer, Master, etc and passed to various init
    methods.  I can configure the MetricsSystemHelper from the same entry point.
    
    For the tablet server instance, I could cycle through the system properties
    and use the first one that includes the word "instance" defaulting to empty
    string.  This would decouple the code from a specific property while still
    allowing users to specify an instance to deconflict metrics.  Is this a
    better solution?
    
    
    
    
    
    
    Bill Oley
    
    On Mon, Aug 7, 2017 at 6:08 PM, Christopher Tubbs <notificati...@github.com>
    wrote:
    
    > @billoley <https://github.com/billoley> What about just including all
    > system properties, so it still supports this use case, but the code isn't
    > tied to a specific launch script implementation? Is it possible to pick 
out
    > just the specific system-property-turned-metric by the metrics consumer?
    >
    > The other thing I was thinking is that maybe we could tie it to a one-up
    > number from the ZooKeeper lock.
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/accumulo/pull/291#issuecomment-320794375>, or 
mute
    > the thread
    > 
<https://github.com/notifications/unsubscribe-auth/AFVhw1fclLHN2b0AJsnzqu4jccwPjJJYks5sV4rkgaJpZM4Ovy7u>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to