[GitHub] activemq-artemis pull request #1346: ARTEMIS-1211 - Allow local transactions...

2017-06-19 Thread andytaylor
GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/1346 ARTEMIS-1211 - Allow local transactions when no jta in Resource Adapter https://issues.apache.org/jira/browse/ARTEMIS-1211 You can merge this pull request into a Git repository by runn

[GitHub] activemq-artemis pull request #1347: ARTEMIS-1221 Duplicated ID causes Large...

2017-06-19 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/1347 ARTEMIS-1221 Duplicated ID causes LargeMessage lost at backup When a large message is replicated to backup, a pendingID is generated when the large message is finished. This pendingI

[GitHub] activemq-artemis issue #1337: ARTEMIS-1205: AMQP Shared Durable Subscriber i...

2017-06-19 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1337 @michaelandrepearce Thanks Michael. I'll do another full suite run here. Once it passes I will merge. Thanks again for the great work. --- If your project is set up for it, you can rep

[GitHub] activemq-artemis pull request #1342: NO-JIRA fix typos in documentation

2017-06-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1342 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis pull request #1339: ARTEMIS-1211 - Allow local transactions...

2017-06-19 Thread andytaylor
Github user andytaylor closed the pull request at: https://github.com/apache/activemq-artemis/pull/1339 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #1346: ARTEMIS-1211 - Allow local transactions...

2017-06-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1346 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis pull request #1344: ARTEMIS-1233 Fix log level in logger me...

2017-06-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1344 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis pull request #1343: ARTEMIS-1233 Fix log level in logger me...

2017-06-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1343 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis pull request #1348: ARTEMIS-1237 - Hard coded timeout on Jo...

2017-06-19 Thread andytaylor
GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/1348 ARTEMIS-1237 - Hard coded timeout on Journal file open Make timeout configurable https://issues.apache.org/jira/browse/ARTEMIS-1237 You can merge this pull request into a Git

[GitHub] activemq-artemis issue #1345: ARTEMIS-1235 Support queue and address deletio...

2017-06-19 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1345 @michaelandrepearce Sure. I get the configuration management tool use case. Two comments: 1. Does it make sense to enable this at the address-settings level vs just a global w

[GitHub] activemq-artemis pull request #1337: ARTEMIS-1205: AMQP Shared Durable Subsc...

2017-06-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1337 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis issue #1345: ARTEMIS-1235 Support queue and address deletio...

2017-06-19 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1345 @mtaylor 1) this was first approach i did actually, but on thought, it might be that you have a subset you maybe not want to manage this way (e.g. some reason some sub sect

[GitHub] activemq-artemis issue #1345: ARTEMIS-1235 Support queue and address deletio...

2017-06-19 Thread andytaylor
Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1345 The issue that needs solving is the fact we have this queues that exist in both the bindings journal and the config and some that are only in the journal and we never automatically remo

[GitHub] activemq-artemis issue #1345: ARTEMIS-1235 Support queue and address deletio...

2017-06-19 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1345 @andytaylor re: > My opinion removing queues should never be done automatically even if that is a configured flag. We actually would want to automati

[GitHub] activemq-artemis issue #1345: ARTEMIS-1235 Support queue and address deletio...

2017-06-19 Thread andytaylor
Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1345 I can only reiterate that removing queues that have messages in my view is a bad thing and we shouldn't allow it. At least not without any thought as to what we should do with the messa

[GitHub] activemq-artemis issue #1345: ARTEMIS-1235 Support queue and address deletio...

2017-06-19 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1345 @andytaylor > I can only reiterate that removing queues that have messages in my view is a bad thing and we shouldn't allow it. At least not without any thought as to w

[GitHub] activemq-artemis issue #1345: ARTEMIS-1235 Support queue and address deletio...

2017-06-19 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1345 Having this policy driven seems to be the way to satisfy both requirements. It also still makes sense if we do go down the route of storing queues/addresses in config only (although as @m

[GitHub] activemq-artemis issue #1345: ARTEMIS-1235 Support queue and address deletio...

2017-06-19 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1345 @mtaylor makes sense. Have update this PR with suggested OFF, FORCE options on the address-settings. Updated also config-reload.md to document the feature, indicating th

[GitHub] activemq-artemis pull request #1349: ARTEMIS-1205: AMQP Shared Durable Subsc...

2017-06-19 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/1349 ARTEMIS-1205: AMQP Shared Durable Subscriber - Document Update Update documents for new configuration toggle for 'amqp-use-core-subscription-naming ' You can merge this pull r

[GitHub] activemq-artemis pull request #1348: ARTEMIS-1237 - Hard coded timeout on Jo...

2017-06-19 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1348#discussion_r122838823 --- Diff: artemis-server/src/main/resources/schema/artemis-configuration.xsd --- @@ -688,6 +688,15 @@

[GitHub] activemq-artemis pull request #1350: ARTEMIS-1240 Disconnect at client side ...

2017-06-19 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/1350 ARTEMIS-1240 Disconnect at client side on decoding error When a broken packet arrives at client side it causes decoding error. Currently artemis doesn't handle it properly. It should