[GitHub] sullis commented on issue #1: projects using ActiveMQ: jms-testkit

sullis commented on issue #1: projects using ActiveMQ: jms-testkit URL: https://github.com/apache/activemq-website/pull/1#issuecomment-450760661 @michaelandrepearce This is an automated message from the Apache Git Service.

[GitHub] sullis opened a new pull request #1: projects using ActiveMQ: jms-testkit

sullis opened a new pull request #1: projects using ActiveMQ: jms-testkit URL: https://github.com/apache/activemq-website/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] michaelandrepearce commented on issue #1: projects using ActiveMQ: jms-testkit

michaelandrepearce commented on issue #1: projects using ActiveMQ: jms-testkit URL: https://github.com/apache/activemq-website/pull/1#issuecomment-451625251 Im on leave currently. Just quickly is this using the newer broker thats jms 2.0 compatible - activemq artemis? Or the

[GitHub] gaohoward opened a new pull request #2500: NO-JIRA Adding test to verify Openwire consuming from FQQN

gaohoward opened a new pull request #2500: NO-JIRA Adding test to verify Openwire consuming from FQQN URL: https://github.com/apache/activemq-artemis/pull/2500 The test verifies that a Openwire queue consumer can consume from pre-configured multicast queues using FQQN.

[GitHub] qihongxu commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

qihongxu commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454780254 @franz1981 > 1. the tps are dependent by the most demanding operation in the CPU flamegraph you've posted >ie

[GitHub] qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454780254 @franz1981 > 1. the tps are dependent by the most demanding operation in the CPU flamegraph you've posted >

[GitHub] qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454780254 @franz1981 > 1. the tps are dependent by the most demanding operation in the CPU flamegraph you've posted >

[GitHub] qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454780254 @franz1981 > 1. the tps are dependent by the most demanding operation in the CPU flamegraph you've posted >

[GitHub] qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454780254 @franz1981 > 1. the tps are dependent by the most demanding operation in the CPU flamegraph you've posted >

[GitHub] qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454780254 @franz1981 > 1. the tps are dependent by the most demanding operation in the CPU flamegraph you've posted >

[GitHub] franz1981 commented on issue #2479: ARTEMIS-2211 Avoid duplicate code for ByteBuffer pooling and alignment

franz1981 commented on issue #2479: ARTEMIS-2211 Avoid duplicate code for ByteBuffer pooling and alignment URL: https://github.com/apache/activemq-artemis/pull/2479#issuecomment-454343022 @clebertsuconic Please wait to merge this: probably I will change the thread-local pool with

[GitHub] gaohoward opened a new pull request #2499: ARTEMIS-2229 Qpid jms consumer cannot receive from multicast queue using FQQN

gaohoward opened a new pull request #2499: ARTEMIS-2229 Qpid jms consumer cannot receive from multicast queue using FQQN URL: https://github.com/apache/activemq-artemis/pull/2499 If a client sends a message to a multicast address and using a qpid-jms client to receive the message

[GitHub] franz1981 edited a comment on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks

franz1981 edited a comment on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks URL: https://github.com/apache/activemq-artemis/pull/2250#issuecomment-454285382 @CNNJYB in this case it is wanted: compaction was leaking buffers big as the

[GitHub] michaelandrepearce commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management

michaelandrepearce commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management URL: https://github.com/apache/activemq-artemis/pull/2498#discussion_r247864160 ## File path:

[GitHub] clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454811544 one test failure at least: JMSMessageGroupsTest The testsuite didn't complete.. but that one is failing for sure.

[GitHub] michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454854944 @clebertsuconic ok so i know whats going on, another feature i have implemented for 2.7.0 reset of message groups,

[GitHub] michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454874083 Sorted locally just extracting repeatble iterator logic as franz is keen on this

[GitHub] michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454854944 @clebertsuconic ok so i know whats going on, another feature i have implemented for 2.7.0 reset of message groups,

[GitHub] michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454854944 @clebertsuconic ok so i know whats going on, another feature i have implemented for 2.7.0 reset of message groups,

[GitHub] michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454842100 Ill have a look This is an automated message from the

[GitHub] michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454842100 Ill have a look, i know that one was working as i had run those and exlusive test when i first pr'd i assume i broke

[GitHub] michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454854944 @clebertsuconic ok so i know whats going on, another feature i have implemented for 2.7.0 reset of message groups, the test

[GitHub] franz1981 commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

franz1981 commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454895122 @qihongxu thanks! I need to put a couple do logs to check how is th behaviour with several consumers and check if live

[GitHub] franz1981 edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

franz1981 edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454895122 @qihongxu thanks! I need to put a couple of logs on the code to check how is the behaviour with several consumers

[GitHub] asfgit closed pull request #2496: ENTMQBR-2178 add Implementation-Version for bundle packaging

asfgit closed pull request #2496: ENTMQBR-2178 add Implementation-Version for bundle packaging URL: https://github.com/apache/activemq-artemis/pull/2496 This is an automated message from the Apache Git Service. To respond

[GitHub] clebertsuconic commented on issue #2482: ARTEMIS-2214 Cache durable in PagedReference

clebertsuconic commented on issue #2482: ARTEMIS-2214 Cache durable in PagedReference URL: https://github.com/apache/activemq-artemis/pull/2482#issuecomment-454946530 ...merging This is an automated message from the Apache

[GitHub] asfgit closed pull request #2482: ARTEMIS-2214 Cache durable in PagedReference

asfgit closed pull request #2482: ARTEMIS-2214 Cache durable in PagedReference URL: https://github.com/apache/activemq-artemis/pull/2482 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454952955 @clebertsuconic sorted, just added ability in consumers to repeat (new repeatable iterator), and then if group, we

[GitHub] michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454952955 @clebertsuconic sorted, just added ability in QueueConsumers to repeat (new repeatable iterator), and then if

[GitHub] clebertsuconic commented on a change in pull request #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging

clebertsuconic commented on a change in pull request #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging URL: https://github.com/apache/activemq-artemis/pull/2459#discussion_r248745062 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging

clebertsuconic commented on a change in pull request #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging URL: https://github.com/apache/activemq-artemis/pull/2459#discussion_r248745062 ## File path:

[GitHub] onlyMIT commented on issue #2466: ARTEMIS-2206 The MQTT consumer reconnection caused the queue to not be cle…

onlyMIT commented on issue #2466: ARTEMIS-2206 The MQTT consumer reconnection caused the queue to not be cle… URL: https://github.com/apache/activemq-artemis/pull/2466#issuecomment-455244484 @michaelandrepearce @jbertram I think my RP failures in

[GitHub] franz1981 commented on a change in pull request #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

franz1981 commented on a change in pull request #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#discussion_r248691840 ## File path:

[GitHub] clebertsuconic commented on issue #2451: ARTEMIS-2192 LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types

clebertsuconic commented on issue #2451: ARTEMIS-2192 LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types URL: https://github.com/apache/activemq-artemis/pull/2451#issuecomment-455247312 @franz1981 you aprooved the changes.. you could just have merged it :)

[GitHub] onlyMIT edited a comment on issue #2466: ARTEMIS-2206 The MQTT consumer reconnection caused the queue to not be cle…

onlyMIT edited a comment on issue #2466: ARTEMIS-2206 The MQTT consumer reconnection caused the queue to not be cle… URL: https://github.com/apache/activemq-artemis/pull/2466#issuecomment-453845902 @jbertram I have a question to consult you and hope you can answer it. 1. Why is there

[GitHub] qihongxu commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

qihongxu commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-455086939 @franz1981 Here's the result of single and 400 consumers. With these settings applied: max-size-bytes = 950MB,

[GitHub] clebertsuconic commented on issue #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging

clebertsuconic commented on issue #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging URL: https://github.com/apache/activemq-artemis/pull/2459#issuecomment-455320839 The real issue was. JournalImpl was refactored a few years ago to use an executor on IO. the call to

[GitHub] asfgit closed pull request #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging

asfgit closed pull request #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging URL: https://github.com/apache/activemq-artemis/pull/2459 This is an automated message from the Apache Git Service. To

[GitHub] michaelandrepearce commented on issue #2434: ARTEMIS-1867 FQQN for producers

michaelandrepearce commented on issue #2434: ARTEMIS-1867 FQQN for producers URL: https://github.com/apache/activemq-artemis/pull/2434#issuecomment-455354819 @jbertram just went to go merge this but seems theres a conflict (our bad for not merging sooner), could you quickly rebase?

[GitHub] clebertsuconic commented on issue #2451: ARTEMIS-2192 LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types

clebertsuconic commented on issue #2451: ARTEMIS-2192 LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types URL: https://github.com/apache/activemq-artemis/pull/2451#issuecomment-455361649 @jbertram this is out of my expertise. Is this ready? only thing I have to say is the nit-pik

[GitHub] asfgit closed pull request #2469: ARTEMIS-2221 avoid unnecessary Bindings instance creation

asfgit closed pull request #2469: ARTEMIS-2221 avoid unnecessary Bindings instance creation URL: https://github.com/apache/activemq-artemis/pull/2469 This is an automated message from the Apache Git Service. To respond to

[GitHub] clebertsuconic commented on a change in pull request #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

clebertsuconic commented on a change in pull request #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#discussion_r248872930 ## File path:

[GitHub] franz1981 commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

franz1981 commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-455379962 @michaelandrepearce I have checked that is not less optimized because the

[GitHub] michaelandrepearce opened a new pull request #2502: NO-JIRA Fix String and SimpleString equals check

michaelandrepearce opened a new pull request #2502: NO-JIRA Fix String and SimpleString equals check URL: https://github.com/apache/activemq-artemis/pull/2502 This is an automated message from the Apache Git Service. To

[GitHub] michaelandrepearce commented on issue #2469: ARTEMIS-2221 avoid unnecessary Bindings instance creation

michaelandrepearce commented on issue #2469: ARTEMIS-2221 avoid unnecessary Bindings instance creation URL: https://github.com/apache/activemq-artemis/pull/2469#issuecomment-455356062 @jbertram could you rebase, after merging another of your pr's

[GitHub] asfgit closed pull request #2446: ARTEMIS-2188 fix address size leak caused by large page message

asfgit closed pull request #2446: ARTEMIS-2188 fix address size leak caused by large page message URL: https://github.com/apache/activemq-artemis/pull/2446 This is an automated message from the Apache Git Service. To

[GitHub] michaelandrepearce commented on issue #2469: ARTEMIS-2221 avoid unnecessary Bindings instance creation

michaelandrepearce commented on issue #2469: ARTEMIS-2221 avoid unnecessary Bindings instance creation URL: https://github.com/apache/activemq-artemis/pull/2469#issuecomment-455362104 @jbertram dont worry managed to sort the conflict on merge.

[GitHub] michaelandrepearce edited a comment on issue #2469: ARTEMIS-2221 avoid unnecessary Bindings instance creation

michaelandrepearce edited a comment on issue #2469: ARTEMIS-2221 avoid unnecessary Bindings instance creation URL: https://github.com/apache/activemq-artemis/pull/2469#issuecomment-455362104 @jbertram dont worry managed to sort the conflict on merge. Thanks for this as always

[GitHub] asfgit closed pull request #2445: ARTEMIS-2187 remove page from softcache before consumedpage

asfgit closed pull request #2445: ARTEMIS-2187 remove page from softcache before consumedpage URL: https://github.com/apache/activemq-artemis/pull/2445 This is an automated message from the Apache Git Service. To respond to

[GitHub] clebertsuconic commented on issue #2391: Add page decoding test for large message …

clebertsuconic commented on issue #2391: Add page decoding test for large message … URL: https://github.com/apache/activemq-artemis/pull/2391#issuecomment-455369545 you're cherry-picking from a commit, and I don't know where that commit is coming from. master should be the root for

[GitHub] michaelandrepearce opened a new pull request #2501: ARTEMIS-2221 Fix Merge

michaelandrepearce opened a new pull request #2501: ARTEMIS-2221 Fix Merge URL: https://github.com/apache/activemq-artemis/pull/2501 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] asfgit merged pull request #2502: NO-JIRA Fix String and SimpleString equals check

asfgit merged pull request #2502: NO-JIRA Fix String and SimpleString equals check URL: https://github.com/apache/activemq-artemis/pull/2502 This is an automated message from the Apache Git Service. To respond to the

[GitHub] michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455592219 @clebertsuconic ive found the pesky thing, in ServerSessionImpl where i had added a new parameter to the createConsumer

[GitHub] michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455507116 @clebertsuconic so as noted, the message groups ones is sorted, repeat needs to occur only if groupconsumer exist.

[GitHub] asfgit closed pull request #2444: ARTEMIS-2186 Large message incomplete when server is crashed

asfgit closed pull request #2444: ARTEMIS-2186 Large message incomplete when server is crashed URL: https://github.com/apache/activemq-artemis/pull/2444 This is an automated message from the Apache Git Service. To respond

[GitHub] michaelandrepearce edited a comment on issue #2509: NO-JIRA Fix Possible NPE in connectToNodeInReplicatedCluster

michaelandrepearce edited a comment on issue #2509: NO-JIRA Fix Possible NPE in connectToNodeInReplicatedCluster URL: https://github.com/apache/activemq-artemis/pull/2509#issuecomment-455719841 This showed up in static analysis, technically because of the try catch(exception) , this would

[GitHub] michaelandrepearce commented on issue #2509: NO-JIRA Fix Possible NPE in connectToNodeInReplicatedCluster

michaelandrepearce commented on issue #2509: NO-JIRA Fix Possible NPE in connectToNodeInReplicatedCluster URL: https://github.com/apache/activemq-artemis/pull/2509#issuecomment-455719841 This showed up in static analysis, technically because of the try catch(exception) , this would be

[GitHub] michaelandrepearce opened a new pull request #2508: NO-JIRA fix writableBuffer so that its only visible after sub statements

michaelandrepearce opened a new pull request #2508: NO-JIRA fix writableBuffer so that its only visible after sub statements URL: https://github.com/apache/activemq-artemis/pull/2508 Potential race condition. This assignment to writableBuffer is visible to other threads before the

[GitHub] asfgit merged pull request #2508: NO-JIRA fix writableBuffer so that its only visible after sub statements

asfgit merged pull request #2508: NO-JIRA fix writableBuffer so that its only visible after sub statements URL: https://github.com/apache/activemq-artemis/pull/2508 This is an automated message from the Apache Git Service.

[GitHub] michaelandrepearce opened a new pull request #2509: NO-JIRA Fix Possible NPE in possibleLive.getA()

michaelandrepearce opened a new pull request #2509: NO-JIRA Fix Possible NPE in possibleLive.getA() URL: https://github.com/apache/activemq-artemis/pull/2509 Variable possibleLive may be null, as signified by trace log above, also dedupe code.

[GitHub] ldebello opened a new pull request #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering

ldebello opened a new pull request #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering URL: https://github.com/apache/activemq-artemis/pull/2510 I am sending this PR to fix the issue https://issues.apache.org/jira/browse/ARTEMIS-2156. I have created

[GitHub] michaelandrepearce edited a comment on issue #2498: ARTEMIS-2228 Large Messages over Management

michaelandrepearce edited a comment on issue #2498: ARTEMIS-2228 Large Messages over Management URL: https://github.com/apache/activemq-artemis/pull/2498#issuecomment-454450983 Just fyi, Re your failed pr build since some recent merges to master ive been getting more intermittent build

[GitHub] clebertsuconic commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management

clebertsuconic commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management URL: https://github.com/apache/activemq-artemis/pull/2498#discussion_r247954437 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management

clebertsuconic commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management URL: https://github.com/apache/activemq-artemis/pull/2498#discussion_r247954437 ## File path:

[GitHub] asfgit closed pull request #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

asfgit closed pull request #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@activemq.apache.org

[GitHub] clebertsuconic commented on issue #2497: ARTEMIS-2228 Check message size sent over management API

clebertsuconic commented on issue #2497: ARTEMIS-2228 Check message size sent over management API URL: https://github.com/apache/activemq-artemis/pull/2497#issuecomment-454073161 I agree with @michaelandrepearce here.. why not just convert it to large message. I think the

[GitHub] asfgit closed pull request #2484: ARTEMIS-2216 Use a specific executor for pageSyncTimer

asfgit closed pull request #2484: ARTEMIS-2216 Use a specific executor for pageSyncTimer URL: https://github.com/apache/activemq-artemis/pull/2484 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@activemq.apache.org

[GitHub] asfgit merged pull request #2498: ARTEMIS-2228 Large Messages over Management

asfgit merged pull request #2498: ARTEMIS-2228 Large Messages over Management URL: https://github.com/apache/activemq-artemis/pull/2498 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@activemq.apache.org

[GitHub] clebertsuconic commented on issue #2497: ARTEMIS-2228 Check message size sent over management API

clebertsuconic commented on issue #2497: ARTEMIS-2228 Check message size sent over management API URL: https://github.com/apache/activemq-artemis/pull/2497#issuecomment-454520641 Can you close this one please? This is an

[GitHub] michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454488334 @franz1981 good to go? This is an automated message from

[GitHub] asfgit closed pull request #2499: ARTEMIS-2229 Qpid jms consumer cannot receive from multicast queue using FQQN

asfgit closed pull request #2499: ARTEMIS-2229 Qpid jms consumer cannot receive from multicast queue using FQQN URL: https://github.com/apache/activemq-artemis/pull/2499 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list,

[GitHub] clebertsuconic commented on a change in pull request #2497: ARTEMIS-2228 Check message size sent over management API

clebertsuconic commented on a change in pull request #2497: ARTEMIS-2228 Check message size sent over management API URL: https://github.com/apache/activemq-artemis/pull/2497#discussion_r247625597 ## File path:

[GitHub] franz1981 commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

franz1981 commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454093850 @qihongxu Both the changes have been merged ie if you want to perform some tests to check if is working as expected

[GitHub] michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454180317 @franz1981 added the tests i owed you. Sorry took some time, had the weekend off.

[GitHub] clebertsuconic opened a new pull request #2498: ARTEMIS-2228 Large Messages over Management

clebertsuconic opened a new pull request #2498: ARTEMIS-2228 Large Messages over Management URL: https://github.com/apache/activemq-artemis/pull/2498 This is an automated message from the Apache Git Service. To respond to

[GitHub] clebertsuconic commented on issue #2497: ARTEMIS-2228 Check message size sent over management API

clebertsuconic commented on issue #2497: ARTEMIS-2228 Check message size sent over management API URL: https://github.com/apache/activemq-artemis/pull/2497#issuecomment-454188027 @gaohoward / @michaelandrepearce look into #2498 please? it's a lot simpler there.

[GitHub] clebertsuconic commented on issue #2497: ARTEMIS-2228 Check message size sent over management API

clebertsuconic commented on issue #2497: ARTEMIS-2228 Check message size sent over management API URL: https://github.com/apache/activemq-artemis/pull/2497#issuecomment-454173953 @gaohoward I pulled your branch and fixed it here.

[GitHub] asfgit closed pull request #2477: ARTEMIS-2190 move tests

asfgit closed pull request #2477: ARTEMIS-2190 move tests URL: https://github.com/apache/activemq-artemis/pull/2477 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@activemq.apache.org

[GitHub] clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454544429 Great work here! I'm running testsuite just to make sure everything is covered.

[GitHub] clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454575214 I tried pulling your branch, but the conflict that I thought I fixed caused a compilation error. do you mind rebasing

[GitHub] michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454585309 rebased This is an automated message from the Apache Git

[GitHub] michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement Consumer Priority

michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454585309 @clebertsuconic rebased This is an automated

[GitHub] qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454254479 > @qihongxu Both the changes have been merged ie if you want to perform some tests to check if is working as

[GitHub] qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454254479 > @qihongxu Both the changes have been merged ie if you want to perform some tests to check if is working as

[GitHub] gaohoward commented on issue #2497: ARTEMIS-2228 Check message size sent over management API

gaohoward commented on issue #2497: ARTEMIS-2228 Check message size sent over management API URL: https://github.com/apache/activemq-artemis/pull/2497#issuecomment-454248859 @michaelandrepearce @clebertsuconic OK thanks guys, I agree with you. I think #2498 is fine.

[GitHub] qihongxu commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

qihongxu commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454254479 > @qihongxu Both the changes have been merged ie if you want to perform some tests to check if is working as expected

[GitHub] CNNJYB commented on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks

CNNJYB commented on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks URL: https://github.com/apache/activemq-artemis/pull/2250#issuecomment-454247122 @franz1981 I mean that it's same with ARTEMIS-1996(SequentialFileFactory may cause

[GitHub] qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

qihongxu edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454254479 > @qihongxu Both the changes have been merged ie if you want to perform some tests to check if is working as

[GitHub] gaohoward closed pull request #2497: ARTEMIS-2228 Check message size sent over management API

gaohoward closed pull request #2497: ARTEMIS-2228 Check message size sent over management API URL: https://github.com/apache/activemq-artemis/pull/2497 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@activemq.apache.org

[GitHub] michaelandrepearce commented on issue #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging

michaelandrepearce commented on issue #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging URL: https://github.com/apache/activemq-artemis/pull/2459#issuecomment-454606274 Whats occuring on this one? This

[GitHub] michaelandrepearce edited a comment on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

michaelandrepearce edited a comment on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-454607131 Theres an outstanding item on this, Still need to find a way to

[GitHub] michaelandrepearce commented on a change in pull request #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

michaelandrepearce commented on a change in pull request #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#discussion_r248116612 ## File path:

[GitHub] michaelandrepearce edited a comment on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

michaelandrepearce edited a comment on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-454607131 Theres an outstanding item on this, Still need to find a way to

[GitHub] michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-454607131 Still need to find a way to optimise so we dont have to for loop round

[GitHub] michaelandrepearce commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management

michaelandrepearce commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management URL: https://github.com/apache/activemq-artemis/pull/2498#discussion_r247781204 ## File path:

[GitHub] franz1981 commented on a change in pull request #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering

franz1981 commented on a change in pull request #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering URL: https://github.com/apache/activemq-artemis/pull/2510#discussion_r249394900 ## File path:

[GitHub] franz1981 commented on a change in pull request #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering

franz1981 commented on a change in pull request #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering URL: https://github.com/apache/activemq-artemis/pull/2510#discussion_r249394900 ## File path:

[GitHub] franz1981 commented on a change in pull request #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering

franz1981 commented on a change in pull request #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering URL: https://github.com/apache/activemq-artemis/pull/2510#discussion_r249403776 ## File path:

[GitHub] ldebello commented on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering

ldebello commented on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering URL: https://github.com/apache/activemq-artemis/pull/2510#issuecomment-456013991 > Can you send the PR against master first? Done.

[GitHub] franz1981 commented on a change in pull request #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

franz1981 commented on a change in pull request #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#discussion_r249402511 ## File path:

  1   2   3   4   5   6   7   8   9   10   >