clebertsuconic commented on a change in pull request #2459: ARTEMIS-2200 NPE 
while dropping/failing large messages on paging
URL: https://github.com/apache/activemq-artemis/pull/2459#discussion_r248745062
 
 

 ##########
 File path: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/OpenWireLargeMessageTest.java
 ##########
 @@ -103,4 +122,47 @@ public void testSendReceiveLargeMessage() throws 
Exception {
          assertArrayEquals(body, bytes);
       }
    }
+
+   @Test
+   public void testFastLargeMessageProducerDropOnPaging() throws Exception {
 
 Review comment:
   Can you use this pattern on this test:
   ```java
   AssertionLoggerHandler.startCapture();
   try {
   ...... do your stuff....
   
   Assert.assertFalse(AssertionLoggerHandler.findText("NullPointerException"));
   Assert.assertFalse(AssertionLoggerHandler.findText("Cannot find record")); 
// or better, use the logger code
   
   } finally {
      AssertionLoggerHandler.stopCapture(); // it's important to stopCapture at 
the end, there's nothing else cleaning it, that would generate lots of 
collected loggers on the AssertionLoggerHandler.
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to