Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2175#discussion_r205158077
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/AtomicBooleanFieldUpdater.java
---
@@ -0,0 +1,154
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2175#discussion_r205195338
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/AtomicBooleanFieldUpdater.java
---
@@ -0,0 +1,154
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2199#discussion_r206064916
--- Diff:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/mapped/MappedSequentialFileFactory.java
---
@@ -20,10 +20,13
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2200#discussion_r206141050
--- Diff:
artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/Filterable.java
---
@@ -41,7 +43,7 @@
* @param
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2203
ARTEMIS-1999 Broker uses 100% core's CPU time if msg grouping is used
The deliver loop won't give up trying to deliver messages when
back-pressure kicks in (credits and/
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2203
@clebertsuconic Please take a look if the change seems to break any other
logic and @michaelandrepearce if exclusive consumers should be affected by a
similar issue (IMO it shouldn'
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2203
I have already run the entire test suite that is already filled of AMQP and
CORE JMS message group tests AFAIK.
About the performance implications (not anymore 100% CPU) I don't
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2203
> exclusive yes i think would have similar issue, after all it followed
the same logic of message groups in part. It would be easy to fix, as in the
same place / if statement j
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2203
@michaelandrepearce ahah fine!
> btw how you get a clean PR build ? without the damn
MultiThreadAsynchronousFileTest failing...like it has been for most PR's
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2203
@clebertsuconic Ok, let me try with the examples too...
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2206#discussion_r206849644
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
---
@@ -609,6 +612,7 @@ public
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2206
> Also, honestly I don't know that it's a great idea to start making this
change everywhere if it only works for a single thread because in the future if
someone refactors
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2211
@michaelandrepearce @clebertsuconic If it is including the changes of
https://github.com/apache/activemq-artemis/pull/2203 please consider to add the
test I have put there too (if it
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2199#discussion_r207702423
--- Diff:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/mapped/MappedSequentialFileFactory.java
---
@@ -20,10 +20,13
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2223
ARTEMIS-2015 PriorityLinkedListImpl::isEmpty is not thread-safe
PriorityLinkedListImpl::size access is changed to be safely
observable by a thread different from the one allowed to
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2228#discussion_r208672703
--- Diff:
artemis-selector/src/main/java/org/apache/activemq/artemis/selector/impl/SelectorParser.java
---
@@ -80,11 +78,15 @@ public static
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2227
@michaelandrepearce You are right indeed, but the change of @mtaylor is
quite smart here: he is avoiding the allocation of byte[] at all, like in the
original code :100:
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2199
@clebertsuconic I think that using a near-to-deprecation feature to solve
the issue can be avoided:
https://github.com/franz1981/activemq-artemis/tree/mmap_ro_2_read_journal
It is a
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2199
@michaelandrepearce good point! I will need to modify it because my
solution do not create any ByteBuffer at all (or will dispose it immediately
with Asyncio) and the test proposed
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2199
@michaelandrepearce @morefuntang
I have just verified that the fix I have done is not complete yet;
there are indeed 3 points where native allocations are performed:
1
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2199
@michaelandrepearce I have near finished :)
The thing is that I have introduced a small API change on SequentialFile
that I'm not very happy with
---
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2250
ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer
off-heap memory leaks
Compaction is now reusing direct ByteBuffers on both
reading and writing with explicit and
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2250
@michaelandrepearce @clebertsuconic I'm on vacation ATM, hence I need help
to test it on CI and obviously review/test it guys :+1:
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2250
I have included the same optimizations while loading the journal, not only
on compaction
---
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2274
ARTEMIS-2059 NettyWritable should use UTF-8 exact length to encode strings
NettyWritable.put(String) tries to enlarge the buffer used to write a UTF-8
string until
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2274
@tabish121 @gemmellr I will be probably able to take a further look on it
after wednesday...
Anyway I think that this PR as it is will just fix the bug at a performance
cost
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2274#discussion_r214067838
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/util/NettyWritable.java
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2274
@gemmellr It is a good precisation indeed: it is more an improvement, but
if have just allocated fixed size ByteBuf it will fail throwing an exception
even if the space is enough
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2274
@gemmellr You are right: indeed I'm thinking if it makes sense to close
this considering that it will cost some perf..
I'm not aware of the lifecycle of the netty buffer u
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2294
ARTEMIS-2068 save reading any file to get AMQP large msg size
ServerJMSBytesMessage::getBodyLength can save reading
the whole large message file by reading just its
file size
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2299
ARTEMIS-2078 AMQP large msg aren't consumed by clusters without persistence
NullStorageLargeServerMessage is not correctly exposing its body buffer
to allow CoreAmqpConvert
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2299
I need to check the CI failures on it :+1:
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2299
It seems that the failures are not dependent by this commit :)
---
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2307
ARTEMIS-2070 broker can reduce buffer copies with large messages
It includes several improvements on large messages:
- AMQP and OpenWire: it reduces the number of copies of the
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2307#discussion_r217143867
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientMessageImpl.java
---
@@ -400,17 +398,10
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2317
ARTEMIS-2089 DB2 sending larger message (1MB) crashes the whole server
It declares JDBC journal Blobs for IBM DB2 DBMS matching max-blob-size
in order to allow to store data with
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2318
ARTEMIS-2090 JDBC Journal is not deleting TX records
JDBCJournalImpl::cleanupTxRecords is not committing
the deleteJournalTxRecords statement leaving the
TX records into the
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2318
@mtaylor @clebertsuconic I'm not very familiar with the records type used
on the journal, but I'm having this issue while connecting a JMS consumer on an
empty queue: I suppos
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2323
ARTEMIS-2089 DB2 sending larger message (1MB) crashes the whole server
(cherry picked from commit f7602e520af66ac44d6e8166330e44dcfcda34d1)
You can merge this pull request into a Git
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2323
@mtaylor Please do not merge it until the one on master will be merged!
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2323
I will close it because it wasn't containing the right commit and it has
been already merged
---
Github user franz1981 closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2323
---
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2325
ARTEMIS-2093 NPE thrown by NettyConnector::createConnection
Given that NettyConnector::createConnection isn't happening on the
channel's event loop, it could race with
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2181#discussion_r220121826
--- Diff:
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
---
@@ -227,7 +227,11
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2328#discussion_r220179880
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java
---
@@ -1056,4 +1107,26 @@ public
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2328#discussion_r220179027
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java
---
@@ -68,22 +73,23 @@ public
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2328#discussion_r220155971
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java
---
@@ -1056,4 +1107,26 @@ public
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2328
@michaelandrepearce Michael, you know that I love doing perf stuff as well,
so I can share some bench with JMH as soon as I would find some minutes during
the day (or this evening) :+1
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2328
@michaelandrepearce I have @home an AMD Thread Ripper dual socket so I can
try something with it :P Just to understand the issue here: with single
threading a stamped lock is fine but
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2328
@michaelandrepearce I have done some experiments on it and I have noticed
that the issue is the contention of the `state` field on `StampedLock` with the
rest of the surrounding fields
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2250#discussion_r220720824
--- Diff:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
---
@@ -1796,15 +1826,15 @@ private
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2181#discussion_r221229493
--- Diff:
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
---
@@ -227,7 +227,11
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2338
ARTEMIS-2101 Do not cluster OpenWire advisory topics
ClusterConnectionBridge needs to ignore any advisory topic
address in the filter used by the notification consumer on
bridge
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2338#discussion_r221536659
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java
---
@@ -350,6 +352,8
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2338
Thanks guys: I'm working on this to improve the decoupling of the solution
from being OpenWire-centric :+1:
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2338
@michaelandrepearce @jbertram @clebertsuconic I have made it more generic
and less OpenWire bounded, but I'm not quite 100% sure about it so please, fi
you have any comments or wo
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2338#discussion_r222008074
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireProtocolManager.java
Github user franz1981 closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2338
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2181#discussion_r222663365
--- Diff:
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
---
@@ -227,7 +227,11
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2347
You can take a weak reference of the ManagementContext instance you want to
test the leak, force a GC + run finalizer (we have a method in the test suite
for that) and then verify that
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2349
ARTEMIS-2114 hawtio dest delete/purge buttons overlap if pane resized
Changing the view layout from horizontal to vertical avoid the resizing
issue
You can merge this pull request
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2355
ARTEMIS-2116 Set text message content on producer CLI command
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/franz1981/activemq
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2181
@clebertsuconic If now it looks fine I would cherry-pick it into 2.6-x
too, fater being merged :+1:
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2369#discussion_r224825736
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
---
@@ -599,6 +600,29
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2369#discussion_r224830396
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
---
@@ -599,6 +600,29
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2369#discussion_r224839730
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
---
@@ -599,6 +600,29
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2369#discussion_r225077165
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
---
@@ -599,6 +600,29
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2371#discussion_r225093373
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/ActiveMQAddressBlockedException.java
---
@@ -0,0 +1,24
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2369#discussion_r225419711
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
---
@@ -599,6 +600,18
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2373
ARTEMIS-2125 Queue preference changes to display columns not persistent
through page refresh
You can merge this pull request into a Git repository by running:
$ git pull https
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2373
@tadayosi Please take a look if it is similar to what you have done on
queues...and thanks for the PR :+1:
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2370
@tadayosi I've opened https://github.com/apache/activemq-artemis/pull/2373
to address this one too (using your commit :))
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2373
@andytaylor thanks!! I will cherry-pick into 2.6-x too :+1:
---
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2378
ARTEMIS-2131 Error compacting journal
Compaction cannot free a sliced view of a ByteBuffer on Java >=9:
the fix is using the original ByteBuffer instead of the slice
to perf
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2378
This PR is addressing just the a change in Java 9 of the Cleaner behaviour:
a more complete fix that address the direct memory leak on it would be
https://github.com/apache/activemq
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2199
@morefuntang Please check if master has fixed your issue with GC and close
this one: it has been addressed on
https://github.com/apache/activemq-artemis/pull/2250
With it there
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2392
ARTEMIS-2100 address routing-type overridden on attaching AMQP sender
AMQPSender has to honor an already existing routingType of an address
while attempting to create a fresh new
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2392
@jbertram I need to run the whole test suite on this first, but feel free
to review it given that you're the last one that has worked near this same code
:+1:
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2393#discussion_r227822843
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java
---
@@ -349,7 +349,9 @@ public
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2392
@michaelandrepearce I understand your point here, just I'm not sure is only
a matter of flexibility here, but more of user expectations and I admit that it
makes this a lot
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2392
@michaelandrepearce I think to have misread the issue: the current
behaviour is not bad, just is not taking in consideration the already existing
address routingType(s) and just
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2396
@michaelandrepearce Someone has summoned me? If you repeat my name 3 times
I'll disappear (cit: Beetlejuice)
---
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2401
ARTEMIS-1710 Allow management msgs to pass the global-max-size limit
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/franz1981
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2401#discussion_r229013120
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingManagerImpl.java
---
@@ -437,12 +449,27 @@ public
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2401#discussion_r229013748
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
---
@@ -700,7 +720,7 @@ public
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2392
@mtaylor I've addressed the requests you've made and added another test to
cover the case where the queue is being created too :+1:
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2401#discussion_r229110673
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
---
@@ -700,7 +720,7 @@ public
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2401#discussion_r229111410
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingManagerImpl.java
---
@@ -437,12 +449,27 @@ public
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2401
> Surely this would be better handled with simply setting better values per
address.
I could be wrong (and @mtaylor or @clebertsuconic can help me to understand
the conditi
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2402
You need to disable data-sync too if you want to rely just on the sync
provided by OS ie just application failure protection AFAIK.
Without being too OT, provided you have enough RAM
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2401
@clebertsuconic Let me run it while I'm working on an alternative version
too: we can talk later about it mate?
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2401#discussion_r229640945
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingManagerImpl.java
---
@@ -437,12 +449,27 @@ public
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2401
@michaelandrepearce I've started working on the alternative one based on a
second level global limit, but TBH I've already found quite complex to add such
condition without br
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2401
@clebertsuconic I'm fixing a couple of things on this one too
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2401
@clebertsuconic I have added some additional unit tests on `PagingStoreImpl`
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2401
@mtaylor @michaelandrepearce I can't ignore all these useful
comments/feedbacks guys so I will work more on this one to see if it can be
done in a better way; thanks for the reviews :+1:
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2401
@michaelandrepearce @lulf @mtaylor I will continue on the issue comments
:+1:
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2401#discussion_r229845531
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/Configuration.java
---
@@ -493,6 +493,17 @@ Configuration
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2401
@clebert I will try to connect later in order to understand what you mean
mate (ATM I'm on the phone)
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2401
@lulf @michaelandrepearce I was looking to implement it as:
```xml
30
```
Per address-settings to allow all the addresses matching it to share a 30%
of the configured
1 - 100 of 947 matches
Mail list logo
