Re: [RESULT][VOTE] Release Airflow 1.10.0

2018-08-28 Thread Ash Berlin-Taylor
And mine is 'ashb', please :) > On 27 Aug 2018, at 18:19, Sid Anand wrote: > > @max (mine is r39132) > > On Mon, Aug 27, 2018 at 10:13 AM Driesprong, Fokko > wrote: > >> Thanks for picking this up Naik! Did not have the time today to upload the >> artifacts. >> >> Cheers, Fokko >> >> Op

Re: Python 3.6 Support for Airflow 1.10.0

2018-08-28 Thread Naik Kaxil
To provide more context to the issue: PyPI shows that Airflow is supported on Py2.7, 3.4 and 3.5 : https://pypi.org/project/apache-airflow/ This is picked from setup.py: https://github.com/apache/incubator-airflow/blob/26e0d449737e8671000f671d820a9537f23f345a/setup.py#L367 So, should we

Python 3.6 Support for Airflow 1.10.0

2018-08-28 Thread Naik Kaxil
Hi all, @fokko – I remember that you had test Airflow on 3.6 . Can we include 3.6 in setup.py then ? Regards, Kaxil Kaxil Naik Data Reply 2nd Floor, Nova South 160 Victoria Street, Westminster London SW1E 5LB - UK phone: +44 (0)20 7730 6000 k.n...@reply.com

Re: Python 3.6 Support for Airflow 1.10.0

2018-08-28 Thread Ash Berlin-Taylor
Supporting 3.7 is absolutely something we should do - it just got released while we were already mid-way through the release process of 1.10 and didn't want the scope creep. I'm happy to release a 1.10.1 that supports Py 3.7. The only issue I've seen so far is around the use of `async` as a

Re: Python 3.6 Support for Airflow 1.10.0

2018-08-28 Thread Taylor Edmiston
I am onboard with dropping Python 2.x support. Django officially dropped Python 2.x support with their 2.0 release since December 2017. *Taylor Edmiston* Blog | CV | LinkedIn | AngelList

Re: Python 3.6 Support for Airflow 1.10.0

2018-08-28 Thread Adam Boscarino
fwiw, we run Airflow on Python 3.6. On Tue, Aug 28, 2018 at 8:30 AM Naik Kaxil wrote: > To provide more context to the issue: > > > > PyPI shows that Airflow is supported on Py2.7, 3.4 and 3.5 : > https://pypi.org/project/apache-airflow/ > > > > This is picked from setup.py: > > >

Re: Python 3.6 Support for Airflow 1.10.0

2018-08-28 Thread Taylor Edmiston
We are also running on 3.6 for some time. I put a quick branch together adding / upgrading to 3.6 in all of the places. CI is still running so I may expect some test failures but hopefully nothing major. I would be happy to merge this into Kaxil's current #3815 or as a follow-on PR. I'll paste

Re: Python 3.6 Support for Airflow 1.10.0

2018-08-28 Thread Naik Kaxil
We should definitely support 3.7. I left comments on the PR @tedmiston regarding the same. Python 2.7 will be dropped in 2020, so I guess we should start planning about it. Not really 100% sure though that we should drop it in Airflow 2.0 On 28/08/2018, 17:08, "Taylor Edmiston" wrote:

Re: explicit_defaults_for_timestamp for mysql

2018-08-28 Thread Feng Lu
Bolke, a gentle ping.. Thank you. On Thu, Aug 23, 2018, 23:01 Feng Lu wrote: > Hi all, > > After reading the MySQL documentation on the > exlicit_defaults_for_timestamp, it appears that we can skip the check on > explicit_defaults_for_timestamp > = 1 >

Fwd: [PPMCS] Podling project logos wanted

2018-08-28 Thread Sid Anand
Hi Folks! Firstly, I didn't even know we had a logo. http://www.apache.org/logos/#incubating It's not super great looking. Anyone want to take a crack at a better one? @max ? -s -- Forwarded message - From: Daniel Gruno Date: Tue, Aug 28, 2018 at 3:10 AM Subject: [PPMCS]

Re: Python 3.6 Support for Airflow 1.10.0

2018-08-28 Thread Arthur Wiedmer
Given that Python 2.7 EOL is slated for January 1st 2020, we should probably ensure that the early releases of 2019 are still 2.7 compatible. Beyond this, I think we can also be responsible security wise and help nudge people towards 3. Best, Arthur On Tue, Aug 28, 2018 at 10:28 AM Bolke de

Re: PR Review Dashboard?

2018-08-28 Thread Maxime Beauchemin
Alright let's keep things this way at least for now so that we can move forward with the Spark approach. Max On Tue, Aug 28, 2018 at 10:39 AM Bolke de Bruin wrote: > I’m not in favor of moving to GitHub issues. While JIRA is not perfect it > actually moves discussion to the mailing list. With

Re: Python 3.6 Support for Airflow 1.10.0

2018-08-28 Thread Bolke de Bruin
Let’s not drop 2.7 too quickly but maybe mark it deprecated. I’m pretty sure Airbnb still runs on 2.7. Also RedHat does not deliver python 3 in its enterprise edition yet by default so it will put enterprise users in a bit of an awkward spot. B. Verstuurd vanaf mijn iPad > Op 28 aug. 2018 om

Re: [PPMCS] Podling project logos wanted

2018-08-28 Thread Sid Anand
To provide a bit more context, one improvement is for the logo to read Apache Airflow. I like the font & styling used in Apache Airavata. If you have a creative streak, feel free to raise a PR with your logo -- once merged, we can update the Apache logo page. Looking in

Re: Python 3.6 Support for Airflow 1.10.0

2018-08-28 Thread Sid Anand
I'm +1 on going to 3.7 -- I'm running 3.6 myself. Regarding dropping Python2 support, with almost 200 companies using Airflow, I'd want to be very careful that we don't put any of them at a disadvantage. For example, my former employer (a small startup) is running on Python2 -- after I left, they

Re: PR Review Dashboard?

2018-08-28 Thread Bolke de Bruin
I’m not in favor of moving to GitHub issues. While JIRA is not perfect it actually moves discussion to the mailing list. With GitHub issues the stuff just gets lost imho. I do like our changelogs a lot better now. B. Verstuurd vanaf mijn iPad > Op 27 aug. 2018 om 05:53 heeft Holden Karau

Re: PR Review Dashboard?

2018-08-28 Thread Jakob Homan
Spark is an order of magnitude larger in terms of contributors, codebase, issues, etc. I don't think adding an layer of complexity into the review process would be helpful right now. Not everything that works for one ASF project works for another. I'd vote against this. -Jakob On 28 August

Re: Python 3.6 Support for Airflow 1.10.0

2018-08-28 Thread Feng Lu
+1 for keeping 2.7 as long as we can so people have time to plan and migrate away from it. On Tue, Aug 28, 2018, 10:35 Arthur Wiedmer wrote: > Given that Python 2.7 EOL is slated for January 1st 2020, we should > probably ensure that the early releases of 2019 are still 2.7 compatible. > >

Running unit tests against SLUGIFY_USES_TEXT_UNIDECODE and AIRFLOW_GPL_UNIDECODE (also is this broken?)

2018-08-28 Thread Taylor Edmiston
Since the release of 1.10, we now have the option to install Airflow with either: 1. python-nvd3 --> python-slugify --> text-unidecode (via env var

Re: Python 3.6 Support for Airflow 1.10.0

2018-08-28 Thread Tao Feng
+1 for keeping 2.7 as well. Lyft runs airflow on 2.7 internally. On Tue, Aug 28, 2018 at 1:12 PM, Feng Lu wrote: > +1 for keeping 2.7 as long as we can so people have time to plan and > migrate away from it. > > On Tue, Aug 28, 2018, 10:35 Arthur Wiedmer > wrote: > > > Given that Python 2.7

Re: Getting Task Killed Externally

2018-08-28 Thread Vardan Gupta
Hi Trent, Thanks for replying. Though you're suggesting that there might be case where we might be hitting caps, but on our side, there are hardly any concurrent tasks, rarely 1-2 at a time with parallelism set to 50. But yeah, we'll just increase the parallelism and and see if that solves the

Re: Getting Task Killed Externally

2018-08-28 Thread Trent Robbins
We saw the same thing. Only a few truly active tasks yet the task queue was filling up with pending tasks. Best, Trent On Tue, Aug 28, 2018 at 12:47 AM Vardan Gupta wrote: > Hi Trent, > > Thanks for replying. Though you're suggesting that there might be case > where we might be hitting caps,