[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-15 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/60 JUnit 5 support - A new junitlauncher task This is the initial working version of a new `junitlauncher` task that support using JUnit 5 framework for testing, within Ant build files. The commit in thi

[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

2018-02-15 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/60 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/34/ --- --

[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

2018-02-15 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/60 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/40/ ---

Re: Ant support for users who use JUnit5

2018-02-15 Thread Jaikiran Pai
I'm now done with the initial goals that I had in mind for this task. I've opened a PR[1] for review. I've included a manual for this task and it can be currently found here[2]. I would suggest reading the manual first, before reviewing the PR, since the manual will give an overall idea of what

[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

2018-02-15 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/60 Please ignore the Jenkins failures on this PR. I'll sort out that part in a separate discussion. --- - To unsubscribe, e-mail: dev-u

Re: Ant support for users who use JUnit5

2018-02-15 Thread Jaikiran Pai
From a release point of view - I know we are currently sorting out some regressions and issues that have been uncovered by the latest release. So if it makes things easier from a stability point of view, we can wait to merge this only after we have done another release which addresses only the

[GitHub] ant issue #58: Use StringBuilder instead of StringBuffer as it offers high p...

2018-02-15 Thread reudismam
Github user reudismam commented on the issue: https://github.com/apache/ant/pull/58 Undo edits to src/main/org/apache/tools/ant/listener/MailLogger.java and src/main/org/apache/tools/ant/taskdefs/Parallel.java --- -

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

2018-02-15 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/61 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail:

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

2018-02-15 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/61 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail:

[GitHub] ant pull request #61: Use the isEmpty method instead of comparing the value ...

2018-02-15 Thread reudismam
GitHub user reudismam opened a pull request: https://github.com/apache/ant/pull/61 Use the isEmpty method instead of comparing the value of size() to 0. You can merge this pull request into a Git repository by running: $ git pull https://github.com/reudismam/ant size Alternat

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

2018-02-15 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/61 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.

[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

2018-02-15 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/60 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

2018-02-15 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/61 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.

[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

2018-02-15 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/60 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/35/ --- --

[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

2018-02-15 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/60 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/41/ ---

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

2018-02-15 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/61 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/36/ --- --

[GitHub] ant pull request #61: Use the isEmpty method instead of comparing the value ...

2018-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant/pull/61 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

2018-02-15 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/61 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/42/ ---

[GitHub] ant issue #61: Use the isEmpty method instead of comparing the value of size...

2018-02-15 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/61 Thank for you the PR. This is now merged --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mai

Re: Ant support for users who use JUnit5

2018-02-15 Thread Jaikiran Pai
I just realized that the manual that I linked in my mail isn't accessible to everyone. So here's an alternative link to the same https://home.apache.org/~jaikiran/temp_workspace/manual/Tasks/junitlauncher.html -Jaikiran On 15/02/18 7:21 PM, Jaikiran Pai wrote: I'm now done with the initial go