[GitHub] ant-ivy issue #74: Fix IVY-982 by removing negated entries from wildcard bin

[twogee]

Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/74
  
Thank you, the fix is in master now. Please rebase to verify and close the 
PR.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #74: Fix IVY-982 by removing negated entries from wildcard bin

[twogee]

Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/74
  
`singletonList()` for single-element lists is the pattern used across Ivy 
tests. Thriftiness is a virtue, despite what people may say 😄


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #74: Fix IVY-982 by removing negated entries from wildcard bin

[aprelev]

Github user aprelev commented on the issue:

https://github.com/apache/ant-ivy/pull/74
  
Do you think overhead decrease achieved by using `singletonList()` 
outweighs breaking the pattern of `List` initialisations in test body? This is 
my second week with Java, these subtle differences are new to me.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #74: Fix IVY-982 by removing negated entries from wildcard bin

[twogee]

Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/74
  
The disk is full again 😦Anyway, in case there is only one element, 
`Collections.singletonList()` is preferable.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #74: Fix IVY-982 by removing negated entries from wildcard bin

[aprelev]

Github user aprelev commented on the issue:

https://github.com/apache/ant-ivy/pull/74
  
I replaced `Arrays.equals()` with `List.containsAll()`, as you suggested; 
thank you.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #74: Fix IVY-982 by removing negated entries from wildcard bin

[twogee]

Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/74
  
Sorting is a problem, in `rootModuleConfs` field of `IvyNodeUsage` by the 
looks of it.
```
assertTrue(Arrays.asList("myconf1", 
"myconf2").containsAll(Arrays.asList(

crp.getDependency(mod22).getConfigurations(crp.getConfiguration();
```
does the bill, not sure if that's good enough, though.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #74: Fix IVY-982 by removing negated entries from wildcard bin

[twogee]

Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/74
  
@aprelev Unfortunately, the fix fails on Java 7 but not the later versions 
(reproduced on macOS here, too). Do you need assistance to investigate further?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org