Re: Patch JavaCC - KEEP_LINE_COLUMN, JJTree - OUTPUT_FILE and new tas kdef JJDoc
On Fri, 4 Apr 2003, Jene Jasper [EMAIL PROTECTED] wrote: Would it be useful if I add an updated patch.txt to bug 18602 for JavaCC.java and JJTree.java after the changes are available in a nightly build ?? Maybe, but I don't think that merging them will be a big deal anyway. Stefan
Re: Patch JavaCC - KEEP_LINE_COLUMN, JJTree - OUTPUT_FILE and new tas kdef JJDoc
On Wed, 2 Apr 2003, Jene Jasper [EMAIL PROTECTED] wrote: As mentioned yesterday, I have made some changes to the JavaCC and JJTree taskdefs and added a new taskdef for JJDoc. I have included the patch.txt for the changes. But what is the best way to deliver the new files JJDoc.java and jjdoc.html ? Create an enhancement request in Bugzilla, attach this patch and the two new files. Does your patch include the JavaCC 3.0/2.1 changes? I'd like to tackle that separately if possible. Stefan
RE: Patch JavaCC - KEEP_LINE_COLUMN, JJTree - OUTPUT_FILE and new tas kdef JJDoc
On Wed, 2 Apr 2003, Jene Jasper [EMAIL PROTECTED] wrote: As mentioned yesterday, I have made some changes to the JavaCC and JJTree taskdefs and added a new taskdef for JJDoc. I have included the patch.txt for the changes. But what is the best way to deliver the new files JJDoc.java and jjdoc.html ? Create an enhancement request in Bugzilla, attach this patch and the two new files. Does your patch include the JavaCC 3.0/2.1 changes? I'd like to tackle that separately if possible. We are thinking along the same line. That is why I created this separate patch. And about the patch for the JavaCC 3.0/2.1 changes, I have the following question: Does it make a difference if I make the patch on my latest revision or the snapshot of April 1st? I don't think it will involve the same lines of code. Jene.
RE: Patch JavaCC - KEEP_LINE_COLUMN, JJTree - OUTPUT_FILE and new tas kdef JJDoc
On Wed, 2 Apr 2003, Jene Jasper [EMAIL PROTECTED] wrote: Does it make a difference if I make the patch on my latest revision or the snapshot of April 1st? It might be easier to do if you diffed against CVS HEAD, but ... I don't think it will involve the same lines of code. in this case, patch might work with some fuzzyness. You could try to apply your patch against a CVS HEAD version to be sure. Stefan I having some problems getting anonymous cvs to work tunneling through my firewall with PuTTy. Thus I will try to check in a patch for JavaCC 2.1/3.0 changes against the latest snapshot around Monday. Jene.
Re: Patch JavaCC - KEEP_LINE_COLUMN, JJTree - OUTPUT_FILE and new tas kdef JJDoc
On Wed, 2 Apr 2003, Jene Jasper [EMAIL PROTECTED] wrote: Thus I will try to check in a patch for JavaCC 2.1/3.0 changes against the latest snapshot around Monday. CVS HEAD hasn't changed for quite some time, shouldn't be a problem. Stefan
