[jira] [Comment Edited] (APEXMALHAR-2284) POJOInnerJoinOperatorTest fails in Travis CI
[
https://issues.apache.org/jira/browse/APEXMALHAR-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588941#comment-15588941
]
Chandni Singh edited comment on APEXMALHAR-2284 at 10/19/16 2:36 PM:
-
[~bhup...@apache.org], [~chaithu] I disagree. There are ways that Spillable...
can be enhanced to support event time.
ManagedTimeStateMultiValue is not even a Managed State Implementation so don't
really know why it is with other managed state implementations.
was (Author: csingh):
[~bhup...@apache.org], [~chaithu] I disagree. There are ways that Spillable...
be enhanced to support event time.
ManagedTimeStateMultiValue is not even a Managed State Implementation so don't
really know why it is with other managed state implementations.
> POJOInnerJoinOperatorTest fails in Travis CI
>
>
> Key: APEXMALHAR-2284
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2284
> Project: Apache Apex Malhar
> Issue Type: Bug
>Reporter: Thomas Weise
>Assignee: Chaitanya
>Priority: Blocker
> Fix For: 3.6.0
>
>
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/166322754/log.txt
> {code}
> Failed tests:
> POJOInnerJoinOperatorTest.testEmitMultipleTuplesFromStream2:337 Number of
> tuple emitted expected:<2> but was:<4>
> POJOInnerJoinOperatorTest.testInnerJoinOperator:184 Number of tuple emitted
> expected:<1> but was:<2>
> POJOInnerJoinOperatorTest.testMultipleValues:236 Number of tuple emitted
> expected:<2> but was:<3>
> POJOInnerJoinOperatorTest.testUpdateStream1Values:292 Number of tuple
> emitted expected:<1> but was:<2>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (APEXMALHAR-2284) POJOInnerJoinOperatorTest fails in Travis CI
[
https://issues.apache.org/jira/browse/APEXMALHAR-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15585751#comment-15585751
]
Chandni Singh edited comment on APEXMALHAR-2284 at 10/18/16 3:40 PM:
-
One concept that I think I should point is how getAsync improves performance is
that if the value is not available immediately, then the client can cache the
future and work on other keys. Look at the implementations of AbstractDeduper.
1. If SpillableArrayListMultimap only lacks asynchronous get, then that can be
added to it. That should not be the only reason to duplicate the functionality.
2. ManagedTimeMultiValueState has no tests and is full of warnings.
We should not create a complete separate implementation which duplicates a
larger part of functionality provided by something existing otherwise we will
have too many slightly different variations of the same thing and that will be
very difficult to manage.
IMO this is a good opportunity to improve SpillableArrayListMultimapImpl and
use that.
was (Author: csingh):
One concept that I think I should point is that getAsync improves performance
is that if the value is not available immediately, then the client can cache
the future and work on other keys. Look at the implementations of
AbstractDeduper.
1. If SpillableArrayListMultimap only lacks asynchronous get, then that can be
added to it. That should not be the only reason to duplicate the functionality.
2. ManagedTimeMultiValueState has no tests and is full of warnings.
We should not create a complete separate implementation which duplicates a
larger part of functionality provided by something existing otherwise we will
have too many slightly different variations of the same thing and that will be
very difficult to manage.
IMO this is a good opportunity to improve SpillableArrayListMultimapImpl and
use that.
> POJOInnerJoinOperatorTest fails in Travis CI
>
>
> Key: APEXMALHAR-2284
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2284
> Project: Apache Apex Malhar
> Issue Type: Bug
>Reporter: Thomas Weise
>Assignee: Chaitanya
>Priority: Blocker
> Fix For: 3.6.0
>
>
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/166322754/log.txt
> {code}
> Failed tests:
> POJOInnerJoinOperatorTest.testEmitMultipleTuplesFromStream2:337 Number of
> tuple emitted expected:<2> but was:<4>
> POJOInnerJoinOperatorTest.testInnerJoinOperator:184 Number of tuple emitted
> expected:<1> but was:<2>
> POJOInnerJoinOperatorTest.testMultipleValues:236 Number of tuple emitted
> expected:<2> but was:<3>
> POJOInnerJoinOperatorTest.testUpdateStream1Values:292 Number of tuple
> emitted expected:<1> but was:<2>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (APEXMALHAR-2284) POJOInnerJoinOperatorTest fails in Travis CI
[
https://issues.apache.org/jira/browse/APEXMALHAR-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571119#comment-15571119
]
Chandni Singh edited comment on APEXMALHAR-2284 at 10/13/16 7:27 AM:
-
Chaitanya,
Please feel free to assign the ticket to me if my PR broke these tests. Having
a variable {code}asyncReadSource{code} didn't really make much sense to me.
Changing how reader thread fetch value from a bucket doesn't need to be exposed
and configured.
Anyways if this was done for tests, then there are better ways of doing it.
was (Author: csingh):
Chaitanya,
Please feel free to assign the ticket to me if my PR broke these tests. Having
a variable {code}asyncReadSource{code} didn't really make much sense to me.
Changing how reader thread fetch value from a bucket doesn't need to be
altered.
Anyways if this was done for tests, then there are better ways of doing it.
> POJOInnerJoinOperatorTest fails in Travis CI
>
>
> Key: APEXMALHAR-2284
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2284
> Project: Apache Apex Malhar
> Issue Type: Bug
>Reporter: Thomas Weise
>Assignee: Chaitanya
>Priority: Blocker
>
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/166322754/log.txt
> {code}
> Failed tests:
> POJOInnerJoinOperatorTest.testEmitMultipleTuplesFromStream2:337 Number of
> tuple emitted expected:<2> but was:<4>
> POJOInnerJoinOperatorTest.testInnerJoinOperator:184 Number of tuple emitted
> expected:<1> but was:<2>
> POJOInnerJoinOperatorTest.testMultipleValues:236 Number of tuple emitted
> expected:<2> but was:<3>
> POJOInnerJoinOperatorTest.testUpdateStream1Values:292 Number of tuple
> emitted expected:<1> but was:<2>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (APEXMALHAR-2284) POJOInnerJoinOperatorTest fails in Travis CI
[
https://issues.apache.org/jira/browse/APEXMALHAR-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571074#comment-15571074
]
Chandni Singh edited comment on APEXMALHAR-2284 at 10/13/16 6:57 AM:
-
Are you sure about that?
The tests were failing before merging the PR on a different PR as well, if I
remember correctly.
Also why do they fail intermittently?
was (Author: csingh):
Are you sure about that?
The tests were failing before merging the PR on a different PR as well, if I
remember correctly?
Also why do they fail intermittently?
> POJOInnerJoinOperatorTest fails in Travis CI
>
>
> Key: APEXMALHAR-2284
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2284
> Project: Apache Apex Malhar
> Issue Type: Bug
>Reporter: Thomas Weise
>Assignee: Chaitanya
>Priority: Blocker
>
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/166322754/log.txt
> {code}
> Failed tests:
> POJOInnerJoinOperatorTest.testEmitMultipleTuplesFromStream2:337 Number of
> tuple emitted expected:<2> but was:<4>
> POJOInnerJoinOperatorTest.testInnerJoinOperator:184 Number of tuple emitted
> expected:<1> but was:<2>
> POJOInnerJoinOperatorTest.testMultipleValues:236 Number of tuple emitted
> expected:<2> but was:<3>
> POJOInnerJoinOperatorTest.testUpdateStream1Values:292 Number of tuple
> emitted expected:<1> but was:<2>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (APEXMALHAR-2284) POJOInnerJoinOperatorTest fails in Travis CI
[
https://issues.apache.org/jira/browse/APEXMALHAR-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571020#comment-15571020
]
Chaitanya edited comment on APEXMALHAR-2284 at 10/13/16 6:46 AM:
-
[~thw] This was failing due to the below merged PR:
https://github.com/apache/apex-malhar/pull/444.
Please suggest the right approach further.
was (Author: chaithu):
This was failing due to the below merged PR:
https://github.com/apache/apex-malhar/pull/444
> POJOInnerJoinOperatorTest fails in Travis CI
>
>
> Key: APEXMALHAR-2284
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2284
> Project: Apache Apex Malhar
> Issue Type: Bug
>Reporter: Thomas Weise
>Assignee: Chaitanya
>Priority: Blocker
>
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/166322754/log.txt
> {code}
> Failed tests:
> POJOInnerJoinOperatorTest.testEmitMultipleTuplesFromStream2:337 Number of
> tuple emitted expected:<2> but was:<4>
> POJOInnerJoinOperatorTest.testInnerJoinOperator:184 Number of tuple emitted
> expected:<1> but was:<2>
> POJOInnerJoinOperatorTest.testMultipleValues:236 Number of tuple emitted
> expected:<2> but was:<3>
> POJOInnerJoinOperatorTest.testUpdateStream1Values:292 Number of tuple
> emitted expected:<1> but was:<2>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (APEXMALHAR-2284) POJOInnerJoinOperatorTest fails in Travis CI
[
https://issues.apache.org/jira/browse/APEXMALHAR-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570783#comment-15570783
]
Chinmay Kolhatkar edited comment on APEXMALHAR-2284 at 10/13/16 4:19 AM:
-
Changing priority to a blocker as number of PRs are failing in travis because
of this and hence PR merge process for other work is getting blocked.
was (Author: chinmay):
Changing priority to a blocker as number of PRs are failing in travis because
of this.
> POJOInnerJoinOperatorTest fails in Travis CI
>
>
> Key: APEXMALHAR-2284
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2284
> Project: Apache Apex Malhar
> Issue Type: Bug
>Reporter: Thomas Weise
>Assignee: Chaitanya
>Priority: Blocker
>
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/166322754/log.txt
> {code}
> Failed tests:
> POJOInnerJoinOperatorTest.testEmitMultipleTuplesFromStream2:337 Number of
> tuple emitted expected:<2> but was:<4>
> POJOInnerJoinOperatorTest.testInnerJoinOperator:184 Number of tuple emitted
> expected:<1> but was:<2>
> POJOInnerJoinOperatorTest.testMultipleValues:236 Number of tuple emitted
> expected:<2> but was:<3>
> POJOInnerJoinOperatorTest.testUpdateStream1Values:292 Number of tuple
> emitted expected:<1> but was:<2>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
