Re: Issues/questions with apr_memcache_multigetp

2015-10-31 Thread Yann Ylavic
Thanks Jeffrey for testing. Committed to trunk in http://svn.apache.org/r1711657, will let it there for a few times (review) and then backport it to 1.6.x and 1.5.x branches. Regards, Yann. On Wed, Oct 28, 2015 at 3:41 PM, Jeffrey Crowell wrote: > That patch works, and users have confirmed tha

Re: Issues/questions with apr_memcache_multigetp

2015-10-28 Thread Jeffrey Crowell
That patch works, and users have confirmed that the error message added has appeared in logs. (applied to our copy here) https://github.com/pagespeed/mod_pagespeed/commit/84a9deaf9c4df13ae707f44d06f577321de46e8c Thanks, Jeff On Thu, Sep 24, 2015 at 1:28 PM, Jeffrey Crowell wrote: > Hi Yann, >

Re: Issues/questions with apr_memcache_multigetp

2015-09-24 Thread Jeffrey Crowell
Hi Yann, This patch looks like it should fix the hang we've seen based on the instruction trace provided from a bug report ( http://i.imgur.com/RI3TKrU.png ) where essentially, queries_sent ( https://github.com/pagespeed/mod_pagespeed/blob/master/third_party/aprutil/apr_memcache2.c#L1414 ) is neve

Re: Issues/questions with apr_memcache_multigetp

2015-09-24 Thread Yann Ylavic
Hi Jeffrey, On Wed, Sep 23, 2015 at 9:23 PM, Jeffrey Crowell wrote: > > We have some patches which were created in an attempt to fix some signed > bugs in the original code that I think may be causing our issue. > > Namely here: > https://github.com/pagespeed/mod_pagespeed/blob/master/third_party

Re: Issues/questions with apr_memcache_multigetp

2015-09-23 Thread Jeffrey Crowell
Jim, Our current patches were to fix some compile time warnings about signed vs. unsigned comparisons, which I think have actually backfired and are causing the 100% cpu usage. My current guess is that our forked version works as the initial code intended, and causes the hang, and the upstream ve

Re: Issues/questions with apr_memcache_multigetp

2015-09-23 Thread Jim Jagielski
Haven't looked at the actual bug but yet, in general, we appreciate it when people send in patches that fix bugs or errors in our code instead of simply forking off those changes. Apache tries to work a little bit differently than the current buzz about forking and working in isolation; we instead