Re: Review Request 71564: ATLAS-3431: Ability to create and store user defined key-value pairs in Atlas entity instances

2019-10-02 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71564/#review218014 --- Fix it, then Ship it!

[jira] [Created] (ATLAS-3433) Basic Search: Results include Internal Entities

2019-10-02 Thread Ashutosh Mestry (Jira)
Ashutosh Mestry created ATLAS-3433: -- Summary: Basic Search: Results include Internal Entities Key: ATLAS-3433 URL: https://issues.apache.org/jira/browse/ATLAS-3433 Project: Atlas Issue

[jira] [Commented] (ATLAS-3433) Basic Search: Results include Internal Entities

2019-10-02 Thread Sridhar (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943032#comment-16943032 ] Sridhar commented on ATLAS-3433: +1 on patch. can be shipped. > Basic Search: Results include Internal

[jira] [Commented] (ATLAS-3434) Update janusgraph-hbase storage manager PREFERRED_TIMESTAMPS from MILLI to MICRO

2019-10-02 Thread Ashutosh Mestry (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943035#comment-16943035 ] Ashutosh Mestry commented on ATLAS-3434: Can you please add PC build details. > Update

[jira] [Resolved] (ATLAS-3348) Update jackson.databind.version to 2.9.9.1

2019-10-02 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian resolved ATLAS-3348. --- Resolution: Fixed > Update jackson.databind.version to 2.9.9.1 >

[jira] [Updated] (ATLAS-3433) Basic Search: Results include Internal Entities

2019-10-02 Thread Ashutosh Mestry (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Mestry updated ATLAS-3433: --- Attachment: ATLAS-3433-Internal-entities-were-inadvertently-index.patch > Basic Search:

[jira] [Commented] (ATLAS-3434) Update janusgraph-hbase storage manager PREFERRED_TIMESTAMPS from MILLI to MICRO

2019-10-02 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943059#comment-16943059 ] Madhan Neethiraj commented on ATLAS-3434: - +1 for the fix. Thanks [~sarath]! > Update

[jira] [Resolved] (ATLAS-3351) Atlas Entity: Support Storing Arbitrary Name-Value Pairs

2019-10-02 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian resolved ATLAS-3351. --- Resolution: Fixed > Atlas Entity: Support Storing Arbitrary Name-Value Pairs >

[jira] [Commented] (ATLAS-3432) Add Machine Learning Governance integration

2019-10-02 Thread Karthik Manamcheri (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942961#comment-16942961 ] Karthik Manamcheri commented on ATLAS-3432: --- This integration is very specific to one

Re: Review Request 71564: ATLAS-3431: Ability to create and store user defined key-value pairs in Atlas entity instances

2019-10-02 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71564/ --- (Updated Oct. 2, 2019, 9:51 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71564: ATLAS-3431: Ability to create and store user defined key-value pairs in Atlas entity instances

2019-10-02 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71564/#review218024 --- Ship it! Ship It! - Madhan Neethiraj On Oct. 2, 2019, 4:51

[jira] [Created] (ATLAS-3434) Update janusgraph-hbase storage manager PREFERRED_TIMESTAMPS from MILLI to MICRO

2019-10-02 Thread Sarath Subramanian (Jira)
Sarath Subramanian created ATLAS-3434: - Summary: Update janusgraph-hbase storage manager PREFERRED_TIMESTAMPS from MILLI to MICRO Key: ATLAS-3434 URL: https://issues.apache.org/jira/browse/ATLAS-3434

[jira] [Updated] (ATLAS-3434) Update janusgraph-hbase storage manager PREFERRED_TIMESTAMPS from MILLI to MICRO

2019-10-02 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3434: -- Attachment: ATLAS-3434.001.patch > Update janusgraph-hbase storage manager

[jira] [Updated] (ATLAS-3434) Update janusgraph-hbase storage manager PREFERRED_TIMESTAMPS from MILLI to MICRO

2019-10-02 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3434: -- Attachment: precommit-atlas-3434 > Update janusgraph-hbase storage manager

[jira] [Commented] (ATLAS-3433) Basic Search: Results include Internal Entities

2019-10-02 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943107#comment-16943107 ] Sarath Subramanian commented on ATLAS-3433: --- +1 Thanks for the patch [~amestry]. > Basic

[jira] [Commented] (ATLAS-3346) Import Service: Add support to re-activate deleted entity

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943088#comment-16943088 ] ASF subversion and git services commented on ATLAS-3346: Commit

[jira] [Commented] (ATLAS-3431) Ability to create and store user defined key-value pairs in Atlas entity instances

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943089#comment-16943089 ] ASF subversion and git services commented on ATLAS-3431: Commit

[jira] [Commented] (ATLAS-3434) Update janusgraph-hbase storage manager PREFERRED_TIMESTAMPS from MILLI to MICRO

2019-10-02 Thread Ashutosh Mestry (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943096#comment-16943096 ] Ashutosh Mestry commented on ATLAS-3434: [~sarath] Thanks for the patch. I ran few tests with

[jira] [Commented] (ATLAS-3434) Update janusgraph-hbase storage manager PREFERRED_TIMESTAMPS from MILLI to MICRO

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943102#comment-16943102 ] ASF subversion and git services commented on ATLAS-3434: Commit

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-02 Thread Karthik Manamcheri via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71568/#review218031 --- Add a README file which explains what this is and how to run the

[jira] [Commented] (ATLAS-3431) Ability to create and store user defined key-value pairs in Atlas entity instances

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943085#comment-16943085 ] ASF subversion and git services commented on ATLAS-3431: Commit

[jira] [Commented] (ATLAS-3434) Update janusgraph-hbase storage manager PREFERRED_TIMESTAMPS from MILLI to MICRO

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943099#comment-16943099 ] ASF subversion and git services commented on ATLAS-3434: Commit

[jira] [Commented] (ATLAS-3433) Basic Search: Results include Internal Entities

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943110#comment-16943110 ] ASF subversion and git services commented on ATLAS-3433: Commit

[jira] [Commented] (ATLAS-3433) Basic Search: Results include Internal Entities

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943112#comment-16943112 ] ASF subversion and git services commented on ATLAS-3433: Commit

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-02 Thread Karthik Manamcheri via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71568/#review218027 ---

[jira] [Commented] (ATLAS-3433) Basic Search: Results include Internal Entities

2019-10-02 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943132#comment-16943132 ] Madhan Neethiraj commented on ATLAS-3433: - Couple of comments on this patch: # Avoid double

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-02 Thread Na Li via Review Board
> On Oct. 2, 2019, 7:56 p.m., Karthik Manamcheri wrote: > > addons/ml-bridge-shim/src/main/java/org/apache/atlas/ml/governance/hooks/GovernanceLineageHook.java > > Lines 28 (patched) > > > > > > This comment is

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-02 Thread Karthik Manamcheri via Review Board
> On Oct. 2, 2019, 7:56 p.m., Karthik Manamcheri wrote: > > addons/ml-bridge-shim/src/main/java/org/apache/atlas/ml/governance/hooks/GovernanceLineageHook.java > > Lines 28 (patched) > > > > > > This comment is

[jira] [Created] (ATLAS-3435) Handle all fields of User entity from ML Governance Hook input

2019-10-02 Thread Na Li (Jira)
Na Li created ATLAS-3435: Summary: Handle all fields of User entity from ML Governance Hook input Key: ATLAS-3435 URL: https://issues.apache.org/jira/browse/ATLAS-3435 Project: Atlas Issue Type:

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-02 Thread Na Li via Review Board
> On Oct. 2, 2019, 7:56 p.m., Karthik Manamcheri wrote: > > addons/ml-bridge/src/main/java/org/apache/atlas/ml/governance/MlGovernanceHookTool.java > > Lines 51 (patched) > > > > > > Where or why do we need this? and

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-02 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71568/ --- (Updated Oct. 2, 2019, 11:31 p.m.) Review request for atlas, Austin Nobis,

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-02 Thread Austin Nobis via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71568/#review218032 --- Some initial comments. I will make more comments later.

Re: Review Request 71564: ATLAS-3431: Ability to create and store user defined key-value pairs in Atlas entity instances

2019-10-02 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71564/#review218042 --- Ship it! Ship It! - Ashutosh Mestry On Oct. 2, 2019, 4:51

Re: Review Request 71564: ATLAS-3431: Ability to create and store user defined key-value pairs in Atlas entity instances

2019-10-02 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71564/#review218041 --- intg/src/main/java/org/apache/atlas/AtlasConfiguration.java

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-02 Thread radford nguyen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71568/#review218040 ---