Re: Review Request 72441: Support solr in standalone (http) mode

2020-04-28 Thread Damian Warszawski
graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 484c161f0 Diff: https://reviews.apache.org/r/72441/diff/1/ Testing --- Patch was applied and verified on our dev env with embedded solr and external hbase. Thanks, Damian Warszawski

Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-04-28 Thread Damian Warszawski
in the search query. Thanks, Damian Warszawski

Review Request 72446: Optimize FreeTextSearchProcessor to apply exclude deleted entity filter on solr side.

2020-04-28 Thread Damian Warszawski
entities. Thanks, Damian Warszawski

Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-01 Thread Damian Warszawski
{"exception":{"message":"Attribute Table.popularityScore not found for type Table","class":"org.apache.atlas.exception.AtlasBaseException","stacktrace":"org.apache.atlas.exception.AtlasBaseException: Attribute Table.popularityScore not found for type Table\n\tat org.apache.atlas.discovery.SearchContext.validateAttributes(SearchContext.java:288) ``` Reference to JIRA https://issues.apache.org/jira/browse/ATLAS-3776 Diffs - repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 1a7bf6b16 Diff: https://reviews.apache.org/r/72459/diff/1/ Testing --- tested on our dev env. Thanks, Damian Warszawski

Re: Review Request 72446: Optimize FreeTextSearchProcessor to apply exclude deleted entity filter on solr side.

2020-04-29 Thread Damian Warszawski
/FreeTextSearchProcessor.java 92b5eb4d2 Diff: https://reviews.apache.org/r/72446/diff/1/ Testing (updated) --- Verified on our dev env and achieved 10x faster response for simple call to atlas basic search with over 50k entities. Patch applied on top of master branch. Thanks, Damian Warszawski

Re: Review Request 72441: Support solr in standalone (http) mode

2020-04-29 Thread Damian Warszawski
/ Testing --- Patch was applied and verified on our dev env with embedded solr and external hbase. Thanks, Damian Warszawski

Re: Review Request 72446: Optimize FreeTextSearchProcessor to apply exclude deleted entity filter on solr side.

2020-04-29 Thread Damian Warszawski
://reviews.apache.org/r/72446/diff/1/ Testing --- Verified on our dev env and achieved 10x faster response for simple call to atlas basic search with over 50k entities. Thanks, Damian Warszawski

Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-04-29 Thread Damian Warszawski
://reviews.apache.org/r/72440/diff/1/ Testing --- Patch was applied on our dev env with custom entity definitions and successfully verified if order is applied as specified in the search query. Thanks, Damian Warszawski

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-06 Thread Damian Warszawski
//reviews.apache.org/r/72459/#review220660 --- On May 5, 2020, 10:11 p.m., Damian Warszawski wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-05 Thread Damian Warszawski
Query never worked properly. - Damian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72459/#review220587 ------- On May 5, 2

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-05 Thread Damian Warszawski
) - repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 1a7bf6b16 repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java PRE-CREATION repository/src/test/java/org/apache/atlas/query/BasicTestSetup.java 9aa554ad5 repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 0bbff2f46 Diff: https://reviews.apache.org/r/72459/diff/3/ Changes: https://reviews.apache.org/r/72459/diff/2-3/ Testing --- tested on our dev env. Thanks, Damian Warszawski

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-07 Thread Damian Warszawski
tory/graphdb/tinkerpop/query/TinkerpopGraphQuery.java c70e8bfe8 repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 1a7bf6b16 repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java PRE-CREATION repository/src/test/java/org/apache/atlas/query/BasicTestSetup.java 9aa554ad5 repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 0bbff2f46 Diff: https://reviews.apache.org/r/72459/diff/5/ Changes: https://reviews.apache.org/r/72459/diff/4-5/ Testing --- tested on our dev env. Thanks, Damian Warszawski

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-05 Thread Damian Warszawski
https://issues.apache.org/jira/browse/ATLAS-3776 Diffs (updated) - graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java c70e8bfe8 repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 1a7bf6b16 repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java PRE-CREATION repository/src/test/java/org/apache/atlas/query/BasicTestSetup.java 9aa554ad5 repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 0bbff2f46 Diff: https://reviews.apache.org/r/72459/diff/4/ Changes: https://reviews.apache.org/r/72459/diff/3-4/ Testing --- tested on our dev env. Thanks, Damian Warszawski

Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-05-13 Thread Damian Warszawski
was applied on our dev env with custom entity definitions and successfully verified if order is applied as specified in the search query. Thanks, Damian Warszawski

Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-05-13 Thread Damian Warszawski
y generated e-mail. To reply, visit: https://reviews.apache.org/r/72440/#review220648 --- On May 13, 2020, 10:51 p.m., Damian Warszawski wrote: > > --- > This is an automatically

Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-05-13 Thread Damian Warszawski
ps://reviews.apache.org/r/72440/#review220666 ------- On May 13, 2020, 10:51 p.m., Damian Warszawski wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-07 Thread Damian Warszawski
367> > > > > I suggest to replace use of guava library class with JDK equivalent: > > StreamSupport.stream(graphQuery.vertexIds().iterator(), false).count() Fixed. - Damian ------- This is an aut

Enable support for solr in http mode.

2020-03-21 Thread Damian Warszawski
Hi everyone, For testing purposes in our Atlas dev deployments In ING WBAA, it was required to run embedded solr with external Hbase. It was enabled by changes in the start scripts as well as in the way Solr client is configured to avoid setting up zookeeper by using solr in http mode. Additional

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-05 Thread Damian Warszawski
ttribute Table.popularityScore not found for type Table\n\tat org.apache.atlas.discovery.SearchContext.validateAttributes(SearchContext.java:288) ``` Reference to JIRA https://issues.apache.org/jira/browse/ATLAS-3776 Diffs (updated) - repository/src/main/java/org/apache/atlas/discove

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-05 Thread Damian Warszawski
tlasBaseException: Attribute Table.popularityScore not found for type Table\n\tat org.apache.atlas.discovery.SearchContext.validateAttributes(SearchContext.java:288) ``` Reference to JIRA https://issues.apache.org/jira/browse/ATLAS-3776 Diffs - repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 1a7bf6b16 Diff: https://reviews.apache.org/r/72459/diff/1/ Testing --- tested on our dev env. File Attachments (updated) ATLAS-3776-1.patch https://reviews.apache.org/media/uploaded/files/2020/05/05/96de2792-c75b-4440-8368-8791be7b005f__ATLAS-3776-1.patch Thanks, Damian Warszawski

Re: Review Request 72441: Support solr in standalone (http) mode

2020-05-19 Thread Damian Warszawski
tch. - Damian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72441/#review220661 --- On May 19, 2020, 10:02 p.m., Damian W

Re: Review Request 72441: Support solr in standalone (http) mode

2020-05-19 Thread Damian Warszawski
/Solr6Index.java 484c161f0 Diff: https://reviews.apache.org/r/72441/diff/2/ Changes: https://reviews.apache.org/r/72441/diff/1-2/ Testing --- Patch was applied and verified on our dev env with embedded solr and external hbase. Thanks, Damian Warszawski

Re: Review Request 72441: Support solr in standalone (http) mode

2020-05-25 Thread Damian Warszawski
Diff: https://reviews.apache.org/r/72441/diff/3/ Changes: https://reviews.apache.org/r/72441/diff/2-3/ Testing --- Patch was applied and verified on our dev env with embedded solr and external hbase. Thanks, Damian Warszawski

Re: Review Request 72441: Support solr in standalone (http) mode

2020-05-26 Thread Damian Warszawski
/Solr6Index.java 484c161f0 Diff: https://reviews.apache.org/r/72441/diff/4/ Changes: https://reviews.apache.org/r/72441/diff/3-4/ Testing --- Patch was applied and verified on our dev env with embedded solr and external hbase. Thanks, Damian Warszawski

Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-20 Thread Damian Warszawski
: https://reviews.apache.org/r/72695/diff/1/ Testing --- Not possible to reproduce the error on local machine. Enable locking on our dev env and have not introduce any regression. Thanks, Damian Warszawski

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-29 Thread Damian Warszawski
gt; AtlasDiscoveryServiceTest.query_entity_entityFilter_tag_tagFilter:260 > expected [true] but found [false] > AtlasDiscoveryServiceTest.query_entity_tag:289 expected [true] but found > [false] > AtlasDiscoveryServiceTest.query_entity_tag_tagFilter:275 expected [true] > but foun

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-25 Thread Damian Warszawski
env and have not introduce any regression. Thanks, Damian Warszawski

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-29 Thread Damian Warszawski
it: https://reviews.apache.org/r/72695/#review221401 --- On July 25, 2020, 8:53 p.m., Damian Warszawski wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-24 Thread Damian Warszawski
. Thanks, Damian Warszawski

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-24 Thread Damian Warszawski
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221297 --- On July 24, 2020, 8:23 a.m., Damian Warszawski wrote: > > ---

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-24 Thread Damian Warszawski
ps://reviews.apache.org/r/72695/#review221323 ------- On July 24, 2020, 8:23 a.m., Damian Warszawski wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-24 Thread Damian Warszawski
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221338 --- On July 24, 2020, 8:23 a.m., Damian Warszawski wrote: > > --

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-24 Thread Damian Warszawski
t; I suggest use AtlasConfiguration for this. Also, I think this should be > > true by default. > > Damian Warszawski wrote: > Great simplification. Thanks Ashutosh. Not sure if that should be true by default as long as not having a proper be

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-30 Thread Damian Warszawski
/ Changes: https://reviews.apache.org/r/72695/diff/3-4/ Testing --- Not possible to reproduce the error on local machine. Enable locking on our dev env and have not introduce any regression. Thanks, Damian Warszawski

[jira] [Created] (ATLAS-3654) Support solr in standalone (http) mode

2020-03-05 Thread Damian Warszawski (Jira)
Damian Warszawski created ATLAS-3654: Summary: Support solr in standalone (http) mode Key: ATLAS-3654 URL: https://issues.apache.org/jira/browse/ATLAS-3654 Project: Atlas Issue Type

[jira] [Updated] (ATLAS-3654) Support solr in standalone (http) mode

2020-03-05 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Warszawski updated ATLAS-3654: - Attachment: ATLAS-3654.patch > Support solr in standalone (http) m

[jira] [Updated] (ATLAS-3654) Support solr in standalone (http) mode

2020-03-05 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Warszawski updated ATLAS-3654: - External issue URL: https://github.com/apache/atlas/pull/90 > Support solr in standal

[jira] [Updated] (ATLAS-3654) Support solr in standalone (http) mode

2020-03-05 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Warszawski updated ATLAS-3654: - Attachment: (was: ATLAS-3654.patch) > Support solr in standalone (http) m

[jira] [Updated] (ATLAS-3654) Support solr in standalone (http) mode

2020-03-05 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Warszawski updated ATLAS-3654: - Attachment: ATLAS-3654.patch > Support solr in standalone (http) m

[jira] [Created] (ATLAS-3760) Optimize FreeTextSearchProcessor to apply exclude deleted entity filter on solr side.

2020-04-28 Thread Damian Warszawski (Jira)
Damian Warszawski created ATLAS-3760: Summary: Optimize FreeTextSearchProcessor to apply exclude deleted entity filter on solr side. Key: ATLAS-3760 URL: https://issues.apache.org/jira/browse/ATLAS-3760

[jira] [Updated] (ATLAS-3654) Support solr in standalone (http) mode

2020-04-27 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Warszawski updated ATLAS-3654: - Attachment: ATLAS-3654.patch > Support solr in standalone (http) m

[jira] [Updated] (ATLAS-3758) Support sort params for FreeTextSearchProcessor

2020-04-27 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Warszawski updated ATLAS-3758: - Description: *Problem description* No way to sort results by specified attribute while

[jira] [Updated] (ATLAS-3654) Support solr in standalone (http) mode

2020-04-27 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Warszawski updated ATLAS-3654: - Attachment: (was: ATLAS-3654.patch) > Support solr in standalone (http) m

[jira] [Created] (ATLAS-3758) Support sort params for FreeTextSearchProcessor

2020-04-27 Thread Damian Warszawski (Jira)
Damian Warszawski created ATLAS-3758: Summary: Support sort params for FreeTextSearchProcessor Key: ATLAS-3758 URL: https://issues.apache.org/jira/browse/ATLAS-3758 Project: Atlas Issue

[jira] [Updated] (ATLAS-3758) Support sort params for FreeTextSearchProcessor

2020-04-27 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Warszawski updated ATLAS-3758: - Attachment: ATLAS-3758.patch > Support sort params for FreeTextSearchProces

[jira] [Updated] (ATLAS-3760) Optimize FreeTextSearchProcessor to apply exclude deleted entity filter on solr side.

2020-04-28 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Warszawski updated ATLAS-3760: - Description: *Problem description* Current implementation of FreeTextSearchProcessor

[jira] [Comment Edited] (ATLAS-3654) Support solr in standalone (http) mode

2020-04-29 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095892#comment-17095892 ] Damian Warszawski edited comment on ATLAS-3654 at 4/29/20, 9:09 PM

[jira] [Commented] (ATLAS-3654) Support solr in standalone (http) mode

2020-04-29 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095892#comment-17095892 ] Damian Warszawski commented on ATLAS-3654: -- it is controlled with following application property

[jira] [Comment Edited] (ATLAS-3654) Support solr in standalone (http) mode

2020-04-29 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095892#comment-17095892 ] Damian Warszawski edited comment on ATLAS-3654 at 4/29/20, 9:10 PM

[jira] [Commented] (ATLAS-3760) Optimize FreeTextSearchProcessor to apply exclude deleted entity filter on solr side.

2020-04-29 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095884#comment-17095884 ] Damian Warszawski commented on ATLAS-3760: -- [~madhan] thanks for getting this done so quickly

[jira] [Created] (ATLAS-3776) graph query fails when orderBy attribute is specified

2020-05-01 Thread Damian Warszawski (Jira)
Damian Warszawski created ATLAS-3776: Summary: graph query fails when orderBy attribute is specified Key: ATLAS-3776 URL: https://issues.apache.org/jira/browse/ATLAS-3776 Project: Atlas

[jira] [Updated] (ATLAS-3776) graph query fails when orderBy attribute is specified

2020-05-01 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Warszawski updated ATLAS-3776: - Description: EntitySearchProcessor fails when doing search by classification and specify

[jira] [Closed] (ATLAS-3758) Support sort params for FreeTextSearchProcessor

2020-05-14 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Warszawski closed ATLAS-3758. Fixed and merged. > Support sort params for FreeTextSearchProces

[jira] [Closed] (ATLAS-3760) Optimize FreeTextSearchProcessor to apply exclude deleted entity filter on solr side.

2020-05-14 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Warszawski closed ATLAS-3760. Fixed and merged > Optimize FreeTextSearchProcessor to apply exclude deleted entity fil

[jira] [Closed] (ATLAS-3776) graph query fails when orderBy attribute is specified

2020-05-14 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Warszawski closed ATLAS-3776. fixed and merged. > graph query fails when orderBy attribute is specif

[jira] [Closed] (ATLAS-3654) Support solr in standalone (http) mode

2020-05-27 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Warszawski closed ATLAS-3654. fixed and merged > Support solr in standalone (http) m

[jira] [Commented] (ATLAS-3758) Support sort params for FreeTextSearchProcessor

2020-06-01 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121023#comment-17121023 ] Damian Warszawski commented on ATLAS-3758: -- thx for update > Support sort par

[jira] [Commented] (ATLAS-3398) Duplicates for unique attributes

2020-07-31 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169160#comment-17169160 ] Damian Warszawski commented on ATLAS-3398: -- Thanks [~amestry]. Of course, I don't mind

[jira] [Commented] (ATLAS-3398) Duplicates for unique attributes

2020-07-20 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17161569#comment-17161569 ] Damian Warszawski commented on ATLAS-3398: -- Optional configuration to support locks

[jira] [Commented] (ATLAS-3398) Duplicates for unique attributes

2020-07-21 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17161884#comment-17161884 ] Damian Warszawski commented on ATLAS-3398: -- According to our observations that can be a race

[jira] [Commented] (ATLAS-3398) Duplicates for unique attributes

2020-07-30 Thread Damian Warszawski (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168268#comment-17168268 ] Damian Warszawski commented on ATLAS-3398: -- [~mad...@apache.org], [~amestry]  uploaded another