Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61526/ --- (Updated Sept. 13, 2017, 1:38 p.m.) Review request for atlas, Graham Wallis,

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61526/#review185236 ---

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61526/#review185201 ---

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

> On Sept. 8, 2017, 6:34 p.m., Apoorv Naik wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java > > Lines 450 (patched) > > > > > > return type void for a get method ? > > > > Doesn't

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

> On Sept. 1, 2017, 8:18 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java > > Lines 99 (patched) > > > > > > I think we should treat classification's empty entity-type to mean

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61526/ --- (Updated Sept. 12, 2017, 12:09 p.m.) Review request for atlas, Graham Wallis,

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61526/#review184993 --- intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

> On Sept. 1, 2017, 8:18 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > > Lines 394 (patched) > > > > > > With the changes suggested in resolveReferences(),

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

> On Sept. 1, 2017, 6:54 p.m., Sarath Subramanian wrote: > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java > > Lines 181 (patched) > > > > > > NPE here when 's' is null. Consider

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61526/#review184373 --- intg/src/main/java/org/apache/atlas/AtlasErrorCode.java Lines 99

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61526/#review184375 --- intg/src/main/java/org/apache/atlas/AtlasErrorCode.java Lines

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

> On Aug. 20, 2017, 6:56 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > > Lines 742 (patched) > > > > > > Ensure that references are

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61526/ --- (Updated Sept. 1, 2017, 9:50 a.m.) Review request for atlas, Graham Wallis,

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

> On Aug. 20, 2017, 6:56 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > > Lines 742 (patched) > > > > > > Ensure that references are

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

> On Aug. 20, 2017, 6:56 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > > Lines 54 (patched) > > > > > > >> we need to store the entityTypes specified in our

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

> On Aug. 20, 2017, 6:56 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > > Lines 54 (patched) > > > > > > >> we need to store the entityTypes specified in our

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

> On Aug. 20, 2017, 6:56 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > > Lines 386 (patched) > > > > > > blocks between #387 and #392 can be folded into a

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61526/#review183296 ---

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

> On Aug. 17, 2017, 5:54 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java > > Lines 176 (patched) > > > > > > Classes in 'org.apache.atlas.model' are

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61526/#review183142 ---