Re: Review Request 66374: ATLAS-2526: misc model updates

2018-04-12 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66374/#review201037
---


Ship it!




Ship It!

- Sarath Subramanian


On April 12, 2018, 12:49 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66374/
> ---
> 
> (Updated April 12, 2018, 12:49 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2526
> https://issues.apache.org/jira/browse/ATLAS-2526
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - fixed incorrect syntax/braces in 0120-Collections.json that resulted in 
> relationshipDefs not to be loaded
> - renamed sourceToProcesses as inputToProcess and sinkFromProcesses as 
> outputFromProcess
> - added terms and categories as direct attributes of Glossary
> - added anchor, parentCategory and childrenCategories as direct attributes of 
> GlossaryCategory
> - added anchor as direct attribute of GlossaryTerm
> 
> 
> Diffs
> -
> 
>   addons/models/-Area0/0010-base_model.json aebe955db 
> 
> 
> Diff: https://reviews.apache.org/r/66374/diff/2/
> 
> 
> Testing
> ---
> 
> Verified Atlas server starts up successfully with updated models
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 66374: ATLAS-2526: misc model updates

2018-04-12 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66374/
---

(Updated April 12, 2018, 7:49 p.m.)


Review request for atlas.


Changes
---

updated the patch for removal of model files in ATLAS-2527


Bugs: ATLAS-2526
https://issues.apache.org/jira/browse/ATLAS-2526


Repository: atlas


Description
---

- fixed incorrect syntax/braces in 0120-Collections.json that resulted in 
relationshipDefs not to be loaded
- renamed sourceToProcesses as inputToProcess and sinkFromProcesses as 
outputFromProcess
- added terms and categories as direct attributes of Glossary
- added anchor, parentCategory and childrenCategories as direct attributes of 
GlossaryCategory
- added anchor as direct attribute of GlossaryTerm


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json aebe955db 


Diff: https://reviews.apache.org/r/66374/diff/2/

Changes: https://reviews.apache.org/r/66374/diff/1-2/


Testing
---

Verified Atlas server starts up successfully with updated models


Thanks,

Madhan Neethiraj

Re: Review Request 66374: ATLAS-2526: misc model updates

2018-04-01 Thread Mandy Chessell 


> On March 30, 2018, 12:39 p.m., Mandy Chessell wrote:
> > The open metadata model files will be deleted before we ship v1.0.  Could 
> > be in this Jira, or another one.
> 
> Madhan Neethiraj wrote:
> The plan was to move this model files from the current location to 
> another library in Apache Atlas. These types (Glossary, GlossaryTerm and 
> GlossaryCategory) will still be part of Apache Atlas, right?

There are still TypeDefs for Glossary, GlossaryTerm and GlossaryCategory in the 
open metadata types archive.  These files changed in this JIRA are obsolete and 
cause problems when we are testing open metadata with Atlas because they cause 
duplicate types.  As David has pointed out, the proposed changes in this Jira 
are not compatible with the open metadata definitions that use pure 
relationships and no legacy attribute entries in the EntityDef.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66374/#review200233
---


On March 30, 2018, 8:16 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66374/
> ---
> 
> (Updated March 30, 2018, 8:16 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2526
> https://issues.apache.org/jira/browse/ATLAS-2526
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - fixed incorrect syntax/braces in 0120-Collections.json that resulted in 
> relationshipDefs not to be loaded
> - renamed sourceToProcesses as inputToProcess and sinkFromProcesses as 
> outputFromProcess
> - added terms and categories as direct attributes of Glossary
> - added anchor, parentCategory and childrenCategories as direct attributes of 
> GlossaryCategory
> - added anchor as direct attribute of GlossaryTerm
> 
> 
> Diffs
> -
> 
>   addons/models/-Area0/0010-base_model.json aebe955d 
>   addons/models/0100-Area1-Collaboration/0120-Collections.json 4dbd2adb 
>   addons/models/0300-Area3-SubjectArea/0310-Glossary.json cac2ce2a 
>   addons/models/0300-Area3-SubjectArea/0320-CategoryHierarchy.json 10637970 
>   addons/models/0300-Area3-SubjectArea/0330-Terms.json f492ddfd 
> 
> 
> Diff: https://reviews.apache.org/r/66374/diff/1/
> 
> 
> Testing
> ---
> 
> Verified Atlas server starts up successfully with updated models
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 66374: ATLAS-2526: misc model updates

2018-03-31 Thread Madhan Neethiraj 


> On March 30, 2018, 12:39 p.m., Mandy Chessell wrote:
> > The open metadata model files will be deleted before we ship v1.0.  Could 
> > be in this Jira, or another one.

The plan was to move this model files from the current location to another 
library in Apache Atlas. These types (Glossary, GlossaryTerm and 
GlossaryCategory) will still be part of Apache Atlas, right?


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66374/#review200233
---


On March 30, 2018, 8:16 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66374/
> ---
> 
> (Updated March 30, 2018, 8:16 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2526
> https://issues.apache.org/jira/browse/ATLAS-2526
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - fixed incorrect syntax/braces in 0120-Collections.json that resulted in 
> relationshipDefs not to be loaded
> - renamed sourceToProcesses as inputToProcess and sinkFromProcesses as 
> outputFromProcess
> - added terms and categories as direct attributes of Glossary
> - added anchor, parentCategory and childrenCategories as direct attributes of 
> GlossaryCategory
> - added anchor as direct attribute of GlossaryTerm
> 
> 
> Diffs
> -
> 
>   addons/models/-Area0/0010-base_model.json aebe955d 
>   addons/models/0100-Area1-Collaboration/0120-Collections.json 4dbd2adb 
>   addons/models/0300-Area3-SubjectArea/0310-Glossary.json cac2ce2a 
>   addons/models/0300-Area3-SubjectArea/0320-CategoryHierarchy.json 10637970 
>   addons/models/0300-Area3-SubjectArea/0330-Terms.json f492ddfd 
> 
> 
> Diff: https://reviews.apache.org/r/66374/diff/1/
> 
> 
> Testing
> ---
> 
> Verified Atlas server starts up successfully with updated models
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 66374: ATLAS-2526: misc model updates

2018-03-30 Thread Madhan Neethiraj 


> On March 30, 2018, 9:47 a.m., David Radley wrote:
> > addons/models/-Area0/0010-base_model.json
> > Line 205 (original), 205 (patched)
> > 
> >
> > I suggest there may be migration implications to renaming these base 
> > types. I suggest versioning this change.

Relationships 'dataset_process_inputs' and 'process_dataset_outputs' were 
introduced only in master branch in 1.0. Renaming ends of these relationships 
won't impact migration from earlier version.


> On March 30, 2018, 9:47 a.m., David Radley wrote:
> > addons/models/0300-Area3-SubjectArea/0310-Glossary.json
> > Lines 89 (patched)
> > 
> >
> > I thought that we were thinking of these constraints as legacy and had 
> > assumed that we would not be adding any new ones. Doesn't the owned 
> > constraint imply that this is a one directional relationship, but the 
> > relationship definition is bidirectional. 
> > 
> > What does it mean that there is an attribute that uses the contraint 
> > but is not marked as legacy?
> > 
> > I am wondering what we gain by adding the attribute in this way?

- Without mandatory attribute 'anchor', terms and categories can exist without 
being associated with a glossary. This is incorrect.
- Current relationship model doesn't allow to mark a relationship attribute as 
manadatory. In fact allowing such constraint on relationships will make it 
difficult/impossible to build clients that deal with CRUD of entities in such 
relationships, as they need to be updated whenever a new mandatory relationship 
attribute is introduced later.
- From modelling point of view, attributes like 'anchor' and 'parent' are 
integral part of Term and Category; and these shouldn't have to be injected via 
relationship


> On March 30, 2018, 9:47 a.m., David Radley wrote:
> > addons/models/0300-Area3-SubjectArea/0320-CategoryHierarchy.json
> > Lines 32 (patched)
> > 
> >
> > I wonder why we are adding legacy attributes. I can see it gives us a 
> > manditory parent; I thought the relationship design was such that we were 
> > dropping this capability.

The field name 'legacy' is unfortunate (I think you pointed this earlier when 
this was introduced). It is meant to convey if the entity at this relationship 
end has an attribute that represents this end.


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66374/#review200231
---


On March 30, 2018, 8:16 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66374/
> ---
> 
> (Updated March 30, 2018, 8:16 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2526
> https://issues.apache.org/jira/browse/ATLAS-2526
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - fixed incorrect syntax/braces in 0120-Collections.json that resulted in 
> relationshipDefs not to be loaded
> - renamed sourceToProcesses as inputToProcess and sinkFromProcesses as 
> outputFromProcess
> - added terms and categories as direct attributes of Glossary
> - added anchor, parentCategory and childrenCategories as direct attributes of 
> GlossaryCategory
> - added anchor as direct attribute of GlossaryTerm
> 
> 
> Diffs
> -
> 
>   addons/models/-Area0/0010-base_model.json aebe955d 
>   addons/models/0100-Area1-Collaboration/0120-Collections.json 4dbd2adb 
>   addons/models/0300-Area3-SubjectArea/0310-Glossary.json cac2ce2a 
>   addons/models/0300-Area3-SubjectArea/0320-CategoryHierarchy.json 10637970 
>   addons/models/0300-Area3-SubjectArea/0330-Terms.json f492ddfd 
> 
> 
> Diff: https://reviews.apache.org/r/66374/diff/1/
> 
> 
> Testing
> ---
> 
> Verified Atlas server starts up successfully with updated models
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 66374: ATLAS-2526: misc model updates

2018-03-30 Thread Mandy Chessell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66374/#review200233
---



The open metadata model files will be deleted before we ship v1.0.  Could be in 
this Jira, or another one.

- Mandy Chessell


On March 30, 2018, 8:16 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66374/
> ---
> 
> (Updated March 30, 2018, 8:16 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2526
> https://issues.apache.org/jira/browse/ATLAS-2526
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - fixed incorrect syntax/braces in 0120-Collections.json that resulted in 
> relationshipDefs not to be loaded
> - renamed sourceToProcesses as inputToProcess and sinkFromProcesses as 
> outputFromProcess
> - added terms and categories as direct attributes of Glossary
> - added anchor, parentCategory and childrenCategories as direct attributes of 
> GlossaryCategory
> - added anchor as direct attribute of GlossaryTerm
> 
> 
> Diffs
> -
> 
>   addons/models/-Area0/0010-base_model.json aebe955d 
>   addons/models/0100-Area1-Collaboration/0120-Collections.json 4dbd2adb 
>   addons/models/0300-Area3-SubjectArea/0310-Glossary.json cac2ce2a 
>   addons/models/0300-Area3-SubjectArea/0320-CategoryHierarchy.json 10637970 
>   addons/models/0300-Area3-SubjectArea/0330-Terms.json f492ddfd 
> 
> 
> Diff: https://reviews.apache.org/r/66374/diff/1/
> 
> 
> Testing
> ---
> 
> Verified Atlas server starts up successfully with updated models
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 66374: ATLAS-2526: misc model updates

2018-03-30 Thread David Radley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66374/#review200231
---




addons/models/-Area0/0010-base_model.json
Line 205 (original), 205 (patched)


I suggest there may be migration implications to renaming these base types. 
I suggest versioning this change.



addons/models/0300-Area3-SubjectArea/0310-Glossary.json
Lines 89 (patched)


I thought that we were thinking of these constraints as legacy and had 
assumed that we would not be adding any new ones. Doesn't the owned constraint 
imply that this is a one directional relationship, but the relationship 
definition is bidirectional. 

What does it mean that there is an attribute that uses the contraint but is 
not marked as legacy?

I am wondering what we gain by adding the attribute in this way?



addons/models/0300-Area3-SubjectArea/0320-CategoryHierarchy.json
Lines 32 (patched)


I wonder why we are adding legacy attributes. I can see it gives us a 
manditory parent; I thought the relationship design was such that we were 
dropping this capability.


- David Radley


On March 30, 2018, 8:16 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66374/
> ---
> 
> (Updated March 30, 2018, 8:16 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2526
> https://issues.apache.org/jira/browse/ATLAS-2526
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - fixed incorrect syntax/braces in 0120-Collections.json that resulted in 
> relationshipDefs not to be loaded
> - renamed sourceToProcesses as inputToProcess and sinkFromProcesses as 
> outputFromProcess
> - added terms and categories as direct attributes of Glossary
> - added anchor, parentCategory and childrenCategories as direct attributes of 
> GlossaryCategory
> - added anchor as direct attribute of GlossaryTerm
> 
> 
> Diffs
> -
> 
>   addons/models/-Area0/0010-base_model.json aebe955d 
>   addons/models/0100-Area1-Collaboration/0120-Collections.json 4dbd2adb 
>   addons/models/0300-Area3-SubjectArea/0310-Glossary.json cac2ce2a 
>   addons/models/0300-Area3-SubjectArea/0320-CategoryHierarchy.json 10637970 
>   addons/models/0300-Area3-SubjectArea/0330-Terms.json f492ddfd 
> 
> 
> Diff: https://reviews.apache.org/r/66374/diff/1/
> 
> 
> Testing
> ---
> 
> Verified Atlas server starts up successfully with updated models
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>