Re: Review Request 61552: ATLAS-2038 : Unit Test cases for AtlasAuthentication and Authorization Filter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61552/#review183352 --- Ship it! Ship It! - Ashutosh Mestry On Aug. 11, 2017, 4:25 p.m., Nixon Rodrigues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61552/ > --- > > (Updated Aug. 11, 2017, 4:25 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-2038 > https://issues.apache.org/jira/browse/ATLAS-2038 > > > Repository: atlas > > > Description > --- > > This patch enable the Unittest from this testclass and includes unit test > cases for testing Authentication and Authorization Filters which can fail if > any regression is introduced in this Filters and authentication/authorization > process. ( eg bugs ATLAS-2009). > > > Diffs > - > > > webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterIT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterTest.java > 389eefe > > > Diff: https://reviews.apache.org/r/61552/diff/2/ > > > Testing > --- > > Excecuted unit and Integration test from mvn clean install > > > Thanks, > > Nixon Rodrigues > >
Re: Review Request 61552: ATLAS-2038 : Unit Test cases for AtlasAuthentication and Authorization Filter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61552/#review182810 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 11, 2017, 4:25 p.m., Nixon Rodrigues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61552/ > --- > > (Updated Aug. 11, 2017, 4:25 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-2038 > https://issues.apache.org/jira/browse/ATLAS-2038 > > > Repository: atlas > > > Description > --- > > This patch enable the Unittest from this testclass and includes unit test > cases for testing Authentication and Authorization Filters which can fail if > any regression is introduced in this Filters and authentication/authorization > process. ( eg bugs ATLAS-2009). > > > Diffs > - > > > webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterIT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterTest.java > 389eefe > > > Diff: https://reviews.apache.org/r/61552/diff/2/ > > > Testing > --- > > Excecuted unit and Integration test from mvn clean install > > > Thanks, > > Nixon Rodrigues > >
Re: Review Request 61552: ATLAS-2038 : Unit Test cases for AtlasAuthentication and Authorization Filter
> On Aug. 10, 2017, 2:19 p.m., Apoorv Naik wrote: > > Looks good overall. Is this an IT or UT ? This should be under IT I > > believe, that would eliminate the need of starting the server. Make sense tobe IT instead UT - Nixon --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61552/#review182587 --- On Aug. 10, 2017, 11:20 a.m., Nixon Rodrigues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61552/ > --- > > (Updated Aug. 10, 2017, 11:20 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-2038 > https://issues.apache.org/jira/browse/ATLAS-2038 > > > Repository: atlas > > > Description > --- > > This patch enable the Unittest from this testclass and includes unit test > cases for testing Authentication and Authorization Filters which can fail if > any regression is introduced in this Filters and authentication/authorization > process. ( eg bugs ATLAS-2009). > > > Diffs > - > > > webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterTest.java > 389eefe > webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java > ad87025 > > > Diff: https://reviews.apache.org/r/61552/diff/1/ > > > Testing > --- > > Excecuted unit and Integration test from mvn clean install > > > Thanks, > > Nixon Rodrigues > >
Re: Review Request 61552: ATLAS-2038 : Unit Test cases for AtlasAuthentication and Authorization Filter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61552/ --- (Updated Aug. 11, 2017, 4:25 p.m.) Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian. Changes --- This patch handles review comment from Apoorv to make it IT instead UT. Bugs: ATLAS-2038 https://issues.apache.org/jira/browse/ATLAS-2038 Repository: atlas Description --- This patch enable the Unittest from this testclass and includes unit test cases for testing Authentication and Authorization Filters which can fail if any regression is introduced in this Filters and authentication/authorization process. ( eg bugs ATLAS-2009). Diffs (updated) - webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterIT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterTest.java 389eefe Diff: https://reviews.apache.org/r/61552/diff/2/ Changes: https://reviews.apache.org/r/61552/diff/1-2/ Testing --- Excecuted unit and Integration test from mvn clean install Thanks, Nixon Rodrigues
Re: Review Request 61552: ATLAS-2038 : Unit Test cases for AtlasAuthentication and Authorization Filter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61552/#review182587 --- Looks good overall. Is this an IT or UT ? This should be under IT I believe, that would eliminate the need of starting the server. - Apoorv Naik On Aug. 10, 2017, 11:20 a.m., Nixon Rodrigues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61552/ > --- > > (Updated Aug. 10, 2017, 11:20 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-2038 > https://issues.apache.org/jira/browse/ATLAS-2038 > > > Repository: atlas > > > Description > --- > > This patch enable the Unittest from this testclass and includes unit test > cases for testing Authentication and Authorization Filters which can fail if > any regression is introduced in this Filters and authentication/authorization > process. ( eg bugs ATLAS-2009). > > > Diffs > - > > > webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterTest.java > 389eefe > webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java > ad87025 > > > Diff: https://reviews.apache.org/r/61552/diff/1/ > > > Testing > --- > > Excecuted unit and Integration test from mvn clean install > > > Thanks, > > Nixon Rodrigues > >
Review Request 61552: ATLAS-2038 : Unit Test cases for AtlasAuthentication and Authorization Filter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61552/ --- Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian. Bugs: ATLAS-2038 https://issues.apache.org/jira/browse/ATLAS-2038 Repository: atlas Description --- This patch enable the Unittest from this testclass and includes unit test cases for testing Authentication and Authorization Filters which can fail if any regression is introduced in this Filters and authentication/authorization process. ( eg bugs ATLAS-2009). Diffs - webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterTest.java 389eefe webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java ad87025 Diff: https://reviews.apache.org/r/61552/diff/1/ Testing --- Excecuted unit and Integration test from mvn clean install Thanks, Nixon Rodrigues
