Re: Review Request 72458: Shadow Attributes Update Post-Migration from 0.8

2020-05-01 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72458/#review220583
---


Ship it!




Ship It!

- Sarath Subramanian


On May 1, 2020, 10:18 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72458/
> ---
> 
> (Updated May 1, 2020, 10:18 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3773
> https://issues.apache.org/jira/browse/ATLAS-3773
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> Please refer to JIRA for details.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatch.java
>  2b5811919 
> 
> 
> Diff: https://reviews.apache.org/r/72458/diff/3/
> 
> 
> Testing
> ---
> 
> **Manual verification**
> Steps:
> - Imported dataset from 0.8 using migration import.
> - Let the patch handlers run.
> - Verified DSL queries and basic search functionality.
> 
> **Pre-commit**
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1862/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 72458: Shadow Attributes Update Post-Migration from 0.8

2020-05-01 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72458/#review220582
---


Ship it!




Ship It!

- Madhan Neethiraj


On May 1, 2020, 5:18 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72458/
> ---
> 
> (Updated May 1, 2020, 5:18 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3773
> https://issues.apache.org/jira/browse/ATLAS-3773
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> Please refer to JIRA for details.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatch.java
>  2b5811919 
> 
> 
> Diff: https://reviews.apache.org/r/72458/diff/3/
> 
> 
> Testing
> ---
> 
> **Manual verification**
> Steps:
> - Imported dataset from 0.8 using migration import.
> - Let the patch handlers run.
> - Verified DSL queries and basic search functionality.
> 
> **Pre-commit**
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1862/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 72458: Shadow Attributes Update Post-Migration from 0.8

2020-05-01 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72458/
---

(Updated May 1, 2020, 5:18 p.m.)


Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and 
Sarath Subramanian.


Changes
---

Updates include: Addressed review comments.


Bugs: ATLAS-3773
https://issues.apache.org/jira/browse/ATLAS-3773


Repository: atlas


Description
---

**Approach**
Please refer to JIRA for details.


Diffs (updated)
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
 6986ba176 
  
repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatch.java
 2b5811919 


Diff: https://reviews.apache.org/r/72458/diff/2/

Changes: https://reviews.apache.org/r/72458/diff/1-2/


Testing
---

**Manual verification**
Steps:
- Imported dataset from 0.8 using migration import.
- Let the patch handlers run.
- Verified DSL queries and basic search functionality.

**Pre-commit**
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1862/


Thanks,

Ashutosh Mestry

Re: Review Request 72458: Shadow Attributes Update Post-Migration from 0.8

2020-05-01 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72458/#review220580
---


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatch.java
Lines 162 (patched)


for clarity, I suggest the following:

   void processIndexStringAttributes(AtlasVertex vertex, AtlasEntityType 
entityType) {
 for (AtlasAttribute attribute : 
entityType.getAllAttributes().values()) {
if 
(AtlasAttributeDef.IndexType.STRING.equals(attribute.getIndexType()) {
  ...
}
 }
   }
   
   void processUniqueAttributes(AtlasVertex vertex, AtlasEntityType 
entityType) {
 for (AtlasAttribute attribute : 
entityType.getUniqAttributes().values()) {
   ..
 }
   }


- Madhan Neethiraj


On May 1, 2020, 4:31 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72458/
> ---
> 
> (Updated May 1, 2020, 4:31 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3773
> https://issues.apache.org/jira/browse/ATLAS-3773
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> Please refer to JIRA for details.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatch.java
>  2b5811919 
> 
> 
> Diff: https://reviews.apache.org/r/72458/diff/1/
> 
> 
> Testing
> ---
> 
> **Manual verification**
> Steps:
> - Imported dataset from 0.8 using migration import.
> - Let the patch handlers run.
> - Verified DSL queries and basic search functionality.
> 
> **Pre-commit**
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1862/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Review Request 72458: Shadow Attributes Update Post-Migration from 0.8

2020-04-30 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72458/
---

Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and 
Sarath Subramanian.


Bugs: ATLAS-3773
https://issues.apache.org/jira/browse/ATLAS-3773


Repository: atlas


Description
---

**Approach**
Please refer to JIRA for details.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatch.java
 2b5811919 


Diff: https://reviews.apache.org/r/72458/diff/1/


Testing
---

**Manual verification**
Steps:
- Imported dataset from 0.8 using migration import.
- Let the patch handlers run.
- Verified DSL queries and basic search functionality.

**Pre-commit**
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1862/


Thanks,

Ashutosh Mestry