[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1847:
-
Status: Patch Available (was: Open)
> IDL compiler uses ByteBuffer for decimal type even if logical type i
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1847:
-
Attachment: AVRO-1847.1.patch
> IDL compiler uses ByteBuffer for decimal type even if logical type is
> su
Yibing Shi created AVRO-1847:
Summary: IDL compiler uses ByteBuffer for decimal type even if
logical type is supported
Key: AVRO-1847
URL: https://issues.apache.org/jira/browse/AVRO-1847
Project: Avro
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290055#comment-15290055
]
Yibing Shi commented on AVRO-1847:
--
Hi [~rdblue], thanks for the guide! I will modify the
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1847:
-
Attachment: AVRO-1847.2.patch
[~rdblue], I have attached another patch that adds the missing parts mentione
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15309321#comment-15309321
]
Yibing Shi commented on AVRO-1847:
--
[~rdblue], could you please help have a look at the ne
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311336#comment-15311336
]
Yibing Shi commented on AVRO-1847:
--
Understood! Thanks for the response!
> IDL compiler u
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1847:
-
Attachment: AVRO-1847.3.patch
Attach another patch, which fixes the problem where classes generated by IDL
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1847:
-
Attachment: AVRO-1847.4.patch
Add another patch, which add the backward compatibility of logical type
supp
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328665#comment-15328665
]
Yibing Shi commented on AVRO-1847:
--
Agree. Will do that.
> IDL compiler uses ByteBuffer f
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328665#comment-15328665
]
Yibing Shi edited comment on AVRO-1847 at 6/14/16 1:18 PM:
---
Agree
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329494#comment-15329494
]
Yibing Shi commented on AVRO-1847:
--
The {{conver}} method is newly added by this patch. It
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329495#comment-15329495
]
Yibing Shi commented on AVRO-1847:
--
I have removed the passthrough behaviour in convert to
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329501#comment-15329501
]
Yibing Shi commented on AVRO-1847:
--
Since we always try to use Joda or Java classes for da
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329511#comment-15329511
]
Yibing Shi commented on AVRO-1847:
--
I didn't think of childrens of this class may need to
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329522#comment-15329522
]
Yibing Shi commented on AVRO-1847:
--
Same as above
> IDL compiler uses ByteBuffer for deci
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329521#comment-15329521
]
Yibing Shi commented on AVRO-1847:
--
As mentioned above, I don't think we need a separate f
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329515#comment-15329515
]
Yibing Shi commented on AVRO-1847:
--
Oops! Have corrected it.
> IDL compiler uses ByteBuff
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1847:
-
Attachment: AVRO-1847.5.patch
Upload the new patch that contains all the changes based on code review.
> I
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331268#comment-15331268
]
Yibing Shi commented on AVRO-1847:
--
# I will add javadoc to those public functions
# I wi
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331271#comment-15331271
]
Yibing Shi commented on AVRO-1847:
--
I had a very busy day. Will work on this tonight and u
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331759#comment-15331759
]
Yibing Shi commented on AVRO-1847:
--
Method {{GenericDatumWriter.convert}} is a protected m
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331268#comment-15331268
]
Yibing Shi edited comment on AVRO-1847 at 6/15/16 2:01 PM:
---
# I w
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1847:
-
Attachment: AVRO-1847.6.patch
Upload a new patch
> IDL compiler uses ByteBuffer for decimal type even if l
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1847:
-
Attachment: AVRO-1847.7.patch
Upload a new patch:
# Fixed all the javadoc errors pointed out by [~busbey]
#
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337884#comment-15337884
]
Yibing Shi commented on AVRO-1847:
--
Yes, I did add the test for UUID. It always use CharSe
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337885#comment-15337885
]
Yibing Shi commented on AVRO-1847:
--
Thank you very much for your help, [~busbey]!
[~rdblue
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1847:
-
Attachment: AVRO-1847.8.patch
I forgot to apply the decimal type flag to
{{SpecificCompiler.conversionInst
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346370#comment-15346370
]
Yibing Shi commented on AVRO-1847:
--
[~busbey] and [~rdblue], thank you for your help on th
[
https://issues.apache.org/jira/browse/AVRO-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352944#comment-15352944
]
Yibing Shi commented on AVRO-1869:
--
Thanks [~rdblue]!
> Decimal conversion from ByteBuffe
[
https://issues.apache.org/jira/browse/AVRO-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi reassigned AVRO-1811:
Assignee: Yibing Shi
> SpecificData.deepCopy() cannot be used if schema compiler generated Java
> o
[
https://issues.apache.org/jira/browse/AVRO-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360955#comment-15360955
]
Yibing Shi commented on AVRO-1811:
--
Hi [~rdblue], this problem may not be very easy. It ha
[
https://issues.apache.org/jira/browse/AVRO-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1811:
-
Attachment: AVRO-1811.1.patch
> SpecificData.deepCopy() cannot be used if schema compiler generated Java
>
[
https://issues.apache.org/jira/browse/AVRO-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1811:
-
Affects Version/s: 1.8.1
Status: Patch Available (was: Open)
> SpecificData.deepCopy() cann
[
https://issues.apache.org/jira/browse/AVRO-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361264#comment-15361264
]
Yibing Shi commented on AVRO-1811:
--
Hi [~rdblue], I have another consideration about this
[
https://issues.apache.org/jira/browse/AVRO-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362617#comment-15362617
]
Yibing Shi commented on AVRO-1811:
--
{quote}
What's the current behavior if we try to turn
Yibing Shi created AVRO-1877:
Summary: AVRO-1847 accidentally breaks javaUnbox method in
SpecificCompiler
Key: AVRO-1877
URL: https://issues.apache.org/jira/browse/AVRO-1877
Project: Avro
Issue
[
https://issues.apache.org/jira/browse/AVRO-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1877:
-
Hadoop Flags: (was: Incompatible change)
> AVRO-1847 accidentally breaks javaUnbox method in SpecificComp
[
https://issues.apache.org/jira/browse/AVRO-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1877:
-
Attachment: AVRO-1877.1.patch
> AVRO-1847 accidentally breaks javaUnbox method in SpecificCompiler
> --
[
https://issues.apache.org/jira/browse/AVRO-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1877:
-
Status: Patch Available (was: Open)
> AVRO-1847 accidentally breaks javaUnbox method in SpecificCompiler
>
[
https://issues.apache.org/jira/browse/AVRO-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367651#comment-15367651
]
Yibing Shi commented on AVRO-1877:
--
Hi [~rdblue], it was my fault. I accidentally deleted
[
https://issues.apache.org/jira/browse/AVRO-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367651#comment-15367651
]
Yibing Shi edited comment on AVRO-1877 at 7/8/16 1:14 PM:
--
Hi [~rd
[
https://issues.apache.org/jira/browse/AVRO-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369631#comment-15369631
]
Yibing Shi commented on AVRO-1877:
--
{quote}
The way you call javaType from javaUnbox in th
[
https://issues.apache.org/jira/browse/AVRO-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1877:
-
Attachment: AVRO-1877.2.patch
> AVRO-1847 accidentally breaks javaUnbox method in SpecificCompiler
> --
[
https://issues.apache.org/jira/browse/AVRO-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369646#comment-15369646
]
Yibing Shi commented on AVRO-1877:
--
[~mwong], I have uploaded another patch, but fixes the
[
https://issues.apache.org/jira/browse/AVRO-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369995#comment-15369995
]
Yibing Shi commented on AVRO-1877:
--
{quote}
Honestly, I like the old code better.
{quote}
[
https://issues.apache.org/jira/browse/AVRO-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369995#comment-15369995
]
Yibing Shi edited comment on AVRO-1877 at 7/10/16 11:29 PM:
{qu
[
https://issues.apache.org/jira/browse/AVRO-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1877:
-
Attachment: AVRO-1877.3.patch
Upload a new patch with code refactored
> AVRO-1847 accidentally breaks jav
Yibing Shi created AVRO-1883:
Summary: Schema validator cannot find broken backwards
compatibility in Union type elements
Key: AVRO-1883
URL: https://issues.apache.org/jira/browse/AVRO-1883
Project: Avro
[
https://issues.apache.org/jira/browse/AVRO-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1883:
-
Attachment: AVRO-1883.1.patch
> Schema validator cannot find broken backwards compatibility in Union type
[
https://issues.apache.org/jira/browse/AVRO-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1883:
-
Status: Patch Available (was: Open)
> Schema validator cannot find broken backwards compatibility in Union
[
https://issues.apache.org/jira/browse/AVRO-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi reassigned AVRO-1883:
Assignee: Yibing Shi
> Schema validator cannot find broken backwards compatibility in Union type
>
[
https://issues.apache.org/jira/browse/AVRO-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388623#comment-15388623
]
Yibing Shi commented on AVRO-1877:
--
Thanks for the tip, [~busbey]!
> AVRO-1847 accidental
[
https://issues.apache.org/jira/browse/AVRO-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398756#comment-15398756
]
Yibing Shi commented on AVRO-1817:
--
[~busbey], I am not sure whether this task is feasible
[
https://issues.apache.org/jira/browse/AVRO-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400569#comment-15400569
]
Yibing Shi commented on AVRO-1890:
--
[~ryonday], it is recommended to use record builder to
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405931#comment-15405931
]
Yibing Shi commented on AVRO-1891:
--
Had a quick look at this. The scope of this problem is
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405931#comment-15405931
]
Yibing Shi edited comment on AVRO-1891 at 8/3/16 1:46 PM:
--
Had a q
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405931#comment-15405931
]
Yibing Shi edited comment on AVRO-1891 at 8/3/16 1:52 PM:
--
Had a q
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406991#comment-15406991
]
Yibing Shi commented on AVRO-1891:
--
Hi [~rdblue], thanks for the reply!
I agree that we ne
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410947#comment-15410947
]
Yibing Shi commented on AVRO-1891:
--
Things can become even more complicated. AVRO supports
[
https://issues.apache.org/jira/browse/AVRO-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410949#comment-15410949
]
Yibing Shi commented on AVRO-1894:
--
How about add all the default conversions into {{Speci
[
https://issues.apache.org/jira/browse/AVRO-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410955#comment-15410955
]
Yibing Shi commented on AVRO-1895:
--
The workaround in AVRO-1891 may not help here. DeepCop
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411921#comment-15411921
]
Yibing Shi commented on AVRO-1891:
--
[~rdblue], [~busbey], could you please help confirm wh
[
https://issues.apache.org/jira/browse/AVRO-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432801#comment-15432801
]
Yibing Shi commented on AVRO-1901:
--
[~radai], are you trying to define an error in your ID
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453755#comment-15453755
]
Yibing Shi commented on AVRO-1891:
--
{quote}
We could do this by adding a constructor to Sp
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457575#comment-15457575
]
Yibing Shi commented on AVRO-1891:
--
{quote}
When resolveUnion is called there is no Specif
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1891:
-
Attachment: AVRO-1891.yshi.1.patch
> Generated Java code fails with union containing logical type
> ---
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1891:
-
Attachment: AVRO-1891.yshi.2.patch
Attach another patch that fixes the reading problems
> Generated Java c
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1891:
-
Attachment: AVRO-1891.yshi.3.patch
> Generated Java code fails with union containing logical type
> ---
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15460708#comment-15460708
]
Yibing Shi commented on AVRO-1891:
--
{quote}
although this has the effect of creating anoth
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15460722#comment-15460722
]
Yibing Shi commented on AVRO-1891:
--
{quote}
I don't see the advantage of adding Conversion
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15460903#comment-15460903
]
Yibing Shi commented on AVRO-1891:
--
I have another look into the code, and find that we mi
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15460908#comment-15460908
]
Yibing Shi commented on AVRO-1891:
--
Just found the {{defaultValue}} method I added has a b
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1891:
-
Attachment: AVRO-1891.yshi.4.patch
Upload a new patch that fixes the defaultValue bug and can be applied to
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15463713#comment-15463713
]
Yibing Shi commented on AVRO-1891:
--
[~rdblue], you idea looks good to me!
{quote}
Maintai
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15466040#comment-15466040
]
Yibing Shi commented on AVRO-1891:
--
The patch looks great, [~rdblue]!
I add a few comment
[
https://issues.apache.org/jira/browse/AVRO-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522012#comment-15522012
]
Yibing Shi commented on AVRO-1927:
--
[~asmaier], currently the generated code doesn't check
[
https://issues.apache.org/jira/browse/AVRO-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15688256#comment-15688256
]
Yibing Shi commented on AVRO-1961:
--
[~nielsbasjes], would you please provide more details
[
https://issues.apache.org/jira/browse/AVRO-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15688400#comment-15688400
]
Yibing Shi commented on AVRO-1962:
--
[~xiongtx], sorry for the misleading info in mail list
[
https://issues.apache.org/jira/browse/AVRO-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15713643#comment-15713643
]
Yibing Shi commented on AVRO-1961:
--
{quote}
Actually, on the setter/builder/constructor, w
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952612#comment-15952612
]
Yibing Shi commented on AVRO-1847:
--
[~vijayp...@gmail.com], I have no idea about the relea
81 matches
Mail list logo
