[jira] [Commented] (BAHIR-91) Upgrade bahir-flink to support Flink 1.2
[
https://issues.apache.org/jira/browse/BAHIR-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895730#comment-15895730
]
ASF subversion and git services commented on BAHIR-91:
--
Commit 3f180342ca0efaf48ffa4d1f7b6dbfcb4cd892b6 in bahir-flink's branch
refs/heads/master from [~tzulitai]
[ https://git-wip-us.apache.org/repos/asf?p=bahir-flink.git;h=3f18034 ]
[BAHIR-91] Upgrade Flink version to 1.2.0
This closes #11
This closes #9 (Closing PR due to inactivity)
> Upgrade bahir-flink to support Flink 1.2
>
>
> Key: BAHIR-91
> URL: https://issues.apache.org/jira/browse/BAHIR-91
> Project: Bahir
> Issue Type: New Feature
> Components: Flink Streaming Connectors
>Affects Versions: Flink-0.1
> Environment: Ubuntu Yakkety Yak
>Reporter: Markus Müller
>Assignee: Tzu-Li (Gordon) Tai
> Fix For: Flink-0.1
>
>
> After working around https://issues.apache.org/jira/browse/FLINK-4813 by
> specifying Flink version 1.3-SNAPSHOT instead of 1.2.0 in the bahir-flink pom
> file, I get the following compiler errors for the ActiveMQ connector:
> {code}
> ERROR]
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[32,33]
> error: cannot find symbol
> [ERROR] symbol: class ForkableFlinkMiniCluster
> location: package org.apache.flink.test.util
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[54,19]
> error: cannot find symbol
> [ERROR] symbol: class ForkableFlinkMiniCluster
> location: class ActiveMQConnectorITCase
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[66,20]
> error: cannot find symbol
> [ERROR] symbol: class ForkableFlinkMiniCluster
> location: class ActiveMQConnectorITCase
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[216,22]
> error: method snapshotState in class
> MessageAcknowledgingSourceBase cannot be applied to given types;
> [ERROR] required: FunctionSnapshotContext
> found: long,long
> reason: actual and formal argument lists differ in length
> where Type,UId are type-variables:
> Type extends Object declared in class MessageAcknowledgingSourceBase
> UId extends Object declared in class MessageAcknowledgingSourceBase
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[229,4]
> error: ActiveMQConnectorITCase.TestSourceContext is not abstract and does
> not override abstract method markAsTemporarilyIdle() in SourceContext
> Excluding ActiveMQ from compilation leads to the next issue in the
> Akka-Connector:
> [ERROR]
> /home/markus/src/bahir-flink/flink-connector-akka/src/test/java/org/apache/flink/streaming/connectors/akka/AkkaSourceTest.java:[210,17]
> error: DummySourceContext is not abstract and does not override abstract
> method markAsTemporarilyIdle() in SourceContext
> [INFO] 1 error
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (BAHIR-91) Upgrade bahir-flink to support Flink 1.2
[
https://issues.apache.org/jira/browse/BAHIR-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895731#comment-15895731
]
ASF GitHub Bot commented on BAHIR-91:
-
Github user asfgit closed the pull request at:
https://github.com/apache/bahir-flink/pull/11
> Upgrade bahir-flink to support Flink 1.2
>
>
> Key: BAHIR-91
> URL: https://issues.apache.org/jira/browse/BAHIR-91
> Project: Bahir
> Issue Type: New Feature
> Components: Flink Streaming Connectors
>Affects Versions: Flink-0.1
> Environment: Ubuntu Yakkety Yak
>Reporter: Markus Müller
>Assignee: Tzu-Li (Gordon) Tai
> Fix For: Flink-0.1
>
>
> After working around https://issues.apache.org/jira/browse/FLINK-4813 by
> specifying Flink version 1.3-SNAPSHOT instead of 1.2.0 in the bahir-flink pom
> file, I get the following compiler errors for the ActiveMQ connector:
> {code}
> ERROR]
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[32,33]
> error: cannot find symbol
> [ERROR] symbol: class ForkableFlinkMiniCluster
> location: package org.apache.flink.test.util
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[54,19]
> error: cannot find symbol
> [ERROR] symbol: class ForkableFlinkMiniCluster
> location: class ActiveMQConnectorITCase
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[66,20]
> error: cannot find symbol
> [ERROR] symbol: class ForkableFlinkMiniCluster
> location: class ActiveMQConnectorITCase
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[216,22]
> error: method snapshotState in class
> MessageAcknowledgingSourceBase cannot be applied to given types;
> [ERROR] required: FunctionSnapshotContext
> found: long,long
> reason: actual and formal argument lists differ in length
> where Type,UId are type-variables:
> Type extends Object declared in class MessageAcknowledgingSourceBase
> UId extends Object declared in class MessageAcknowledgingSourceBase
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[229,4]
> error: ActiveMQConnectorITCase.TestSourceContext is not abstract and does
> not override abstract method markAsTemporarilyIdle() in SourceContext
> Excluding ActiveMQ from compilation leads to the next issue in the
> Akka-Connector:
> [ERROR]
> /home/markus/src/bahir-flink/flink-connector-akka/src/test/java/org/apache/flink/streaming/connectors/akka/AkkaSourceTest.java:[210,17]
> error: DummySourceContext is not abstract and does not override abstract
> method markAsTemporarilyIdle() in SourceContext
> [INFO] 1 error
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (BAHIR-91) Upgrade bahir-flink to support Flink 1.2
[
https://issues.apache.org/jira/browse/BAHIR-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895727#comment-15895727
]
ASF GitHub Bot commented on BAHIR-91:
-
Github user rmetzger commented on the issue:
https://github.com/apache/bahir-flink/pull/11
Looks good. Merging change.
> Upgrade bahir-flink to support Flink 1.2
>
>
> Key: BAHIR-91
> URL: https://issues.apache.org/jira/browse/BAHIR-91
> Project: Bahir
> Issue Type: New Feature
> Components: Flink Streaming Connectors
>Affects Versions: Flink-0.1
> Environment: Ubuntu Yakkety Yak
>Reporter: Markus Müller
>Assignee: Tzu-Li (Gordon) Tai
> Fix For: Flink-0.1
>
>
> After working around https://issues.apache.org/jira/browse/FLINK-4813 by
> specifying Flink version 1.3-SNAPSHOT instead of 1.2.0 in the bahir-flink pom
> file, I get the following compiler errors for the ActiveMQ connector:
> {code}
> ERROR]
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[32,33]
> error: cannot find symbol
> [ERROR] symbol: class ForkableFlinkMiniCluster
> location: package org.apache.flink.test.util
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[54,19]
> error: cannot find symbol
> [ERROR] symbol: class ForkableFlinkMiniCluster
> location: class ActiveMQConnectorITCase
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[66,20]
> error: cannot find symbol
> [ERROR] symbol: class ForkableFlinkMiniCluster
> location: class ActiveMQConnectorITCase
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[216,22]
> error: method snapshotState in class
> MessageAcknowledgingSourceBase cannot be applied to given types;
> [ERROR] required: FunctionSnapshotContext
> found: long,long
> reason: actual and formal argument lists differ in length
> where Type,UId are type-variables:
> Type extends Object declared in class MessageAcknowledgingSourceBase
> UId extends Object declared in class MessageAcknowledgingSourceBase
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[229,4]
> error: ActiveMQConnectorITCase.TestSourceContext is not abstract and does
> not override abstract method markAsTemporarilyIdle() in SourceContext
> Excluding ActiveMQ from compilation leads to the next issue in the
> Akka-Connector:
> [ERROR]
> /home/markus/src/bahir-flink/flink-connector-akka/src/test/java/org/apache/flink/streaming/connectors/akka/AkkaSourceTest.java:[210,17]
> error: DummySourceContext is not abstract and does not override abstract
> method markAsTemporarilyIdle() in SourceContext
> [INFO] 1 error
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (BAHIR-91) Upgrade bahir-flink to support Flink 1.2
[ https://issues.apache.org/jira/browse/BAHIR-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891907#comment-15891907 ] ASF GitHub Bot commented on BAHIR-91: - Github user tzulitai commented on the issue: https://github.com/apache/bahir-flink/pull/11 Ah yes, I forgot about that. I'll change that to `1.2.0`. > Upgrade bahir-flink to support Flink 1.2 > > > Key: BAHIR-91 > URL: https://issues.apache.org/jira/browse/BAHIR-91 > Project: Bahir > Issue Type: New Feature > Components: Flink Streaming Connectors >Affects Versions: Flink-0.1 > Environment: Ubuntu Yakkety Yak >Reporter: Markus Müller > Fix For: Flink-0.1 > > > After working around https://issues.apache.org/jira/browse/FLINK-4813 by > specifying Flink version 1.3-SNAPSHOT instead of 1.2.0 in the bahir-flink pom > file, I get the following compiler errors for the ActiveMQ connector: > ERROR] > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[32,33] > error: cannot find symbol > [ERROR] symbol: class ForkableFlinkMiniCluster > location: package org.apache.flink.test.util > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[54,19] > error: cannot find symbol > [ERROR] symbol: class ForkableFlinkMiniCluster > location: class ActiveMQConnectorITCase > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[66,20] > error: cannot find symbol > [ERROR] symbol: class ForkableFlinkMiniCluster > location: class ActiveMQConnectorITCase > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[216,22] > error: method snapshotState in class > MessageAcknowledgingSourceBase cannot be applied to given types; > [ERROR] required: FunctionSnapshotContext > found: long,long > reason: actual and formal argument lists differ in length > where Type,UId are type-variables: > Type extends Object declared in class MessageAcknowledgingSourceBase > UId extends Object declared in class MessageAcknowledgingSourceBase > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[229,4] > error: ActiveMQConnectorITCase.TestSourceContext is not abstract and does > not override abstract method markAsTemporarilyIdle() in SourceContext > Excluding ActiveMQ from compilation leads to the next issue in the > Akka-Connector: > [ERROR] > /home/markus/src/bahir-flink/flink-connector-akka/src/test/java/org/apache/flink/streaming/connectors/akka/AkkaSourceTest.java:[210,17] > error: DummySourceContext is not abstract and does not override abstract > method markAsTemporarilyIdle() in SourceContext > [INFO] 1 error -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BAHIR-91) Upgrade bahir-flink to support Flink 1.2
[ https://issues.apache.org/jira/browse/BAHIR-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891898#comment-15891898 ] ASF GitHub Bot commented on BAHIR-91: - Github user rmetzger commented on the issue: https://github.com/apache/bahir-flink/pull/11 The travis build failed, probably because of the version override from the travis.yml. > Upgrade bahir-flink to support Flink 1.2 > > > Key: BAHIR-91 > URL: https://issues.apache.org/jira/browse/BAHIR-91 > Project: Bahir > Issue Type: New Feature > Components: Flink Streaming Connectors >Affects Versions: Flink-0.1 > Environment: Ubuntu Yakkety Yak >Reporter: Markus Müller > Fix For: Flink-0.1 > > > After working around https://issues.apache.org/jira/browse/FLINK-4813 by > specifying Flink version 1.3-SNAPSHOT instead of 1.2.0 in the bahir-flink pom > file, I get the following compiler errors for the ActiveMQ connector: > ERROR] > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[32,33] > error: cannot find symbol > [ERROR] symbol: class ForkableFlinkMiniCluster > location: package org.apache.flink.test.util > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[54,19] > error: cannot find symbol > [ERROR] symbol: class ForkableFlinkMiniCluster > location: class ActiveMQConnectorITCase > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[66,20] > error: cannot find symbol > [ERROR] symbol: class ForkableFlinkMiniCluster > location: class ActiveMQConnectorITCase > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[216,22] > error: method snapshotState in class > MessageAcknowledgingSourceBase cannot be applied to given types; > [ERROR] required: FunctionSnapshotContext > found: long,long > reason: actual and formal argument lists differ in length > where Type,UId are type-variables: > Type extends Object declared in class MessageAcknowledgingSourceBase > UId extends Object declared in class MessageAcknowledgingSourceBase > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[229,4] > error: ActiveMQConnectorITCase.TestSourceContext is not abstract and does > not override abstract method markAsTemporarilyIdle() in SourceContext > Excluding ActiveMQ from compilation leads to the next issue in the > Akka-Connector: > [ERROR] > /home/markus/src/bahir-flink/flink-connector-akka/src/test/java/org/apache/flink/streaming/connectors/akka/AkkaSourceTest.java:[210,17] > error: DummySourceContext is not abstract and does not override abstract > method markAsTemporarilyIdle() in SourceContext > [INFO] 1 error -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BAHIR-91) Upgrade bahir-flink to support Flink 1.2
[
https://issues.apache.org/jira/browse/BAHIR-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890097#comment-15890097
]
ASF GitHub Bot commented on BAHIR-91:
-
Github user tzulitai commented on the issue:
https://github.com/apache/bahir-flink/pull/11
@rmetzger I don't think there's an easy way to do this, unless we try to
make the affected connectors backwards compatible.
Just rebased on {{master}} to resolve conflicts.
> Upgrade bahir-flink to support Flink 1.2
>
>
> Key: BAHIR-91
> URL: https://issues.apache.org/jira/browse/BAHIR-91
> Project: Bahir
> Issue Type: New Feature
> Components: Flink Streaming Connectors
>Affects Versions: Flink-0.1
> Environment: Ubuntu Yakkety Yak
>Reporter: Markus Müller
> Fix For: Flink-0.1
>
>
> After working around https://issues.apache.org/jira/browse/FLINK-4813 by
> specifying Flink version 1.3-SNAPSHOT instead of 1.2.0 in the bahir-flink pom
> file, I get the following compiler errors for the ActiveMQ connector:
> ERROR]
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[32,33]
> error: cannot find symbol
> [ERROR] symbol: class ForkableFlinkMiniCluster
> location: package org.apache.flink.test.util
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[54,19]
> error: cannot find symbol
> [ERROR] symbol: class ForkableFlinkMiniCluster
> location: class ActiveMQConnectorITCase
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[66,20]
> error: cannot find symbol
> [ERROR] symbol: class ForkableFlinkMiniCluster
> location: class ActiveMQConnectorITCase
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[216,22]
> error: method snapshotState in class
> MessageAcknowledgingSourceBase cannot be applied to given types;
> [ERROR] required: FunctionSnapshotContext
> found: long,long
> reason: actual and formal argument lists differ in length
> where Type,UId are type-variables:
> Type extends Object declared in class MessageAcknowledgingSourceBase
> UId extends Object declared in class MessageAcknowledgingSourceBase
> /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[229,4]
> error: ActiveMQConnectorITCase.TestSourceContext is not abstract and does
> not override abstract method markAsTemporarilyIdle() in SourceContext
> Excluding ActiveMQ from compilation leads to the next issue in the
> Akka-Connector:
> [ERROR]
> /home/markus/src/bahir-flink/flink-connector-akka/src/test/java/org/apache/flink/streaming/connectors/akka/AkkaSourceTest.java:[210,17]
> error: DummySourceContext is not abstract and does not override abstract
> method markAsTemporarilyIdle() in SourceContext
> [INFO] 1 error
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (BAHIR-91) Upgrade bahir-flink to support Flink 1.2
[ https://issues.apache.org/jira/browse/BAHIR-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889880#comment-15889880 ] ASF GitHub Bot commented on BAHIR-91: - Github user rmetzger commented on the issue: https://github.com/apache/bahir-flink/pull/11 I think the travis tests will fail because they are overwriting the Flink version. I have a constant there for the Flink version. My initial plan was to support multiple Flink versions at the same time. Do you think there is an easy way to still support 1.1. and 1.2 with the Bahir connectors? > Upgrade bahir-flink to support Flink 1.2 > > > Key: BAHIR-91 > URL: https://issues.apache.org/jira/browse/BAHIR-91 > Project: Bahir > Issue Type: New Feature > Components: Flink Streaming Connectors >Affects Versions: Flink-0.1 > Environment: Ubuntu Yakkety Yak >Reporter: Markus Müller > Fix For: Flink-0.1 > > > After working around https://issues.apache.org/jira/browse/FLINK-4813 by > specifying Flink version 1.3-SNAPSHOT instead of 1.2.0 in the bahir-flink pom > file, I get the following compiler errors for the ActiveMQ connector: > ERROR] > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[32,33] > error: cannot find symbol > [ERROR] symbol: class ForkableFlinkMiniCluster > location: package org.apache.flink.test.util > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[54,19] > error: cannot find symbol > [ERROR] symbol: class ForkableFlinkMiniCluster > location: class ActiveMQConnectorITCase > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[66,20] > error: cannot find symbol > [ERROR] symbol: class ForkableFlinkMiniCluster > location: class ActiveMQConnectorITCase > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[216,22] > error: method snapshotState in class > MessageAcknowledgingSourceBase cannot be applied to given types; > [ERROR] required: FunctionSnapshotContext > found: long,long > reason: actual and formal argument lists differ in length > where Type,UId are type-variables: > Type extends Object declared in class MessageAcknowledgingSourceBase > UId extends Object declared in class MessageAcknowledgingSourceBase > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[229,4] > error: ActiveMQConnectorITCase.TestSourceContext is not abstract and does > not override abstract method markAsTemporarilyIdle() in SourceContext > Excluding ActiveMQ from compilation leads to the next issue in the > Akka-Connector: > [ERROR] > /home/markus/src/bahir-flink/flink-connector-akka/src/test/java/org/apache/flink/streaming/connectors/akka/AkkaSourceTest.java:[210,17] > error: DummySourceContext is not abstract and does not override abstract > method markAsTemporarilyIdle() in SourceContext > [INFO] 1 error -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BAHIR-91) Upgrade bahir-flink to support Flink 1.2
[ https://issues.apache.org/jira/browse/BAHIR-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889635#comment-15889635 ] ASF GitHub Bot commented on BAHIR-91: - Github user tzulitai commented on a diff in the pull request: https://github.com/apache/bahir-flink/pull/11#discussion_r103620565 --- Diff: pom.xml --- @@ -90,7 +90,7 @@ 1.2.17 --- End diff -- minor note: I changed this line to `Flink version` in #10, so not changing it in this PR to avoid conflicts. > Upgrade bahir-flink to support Flink 1.2 > > > Key: BAHIR-91 > URL: https://issues.apache.org/jira/browse/BAHIR-91 > Project: Bahir > Issue Type: New Feature > Components: Flink Streaming Connectors >Affects Versions: Flink-0.1 > Environment: Ubuntu Yakkety Yak >Reporter: Markus Müller > Fix For: Flink-0.1 > > > After working around https://issues.apache.org/jira/browse/FLINK-4813 by > specifying Flink version 1.3-SNAPSHOT instead of 1.2.0 in the bahir-flink pom > file, I get the following compiler errors for the ActiveMQ connector: > ERROR] > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[32,33] > error: cannot find symbol > [ERROR] symbol: class ForkableFlinkMiniCluster > location: package org.apache.flink.test.util > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[54,19] > error: cannot find symbol > [ERROR] symbol: class ForkableFlinkMiniCluster > location: class ActiveMQConnectorITCase > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[66,20] > error: cannot find symbol > [ERROR] symbol: class ForkableFlinkMiniCluster > location: class ActiveMQConnectorITCase > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[216,22] > error: method snapshotState in class > MessageAcknowledgingSourceBase cannot be applied to given types; > [ERROR] required: FunctionSnapshotContext > found: long,long > reason: actual and formal argument lists differ in length > where Type,UId are type-variables: > Type extends Object declared in class MessageAcknowledgingSourceBase > UId extends Object declared in class MessageAcknowledgingSourceBase > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[229,4] > error: ActiveMQConnectorITCase.TestSourceContext is not abstract and does > not override abstract method markAsTemporarilyIdle() in SourceContext > Excluding ActiveMQ from compilation leads to the next issue in the > Akka-Connector: > [ERROR] > /home/markus/src/bahir-flink/flink-connector-akka/src/test/java/org/apache/flink/streaming/connectors/akka/AkkaSourceTest.java:[210,17] > error: DummySourceContext is not abstract and does not override abstract > method markAsTemporarilyIdle() in SourceContext > [INFO] 1 error -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BAHIR-91) Upgrade bahir-flink to support Flink 1.2
[ https://issues.apache.org/jira/browse/BAHIR-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889619#comment-15889619 ] ASF GitHub Bot commented on BAHIR-91: - GitHub user tzulitai opened a pull request: https://github.com/apache/bahir-flink/pull/11 [BAHIR-91] Upgrade Flink version to 1.2.0 This required some Flink state API updates in the tests. We probably should keep an extra eye for these kind of Flink API changes; the source APIs may be stable, but API changes like these can also break code in bahir-flink. Note about the additional `maven-bundle-plugin` in the Redis connector: After the 1.2.0 upgrade, the project had a new dependency to Apacheds JDBM 2.0.0-M2, which packages using the "bundle" type. The plugin helps recognizes the type when building. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tzulitai/bahir-flink BAHIR-91 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bahir-flink/pull/11.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11 commit 9b9be286543fb8c972d48e715a724da261f71d24 Author: Tzu-Li (Gordon) Tai Date: 2017-03-01T06:41:21Z [BAHIR-91] Upgrade Flink version to 1.2.0 > Upgrade bahir-flink to support Flink 1.2 > > > Key: BAHIR-91 > URL: https://issues.apache.org/jira/browse/BAHIR-91 > Project: Bahir > Issue Type: New Feature > Components: Flink Streaming Connectors >Affects Versions: Flink-0.1 > Environment: Ubuntu Yakkety Yak >Reporter: Markus Müller > Fix For: Flink-0.1 > > > After working around https://issues.apache.org/jira/browse/FLINK-4813 by > specifying Flink version 1.3-SNAPSHOT instead of 1.2.0 in the bahir-flink pom > file, I get the following compiler errors for the ActiveMQ connector: > ERROR] > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[32,33] > error: cannot find symbol > [ERROR] symbol: class ForkableFlinkMiniCluster > location: package org.apache.flink.test.util > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[54,19] > error: cannot find symbol > [ERROR] symbol: class ForkableFlinkMiniCluster > location: class ActiveMQConnectorITCase > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[66,20] > error: cannot find symbol > [ERROR] symbol: class ForkableFlinkMiniCluster > location: class ActiveMQConnectorITCase > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[216,22] > error: method snapshotState in class > MessageAcknowledgingSourceBase cannot be applied to given types; > [ERROR] required: FunctionSnapshotContext > found: long,long > reason: actual and formal argument lists differ in length > where Type,UId are type-variables: > Type extends Object declared in class MessageAcknowledgingSourceBase > UId extends Object declared in class MessageAcknowledgingSourceBase > /home/markus/src/bahir-flink/flink-connector-activemq/src/test/java/org/apache/flink/streaming/connectors/activemq/ActiveMQConnectorITCase.java:[229,4] > error: ActiveMQConnectorITCase.TestSourceContext is not abstract and does > not override abstract method markAsTemporarilyIdle() in SourceContext > Excluding ActiveMQ from compilation leads to the next issue in the > Akka-Connector: > [ERROR] > /home/markus/src/bahir-flink/flink-connector-akka/src/test/java/org/apache/flink/streaming/connectors/akka/AkkaSourceTest.java:[210,17] > error: DummySourceContext is not abstract and does not override abstract > method markAsTemporarilyIdle() in SourceContext > [INFO] 1 error -- This message was sent by Atlassian JIRA (v6.3.15#6346)
