Re: [CANCEL][VOTE] Apache Beam, version 2.5.0, release candidate #1

[Jean-Baptiste Onofré]

It looks good to me, I'm merging and moving forward.

Regards
JB

On 14/06/2018 00:45, Pablo Estrada wrote:
> Sent out https://github.com/apache/beam/pull/5640 to ignore the flaky
> test. As JB is the release manager, I'l let him make the call on what to
> do about it.
> Best
> -P.
> 
> On Wed, Jun 13, 2018 at 3:34 PM Ahmet Altay  > wrote:
> 
> I would vote for second option, not a release blocker and disable
> the test in the release branch. My reasoning is:
> - ReferenceRunner is not yet the official alternative to existing
> direct runners.
> - It is bad to have flaky tests on the release branch, and we would
> not get good signal during validation.
> 
> On Wed, Jun 13, 2018 at 3:14 PM, Pablo Estrada  > wrote:
> 
> Hello all,
> cherrypicks for the release branch seem to be going well, but
> thanks to them we were able to surface a flaky test in the
> release branch. JIRA is
> filed: https://issues.apache.org/jira/projects/BEAM/issues/BEAM-4558
> 
> Given that test issue, I see the following options:
> - Consider that this test is not a release blocker. Go ahead
> with RC2 after cherrypicks are brought in, or
> - Consider that this test is not a release blocker, so we
> disable it before cutting RC2.
> - Consider this test a release blocker, and triage the bug for
> fixing.
> 
> What do you think?
> 
> Best
> -P.
> 
> On Wed, Jun 13, 2018 at 9:54 AM Pablo Estrada
> mailto:pabl...@google.com>> wrote:
> 
> Precommits for
> PR https://github.com/apache/beam/pull/5609 are now passing.
> For now I've simply set failOnWarning to false to cherrypick
> into the release, and fix in master later on.
> Best
> -P.
> 
> On Wed, Jun 13, 2018 at 9:08 AM Scott Wegner
> mailto:sweg...@google.com>> wrote:
> 
> From my understanding, the @SuppressFBWarnings usage is
> in a dependency (ByteBuddy) rather than directly in our
> code; so we're not able to modify the usage.
> 
> Pablo, feel free to disable failOnWarning for the
> sdks-java-core project temporarily. This isn't a major
> regression since we've only recently made the change to
> enable it [1]. We can work separately on figuring out
> how to resolve the warnings.
> 
> [1] https://github.com/apache/beam/pull/5319 
> 
> On Tue, Jun 12, 2018 at 11:57 PM Tim Robertson
>  > wrote:
> 
> Hi Pablo,
> 
> I'm afraid I couldn't find one either... there is an
> issue about it [1] which is old so it doesn't look
> likely to be resolved either.
> 
> If you have time (sorry I am a bit busy) could you
> please verify the version does work if you install
> that version locally? I know the maven version of
> that [2] but not sure on the gradle equivalent. If
> we know it works, we can then find a repository that
> fits ok with Apache/Beam policy.
> 
> Alternatively, we could consider using a fully
> qualified reference (i.e.
> @edu.umd.cs.findbugs.annotations.SuppressWarnings)
> to the deprecated version and leave the dependency
> at the 1.3.9-1. I believe our general direction is
> to remove findbugs when errorprone covers all
> aspects so I *expect* this should be considered
> reasonable.
> 
> I hope this helps,
> Tim
> 
> [1] 
> https://github.com/stephenc/findbugs-annotations/issues/4
> [2] 
> https://maven.apache.org/guides/mini/guide-3rd-party-jars-local.html
> 
> On Wed, Jun 13, 2018 at 8:39 AM, Pablo Estrada
> mailto:pabl...@google.com>> wrote:
> 
> Hi Tim,
> you're right. Thanks for pointing that out.
> There's just one problem that I'm running into
> now: The 3.0.1-1 version does not seem to be
> available in Maven Central[1]. Looking at the
> website, I am not quite sure if there's another
> repository where they do stage the newer
> versions?[2]
> 
> -P
> 
> [1] 
> https://repo.maven.apache.org/maven2/com/github/stephenc/findbugs/fin

Re: [CANCEL][VOTE] Apache Beam, version 2.5.0, release candidate #1

[Eugene Kirpichov]

FWIW I have a fix to the flaky test in
https://github.com/apache/beam/pull/5585 (open)

On Wed, Jun 13, 2018 at 5:26 PM Udi Meiri  wrote:

> +1 to ignoring flaky test.
>
> FYI there's a fourth cherrypick: https://github.com/apache/beam/pull/5624
>
> On Wed, Jun 13, 2018 at 3:45 PM Pablo Estrada  wrote:
>
>> Sent out https://github.com/apache/beam/pull/5640 to ignore the flaky
>> test. As JB is the release manager, I'l let him make the call on what to do
>> about it.
>> Best
>> -P.
>>
>> On Wed, Jun 13, 2018 at 3:34 PM Ahmet Altay  wrote:
>>
>>> I would vote for second option, not a release blocker and disable the
>>> test in the release branch. My reasoning is:
>>> - ReferenceRunner is not yet the official alternative to existing direct
>>> runners.
>>> - It is bad to have flaky tests on the release branch, and we would not
>>> get good signal during validation.
>>>
>>> On Wed, Jun 13, 2018 at 3:14 PM, Pablo Estrada 
>>> wrote:
>>>
 Hello all,
 cherrypicks for the release branch seem to be going well, but thanks to
 them we were able to surface a flaky test in the release branch. JIRA is
 filed: https://issues.apache.org/jira/projects/BEAM/issues/BEAM-4558

 Given that test issue, I see the following options:
 - Consider that this test is not a release blocker. Go ahead with RC2
 after cherrypicks are brought in, or
 - Consider that this test is not a release blocker, so we disable it
 before cutting RC2.
 - Consider this test a release blocker, and triage the bug for fixing.

 What do you think?

 Best
 -P.

 On Wed, Jun 13, 2018 at 9:54 AM Pablo Estrada 
 wrote:

> Precommits for PR https://github.com/apache/beam/pull/5609 are now
> passing. For now I've simply set failOnWarning to false to cherrypick into
> the release, and fix in master later on.
> Best
> -P.
>
> On Wed, Jun 13, 2018 at 9:08 AM Scott Wegner 
> wrote:
>
>> From my understanding, the @SuppressFBWarnings usage is in a
>> dependency (ByteBuddy) rather than directly in our code; so we're not 
>> able
>> to modify the usage.
>>
>> Pablo, feel free to disable failOnWarning for the sdks-java-core
>> project temporarily. This isn't a major regression since we've only
>> recently made the change to enable it [1]. We can work separately on
>> figuring out how to resolve the warnings.
>>
>> [1] https://github.com/apache/beam/pull/5319
>>
>> On Tue, Jun 12, 2018 at 11:57 PM Tim Robertson <
>> timrobertson...@gmail.com> wrote:
>>
>>> Hi Pablo,
>>>
>>> I'm afraid I couldn't find one either... there is an issue about it
>>> [1] which is old so it doesn't look likely to be resolved either.
>>>
>>> If you have time (sorry I am a bit busy) could you please verify the
>>> version does work if you install that version locally? I know the maven
>>> version of that [2] but not sure on the gradle equivalent. If we know it
>>> works, we can then find a repository that fits ok with Apache/Beam 
>>> policy.
>>>
>>> Alternatively, we could consider using a fully qualified reference
>>> (i.e. @edu.umd.cs.findbugs.annotations.SuppressWarnings) to the 
>>> deprecated
>>> version and leave the dependency at the 1.3.9-1. I believe our general
>>> direction is to remove findbugs when errorprone covers all aspects so I
>>> *expect* this should be considered reasonable.
>>>
>>> I hope this helps,
>>> Tim
>>>
>>> [1] https://github.com/stephenc/findbugs-annotations/issues/4
>>> [2]
>>> https://maven.apache.org/guides/mini/guide-3rd-party-jars-local.html
>>>
>>> On Wed, Jun 13, 2018 at 8:39 AM, Pablo Estrada 
>>> wrote:
>>>
 Hi Tim,
 you're right. Thanks for pointing that out. There's just one
 problem that I'm running into now: The 3.0.1-1 version does not seem 
 to be
 available in Maven Central[1]. Looking at the website, I am not quite 
 sure
 if there's another repository where they do stage the newer 
 versions?[2]

 -P

 [1]
 https://repo.maven.apache.org/maven2/com/github/stephenc/findbugs/findbugs-annotations
 /
 [2] http://stephenc.github.io/findbugs-annotations/

 On Tue, Jun 12, 2018 at 11:10 PM Tim Robertson <
 timrobertson...@gmail.com> wrote:

> Hi Pablo,
>
> I took only a quick look.
>
> "- The JAR from the non-LGPL findbugs does not contain the
> SuppressFBWarnings annotation"
>
> Unless I misunderstand you it looks like SuppressFBWarnings was
> added in Stephen's version in this commit [1] which was
> introduced in version 2.0.3-1 -  I've checked is in the 3.0.1-1 build 
> [2]
> I notice in your commits [1] you've been exploring 

Re: [CANCEL][VOTE] Apache Beam, version 2.5.0, release candidate #1

[Udi Meiri]

+1 to ignoring flaky test.

FYI there's a fourth cherrypick: https://github.com/apache/beam/pull/5624

On Wed, Jun 13, 2018 at 3:45 PM Pablo Estrada  wrote:

> Sent out https://github.com/apache/beam/pull/5640 to ignore the flaky
> test. As JB is the release manager, I'l let him make the call on what to do
> about it.
> Best
> -P.
>
> On Wed, Jun 13, 2018 at 3:34 PM Ahmet Altay  wrote:
>
>> I would vote for second option, not a release blocker and disable the
>> test in the release branch. My reasoning is:
>> - ReferenceRunner is not yet the official alternative to existing direct
>> runners.
>> - It is bad to have flaky tests on the release branch, and we would not
>> get good signal during validation.
>>
>> On Wed, Jun 13, 2018 at 3:14 PM, Pablo Estrada 
>> wrote:
>>
>>> Hello all,
>>> cherrypicks for the release branch seem to be going well, but thanks to
>>> them we were able to surface a flaky test in the release branch. JIRA is
>>> filed: https://issues.apache.org/jira/projects/BEAM/issues/BEAM-4558
>>>
>>> Given that test issue, I see the following options:
>>> - Consider that this test is not a release blocker. Go ahead with RC2
>>> after cherrypicks are brought in, or
>>> - Consider that this test is not a release blocker, so we disable it
>>> before cutting RC2.
>>> - Consider this test a release blocker, and triage the bug for fixing.
>>>
>>> What do you think?
>>>
>>> Best
>>> -P.
>>>
>>> On Wed, Jun 13, 2018 at 9:54 AM Pablo Estrada 
>>> wrote:
>>>
 Precommits for PR https://github.com/apache/beam/pull/5609 are now
 passing. For now I've simply set failOnWarning to false to cherrypick into
 the release, and fix in master later on.
 Best
 -P.

 On Wed, Jun 13, 2018 at 9:08 AM Scott Wegner 
 wrote:

> From my understanding, the @SuppressFBWarnings usage is in a
> dependency (ByteBuddy) rather than directly in our code; so we're not able
> to modify the usage.
>
> Pablo, feel free to disable failOnWarning for the sdks-java-core
> project temporarily. This isn't a major regression since we've only
> recently made the change to enable it [1]. We can work separately on
> figuring out how to resolve the warnings.
>
> [1] https://github.com/apache/beam/pull/5319
>
> On Tue, Jun 12, 2018 at 11:57 PM Tim Robertson <
> timrobertson...@gmail.com> wrote:
>
>> Hi Pablo,
>>
>> I'm afraid I couldn't find one either... there is an issue about it
>> [1] which is old so it doesn't look likely to be resolved either.
>>
>> If you have time (sorry I am a bit busy) could you please verify the
>> version does work if you install that version locally? I know the maven
>> version of that [2] but not sure on the gradle equivalent. If we know it
>> works, we can then find a repository that fits ok with Apache/Beam 
>> policy.
>>
>> Alternatively, we could consider using a fully qualified reference
>> (i.e. @edu.umd.cs.findbugs.annotations.SuppressWarnings) to the 
>> deprecated
>> version and leave the dependency at the 1.3.9-1. I believe our general
>> direction is to remove findbugs when errorprone covers all aspects so I
>> *expect* this should be considered reasonable.
>>
>> I hope this helps,
>> Tim
>>
>> [1] https://github.com/stephenc/findbugs-annotations/issues/4
>> [2]
>> https://maven.apache.org/guides/mini/guide-3rd-party-jars-local.html
>>
>> On Wed, Jun 13, 2018 at 8:39 AM, Pablo Estrada 
>> wrote:
>>
>>> Hi Tim,
>>> you're right. Thanks for pointing that out. There's just one problem
>>> that I'm running into now: The 3.0.1-1 version does not seem to be
>>> available in Maven Central[1]. Looking at the website, I am not quite 
>>> sure
>>> if there's another repository where they do stage the newer versions?[2]
>>>
>>> -P
>>>
>>> [1]
>>> https://repo.maven.apache.org/maven2/com/github/stephenc/findbugs/findbugs-annotations
>>> /
>>> [2] http://stephenc.github.io/findbugs-annotations/
>>>
>>> On Tue, Jun 12, 2018 at 11:10 PM Tim Robertson <
>>> timrobertson...@gmail.com> wrote:
>>>
 Hi Pablo,

 I took only a quick look.

 "- The JAR from the non-LGPL findbugs does not contain the
 SuppressFBWarnings annotation"

 Unless I misunderstand you it looks like SuppressFBWarnings was
 added in Stephen's version in this commit [1] which was introduced
 in version 2.0.3-1 -  I've checked is in the 3.0.1-1 build [2]
 I notice in your commits [1] you've been exploring version 3.0.0
 already though... what happens when you use 3.0.1-1? It sounds like the
 wrong version is coming in rather than the annotation being missing.

 Thanks,
 Tim

 [1]
 https://github.com/stephenc/findbugs-annotations/commits/mast

Re: [CANCEL][VOTE] Apache Beam, version 2.5.0, release candidate #1

[Pablo Estrada]

Sent out https://github.com/apache/beam/pull/5640 to ignore the flaky test.
As JB is the release manager, I'l let him make the call on what to do about
it.
Best
-P.

On Wed, Jun 13, 2018 at 3:34 PM Ahmet Altay  wrote:

> I would vote for second option, not a release blocker and disable the test
> in the release branch. My reasoning is:
> - ReferenceRunner is not yet the official alternative to existing direct
> runners.
> - It is bad to have flaky tests on the release branch, and we would not
> get good signal during validation.
>
> On Wed, Jun 13, 2018 at 3:14 PM, Pablo Estrada  wrote:
>
>> Hello all,
>> cherrypicks for the release branch seem to be going well, but thanks to
>> them we were able to surface a flaky test in the release branch. JIRA is
>> filed: https://issues.apache.org/jira/projects/BEAM/issues/BEAM-4558
>>
>> Given that test issue, I see the following options:
>> - Consider that this test is not a release blocker. Go ahead with RC2
>> after cherrypicks are brought in, or
>> - Consider that this test is not a release blocker, so we disable it
>> before cutting RC2.
>> - Consider this test a release blocker, and triage the bug for fixing.
>>
>> What do you think?
>>
>> Best
>> -P.
>>
>> On Wed, Jun 13, 2018 at 9:54 AM Pablo Estrada  wrote:
>>
>>> Precommits for PR https://github.com/apache/beam/pull/5609 are now
>>> passing. For now I've simply set failOnWarning to false to cherrypick into
>>> the release, and fix in master later on.
>>> Best
>>> -P.
>>>
>>> On Wed, Jun 13, 2018 at 9:08 AM Scott Wegner  wrote:
>>>
 From my understanding, the @SuppressFBWarnings usage is in a dependency
 (ByteBuddy) rather than directly in our code; so we're not able to modify
 the usage.

 Pablo, feel free to disable failOnWarning for the sdks-java-core
 project temporarily. This isn't a major regression since we've only
 recently made the change to enable it [1]. We can work separately on
 figuring out how to resolve the warnings.

 [1] https://github.com/apache/beam/pull/5319

 On Tue, Jun 12, 2018 at 11:57 PM Tim Robertson <
 timrobertson...@gmail.com> wrote:

> Hi Pablo,
>
> I'm afraid I couldn't find one either... there is an issue about it
> [1] which is old so it doesn't look likely to be resolved either.
>
> If you have time (sorry I am a bit busy) could you please verify the
> version does work if you install that version locally? I know the maven
> version of that [2] but not sure on the gradle equivalent. If we know it
> works, we can then find a repository that fits ok with Apache/Beam policy.
>
> Alternatively, we could consider using a fully qualified reference
> (i.e. @edu.umd.cs.findbugs.annotations.SuppressWarnings) to the deprecated
> version and leave the dependency at the 1.3.9-1. I believe our general
> direction is to remove findbugs when errorprone covers all aspects so I
> *expect* this should be considered reasonable.
>
> I hope this helps,
> Tim
>
> [1] https://github.com/stephenc/findbugs-annotations/issues/4
> [2]
> https://maven.apache.org/guides/mini/guide-3rd-party-jars-local.html
>
> On Wed, Jun 13, 2018 at 8:39 AM, Pablo Estrada 
> wrote:
>
>> Hi Tim,
>> you're right. Thanks for pointing that out. There's just one problem
>> that I'm running into now: The 3.0.1-1 version does not seem to be
>> available in Maven Central[1]. Looking at the website, I am not quite 
>> sure
>> if there's another repository where they do stage the newer versions?[2]
>>
>> -P
>>
>> [1]
>> https://repo.maven.apache.org/maven2/com/github/stephenc/findbugs/findbugs-annotations
>> /
>> [2] http://stephenc.github.io/findbugs-annotations/
>>
>> On Tue, Jun 12, 2018 at 11:10 PM Tim Robertson <
>> timrobertson...@gmail.com> wrote:
>>
>>> Hi Pablo,
>>>
>>> I took only a quick look.
>>>
>>> "- The JAR from the non-LGPL findbugs does not contain the
>>> SuppressFBWarnings annotation"
>>>
>>> Unless I misunderstand you it looks like SuppressFBWarnings was
>>> added in Stephen's version in this commit [1] which was introduced
>>> in version 2.0.3-1 -  I've checked is in the 3.0.1-1 build [2]
>>> I notice in your commits [1] you've been exploring version 3.0.0
>>> already though... what happens when you use 3.0.1-1? It sounds like the
>>> wrong version is coming in rather than the annotation being missing.
>>>
>>> Thanks,
>>> Tim
>>>
>>> [1]
>>> https://github.com/stephenc/findbugs-annotations/commits/master/src/main/java/edu/umd/cs/findbugs/annotations/SuppressWarnings.java
>>> [2] https://github.com/stephenc/findbugs-annotations/releases
>>> [3]
>>> https://github.com/apache/beam/pull/5609/commits/32c7df706e970557f154ff6bc521b2e00f9d09ab
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>

Re: [CANCEL][VOTE] Apache Beam, version 2.5.0, release candidate #1

[Ahmet Altay]

I would vote for second option, not a release blocker and disable the test
in the release branch. My reasoning is:
- ReferenceRunner is not yet the official alternative to existing direct
runners.
- It is bad to have flaky tests on the release branch, and we would not get
good signal during validation.

On Wed, Jun 13, 2018 at 3:14 PM, Pablo Estrada  wrote:

> Hello all,
> cherrypicks for the release branch seem to be going well, but thanks to
> them we were able to surface a flaky test in the release branch. JIRA is
> filed: https://issues.apache.org/jira/projects/BEAM/issues/BEAM-4558
>
> Given that test issue, I see the following options:
> - Consider that this test is not a release blocker. Go ahead with RC2
> after cherrypicks are brought in, or
> - Consider that this test is not a release blocker, so we disable it
> before cutting RC2.
> - Consider this test a release blocker, and triage the bug for fixing.
>
> What do you think?
>
> Best
> -P.
>
> On Wed, Jun 13, 2018 at 9:54 AM Pablo Estrada  wrote:
>
>> Precommits for PR https://github.com/apache/beam/pull/5609 are now
>> passing. For now I've simply set failOnWarning to false to cherrypick into
>> the release, and fix in master later on.
>> Best
>> -P.
>>
>> On Wed, Jun 13, 2018 at 9:08 AM Scott Wegner  wrote:
>>
>>> From my understanding, the @SuppressFBWarnings usage is in a dependency
>>> (ByteBuddy) rather than directly in our code; so we're not able to modify
>>> the usage.
>>>
>>> Pablo, feel free to disable failOnWarning for the sdks-java-core project
>>> temporarily. This isn't a major regression since we've only recently made
>>> the change to enable it [1]. We can work separately on figuring out how to
>>> resolve the warnings.
>>>
>>> [1] https://github.com/apache/beam/pull/5319
>>>
>>> On Tue, Jun 12, 2018 at 11:57 PM Tim Robertson <
>>> timrobertson...@gmail.com> wrote:
>>>
 Hi Pablo,

 I'm afraid I couldn't find one either... there is an issue about it [1]
 which is old so it doesn't look likely to be resolved either.

 If you have time (sorry I am a bit busy) could you please verify the
 version does work if you install that version locally? I know the maven
 version of that [2] but not sure on the gradle equivalent. If we know it
 works, we can then find a repository that fits ok with Apache/Beam policy.

 Alternatively, we could consider using a fully qualified reference
 (i.e. @edu.umd.cs.findbugs.annotations.SuppressWarnings) to the
 deprecated version and leave the dependency at the 1.3.9-1. I believe our
 general direction is to remove findbugs when errorprone covers all aspects
 so I *expect* this should be considered reasonable.

 I hope this helps,
 Tim

 [1] https://github.com/stephenc/findbugs-annotations/issues/4
 [2] https://maven.apache.org/guides/mini/guide-3rd-party-
 jars-local.html

 On Wed, Jun 13, 2018 at 8:39 AM, Pablo Estrada 
 wrote:

> Hi Tim,
> you're right. Thanks for pointing that out. There's just one problem
> that I'm running into now: The 3.0.1-1 version does not seem to be
> available in Maven Central[1]. Looking at the website, I am not quite sure
> if there's another repository where they do stage the newer versions?[2]
>
> -P
>
> [1] https://repo.maven.apache.org/maven2/com/github/
> stephenc/findbugs/findbugs-annotations/
> [2] http://stephenc.github.io/findbugs-annotations/
>
> On Tue, Jun 12, 2018 at 11:10 PM Tim Robertson <
> timrobertson...@gmail.com> wrote:
>
>> Hi Pablo,
>>
>> I took only a quick look.
>>
>> "- The JAR from the non-LGPL findbugs does not contain the
>> SuppressFBWarnings annotation"
>>
>> Unless I misunderstand you it looks like SuppressFBWarnings was added
>> in Stephen's version in this commit [1] which was introduced in
>> version 2.0.3-1 -  I've checked is in the 3.0.1-1 build [2]
>> I notice in your commits [1] you've been exploring version 3.0.0
>> already though... what happens when you use 3.0.1-1? It sounds like the
>> wrong version is coming in rather than the annotation being missing.
>>
>> Thanks,
>> Tim
>>
>> [1] https://github.com/stephenc/findbugs-annotations/
>> commits/master/src/main/java/edu/umd/cs/findbugs/
>> annotations/SuppressWarnings.java
>> [2] https://github.com/stephenc/findbugs-annotations/releases
>> [3] https://github.com/apache/beam/pull/5609/commits/
>> 32c7df706e970557f154ff6bc521b2e00f9d09ab
>>
>>
>>
>>
>>
>>
>>
>> On Wed, Jun 13, 2018 at 2:37 AM, Pablo Estrada 
>> wrote:
>>
>>> Hi all,
>>> I'll humbly declare that after wrestling with he build to stop
>>> depending on the wrong findbugs_annotations, I feel somewhat lost. The
>>> issue is actually quite small:
>>>
>>> - The JAR from the non-LGPL findbugs does not contain the

Re: [CANCEL][VOTE] Apache Beam, version 2.5.0, release candidate #1

[Pablo Estrada]

Hello all,
cherrypicks for the release branch seem to be going well, but thanks to
them we were able to surface a flaky test in the release branch. JIRA is
filed: https://issues.apache.org/jira/projects/BEAM/issues/BEAM-4558

Given that test issue, I see the following options:
- Consider that this test is not a release blocker. Go ahead with RC2 after
cherrypicks are brought in, or
- Consider that this test is not a release blocker, so we disable it before
cutting RC2.
- Consider this test a release blocker, and triage the bug for fixing.

What do you think?

Best
-P.

On Wed, Jun 13, 2018 at 9:54 AM Pablo Estrada  wrote:

> Precommits for PR https://github.com/apache/beam/pull/5609 are now
> passing. For now I've simply set failOnWarning to false to cherrypick into
> the release, and fix in master later on.
> Best
> -P.
>
> On Wed, Jun 13, 2018 at 9:08 AM Scott Wegner  wrote:
>
>> From my understanding, the @SuppressFBWarnings usage is in a dependency
>> (ByteBuddy) rather than directly in our code; so we're not able to modify
>> the usage.
>>
>> Pablo, feel free to disable failOnWarning for the sdks-java-core project
>> temporarily. This isn't a major regression since we've only recently made
>> the change to enable it [1]. We can work separately on figuring out how to
>> resolve the warnings.
>>
>> [1] https://github.com/apache/beam/pull/5319
>>
>> On Tue, Jun 12, 2018 at 11:57 PM Tim Robertson 
>> wrote:
>>
>>> Hi Pablo,
>>>
>>> I'm afraid I couldn't find one either... there is an issue about it [1]
>>> which is old so it doesn't look likely to be resolved either.
>>>
>>> If you have time (sorry I am a bit busy) could you please verify the
>>> version does work if you install that version locally? I know the maven
>>> version of that [2] but not sure on the gradle equivalent. If we know it
>>> works, we can then find a repository that fits ok with Apache/Beam policy.
>>>
>>> Alternatively, we could consider using a fully qualified reference (i.e.
>>> @edu.umd.cs.findbugs.annotations.SuppressWarnings) to the deprecated
>>> version and leave the dependency at the 1.3.9-1. I believe our general
>>> direction is to remove findbugs when errorprone covers all aspects so I
>>> *expect* this should be considered reasonable.
>>>
>>> I hope this helps,
>>> Tim
>>>
>>> [1] https://github.com/stephenc/findbugs-annotations/issues/4
>>> [2] https://maven.apache.org/guides/mini/guide-3rd-party-jars-local.html
>>>
>>> On Wed, Jun 13, 2018 at 8:39 AM, Pablo Estrada 
>>> wrote:
>>>
 Hi Tim,
 you're right. Thanks for pointing that out. There's just one problem
 that I'm running into now: The 3.0.1-1 version does not seem to be
 available in Maven Central[1]. Looking at the website, I am not quite sure
 if there's another repository where they do stage the newer versions?[2]

 -P

 [1]
 https://repo.maven.apache.org/maven2/com/github/stephenc/findbugs/findbugs-annotations
 /
 [2] http://stephenc.github.io/findbugs-annotations/

 On Tue, Jun 12, 2018 at 11:10 PM Tim Robertson <
 timrobertson...@gmail.com> wrote:

> Hi Pablo,
>
> I took only a quick look.
>
> "- The JAR from the non-LGPL findbugs does not contain the
> SuppressFBWarnings annotation"
>
> Unless I misunderstand you it looks like SuppressFBWarnings was added
> in Stephen's version in this commit [1] which was introduced in
> version 2.0.3-1 -  I've checked is in the 3.0.1-1 build [2]
> I notice in your commits [1] you've been exploring version 3.0.0
> already though... what happens when you use 3.0.1-1? It sounds like the
> wrong version is coming in rather than the annotation being missing.
>
> Thanks,
> Tim
>
> [1]
> https://github.com/stephenc/findbugs-annotations/commits/master/src/main/java/edu/umd/cs/findbugs/annotations/SuppressWarnings.java
> [2] https://github.com/stephenc/findbugs-annotations/releases
> [3]
> https://github.com/apache/beam/pull/5609/commits/32c7df706e970557f154ff6bc521b2e00f9d09ab
>
>
>
>
>
>
>
> On Wed, Jun 13, 2018 at 2:37 AM, Pablo Estrada 
> wrote:
>
>> Hi all,
>> I'll humbly declare that after wrestling with he build to stop
>> depending on the wrong findbugs_annotations, I feel somewhat lost. The
>> issue is actually quite small:
>>
>> - The JAR from the non-LGPL findbugs does not contain the
>> SuppressFBWarnings annotation. This means that when building, ByteBuddy
>> produces a few warnings (nothing critical).
>> - The easiest way to avoid this failure is to call
>> applyJavaNature(failOnWarning: false), but this would be bad, since we 
>> want
>> to keep a high standard for tasks like ErrorProne and FindBugs itself.
>> - So I find myself lost: How do we suppress trivial warnings coming
>> from missing annotations, and honor warnings coming from other plugins?
>>
>> Any help

Re: [CANCEL][VOTE] Apache Beam, version 2.5.0, release candidate #1

[Boyuan Zhang]

Hey all,

Currently we have 3 PRs supposed to be cherrypicked into RC2:
Pablo:  https://github.com/apache/beam/pull/5609 (merged)
Udi: https://github.com/apache/beam/pull/5607 (open)
Charles:  https://github.com/apache/beam/pull/5636 (open)

Boyuan

On Wed, Jun 13, 2018 at 9:54 AM Pablo Estrada  wrote:

> Precommits for PR https://github.com/apache/beam/pull/5609 are now
> passing. For now I've simply set failOnWarning to false to cherrypick into
> the release, and fix in master later on.
> Best
> -P.
>
> On Wed, Jun 13, 2018 at 9:08 AM Scott Wegner  wrote:
>
>> From my understanding, the @SuppressFBWarnings usage is in a dependency
>> (ByteBuddy) rather than directly in our code; so we're not able to modify
>> the usage.
>>
>> Pablo, feel free to disable failOnWarning for the sdks-java-core project
>> temporarily. This isn't a major regression since we've only recently made
>> the change to enable it [1]. We can work separately on figuring out how to
>> resolve the warnings.
>>
>> [1] https://github.com/apache/beam/pull/5319
>>
>> On Tue, Jun 12, 2018 at 11:57 PM Tim Robertson 
>> wrote:
>>
>>> Hi Pablo,
>>>
>>> I'm afraid I couldn't find one either... there is an issue about it [1]
>>> which is old so it doesn't look likely to be resolved either.
>>>
>>> If you have time (sorry I am a bit busy) could you please verify the
>>> version does work if you install that version locally? I know the maven
>>> version of that [2] but not sure on the gradle equivalent. If we know it
>>> works, we can then find a repository that fits ok with Apache/Beam policy.
>>>
>>> Alternatively, we could consider using a fully qualified reference (i.e.
>>> @edu.umd.cs.findbugs.annotations.SuppressWarnings) to the deprecated
>>> version and leave the dependency at the 1.3.9-1. I believe our general
>>> direction is to remove findbugs when errorprone covers all aspects so I
>>> *expect* this should be considered reasonable.
>>>
>>> I hope this helps,
>>> Tim
>>>
>>> [1] https://github.com/stephenc/findbugs-annotations/issues/4
>>> [2] https://maven.apache.org/guides/mini/guide-3rd-party-jars-local.html
>>>
>>> On Wed, Jun 13, 2018 at 8:39 AM, Pablo Estrada 
>>> wrote:
>>>
 Hi Tim,
 you're right. Thanks for pointing that out. There's just one problem
 that I'm running into now: The 3.0.1-1 version does not seem to be
 available in Maven Central[1]. Looking at the website, I am not quite sure
 if there's another repository where they do stage the newer versions?[2]

 -P

 [1]
 https://repo.maven.apache.org/maven2/com/github/stephenc/findbugs/findbugs-annotations
 /
 [2] http://stephenc.github.io/findbugs-annotations/

 On Tue, Jun 12, 2018 at 11:10 PM Tim Robertson <
 timrobertson...@gmail.com> wrote:

> Hi Pablo,
>
> I took only a quick look.
>
> "- The JAR from the non-LGPL findbugs does not contain the
> SuppressFBWarnings annotation"
>
> Unless I misunderstand you it looks like SuppressFBWarnings was added
> in Stephen's version in this commit [1] which was introduced in
> version 2.0.3-1 -  I've checked is in the 3.0.1-1 build [2]
> I notice in your commits [1] you've been exploring version 3.0.0
> already though... what happens when you use 3.0.1-1? It sounds like the
> wrong version is coming in rather than the annotation being missing.
>
> Thanks,
> Tim
>
> [1]
> https://github.com/stephenc/findbugs-annotations/commits/master/src/main/java/edu/umd/cs/findbugs/annotations/SuppressWarnings.java
> [2] https://github.com/stephenc/findbugs-annotations/releases
> [3]
> https://github.com/apache/beam/pull/5609/commits/32c7df706e970557f154ff6bc521b2e00f9d09ab
>
>
>
>
>
>
>
> On Wed, Jun 13, 2018 at 2:37 AM, Pablo Estrada 
> wrote:
>
>> Hi all,
>> I'll humbly declare that after wrestling with he build to stop
>> depending on the wrong findbugs_annotations, I feel somewhat lost. The
>> issue is actually quite small:
>>
>> - The JAR from the non-LGPL findbugs does not contain the
>> SuppressFBWarnings annotation. This means that when building, ByteBuddy
>> produces a few warnings (nothing critical).
>> - The easiest way to avoid this failure is to call
>> applyJavaNature(failOnWarning: false), but this would be bad, since we 
>> want
>> to keep a high standard for tasks like ErrorProne and FindBugs itself.
>> - So I find myself lost: How do we suppress trivial warnings coming
>> from missing annotations, and honor warnings coming from other plugins?
>>
>> Any help / a PR from someone more capable would be appreciated.
>> Best
>> -P.
>>
>> On Tue, Jun 12, 2018 at 3:02 PM Ismaël Mejía 
>> wrote:
>>
>>> Yes, ok I was not aware it was already being addressed, nice.
>>> On Tue, Jun 12, 2018 at 11:56 PM Ahmet Altay 
>>> wrote:
>>> >
>>> > Ismaël,

Re: [CANCEL][VOTE] Apache Beam, version 2.5.0, release candidate #1

[Pablo Estrada]

Precommits for PR https://github.com/apache/beam/pull/5609 are now passing.
For now I've simply set failOnWarning to false to cherrypick into the
release, and fix in master later on.
Best
-P.

On Wed, Jun 13, 2018 at 9:08 AM Scott Wegner  wrote:

> From my understanding, the @SuppressFBWarnings usage is in a dependency
> (ByteBuddy) rather than directly in our code; so we're not able to modify
> the usage.
>
> Pablo, feel free to disable failOnWarning for the sdks-java-core project
> temporarily. This isn't a major regression since we've only recently made
> the change to enable it [1]. We can work separately on figuring out how to
> resolve the warnings.
>
> [1] https://github.com/apache/beam/pull/5319
>
> On Tue, Jun 12, 2018 at 11:57 PM Tim Robertson 
> wrote:
>
>> Hi Pablo,
>>
>> I'm afraid I couldn't find one either... there is an issue about it [1]
>> which is old so it doesn't look likely to be resolved either.
>>
>> If you have time (sorry I am a bit busy) could you please verify the
>> version does work if you install that version locally? I know the maven
>> version of that [2] but not sure on the gradle equivalent. If we know it
>> works, we can then find a repository that fits ok with Apache/Beam policy.
>>
>> Alternatively, we could consider using a fully qualified reference (i.e.
>> @edu.umd.cs.findbugs.annotations.SuppressWarnings) to the deprecated
>> version and leave the dependency at the 1.3.9-1. I believe our general
>> direction is to remove findbugs when errorprone covers all aspects so I
>> *expect* this should be considered reasonable.
>>
>> I hope this helps,
>> Tim
>>
>> [1] https://github.com/stephenc/findbugs-annotations/issues/4
>> [2] https://maven.apache.org/guides/mini/guide-3rd-party-jars-local.html
>>
>> On Wed, Jun 13, 2018 at 8:39 AM, Pablo Estrada 
>> wrote:
>>
>>> Hi Tim,
>>> you're right. Thanks for pointing that out. There's just one problem
>>> that I'm running into now: The 3.0.1-1 version does not seem to be
>>> available in Maven Central[1]. Looking at the website, I am not quite sure
>>> if there's another repository where they do stage the newer versions?[2]
>>>
>>> -P
>>>
>>> [1]
>>> https://repo.maven.apache.org/maven2/com/github/stephenc/findbugs/findbugs-annotations
>>> /
>>> [2] http://stephenc.github.io/findbugs-annotations/
>>>
>>> On Tue, Jun 12, 2018 at 11:10 PM Tim Robertson <
>>> timrobertson...@gmail.com> wrote:
>>>
 Hi Pablo,

 I took only a quick look.

 "- The JAR from the non-LGPL findbugs does not contain the
 SuppressFBWarnings annotation"

 Unless I misunderstand you it looks like SuppressFBWarnings was added
 in Stephen's version in this commit [1] which was introduced in
 version 2.0.3-1 -  I've checked is in the 3.0.1-1 build [2]
 I notice in your commits [1] you've been exploring version 3.0.0
 already though... what happens when you use 3.0.1-1? It sounds like the
 wrong version is coming in rather than the annotation being missing.

 Thanks,
 Tim

 [1]
 https://github.com/stephenc/findbugs-annotations/commits/master/src/main/java/edu/umd/cs/findbugs/annotations/SuppressWarnings.java
 [2] https://github.com/stephenc/findbugs-annotations/releases
 [3]
 https://github.com/apache/beam/pull/5609/commits/32c7df706e970557f154ff6bc521b2e00f9d09ab







 On Wed, Jun 13, 2018 at 2:37 AM, Pablo Estrada 
 wrote:

> Hi all,
> I'll humbly declare that after wrestling with he build to stop
> depending on the wrong findbugs_annotations, I feel somewhat lost. The
> issue is actually quite small:
>
> - The JAR from the non-LGPL findbugs does not contain the
> SuppressFBWarnings annotation. This means that when building, ByteBuddy
> produces a few warnings (nothing critical).
> - The easiest way to avoid this failure is to call
> applyJavaNature(failOnWarning: false), but this would be bad, since we 
> want
> to keep a high standard for tasks like ErrorProne and FindBugs itself.
> - So I find myself lost: How do we suppress trivial warnings coming
> from missing annotations, and honor warnings coming from other plugins?
>
> Any help / a PR from someone more capable would be appreciated.
> Best
> -P.
>
> On Tue, Jun 12, 2018 at 3:02 PM Ismaël Mejía 
> wrote:
>
>> Yes, ok I was not aware it was already being addressed, nice.
>> On Tue, Jun 12, 2018 at 11:56 PM Ahmet Altay 
>> wrote:
>> >
>> > Ismaël,
>> >
>> > I believe Pablo's https://github.com/apache/beam/pull/5609 is
>> fixing the issue by changing the findbugs back to
>> "com.github.stephenc.findbugs". Is this what you are referring to?
>> >
>> > Ahmet
>> >
>> > On Tue, Jun 12, 2018 at 2:51 PM, Boyuan Zhang 
>> wrote:
>> >>
>> >> Hey JB,
>> >>
>> >> I added some instructions about how to create python wheels in
>> 

Re: [CANCEL][VOTE] Apache Beam, version 2.5.0, release candidate #1

[Scott Wegner]

>From my understanding, the @SuppressFBWarnings usage is in a dependency
(ByteBuddy) rather than directly in our code; so we're not able to modify
the usage.

Pablo, feel free to disable failOnWarning for the sdks-java-core project
temporarily. This isn't a major regression since we've only recently made
the change to enable it [1]. We can work separately on figuring out how to
resolve the warnings.

[1] https://github.com/apache/beam/pull/5319

On Tue, Jun 12, 2018 at 11:57 PM Tim Robertson 
wrote:

> Hi Pablo,
>
> I'm afraid I couldn't find one either... there is an issue about it [1]
> which is old so it doesn't look likely to be resolved either.
>
> If you have time (sorry I am a bit busy) could you please verify the
> version does work if you install that version locally? I know the maven
> version of that [2] but not sure on the gradle equivalent. If we know it
> works, we can then find a repository that fits ok with Apache/Beam policy.
>
> Alternatively, we could consider using a fully qualified reference (i.e.
> @edu.umd.cs.findbugs.annotations.SuppressWarnings) to the deprecated
> version and leave the dependency at the 1.3.9-1. I believe our general
> direction is to remove findbugs when errorprone covers all aspects so I
> *expect* this should be considered reasonable.
>
> I hope this helps,
> Tim
>
> [1] https://github.com/stephenc/findbugs-annotations/issues/4
> [2] https://maven.apache.org/guides/mini/guide-3rd-party-jars-local.html
>
> On Wed, Jun 13, 2018 at 8:39 AM, Pablo Estrada  wrote:
>
>> Hi Tim,
>> you're right. Thanks for pointing that out. There's just one problem that
>> I'm running into now: The 3.0.1-1 version does not seem to be available in
>> Maven Central[1]. Looking at the website, I am not quite sure if there's
>> another repository where they do stage the newer versions?[2]
>>
>> -P
>>
>> [1]
>> https://repo.maven.apache.org/maven2/com/github/stephenc/findbugs/findbugs-annotations
>> /
>> [2] http://stephenc.github.io/findbugs-annotations/
>>
>> On Tue, Jun 12, 2018 at 11:10 PM Tim Robertson 
>> wrote:
>>
>>> Hi Pablo,
>>>
>>> I took only a quick look.
>>>
>>> "- The JAR from the non-LGPL findbugs does not contain the
>>> SuppressFBWarnings annotation"
>>>
>>> Unless I misunderstand you it looks like SuppressFBWarnings was added in
>>> Stephen's version in this commit [1] which was introduced in version
>>> 2.0.3-1 -  I've checked is in the 3.0.1-1 build [2]
>>> I notice in your commits [1] you've been exploring version 3.0.0 already
>>> though... what happens when you use 3.0.1-1? It sounds like the wrong
>>> version is coming in rather than the annotation being missing.
>>>
>>> Thanks,
>>> Tim
>>>
>>> [1]
>>> https://github.com/stephenc/findbugs-annotations/commits/master/src/main/java/edu/umd/cs/findbugs/annotations/SuppressWarnings.java
>>> [2] https://github.com/stephenc/findbugs-annotations/releases
>>> [3]
>>> https://github.com/apache/beam/pull/5609/commits/32c7df706e970557f154ff6bc521b2e00f9d09ab
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> On Wed, Jun 13, 2018 at 2:37 AM, Pablo Estrada 
>>> wrote:
>>>
 Hi all,
 I'll humbly declare that after wrestling with he build to stop
 depending on the wrong findbugs_annotations, I feel somewhat lost. The
 issue is actually quite small:

 - The JAR from the non-LGPL findbugs does not contain the
 SuppressFBWarnings annotation. This means that when building, ByteBuddy
 produces a few warnings (nothing critical).
 - The easiest way to avoid this failure is to call
 applyJavaNature(failOnWarning: false), but this would be bad, since we want
 to keep a high standard for tasks like ErrorProne and FindBugs itself.
 - So I find myself lost: How do we suppress trivial warnings coming
 from missing annotations, and honor warnings coming from other plugins?

 Any help / a PR from someone more capable would be appreciated.
 Best
 -P.

 On Tue, Jun 12, 2018 at 3:02 PM Ismaël Mejía  wrote:

> Yes, ok I was not aware it was already being addressed, nice.
> On Tue, Jun 12, 2018 at 11:56 PM Ahmet Altay  wrote:
> >
> > Ismaël,
> >
> > I believe Pablo's https://github.com/apache/beam/pull/5609 is
> fixing the issue by changing the findbugs back to
> "com.github.stephenc.findbugs". Is this what you are referring to?
> >
> > Ahmet
> >
> > On Tue, Jun 12, 2018 at 2:51 PM, Boyuan Zhang 
> wrote:
> >>
> >> Hey JB,
> >>
> >> I added some instructions about how to create python wheels in this
> PR: https://github.com/apache/beam-site/pull/467 . Hope it would be
> helpful.
> >>
> >> Boyuan
> >>
> >
>
 --
 Got feedback? go/pabloem-feedback
 

>>>
>>> --
>> Got feedback? go/pabloem-feedback
>> 
>>
>
>

Re: [CANCEL][VOTE] Apache Beam, version 2.5.0, release candidate #1

[Tim Robertson]

Hi Pablo,

I'm afraid I couldn't find one either... there is an issue about it [1]
which is old so it doesn't look likely to be resolved either.

If you have time (sorry I am a bit busy) could you please verify the
version does work if you install that version locally? I know the maven
version of that [2] but not sure on the gradle equivalent. If we know it
works, we can then find a repository that fits ok with Apache/Beam policy.

Alternatively, we could consider using a fully qualified reference (i.e.
@edu.umd.cs.findbugs.annotations.SuppressWarnings) to the deprecated
version and leave the dependency at the 1.3.9-1. I believe our general
direction is to remove findbugs when errorprone covers all aspects so I
*expect* this should be considered reasonable.

I hope this helps,
Tim

[1] https://github.com/stephenc/findbugs-annotations/issues/4
[2] https://maven.apache.org/guides/mini/guide-3rd-party-jars-local.html

On Wed, Jun 13, 2018 at 8:39 AM, Pablo Estrada  wrote:

> Hi Tim,
> you're right. Thanks for pointing that out. There's just one problem that
> I'm running into now: The 3.0.1-1 version does not seem to be available in
> Maven Central[1]. Looking at the website, I am not quite sure if there's
> another repository where they do stage the newer versions?[2]
>
> -P
>
> [1] https://repo.maven.apache.org/maven2/com/github/
> stephenc/findbugs/findbugs-annotations/
> [2] http://stephenc.github.io/findbugs-annotations/
>
> On Tue, Jun 12, 2018 at 11:10 PM Tim Robertson 
> wrote:
>
>> Hi Pablo,
>>
>> I took only a quick look.
>>
>> "- The JAR from the non-LGPL findbugs does not contain the
>> SuppressFBWarnings annotation"
>>
>> Unless I misunderstand you it looks like SuppressFBWarnings was added in
>> Stephen's version in this commit [1] which was introduced in version
>> 2.0.3-1 -  I've checked is in the 3.0.1-1 build [2]
>> I notice in your commits [1] you've been exploring version 3.0.0 already
>> though... what happens when you use 3.0.1-1? It sounds like the wrong
>> version is coming in rather than the annotation being missing.
>>
>> Thanks,
>> Tim
>>
>> [1] https://github.com/stephenc/findbugs-annotations/
>> commits/master/src/main/java/edu/umd/cs/findbugs/
>> annotations/SuppressWarnings.java
>> [2] https://github.com/stephenc/findbugs-annotations/releases
>> [3] https://github.com/apache/beam/pull/5609/commits/
>> 32c7df706e970557f154ff6bc521b2e00f9d09ab
>>
>>
>>
>>
>>
>>
>>
>> On Wed, Jun 13, 2018 at 2:37 AM, Pablo Estrada 
>> wrote:
>>
>>> Hi all,
>>> I'll humbly declare that after wrestling with he build to stop depending
>>> on the wrong findbugs_annotations, I feel somewhat lost. The issue is
>>> actually quite small:
>>>
>>> - The JAR from the non-LGPL findbugs does not contain the
>>> SuppressFBWarnings annotation. This means that when building, ByteBuddy
>>> produces a few warnings (nothing critical).
>>> - The easiest way to avoid this failure is to call
>>> applyJavaNature(failOnWarning: false), but this would be bad, since we want
>>> to keep a high standard for tasks like ErrorProne and FindBugs itself.
>>> - So I find myself lost: How do we suppress trivial warnings coming from
>>> missing annotations, and honor warnings coming from other plugins?
>>>
>>> Any help / a PR from someone more capable would be appreciated.
>>> Best
>>> -P.
>>>
>>> On Tue, Jun 12, 2018 at 3:02 PM Ismaël Mejía  wrote:
>>>
 Yes, ok I was not aware it was already being addressed, nice.
 On Tue, Jun 12, 2018 at 11:56 PM Ahmet Altay  wrote:
 >
 > Ismaël,
 >
 > I believe Pablo's https://github.com/apache/beam/pull/5609 is fixing
 the issue by changing the findbugs back to "com.github.stephenc.findbugs".
 Is this what you are referring to?
 >
 > Ahmet
 >
 > On Tue, Jun 12, 2018 at 2:51 PM, Boyuan Zhang 
 wrote:
 >>
 >> Hey JB,
 >>
 >> I added some instructions about how to create python wheels in this
 PR: https://github.com/apache/beam-site/pull/467 . Hope it would be
 helpful.
 >>
 >> Boyuan
 >>
 >

>>> --
>>> Got feedback? go/pabloem-feedback
>>> 
>>>
>>
>> --
> Got feedback? go/pabloem-feedback
>

Re: [CANCEL][VOTE] Apache Beam, version 2.5.0, release candidate #1

[Pablo Estrada]

Hi Tim,
you're right. Thanks for pointing that out. There's just one problem that
I'm running into now: The 3.0.1-1 version does not seem to be available in
Maven Central[1]. Looking at the website, I am not quite sure if there's
another repository where they do stage the newer versions?[2]

-P

[1]
https://repo.maven.apache.org/maven2/com/github/stephenc/findbugs/findbugs-annotations
/
[2] http://stephenc.github.io/findbugs-annotations/

On Tue, Jun 12, 2018 at 11:10 PM Tim Robertson 
wrote:

> Hi Pablo,
>
> I took only a quick look.
>
> "- The JAR from the non-LGPL findbugs does not contain the
> SuppressFBWarnings annotation"
>
> Unless I misunderstand you it looks like SuppressFBWarnings was added in
> Stephen's version in this commit [1] which was introduced in version
> 2.0.3-1 -  I've checked is in the 3.0.1-1 build [2]
> I notice in your commits [1] you've been exploring version 3.0.0 already
> though... what happens when you use 3.0.1-1? It sounds like the wrong
> version is coming in rather than the annotation being missing.
>
> Thanks,
> Tim
>
> [1]
> https://github.com/stephenc/findbugs-annotations/commits/master/src/main/java/edu/umd/cs/findbugs/annotations/SuppressWarnings.java
> [2] https://github.com/stephenc/findbugs-annotations/releases
> [3]
> https://github.com/apache/beam/pull/5609/commits/32c7df706e970557f154ff6bc521b2e00f9d09ab
>
>
>
>
>
>
>
> On Wed, Jun 13, 2018 at 2:37 AM, Pablo Estrada  wrote:
>
>> Hi all,
>> I'll humbly declare that after wrestling with he build to stop depending
>> on the wrong findbugs_annotations, I feel somewhat lost. The issue is
>> actually quite small:
>>
>> - The JAR from the non-LGPL findbugs does not contain the
>> SuppressFBWarnings annotation. This means that when building, ByteBuddy
>> produces a few warnings (nothing critical).
>> - The easiest way to avoid this failure is to call
>> applyJavaNature(failOnWarning: false), but this would be bad, since we want
>> to keep a high standard for tasks like ErrorProne and FindBugs itself.
>> - So I find myself lost: How do we suppress trivial warnings coming from
>> missing annotations, and honor warnings coming from other plugins?
>>
>> Any help / a PR from someone more capable would be appreciated.
>> Best
>> -P.
>>
>> On Tue, Jun 12, 2018 at 3:02 PM Ismaël Mejía  wrote:
>>
>>> Yes, ok I was not aware it was already being addressed, nice.
>>> On Tue, Jun 12, 2018 at 11:56 PM Ahmet Altay  wrote:
>>> >
>>> > Ismaël,
>>> >
>>> > I believe Pablo's https://github.com/apache/beam/pull/5609 is fixing
>>> the issue by changing the findbugs back to "com.github.stephenc.findbugs".
>>> Is this what you are referring to?
>>> >
>>> > Ahmet
>>> >
>>> > On Tue, Jun 12, 2018 at 2:51 PM, Boyuan Zhang 
>>> wrote:
>>> >>
>>> >> Hey JB,
>>> >>
>>> >> I added some instructions about how to create python wheels in this
>>> PR: https://github.com/apache/beam-site/pull/467 . Hope it would be
>>> helpful.
>>> >>
>>> >> Boyuan
>>> >>
>>> >
>>>
>> --
>> Got feedback? go/pabloem-feedback
>> 
>>
>
> --
Got feedback? go/pabloem-feedback

Re: [CANCEL][VOTE] Apache Beam, version 2.5.0, release candidate #1

[Tim Robertson]

Hi Pablo,

I took only a quick look.

"- The JAR from the non-LGPL findbugs does not contain the
SuppressFBWarnings annotation"

Unless I misunderstand you it looks like SuppressFBWarnings was added in
Stephen's version in this commit [1] which was introduced in version
2.0.3-1 -  I've checked is in the 3.0.1-1 build [2]
I notice in your commits [1] you've been exploring version 3.0.0 already
though... what happens when you use 3.0.1-1? It sounds like the wrong
version is coming in rather than the annotation being missing.

Thanks,
Tim

[1]
https://github.com/stephenc/findbugs-annotations/commits/master/src/main/java/edu/umd/cs/findbugs/annotations/SuppressWarnings.java
[2] https://github.com/stephenc/findbugs-annotations/releases
[3]
https://github.com/apache/beam/pull/5609/commits/32c7df706e970557f154ff6bc521b2e00f9d09ab







On Wed, Jun 13, 2018 at 2:37 AM, Pablo Estrada  wrote:

> Hi all,
> I'll humbly declare that after wrestling with he build to stop depending
> on the wrong findbugs_annotations, I feel somewhat lost. The issue is
> actually quite small:
>
> - The JAR from the non-LGPL findbugs does not contain the
> SuppressFBWarnings annotation. This means that when building, ByteBuddy
> produces a few warnings (nothing critical).
> - The easiest way to avoid this failure is to call
> applyJavaNature(failOnWarning: false), but this would be bad, since we want
> to keep a high standard for tasks like ErrorProne and FindBugs itself.
> - So I find myself lost: How do we suppress trivial warnings coming from
> missing annotations, and honor warnings coming from other plugins?
>
> Any help / a PR from someone more capable would be appreciated.
> Best
> -P.
>
> On Tue, Jun 12, 2018 at 3:02 PM Ismaël Mejía  wrote:
>
>> Yes, ok I was not aware it was already being addressed, nice.
>> On Tue, Jun 12, 2018 at 11:56 PM Ahmet Altay  wrote:
>> >
>> > Ismaël,
>> >
>> > I believe Pablo's https://github.com/apache/beam/pull/5609 is fixing
>> the issue by changing the findbugs back to "com.github.stephenc.findbugs".
>> Is this what you are referring to?
>> >
>> > Ahmet
>> >
>> > On Tue, Jun 12, 2018 at 2:51 PM, Boyuan Zhang 
>> wrote:
>> >>
>> >> Hey JB,
>> >>
>> >> I added some instructions about how to create python wheels in this
>> PR: https://github.com/apache/beam-site/pull/467 . Hope it would be
>> helpful.
>> >>
>> >> Boyuan
>> >>
>> >
>>
> --
> Got feedback? go/pabloem-feedback
>

Re: [CANCEL][VOTE] Apache Beam, version 2.5.0, release candidate #1

[Pablo Estrada]

Hi all,
I'll humbly declare that after wrestling with he build to stop depending on
the wrong findbugs_annotations, I feel somewhat lost. The issue is actually
quite small:

- The JAR from the non-LGPL findbugs does not contain the
SuppressFBWarnings annotation. This means that when building, ByteBuddy
produces a few warnings (nothing critical).
- The easiest way to avoid this failure is to call
applyJavaNature(failOnWarning: false), but this would be bad, since we want
to keep a high standard for tasks like ErrorProne and FindBugs itself.
- So I find myself lost: How do we suppress trivial warnings coming from
missing annotations, and honor warnings coming from other plugins?

Any help / a PR from someone more capable would be appreciated.
Best
-P.

On Tue, Jun 12, 2018 at 3:02 PM Ismaël Mejía  wrote:

> Yes, ok I was not aware it was already being addressed, nice.
> On Tue, Jun 12, 2018 at 11:56 PM Ahmet Altay  wrote:
> >
> > Ismaël,
> >
> > I believe Pablo's https://github.com/apache/beam/pull/5609 is fixing
> the issue by changing the findbugs back to "com.github.stephenc.findbugs".
> Is this what you are referring to?
> >
> > Ahmet
> >
> > On Tue, Jun 12, 2018 at 2:51 PM, Boyuan Zhang 
> wrote:
> >>
> >> Hey JB,
> >>
> >> I added some instructions about how to create python wheels in this PR:
> https://github.com/apache/beam-site/pull/467 . Hope it would be helpful.
> >>
> >> Boyuan
> >>
> >
>
-- 
Got feedback? go/pabloem-feedback

Re: [CANCEL][VOTE] Apache Beam, version 2.5.0, release candidate #1

[Ismaël Mejía]

Yes, ok I was not aware it was already being addressed, nice.
On Tue, Jun 12, 2018 at 11:56 PM Ahmet Altay  wrote:
>
> Ismaël,
>
> I believe Pablo's https://github.com/apache/beam/pull/5609 is fixing the 
> issue by changing the findbugs back to "com.github.stephenc.findbugs". Is 
> this what you are referring to?
>
> Ahmet
>
> On Tue, Jun 12, 2018 at 2:51 PM, Boyuan Zhang  wrote:
>>
>> Hey JB,
>>
>> I added some instructions about how to create python wheels in this PR: 
>> https://github.com/apache/beam-site/pull/467 . Hope it would be helpful.
>>
>> Boyuan
>>
>

Re: [CANCEL][VOTE] Apache Beam, version 2.5.0, release candidate #1

[Ahmet Altay]

Ismaël,

I believe Pablo's https://github.com/apache/beam/pull/5609 is fixing the
issue by changing the findbugs back to "com.github.stephenc.findbugs". Is
this what you are referring to?

Ahmet

On Tue, Jun 12, 2018 at 2:51 PM, Boyuan Zhang  wrote:

> Hey JB,
>
> I added some instructions about how to create python wheels in this PR:
> https://github.com/apache/beam-site/pull/467 . Hope it would be helpful.
>
> Boyuan
>
>

Re: [CANCEL][VOTE] Apache Beam, version 2.5.0, release candidate #1

[Boyuan Zhang]

Hey JB,

I added some instructions about how to create python wheels in this PR:
https://github.com/apache/beam-site/pull/467 . Hope it would be helpful.

Boyuan

On Tue, Jun 12, 2018 at 12:33 PM Jean-Baptiste Onofré 
wrote:

> Hi all,
>
> due to issues found by Udi and Pablo, I cancel RC1 to prepare a new
> release.
>
> Thanks Udi and Pablo for catching up.
>
> I will prepare a RC2 after cherry pick/fixed the found issues (tomorrow
> morning my time).
>
> Regards
> JB
>
>
> On 12/06/2018 21:04, Pablo Estrada wrote:
> > Hello all,
> > I've found another release blocker: The current findbugs dependency in
> > build_rules.gradle has a GPL license. Here's the PR to depend on the
> > correct findbugs: https://github.com/apache/beam/pull/5609
> >
> > Best
> > -P.
> >
> > On Tue, Jun 12, 2018 at 11:03 AM Udi Meiri  > > wrote:
> >
> > Cherrypick created: https://github.com/apache/beam/pull/5607
> > Tests still running.
> >
> > On Tue, Jun 12, 2018 at 9:59 AM Udi Meiri  > > wrote:
> >
> > -1: Would like to cherry pick a fix
> > for https://issues.apache.org/jira/browse/BEAM-4536
> >
> > On Tue, Jun 12, 2018 at 9:48 AM Jean-Baptiste Onofré
> > mailto:j...@nanthrax.net>> wrote:
> >
> > Any update about your vote and fix ?
> >
> > Thanks !
> > Regards
> > JB
> >
> > On 12/06/2018 04:02, Udi Meiri wrote:
> > > Another bug: reading from PubSub with_attributes=True is
> > broken on
> > > Python with Dataflow.
> > > https://issues.apache.org/jira/browse/BEAM-4536
> > >
> > > JB, I'm making a PR that removes this keyword and I'd like
> > to propose it
> > > as a cherrypick to 2.5.0.
> > > (feature should be fixed in the next release)
> > >
> > > On Mon, Jun 11, 2018 at 6:19 PM Chamikara Jayalath
> > mailto:chamik...@google.com>
> > >  > >> wrote:
> > >
> > > FYI: looks like Python tests are failing for Windows.
> JIRA
> > > is https://issues.apache.org/jira/browse/BEAM-4535.
> > >
> > > I don't think this is a release blocker but this
> > should probably go
> > > in release notes (for any user that tries to run tests
> > on Python
> > > source build). And we should try to incorporate a fix
> > if we happen
> > > to cut another release candidate for some reason.
> > >
> > > Thanks,
> > > Cham
> > >
> > > On Mon, Jun 11, 2018 at 5:46 PM Pablo Estrada
> > mailto:pabl...@google.com>
> > >  > >> wrote:
> > >
> > > Thanks everyone who has pitched in to validate the
> > release!
> > >
> > > Boyuan Zhang and I have also run a few pipelines,
> > and verified
> > > that they work properly (see release validation
> > spreadsheet[1]).
> > >
> > > We have also found that the Game Stats pipeline is
> > failing in
> > > Python Streaming Dataflow. I have filed
> > BEAM-4534[2]. This is
> > > not a blocker, since Python streaming is not yet
> > fully supported.
> > >
> > > It seems that the uploaded artifacts look good.
> > >
> > > We have noticed that the Python artifacts are
> > still missing
> > > Python wheel files (compare [3] and [4]). JB,
> > could you please
> > > add the wheel files? Boyuan and I can try to help
> > you prepare
> > > them / upload them if necessary. Please let us
> know.
> > >
> > > Thanks again!
> > > -P.
> > >
> > >
> >  [1]
> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=152451807
> > > [2]
> https://issues.apache.org/jira/browse/BEAM-4534
> > > [3]
> https://dist.apache.org/repos/dist/dev/beam/2.4.0/
> > > [4]
> https://dist.apache.org/repos/dist/dev/beam/2.5.0/
> > >
> > > On Mon, Jun 11, 2018 at 12:37 PM Alan Myrvold
> > > mailto:amyrv...@google.com>
> > >>
> > wrote:
> > >
> > > 

Re: [CANCEL][VOTE] Apache Beam, version 2.5.0, release candidate #1

[Ismaël Mejía]

There is another issue highlighted by Scott Wegner in a non-related to
the vote PR discussion.
https://github.com/apache/beam/pull/5540

It seems that in the migration to gradle we changed the
findbugs-annotations library from com.github.stephenc.findbugs to
com.google.code.findbugs:findbugs-annotations and this one is LGPL
licensed so we should address that too for the next RC.

On Tue, Jun 12, 2018 at 9:33 PM Jean-Baptiste Onofré  wrote:
>
> Hi all,
>
> due to issues found by Udi and Pablo, I cancel RC1 to prepare a new release.
>
> Thanks Udi and Pablo for catching up.
>
> I will prepare a RC2 after cherry pick/fixed the found issues (tomorrow
> morning my time).
>
> Regards
> JB
>
>
> On 12/06/2018 21:04, Pablo Estrada wrote:
> > Hello all,
> > I've found another release blocker: The current findbugs dependency in
> > build_rules.gradle has a GPL license. Here's the PR to depend on the
> > correct findbugs: https://github.com/apache/beam/pull/5609
> >
> > Best
> > -P.
> >
> > On Tue, Jun 12, 2018 at 11:03 AM Udi Meiri  > > wrote:
> >
> > Cherrypick created: https://github.com/apache/beam/pull/5607
> > Tests still running.
> >
> > On Tue, Jun 12, 2018 at 9:59 AM Udi Meiri  > > wrote:
> >
> > -1: Would like to cherry pick a fix
> > for https://issues.apache.org/jira/browse/BEAM-4536
> >
> > On Tue, Jun 12, 2018 at 9:48 AM Jean-Baptiste Onofré
> > mailto:j...@nanthrax.net>> wrote:
> >
> > Any update about your vote and fix ?
> >
> > Thanks !
> > Regards
> > JB
> >
> > On 12/06/2018 04:02, Udi Meiri wrote:
> > > Another bug: reading from PubSub with_attributes=True is
> > broken on
> > > Python with Dataflow.
> > > https://issues.apache.org/jira/browse/BEAM-4536
> > >
> > > JB, I'm making a PR that removes this keyword and I'd like
> > to propose it
> > > as a cherrypick to 2.5.0.
> > > (feature should be fixed in the next release)
> > >
> > > On Mon, Jun 11, 2018 at 6:19 PM Chamikara Jayalath
> > mailto:chamik...@google.com>
> > >  > >> wrote:
> > >
> > > FYI: looks like Python tests are failing for Windows. JIRA
> > > is https://issues.apache.org/jira/browse/BEAM-4535.
> > >
> > > I don't think this is a release blocker but this
> > should probably go
> > > in release notes (for any user that tries to run tests
> > on Python
> > > source build). And we should try to incorporate a fix
> > if we happen
> > > to cut another release candidate for some reason.
> > >
> > > Thanks,
> > > Cham
> > >
> > > On Mon, Jun 11, 2018 at 5:46 PM Pablo Estrada
> > mailto:pabl...@google.com>
> > >  > >> wrote:
> > >
> > > Thanks everyone who has pitched in to validate the
> > release!
> > >
> > > Boyuan Zhang and I have also run a few pipelines,
> > and verified
> > > that they work properly (see release validation
> > spreadsheet[1]).
> > >
> > > We have also found that the Game Stats pipeline is
> > failing in
> > > Python Streaming Dataflow. I have filed
> > BEAM-4534[2]. This is
> > > not a blocker, since Python streaming is not yet
> > fully supported.
> > >
> > > It seems that the uploaded artifacts look good.
> > >
> > > We have noticed that the Python artifacts are
> > still missing
> > > Python wheel files (compare [3] and [4]). JB,
> > could you please
> > > add the wheel files? Boyuan and I can try to help
> > you prepare
> > > them / upload them if necessary. Please let us know.
> > >
> > > Thanks again!
> > > -P.
> > >
> > >
> >  [1] 
> > https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=152451807
> > > [2] https://issues.apache.org/jira/browse/BEAM-4534
> > > [3] https://dist.apache.org/repos/dist/dev/beam/2.4.0/
> > > [4] https://dist.apache.org/repos/dist/dev/beam/2.5.0/
> > >
> > > On Mon, Jun 11, 2018 at 12:37 P