[GitHub] bigtop issue #151: BIGTOP-2553: add rpc/http/https ports to template for non...

2016-10-18 Thread johnsca
Github user johnsca commented on the issue: https://github.com/apache/bigtop/pull/151 @kwmonroe My point was that, since `namenode_hosts` only contains one item in the non-HA case, and the only difference in the code between the HA case and non-HA case was whether we looped over the c

[GitHub] bigtop issue #151: BIGTOP-2553: add rpc/http/https ports to template for non...

2016-10-18 Thread kwmonroe
Github user kwmonroe commented on the issue: https://github.com/apache/bigtop/pull/151 I think you're saying the `namenode_hosts[host, index]` loop is the only difference, but that's a pretty big difference. The hdfs-site.xml property keys are not the same in HA and non-HA cases.

[GitHub] bigtop issue #151: BIGTOP-2553: add rpc/http/https ports to template for non...

2016-10-18 Thread johnsca
Github user johnsca commented on the issue: https://github.com/apache/bigtop/pull/151 Oh, of course you're correct. My mistake. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th