[GitHub] brooklyn-server issue #278: rest api: entity/spec returns unquoted text/x-ya...

2016-07-30 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/278 LGTM / Tested --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] brooklyn-ui issue #31: show tabs in CM editor

2016-08-12 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-ui/pull/31 LGTM / Tested --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] brooklyn-ui pull request #32: Make absolute paths relative

2016-08-12 Thread m4rkmckenna
GitHub user m4rkmckenna opened a pull request: https://github.com/apache/brooklyn-ui/pull/32 Make absolute paths relative Allows you to move the brooklyn-ui from root You can merge this pull request into a Git repository by running: $ git pull https://github.com/m4rkmckenna

[GitHub] brooklyn-ui issue #32: Make absolute paths relative

2016-08-16 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-ui/pull/32 Thanks @tbouron amended --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-ui issue #32: Make absolute paths relative

2016-08-16 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-ui/pull/32 @tbouron sorry my bad ... forgot how git works --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-ui pull request #30: BROOKLYN-323: Improve logout script

2016-08-24 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/30#discussion_r76034844 --- Diff: src/main/webapp/assets/js/util/brooklyn-utils.js --- @@ -175,17 +175,16 @@ define([ }; Util.logout = function logout

[GitHub] brooklyn-ui issue #30: BROOKLYN-323: Improve logout script

2016-08-24 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-ui/pull/30 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] brooklyn-server issue #333: Revert "Update geoip to latest version"

2016-09-19 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/333 Confirmed that this fixes the build / downstream builds --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] brooklyn-dist pull request #56: [DO NOT MERGE] docker image, for standalone ...

2016-11-01 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/56#discussion_r85938600 --- Diff: docker/Dockerfile --- @@ -0,0 +1,68 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] brooklyn-server pull request #450: Allow all certs in TestHttpCall

2016-11-21 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/450#discussion_r3889 --- Diff: test-framework/src/main/java/org/apache/brooklyn/test/framework/TestHttpCall.java --- @@ -51,6 +51,8

[GitHub] brooklyn-library pull request #76: Tweak to password change effector so that...

2016-11-25 Thread m4rkmckenna
GitHub user m4rkmckenna opened a pull request: https://github.com/apache/brooklyn-library/pull/76 Tweak to password change effector so that sed identifier is escaped *Previously* `s@@@g` would not work for a password with an `@` *Now* `s///g` `/` values are escaped in

[GitHub] brooklyn-library issue #76: Tweak to password change effector so that sed id...

2016-11-25 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-library/pull/76 @neykov IMO sed is not the correct tool. I know if i was writing a blueprint that was touching any config files id just install [Augeas](http://augeas.net/) and use it

[GitHub] brooklyn-library pull request #78: A URI must contain a protocol

2016-11-25 Thread m4rkmckenna
GitHub user m4rkmckenna opened a pull request: https://github.com/apache/brooklyn-library/pull/78 A URI must contain a protocol Zookeeper node fails as a `URISyntaxException` is thrown creating the main uri You can merge this pull request into a Git repository by

[GitHub] brooklyn-server pull request #481: [WIP] [NOT MERGE] Jclouds 2.0.0

2016-12-09 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/481#discussion_r91703404 --- Diff: karaf/features/src/main/feature/feature.xml --- @@ -260,13 +260,13 @@ mvn:org.apache.jclouds.driver/jclouds-okhttp

[GitHub] brooklyn-server pull request #481: [WIP] [NOT MERGE] Jclouds 2.0.0

2016-12-09 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/481#discussion_r91704893 --- Diff: karaf/features/src/main/feature/feature.xml --- @@ -260,13 +260,13 @@ mvn:org.apache.jclouds.driver/jclouds-okhttp

[GitHub] brooklyn-server pull request #481: [WIP] [NOT MERGE] Jclouds 2.0.0

2016-12-09 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/481#discussion_r91710710 --- Diff: karaf/features/src/main/feature/feature.xml --- @@ -260,13 +260,13 @@ mvn:org.apache.jclouds.driver/jclouds-okhttp

[GitHub] brooklyn-server pull request #481: [WIP] [NOT MERGE] Jclouds 2.0.0

2016-12-09 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/481#discussion_r91731763 --- Diff: karaf/features/src/main/feature/feature.xml --- @@ -260,13 +260,13 @@ mvn:org.apache.jclouds.driver/jclouds-okhttp

[GitHub] brooklyn-server pull request #481: [WIP] [NOT MERGE] Jclouds 2.0.0

2016-12-12 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/481#discussion_r91934240 --- Diff: karaf/features/src/main/feature/feature.xml --- @@ -260,13 +260,13 @@ mvn:org.apache.jclouds.driver/jclouds-okhttp

[GitHub] brooklyn-dist pull request #70: Reorder `brooklyn-locations-jclouds` so that...

2016-12-13 Thread m4rkmckenna
GitHub user m4rkmckenna opened a pull request: https://github.com/apache/brooklyn-dist/pull/70 Reorder `brooklyn-locations-jclouds` so that its installed before library features Related to https://github.com/apache/brooklyn-server/pull/481 You can merge this pull request into a

[GitHub] brooklyn-server issue #487: Change default `machineCreateAttempts` to 3

2016-12-15 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/487 @tbouron A task per try would be make it clear what happened An hour to fail provisioning (due to misconfiguration) seems like terrible UX so 2 attempts seems like a good

[GitHub] brooklyn-server pull request #492: Allow a user to add or override deseriali...

2016-12-15 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/492#discussion_r92615723 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingClassRenamesProvider.java --- @@ -54,12 +55,20

[GitHub] brooklyn-server pull request #492: Allow a user to add or override deseriali...

2016-12-15 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/492#discussion_r92615373 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingClassRenamesProvider.java --- @@ -37,7 +37,8 @@ public

[GitHub] brooklyn-server pull request #492: Allow a user to add or override deseriali...

2016-12-15 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/492#discussion_r92625798 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingClassRenamesProvider.java --- @@ -54,12 +55,20

[GitHub] brooklyn-server issue #492: Allow a user to add or override deserialize conf...

2016-12-15 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/492 @neykov i think you should be able to get `KARAF_HOME` from the env --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] brooklyn-server pull request #492: Allow a user to add or override deseriali...

2016-12-22 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/492#discussion_r93602795 --- Diff: core/pom.xml --- @@ -237,6 +237,11 @@ tests test

[GitHub] brooklyn-dist pull request #72: Allow a user to add or override deserialize ...

2016-12-22 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/72#discussion_r93714683 --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.apache.brooklyn.classrename.cfg --- @@ -0,0 +1,21

[GitHub] brooklyn-dist issue #72: Allow a user to add or override deserialize configu...

2016-12-28 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-dist/pull/72 @tbouron The pattern is probably not that well known but IMO it's cleaner and the cfg files are versioned --- If your project is set up for it, you can reply to this email and have

[GitHub] brooklyn-server pull request #492: Allow a user to add or override deseriali...

2017-01-04 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/492#discussion_r94558762 --- Diff: karaf/init/pom.xml --- @@ -75,7 +75,18 @@ true

[GitHub] brooklyn-dist pull request #72: Allow a user to add or override deserialize ...

2017-01-05 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/72#discussion_r94785663 --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.apache.brooklyn.classrename.cfg --- @@ -0,0 +1,21

[GitHub] brooklyn-dist issue #75: Use new brooklyn-server-config feature

2017-01-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-dist/pull/75 I think we need to have these files in place before boot for discoverability I would go with the `maven-dependency-plugin` to add them to the etc directory at the correct phase

[GitHub] brooklyn-dist pull request #76: Makes the default catalog location configura...

2017-01-06 Thread m4rkmckenna
GitHub user m4rkmckenna opened a pull request: https://github.com/apache/brooklyn-dist/pull/76 Makes the default catalog location configurable default catalog location can now be configured using the below PID `org.apache.brooklyn.osgilauncher/default.catalog.location

[GitHub] brooklyn-server pull request #507: Makes the default catalog location config...

2017-01-06 Thread m4rkmckenna
GitHub user m4rkmckenna opened a pull request: https://github.com/apache/brooklyn-server/pull/507 Makes the default catalog location configurable default catalog location can now be configured using the below PID `org.apache.brooklyn.osgilauncher/default.catalog.location

[GitHub] brooklyn-dist issue #75: Use new brooklyn-server-config feature

2017-01-09 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-dist/pull/75 @drigodwin the classic launcher (to my knowledge) doesn't use any of this config --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] brooklyn-dist issue #75: Use new brooklyn-server-config feature

2017-01-10 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-dist/pull/75 @aledsage This is the correct way to go IMO. **BUT** before this can be merged I would want the config files put in place at compile not at first boot --- If your project is set

[GitHub] brooklyn-server issue #504: Make the brooklyn server config discoverable by ...

2017-01-10 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/504 @neykov My personal pref is to keep the config files in the same repository as the code that uses it ... I hate PRs that span multiple repositories but i guess its not that big a deal

[GitHub] brooklyn-server issue #509: [wip] Add Azure Location

2017-01-10 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/509 @drigodwin @aledsage I tweaked the startup order in 6b90a4a this now works as expected --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server pull request #510: Fix logging of creation string in Jclouds...

2017-01-10 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/510#discussion_r95351893 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -651,7 +651,7 @@ protected

[GitHub] brooklyn-server issue #519: WIP Add CXF CrossOriginResourceSharing filter

2017-01-13 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/519 @bostko how is the filter configured? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] brooklyn-library pull request #84: Updates zookeeper download URL

2017-01-16 Thread m4rkmckenna
GitHub user m4rkmckenna opened a pull request: https://github.com/apache/brooklyn-library/pull/84 Updates zookeeper download URL Fastbull is not longer a valid download URL for zookeeper ... changed to apache hosted You can merge this pull request into a Git repository by running

[GitHub] brooklyn-library pull request #84: Updates zookeeper download URL

2017-01-16 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/84#discussion_r96202857 --- Diff: software/messaging/src/main/java/org/apache/brooklyn/entity/zookeeper/ZooKeeperNode.java --- @@ -46,7 +46,7

[GitHub] brooklyn-library pull request #84: Updates zookeeper download URL

2017-01-16 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/84#discussion_r96203547 --- Diff: software/messaging/src/main/java/org/apache/brooklyn/entity/zookeeper/ZooKeeperNode.java --- @@ -46,7 +46,7

[GitHub] brooklyn-library pull request #85: Amends ZK download url so that filename p...

2017-01-16 Thread m4rkmckenna
GitHub user m4rkmckenna opened a pull request: https://github.com/apache/brooklyn-library/pull/85 Amends ZK download url so that filename param comes last Previously this caused the script to fork / never install You can merge this pull request into a Git repository by running

[GitHub] brooklyn-server pull request: [OSGi] Support JAAS auth in Jetty

2016-03-19 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-server/pull/41#issuecomment-197400537 Tested this along with #31 & #55 ... noticed the following Works as expected with the following in your `brooklyn.proper

[GitHub] brooklyn-server pull request: [OSGi] Load jclouds bundles in Karaf

2016-03-21 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/73#discussion_r56885604 --- Diff: karaf/features/src/main/feature/feature.xml --- @@ -16,12 +16,17 @@ See the License for the specific language governing

[GitHub] brooklyn-server pull request: a few more OSGi fixes

2016-03-30 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/93#discussion_r57946766 --- Diff: karaf/features/src/main/feature/feature.xml --- @@ -27,6 +27,12 @@ http://central.maven.org/maven2/org/apache

[GitHub] brooklyn-server pull request: a few more OSGi fixes

2016-03-30 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-server/pull/93#issuecomment-203670077 @ahgittin RE logging from karaf console `log:set ` eg `log:set WARN org.apache.brooklyn` Or edit the logging config file under karf/etc can&#

[GitHub] brooklyn-server pull request: a few more OSGi fixes

2016-03-30 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-server/pull/93#issuecomment-203672111 @ahgittin We would need to port the existing logback into https://github.com/apache/brooklyn-server/blob/master/karaf/apache-brooklyn/src/main/resources/etc

[GitHub] brooklyn-server pull request: a few more OSGi fixes

2016-04-01 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-server/pull/93#issuecomment-204342824 @ahgittin Re [Auth / Unauthenticated Access to static content] I couldn't re-produce ... Tested using a chrome incognito tab and was prompted for

[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...

2016-04-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-ui/pull/23#issuecomment-206376464 LGTM Tested with a simulated 50 kb/s connection ... worked as expected --- If your project is set up for it, you can reply to this email and have your

[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...

2016-04-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-ui/pull/23#issuecomment-206420422 @aledsage +1 to including in the 0.9.0 release --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] brooklyn-client pull request: Use Go 1.6 vendoring instead of Gode...

2016-04-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-client/pull/16#issuecomment-206434349 LGTM :: Warnings are gone :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206444894 LGTM **MINOR** * Might be worth adding styling for dragover * Might be worth verifying the type of the dropped file --- If your project is set

[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206451829 My thinking was binding to the dragenter / dragover / dragleave events from the textarea assuming the codemirror code propagates said events. Then

[GitHub] brooklyn-dist pull request: Fix deb package java dependencies

2016-04-12 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/33#discussion_r59369611 --- Diff: deb-packaging/src/deb/control/postrm --- @@ -15,4 +15,6 @@ # KIND, either express or implied. See the License for the

[GitHub] brooklyn-docs pull request: Initial OSGi docs

2016-04-12 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/44#discussion_r59375180 --- Diff: guide/misc/osgi.md --- @@ -0,0 +1,63 @@ +--- +title: FAQ +layout: website-normal +--- + +# Running Apache Brooklin

[GitHub] brooklyn-server pull request: [OSGi] Load properties from config a...

2016-04-12 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/107#discussion_r59376066 --- Diff: karaf/init/src/main/java/org/apache/brooklyn/launcher/osgi/OsgiLauncher.java --- @@ -23,36 +26,78 @@ import

[GitHub] brooklyn-dist pull request: Fix deb package java dependencies

2016-04-12 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-dist/pull/33#issuecomment-208915346 @johnmccabe @alrick87 ``` ${project.build.directory}/apache-brooklyn_${project.version}_all.deb ``` --- If your project is set up for it, you

[GitHub] brooklyn-server pull request: Add Karaf equivalents of cloud comma...

2016-05-12 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/131#discussion_r62988207 --- Diff: launcher-common/src/main/java/org/apache/brooklyn/launcher/command/support/CloudExplorerSupport.java --- @@ -0,0 +1,437

[GitHub] brooklyn-server pull request: Add Karaf equivalents of cloud comma...

2016-05-12 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-server/pull/131#issuecomment-218709538 LGTM :: Tested against openstack As mentioned above the output could be made prettier by using `ShellTable` but this shouldn't hold up th

[GitHub] brooklyn-client pull request: [BROOKLYN-280] add --skipSslChecks f...

2016-05-25 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-client/pull/21#issuecomment-221651007 +1 to matching curl --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] brooklyn-server pull request #182: Change to Catalog API so that policy conf...

2016-06-04 Thread m4rkmckenna
GitHub user m4rkmckenna opened a pull request: https://github.com/apache/brooklyn-server/pull/182 Change to Catalog API so that policy config is correctly returned You can merge this pull request into a Git repository by running: $ git pull https://github.com/m4rkmckenna

[GitHub] brooklyn-server issue #182: Change to Catalog API so that policy config is c...

2016-06-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/182 @neykov comments addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-server pull request #210: Adds the ability for you to fetch all chi...

2016-06-21 Thread m4rkmckenna
GitHub user m4rkmckenna opened a pull request: https://github.com/apache/brooklyn-server/pull/210 Adds the ability for you to fetch all children of an activity Example GET http://localhost:8081/v1/activities/abc123/children/recurse ``` { "sCx

[GitHub] brooklyn-server pull request #210: Adds the ability for you to fetch all chi...

2016-06-21 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/210#discussion_r67854531 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/ActivityApi.java --- @@ -57,6 +57,18 @@ public TaskSummary get

[GitHub] brooklyn-server issue #210: Adds the ability for you to fetch all children o...

2016-06-23 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/210 @neykov > What's the use case for this API? When debugging you are usually only interested in one task being able to fetch the full tree makes debugging much easie

[GitHub] brooklyn-server pull request #255: BROOKLYN-316: fix use of karaf jetty Logi...

2016-07-13 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/255#discussion_r70627205 --- Diff: karaf/jetty-config/src/main/resources/jetty.xml --- @@ -56,6 +56,9

[GitHub] brooklyn-server issue #255: BROOKLYN-316: fix use of karaf jetty LoginServic...

2016-07-13 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/255 LGTM / tested --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] brooklyn-server pull request #519: Add experimental CORS server support

2017-01-18 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/519#discussion_r96609214 --- Diff: core/src/main/java/org/apache/brooklyn/core/BrooklynFeatureEnablement.java --- @@ -61,6 +61,36 @@ /** whether feeds are

[GitHub] brooklyn-server pull request #519: Add experimental CORS server support

2017-01-18 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/519#discussion_r96662638 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/filter/CorsImplSupplierFilter.java --- @@ -0,0 +1,81

[GitHub] brooklyn-server pull request #528: BROOKLYN-426: avoid propagating NoClassDe...

2017-01-19 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/528#discussion_r96872949 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/LoaderDispatcher.java --- @@ -44,6 +44,10 @@ return Maybe.>

[GitHub] brooklyn-server issue #519: Add experimental CORS server support

2017-01-23 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/519 @bostko One from @geomacy RE javadoc (DRY) ... I think the rest have been addressed --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server issue #544: Prefer centos 7

2017-01-31 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/544 @geomacy @duncangrant It was a question and should not be included in this pr But I can see value in exposing all of the hardcoded weights that are within this class. IMO

[GitHub] brooklyn-server pull request #516: Add unit tests for Karaf features

2017-02-15 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/516#discussion_r101255165 --- Diff: karaf/itests/pom.xml --- @@ -0,0 +1,180 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] brooklyn-server pull request #516: Add unit tests for Karaf features

2017-02-15 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/516#discussion_r101255832 --- Diff: karaf/features/src/main/feature/feature.xml --- @@ -260,7 +260,7 @@ https://github.com/square/okhttp/pull/2246

[GitHub] brooklyn-server pull request #516: Add unit tests for Karaf features

2017-02-15 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/516#discussion_r101255259 --- Diff: karaf/itests/pom.xml --- @@ -0,0 +1,180 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] brooklyn-server pull request #516: Add unit tests for Karaf features

2017-02-18 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/516#discussion_r101894381 --- Diff: karaf/itests/src/test/java/org/apache/brooklyn/karaf/itests/FeatureInstallationTest.java --- @@ -0,0 +1,83

[GitHub] brooklyn-server pull request #516: Add unit tests for Karaf features

2017-02-18 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/516#discussion_r101894152 --- Diff: karaf/itests/pom.xml --- @@ -0,0 +1,172 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] brooklyn-server pull request #593: BROOKLYN-451: Adds yaml-dsl rebind tests ...

2017-03-14 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/593#discussion_r105952235 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/xstream/XmlSerializer.java --- @@ -80,6 +80,11 @@ protected MapperWrapper wrapMapper

[GitHub] brooklyn-server pull request #593: BROOKLYN-451: Adds yaml-dsl rebind tests ...

2017-03-14 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/593#discussion_r105952999 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/xstream/ObjectWithDefaultStringImplConverter.java --- @@ -0,0 +1,86

[GitHub] brooklyn-library issue #76: Tweak to password change effector so that sed id...

2017-03-28 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-library/pull/76 @tbouron It would be better to create a pure yaml implementation of this blueprint --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server pull request #612: Brooklyn Camp syntax for adding tags to a...

2017-03-29 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/612#discussion_r108632513 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java --- @@ -257,6

[GitHub] brooklyn-server issue #623: BundleMaker copy fix

2017-04-07 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/623 @Graeme-Miller Can you provide steps to re-produce ... does this happen for every uploaded zip? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] brooklyn-library pull request #76: Tweak to password change effector so that...

2017-04-11 Thread m4rkmckenna
Github user m4rkmckenna closed the pull request at: https://github.com/apache/brooklyn-library/pull/76 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request #635: Allow passing "latest" as version for cat...

2017-04-14 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/635#discussion_r111546975 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/CatalogResource.java --- @@ -331,6 +332,10 @@ public void

[GitHub] brooklyn-server pull request #635: Allow passing "latest" as version for cat...

2017-04-14 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/635#discussion_r111547198 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/CatalogResource.java --- @@ -481,6 +498,10 @@ public

[GitHub] brooklyn-server pull request #648: Update ApplicationTransformer to return l...

2017-04-25 Thread m4rkmckenna
GitHub user m4rkmckenna opened a pull request: https://github.com/apache/brooklyn-server/pull/648 Update ApplicationTransformer to return location catalogItemId Updates ApplicationTransformer to return the catalogItemId (if available) * If unavailable ID is returned. You can

[GitHub] brooklyn-server issue #657: BROOKLYN-334: ascii art banner says “Apache Br...

2017-04-27 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/657 @aledsage I think we took our queue from Apache Karaf who only use [karaf ](https://github.com/apache/karaf/blob/master/shell/console/src/main/filtered-resources/org/apache/karaf/shell

[GitHub] brooklyn-server pull request #648: Changes Application API behaviour so that...

2017-05-02 Thread m4rkmckenna
Github user m4rkmckenna closed the pull request at: https://github.com/apache/brooklyn-server/pull/648 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #648: Changes Application API behaviour so that return...

2017-05-02 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/648 @ahgittin Agree with the above ... closing now ill try and get a better solution --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] brooklyn-server issue #684: Switch to Java 8

2017-05-19 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/684 Thanks @geomacy verified this locally merging now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] brooklyn-client issue #42: Improve login handling.

2017-05-25 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-client/pull/42 @robertgmoss I was un aware we had that functionality ... How is it supposed to work? I tried ``` br login br apps # Returns host1 apps br login br apps

[GitHub] brooklyn-server issue #712: Updated GCE features

2017-05-30 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/712 @andreaturli I agree ... has this been included in a JClouds release yet? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] brooklyn-server pull request #744: Allow catalog item to be force-updated vi...

2017-06-23 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/744#discussion_r123740886 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/CatalogApi.java --- @@ -67,7 +67,7 @@ @ApiResponse(code

[GitHub] brooklyn-client issue #55: Allow catalog item to be force-updated via query ...

2017-06-23 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-client/pull/55 Tested locally merging now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-server pull request #751: Adds method to reset the shutdown flag wi...

2017-06-30 Thread m4rkmckenna
GitHub user m4rkmckenna opened a pull request: https://github.com/apache/brooklyn-server/pull/751 Adds method to reset the shutdown flag within BrooklynShutdownHooks Under karaf if you restarted the brooklyn-init bundle either manually or due to a re-wire the management context

[GitHub] brooklyn-server issue #755: Added endpoint test boms

2017-07-05 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/755 Thanks @Graeme-Miller merging now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] brooklyn-server pull request #758: Adds patent pom relative path to `brookly...

2017-07-07 Thread m4rkmckenna
GitHub user m4rkmckenna opened a pull request: https://github.com/apache/brooklyn-server/pull/758 Adds patent pom relative path to `brooklyn-locations-container` Without this the build will fail when preforming a release You can merge this pull request into a Git repository by

[GitHub] brooklyn-server issue #753: Update jclouds to 2.0.2

2017-07-10 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/753 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] brooklyn-server issue #753: Update jclouds to 2.0.2

2017-07-11 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/753 Thanks @neykov ive tested the above with a simple application in the following locations - AWS - azure-arm - GCE - openstack - Softlayer --- If your project is

[GitHub] brooklyn-server pull request #771: [WIP] Updates karaf to 4.1.1

2017-07-20 Thread m4rkmckenna
GitHub user m4rkmckenna opened a pull request: https://github.com/apache/brooklyn-server/pull/771 [WIP] Updates karaf to 4.1.1 * Jetty update to 9.3.14.v20161028 You can merge this pull request into a Git repository by running: $ git pull https://github.com/m4rkmckenna

  1   2   >